<NME> test_uneven_logit.py
<BEF> """
Tests for the uneven_logit.py file. These tests do not include tests of
the functions that perform the mathematical calculations necessary to estimate
the multinomial Uneven Logit model.
"""
import warnings
import unittest
from collections import OrderedDict
from copy import deepcopy

import mock
import numpy as np
import numpy.testing as npt
import pandas as pd
from scipy.sparse import csr_matrix
from scipy.sparse import diags

import pylogit.uneven_logit as uneven

# Use the following to always show the warnings
np.seterr(all='warn')
warnings.simplefilter("always")


class GenericTestCase(unittest.TestCase):
    """
    Defines the common setUp method used for the different type of tests.
    """

    def setUp(self):
        # The set up being used is one where there are two choice situations,
        # The first having three alternatives, and the second having only two
        # alternatives. There is one generic variable. Two alternative
        # specific constants and all three shape parameters are used.

        # Create the betas to be used during the tests
        self.fake_betas = np.array([-0.6])

        # Create the fake outside intercepts to be used during the tests
        self.fake_intercepts = np.array([1, 0.5])

        # Create names for the intercept parameters
        self.fake_intercept_names = ["ASC 1", "ASC 2"]

        # Record the position of the intercept that is not being estimated
        self.fake_intercept_ref_pos = 2

        # Create the shape parameters to be used during the tests. Note that
        # these are the reparameterized shape parameters, thus they will be
        # exponentiated in the fit_mle process and various calculations.
        self.fake_shapes = np.array([-1, 0, 1])

        # Create names for the intercept parameters
        self.fake_shape_names = ["Shape 1", "Shape 2", "Shape 3"]

        # Create an array of all model parameters
        self.fake_all_params = np.concatenate((self.fake_shapes,
                                               self.fake_intercepts,
                                               self.fake_betas))

        # The mapping between rows and alternatives is given below.
        self.fake_rows_to_alts = csr_matrix(np.array([[1, 0, 0],
                                                      [0, 1, 0],
                                                      [0, 0, 1],
                                                      [1, 0, 0],
                                                      [0, 0, 1]]))

        # Create the fake design matrix with columns denoting X
        # The intercepts are not included because they are kept outside the
        # index in the uneven model.
        self.fake_design = np.array([[1],
                                     [2],
                                     [3],
                                     [1.5],
                                     [3.5]])

        # Create the index array for this set of choice situations
        self.fake_index = self.fake_design.dot(self.fake_betas)

        # Create the needed dataframe for the Uneven Logit constructor
        self.fake_df = pd.DataFrame({"obs_id": [1, 1, 1, 2, 2],
                                     "alt_id": [1, 2, 3, 1, 3],
                                     "choice": [0, 1, 0, 0, 1],
                                     "x": self.fake_design[:, 0],
                                     "intercept": [1 for i in range(5)]})

        # Record the various column names
        self.alt_id_col = "alt_id"
        self.obs_id_col = "obs_id"
        self.choice_col = "choice"

        # Create the index specification  and name dictionaryfor the model
        self.fake_specification = OrderedDict()
        self.fake_names = OrderedDict()
        self.fake_specification["x"] = [[1, 2, 3]]
        self.fake_names["x"] = ["x (generic coefficient)"]

        # Bundle the args and kwargs used to construct the Uneven Logit model.
        self.constructor_args = [self.fake_df,
                                 self.alt_id_col,
                                 self.obs_id_col,
                                 self.choice_col,
                                 self.fake_specification]

        # Create a variable for the kwargs being passed to the constructor
        self.constructor_kwargs = {"intercept_ref_pos":
                                   self.fake_intercept_ref_pos,
                                   "names": self.fake_names,
                                   "intercept_names":
                                   self.fake_intercept_names,
                                   "shape_names": self.fake_shape_names}

        # Initialize a basic uneven model.
        # Create the uneven logit model whose coefficients will be estimated.
        self.model_obj = uneven.MNUL(*self.constructor_args,
                                     **self.constructor_kwargs)

        return None


# Note that inheritance is used to share the setUp method.
class ChoiceObjectTests(GenericTestCase):
    """
    Defines the tests for the Uneven Logit model's `__init__` function and
    its class methods.
    """

    def test_shape_ignore_msg_in_constructor(self):
        """
        Ensures that a UserWarning is raised when the 'shape_ref_pos' keyword
        argument is passed to the Uneven Logit model constructor. This warns
        people against expecting the shape parameters of the Uneven Logit model
        to suffer from identification problems. It also alerts users that they
        are using a Uneven Logit model when they might have been expecting to
        instantiate a different choice model.
        """
        # Create a variable for the kwargs being passed to the constructor
        kwargs = deepcopy(self.constructor_kwargs)
        kwargs["shape_ref_pos"] = 2

        # Test to ensure that the shape ignore message is printed when using
        # either of these two kwargs
        with warnings.catch_warnings(record=True) as context:
            # Use this filter to always trigger the  UserWarnings
            warnings.simplefilter('always', UserWarning)

            # Create a Uneven Logit model object with the irrelevant kwargs.
            # This should trigger a UserWarning
            uneven_obj = uneven.MNUL(*self.constructor_args, **kwargs)
            # Check that the warning has been created.
            self.assertEqual(len(context), 1)
            self.assertIsInstance(context[-1].category, type(UserWarning))
            self.assertIn(uneven._shape_ref_msg, str(context[-1].message))

        return None

    # Note we mock to avoid issues with inverting the hessian, especially since
    # such inversion is not the point of this test.
    @mock.patch('pylogit.base_multinomial_cm_v2.scipy.linalg.inv',
                side_effect=lambda x: np.eye(x.shape[0]))
    def test_ridge_warning_in_fit_mle(self, mock_inv):
        """
        Ensure that a UserWarning is raised when one passes the ridge keyword
        argument to the `fit_mle` method of an Uneven Logit model object.
        """
        # Create a variable for the fit_mle function's kwargs.
        # The print_res = False arguments are to make sure strings aren't
        # printed to the console unnecessarily.
        # The method kwarg is so we test the use of the hessian
        kwargs = {"ridge": 0.5,
                  "print_res": True,
                  "method": "newton-cg"}

        # Test to make sure that the ridge warning message is printed when
        # using the ridge keyword argument
        with warnings.catch_warnings(record=True) as w:
            # Use this filter to always trigger the  UserWarnings
            warnings.simplefilter('always', UserWarning)

            self.model_obj.fit_mle(self.fake_all_params, **kwargs)
            self.assertGreaterEqual(len(w), 1)
            self.assertIsInstance(w[0].category, type(UserWarning))
            self.assertIn(uneven._ridge_warning_msg, str(w[0].message))

        return None

    def test_init_shapes_length_error_in_fit_mle(self):
        """
        Ensures that ValueError is raised if init_shapes has wrong length.
        """
        # Create a variable for the arguments to the fit_mle function.
        # Note `None` is the argument passed when using the init_shapes,
        # init_intercepts and init_coefs keyword arguments.
        fit_args = [None]

        # Create base set of kwargs for fit_mle function
        kwargs = {"init_intercepts": self.fake_intercepts,
                  "init_coefs": self.fake_betas,
                  "print_res": False}

        for i in [1, -1]:
            # This will ensure we have too many or too few shape parameters.
            num_shapes = self.fake_rows_to_alts.shape[1] + i
            kwargs["init_shapes"] = np.arange(num_shapes)

            # Test to ensure that the ValueError is raised when using an
            # init_shapes kwarg with an incorrect number of parameters
            self.assertRaises(ValueError, self.model_obj.fit_mle,
                              *fit_args, **kwargs)

    def test_init_intercepts_length_error_in_fit_mle(self):
        """
        Ensures that ValueError is raised if init_intercepts has wrong length.
        """
        # Create a variable for the arguments to the fit_mle function.
        # Note `None` is the argument passed when using the init_shapes,
        # init_intercepts and init_coefs keyword arguments.
        fit_args = [None]

        # Create base set of kwargs for fit_mle function
        kwargs = {"init_shapes": self.fake_shapes,
                  "init_coefs": self.fake_betas,
                  "print_res": False}

        for i in [1, -1]:
            # This will ensure we have too many or too few intercepts
            num_intercepts = self.fake_intercepts.shape[0] + i
            kwargs["init_intercepts"] = np.arange(num_intercepts)

            # Test to ensure that the ValueError when using an init_intercepts
            # kwarg with an incorrect number of parameters
            self.assertRaises(ValueError, self.model_obj.fit_mle,
                              *fit_args, **kwargs)

        return None

    def test_init_coefs_length_error_in_fit_mle(self):
        """
        Ensures that ValueError is raised if init_coefs has wrong length.
        """
        # Create a variable for the arguments to the fit_mle function.
        # Note `None` is the argument passed when using the init_shapes,
        # init_intercepts and init_coefs keyword arguments.
        fit_args = [None]

        # Create base set of kwargs for fit_mle function
        kwargs = {"init_shapes": self.fake_shapes,
                  "init_intercepts": self.fake_intercepts,
                  "print_res": False}

        # Note there is only one beta, so we can't go lower than zero betas.
        for i in [1, -1]:
            # This will ensure we have too many or too few intercepts
            num_coefs = self.fake_betas.shape[0] + i
            kwargs["init_coefs"] = np.arange(num_coefs)

            # Test to ensure that the ValueError when using an init_intercepts
            # kwarg with an incorrect number of parameters
            self.assertRaises(ValueError, self.model_obj.fit_mle,
                              *fit_args, **kwargs)

        return None

    def test_insufficient_initial_values_in_fit_mle(self):
        """
        Ensure that value errors are raised if neither init_vals OR
        (init_shapes and init_coefs) are passed.
        """
        # Create a variable for the arguments to the fit_mle function.
        # Note `None` is the argument passed when using the init_shapes,
        # init_intercepts and init_coefs keyword arguments.
        fit_args = [None]

        # Create base set of incorrect kwargs for fit_mle function
        kwargs = {"init_shapes": None,
                  "init_intercepts": self.fake_intercepts,
                  "init_coefs": None,
                  "print_res": False}

        kwargs_2 = {"init_shapes": self.fake_shapes,
                    "init_intercepts": self.fake_intercepts,
                    "init_coefs": None,
                    "print_res": False}

        kwargs_3 = {"init_shapes": None,
                    "init_intercepts": self.fake_intercepts,
                    "init_coefs": self.fake_betas,
                    "print_res": False}

        for bad_kwargs in [kwargs, kwargs_2, kwargs_3]:
            # Test to ensure that the ValueError when not passing
            # kwarg with an incorrect number of parameters
            self.assertRaises(ValueError, self.model_obj.fit_mle,
                              *fit_args, **bad_kwargs)

        return None

    def test_keyword_argument_constructor_in_fit_mle(self):
        """
        Ensures that the init_vals object can be successfully created from the
        various init_shapes, init_intercepts, and init_coefs arguments.
        """
        # Create a variable for the arguments to the fit_mle function.
        # Note `None` is the argument passed when using the init_shapes,
        # init_intercepts and init_coefs keyword arguments.
        fit_args = [None]

        # Create base set of incorrect kwargs for fit_mle function (note the
        # ridge is the thing that is incorrect)
        kwargs_1 = {"init_shapes": self.fake_shapes,
                    "init_intercepts": self.fake_intercepts,
                    "init_coefs": self.fake_betas,
                    "ridge": "foo",
                    "print_res": False}

        kwargs_2 = {"init_shapes": self.fake_shapes,
                    "init_coefs": self.fake_betas,
                    "ridge": "foo",
                    "print_res": False}

        # Test to ensure that the raised Value Err is printed when using
        # either of these two kwargs
        for kwargs in [kwargs_1, kwargs_2]:
            self.assertRaisesRegexp(TypeError,
                                    "ridge",
                                    self.model_obj.fit_mle,
                                    *fit_args,
                                    **kwargs)

        return None

    def test_init_vals_length_error_in_fit_mle(self):
        """
        Ensures that ValueError is raised if init_vals has wrong length.
        """
        # Note there is only one beta, so we can't go lower than zero betas.
        original_intercept_ref_position = self.fake_intercept_ref_pos
        for intercept_ref_position in [None, original_intercept_ref_position]:
            self.model_obj.intercept_ref_position = intercept_ref_position
            for i in [1, -1]:
                # This will ensure we have too many or too few intercepts
                num_coefs = self.fake_betas.shape[0] + i

                # Test to ensure that the ValueError when using an
                # init_intercepts kwarg with an incorrect number of parameters
                self.assertRaisesRegexp(ValueError,
                                        "dimension",
                                        self.model_obj.fit_mle,
                                        np.arange(num_coefs),
                                        print_res=False)

        return None

    def test_just_point_kwarg(self):
        # Alias the function being tested
        func = self.model_obj.fit_mle
        # Get the necessary kwargs
        kwargs = {"just_point": True}
        # Get the function results
        func_result = func(self.fake_all_params, **kwargs)
        # Perform the desired tests to make sure we get back a dictionary with
        # an "x" key in it and a value that is a ndarray.
        self.assertIsInstance(func_result, dict)
        self.assertIn("x", func_result)

        return None

    # def test_uneven_transform_deriv_v(self):
    #     """
    #     Tests basic behavior of the scobit_transform_deriv_v.
    #     """
    #     # Note the index has a value that is small and a value that is large to
    #     # test whether or not the function correctly uses L'Hopital's rule to
    #     # deal with underflow and overflow when calculating the derivative.
    #     # When the index is small, the derivative should be the associated
    #     # shape parameter value. When the index is large the derivative should
    #     # be 1.
    #     test_index = np.array([-2, 0, 2, -800, 300])
    #     # Note we use a compressed sparse-row matrix so that we can easily
    #     # convert the output matrix to a numpy array using the '.A' attribute.
    #     num_rows = test_index.shape[0]
    #     test_output = diags(np.ones(num_rows),
    #                         0, format='csr')

    #     # Bundle the arguments needed for _scobit_transform_deriv_v()
    #     args = [test_index,
    #             self.fake_df[self.alt_id_col].values,
    #             self.fake_rows_to_alts,
    #             self.fake_shapes]

    #     # Get the derivative using the function defined in clog_log.py.
    #     derivative = uneven._scobit_transform_deriv_v(*args,
    #                                                   output_array=test_output)

    #     # Initialize an array of correct results
    #     # Note the second element is by design where each of the terms in the
    #     # derivative should evaluate to 1 and we get 1 / 1 = 1.
    #     correct_derivatives = np.array([np.nan,
    #                                     1.0,
    #                                     np.nan,
    #                                     np.exp(self.fake_shapes[0]),
    #                                     1.0])

    #     # Calculate 'by hand' what the correct results should be
    #     for i in [0, 2]:
    #         shape = np.exp(self.fake_shapes[i])
    #         numerator = (shape * 
    #                      np.exp(-test_index[i]) * 
    #                      np.power(1 + np.exp(-test_index[i]), shape - 1))
    #         denominator = np.power(1 + np.exp(-test_index[i]), shape) - 1
    #         correct_derivatives[i] = numerator / denominator

    #     self.assertIsInstance(derivative, type(test_output))
    #     self.assertEqual(len(derivative.shape), 2)
    #     self.assertEqual(derivative.shape, (num_rows, num_rows))
    #     npt.assert_allclose(correct_derivatives,
    #                         np.diag(derivative.A))

    #     return None

    def test_uneven_transform_deriv_alpha(self):
        """
        Ensures that `_uneven_utility_transform()` returns correct results
        """
        # Create a set of systematic utilities that will test the function for
        # correct calculations, for proper dealing with overflow, and for
        # proper dealing with underflow.

        # The first and third elements tests general calculation.
        # The second element of index_array should lead to the transformation
        # equaling the intercept for alternative 2.
        # The fourth element should test what happens with underflow and should
        # lead to max_comp_value.
        # The fifth element should test what happens with overflow and should
        # lead to -1.0 * max_comp_value
        index_array = np.array([1, 0, -1, 1e400, -1e400])

        # Crerate the array of expected results
        intercept_1 = self.fake_intercepts[0]
        intercept_3 = 0
        shape_1 = np.exp(self.fake_shapes[0])
        shape_3 = np.exp(self.fake_shapes[2])

        result_1 = (intercept_1 +
                    index_array[0] +
                    np.log1p(np.exp(-index_array[0])) -
                    np.log1p(np.exp(-shape_1 * index_array[0])))

        result_3 = (intercept_3 +
                    index_array[2] +
                    np.log1p(np.exp(-index_array[2])) -
                    np.log1p(np.exp(-shape_3 * index_array[2])))

        expected_results = np.array([result_1,
                                     self.fake_intercepts[1],
                                     result_3,
                                     uneven.max_comp_value + intercept_1,
                                     - uneven.max_comp_value])[:, None]

        # Use the utility transformation function
        args = [index_array,
                self.fake_df[self.alt_id_col].values,
                self.fake_rows_to_alts,
                self.fake_shapes,
                self.fake_intercepts]
        kwargs = {"intercept_ref_pos": self.fake_intercept_ref_pos}
        func_results = uneven._uneven_utility_transform(*args, **kwargs)

        # Check the correctness of the result
        self.assertIsInstance(func_results, np.ndarray)
        self.assertEqual(len(func_results.shape), 2)
        self.assertEqual(func_results.shape[1], expected_results.shape[1])
        self.assertEqual(func_results.shape[0], expected_results.shape[0])
        npt.assert_allclose(expected_results, func_results)

        return None

    def test_uneven_utility_transform_2d(self):
        """
        Ensure the function returns expected results with 2d systemic_utilities
        """
        # Create a set of systematic utilities that will test the function for
        # correct calculations, for proper dealing with overflow, and for
        # proper dealing with underflow.

        # The first and third elements tests general calculation.
        # The second element of index_array should lead to the transformation
        # equaling the intercept for alternative 2.
        # The fourth element should test what happens with underflow and should
        # lead to max_comp_value.
        # The fifth element should test what happens with overflow and should
        # lead to -1.0 * max_comp_value
        index_array = np.array([1, 0, -1, 1e400, -1e400])
        index_array_2d = np.concatenate([index_array[:, None],
                                         index_array[:, None]],
                                        axis=1)

        # Create 2d array of shapes
        shapes_2d = np.concatenate([self.fake_shapes[:, None],
                                    self.fake_shapes[:, None]],
                                   axis=1)

        # Create 2d array of intercepts
        intercepts_2d = np.concatenate([self.fake_intercepts[:, None],
                                        self.fake_intercepts[:, None]],
                                       axis=1)

        # Crerate the array of expected results
        intercept_1 = self.fake_intercepts[0]
        intercept_3 = 0
        shape_1 = np.exp(self.fake_shapes[0])
        shape_3 = np.exp(self.fake_shapes[2])

        result_1 = (intercept_1 +
                    index_array[0] +
                    np.log1p(np.exp(-index_array[0])) -
                    np.log1p(np.exp(-shape_1 * index_array[0])))

        result_3 = (intercept_3 +
                    index_array[2] +
                    np.log1p(np.exp(-index_array[2])) -
                    np.log1p(np.exp(-shape_3 * index_array[2])))

        expected_results = np.array([result_1,
                                     self.fake_intercepts[1],
                                     result_3,
                                     uneven.max_comp_value + intercept_1,
                                     - uneven.max_comp_value])[:, None]

        # Use the utility transformation function
        args = [index_array_2d,
                self.fake_df[self.alt_id_col].values,
                self.fake_rows_to_alts,
                shapes_2d,
                intercepts_2d]
        kwargs = {"intercept_ref_pos": self.fake_intercept_ref_pos}
        func_results = uneven._uneven_utility_transform(*args, **kwargs)

        # Check the correctness of the result
        self.assertIsInstance(func_results, np.ndarray)
        self.assertEqual(len(func_results.shape), 2)
        # We should have two columns
        self.assertEqual(func_results.shape[1], 2)
        self.assertEqual(func_results.shape[0], expected_results.shape[0])
        for col in [0, 1]:
            npt.assert_allclose(expected_results,
                                func_results[:, col][:, None])

        return None

    def test_uneven_transform_deriv_v(self):
        """
        Tests basic behavior of the uneven_transform_deriv_v.
        """
        # Note the index has a value that is small and a value that is large to
        # test whether or not the function correctly deals with underflow and
        # overflow when calculating the derivative.
        test_index = np.array([-2, 0, 2, -3000, 800])
        # Note we use a compressed sparse-row matrix so that we can easily
        # convert the output matrix to a numpy array using the '.A' attribute.
        num_rows = test_index.shape[0]
        test_output = diags(np.ones(num_rows),
                            0, format='csr')

        # Bundle the arguments needed for _uneven_transform_deriv_v()
        args = [test_index,
                self.fake_df[self.alt_id_col].values,
                self.fake_rows_to_alts,
                self.fake_shapes]

        # Get the derivative using the function defined in uneven_logit.py.
        derivative = uneven._uneven_transform_deriv_v(*args,
                                                      output_array=test_output)

        # Initialize an array of correct results
        # Note the second element is by design where each of the terms in the
        # derivative should evaluate to 1 and we get 1 / 1 = 1.
        correct_derivatives = np.array([np.nan,
                                        (1 + np.exp(self.fake_shapes[1])) / 2,
                                        np.nan,
                                        np.exp(self.fake_shapes[0]),
                                        1.0])

        # Calculate 'by hand' what the correct results should be
        for i in [0, 2]:
            shape = np.exp(self.fake_shapes[i])
            index_val = test_index[i]
            correct_derivatives[i] = ((1 + np.exp(-index_val))**-1 +
                                      shape / (1 + np.exp(shape * index_val)))

        self.assertIsInstance(derivative, type(test_output))
        self.assertEqual(len(derivative.shape), 2)
        self.assertEqual(derivative.shape, (num_rows, num_rows))
        npt.assert_allclose(correct_derivatives,
                            np.diag(derivative.A))

        return None

    def test_uneven_transform_deriv_alpha(self):
        """
        Ensures that uneven_transform_deriv_alpha returns the `output_array`
        kwarg.
        """
        # Bundle the args for the function being tested
        args = [self.fake_index,
                self.fake_df[self.alt_id_col].values,
                self.fake_rows_to_alts,
                self.fake_intercepts]

        # Take the relevant columns of rows_to_alts, as would be done with
        # outside intercepts, or test None for when there are no outside
        # intercepts.
        for test_output in [None, self.fake_rows_to_alts[:, [0, 1]]]:
            kwargs = {"output_array": test_output}
            derivative_results = uneven._uneven_transform_deriv_alpha(*args,
                                                                      **kwargs)
            if test_output is None:
                self.assertIsNone(derivative_results)
            else:
                npt.assert_allclose(test_output.A, derivative_results.A)

        return None

    def test_uneven_transform_deriv_shape(self):
        """
        Ensures that the uneven_transform_deriv_shape() function provides
        correct results, and handles all forms of overflow and underflow
        correctly.
        """
        # Note the index has a value that is small and a value that is large to
        # test whether or not the function correctly uses L'Hopital's rule to
        # deal with underflow and overflow from the index when calculating the
        # derivative. When the index is large, the derivative should be the
        # negative of the inverse of the 'natural' shape parameter. When the
        # index is small the derivative should be max_comp_value (theoretically
        # inf). When the shape is large, the derivative should be the negative
        # of the natural log of 1 + exp(-index).
        test_index = np.array([-10, 0, 2, -10000, 1e8])

        # Note we use a compressed sparse-row matrix so that we can easily
        # convert the output matrix to a numpy array using the '.A' attribute.
        num_rows = test_index.shape[0]
        test_output = diags(np.ones(num_rows),
                            0, format='csr')

        # Create new test shapes to use. We make the first shape parameter big
        # to test overflow handling from this situation and L'Hopital's rule.
        new_shapes = deepcopy(self.fake_shapes)
        new_shapes[0] = np.log(80)
        natural_shapes = np.exp(new_shapes)

        # Bundle the arguments needed for _uneven_transform_deriv_shape()
        args = [test_index,
                self.fake_df[self.alt_id_col].values,
                self.fake_rows_to_alts,
                new_shapes]
        kwargs = {"output_array": test_output}

        # Get the derivative using the function defined in uneven_log.py.
        derivative = uneven._uneven_transform_deriv_shape(*args, **kwargs)

        # Initialize an array of correct results
        # Note the second element is by design so the derivative equals 2ln(2)
        # Also, we precompute the results and multiply by natural shapes to
        # account for the jacobian when computing the gradient with respect to
        # reparameterized shape parameters.
        result_1 = (test_index[0] /
                    (1 + np.exp(natural_shapes[0] * test_index[0])))
        result_3 = (test_index[2] /
                    (1 + np.exp(natural_shapes[2] * test_index[2])))
        correct_derivatives = np.array([result_1 * natural_shapes[0],
                                        0,
                                        result_3 * natural_shapes[2],
                                        test_index[3] * natural_shapes[0],
                                        0])

        self.assertIsInstance(derivative, type(test_output))
        self.assertEqual(len(derivative.shape), 2)
        self.assertEqual(derivative.shape, (num_rows, num_rows))
        npt.assert_allclose(correct_derivatives,
                            np.diag(derivative.A))

        return None

<MSG> More uneven logit tests.

<DFF> @@ -365,58 +365,53 @@ class HelperFuncTests(GenericTestCase):
 
         return None
 
-    # def test_uneven_transform_deriv_v(self):
-    #     """
-    #     Tests basic behavior of the scobit_transform_deriv_v.
-    #     """
-    #     # Note the index has a value that is small and a value that is large to
-    #     # test whether or not the function correctly uses L'Hopital's rule to
-    #     # deal with underflow and overflow when calculating the derivative.
-    #     # When the index is small, the derivative should be the associated
-    #     # shape parameter value. When the index is large the derivative should
-    #     # be 1.
-    #     test_index = np.array([-2, 0, 2, -800, 300])
-    #     # Note we use a compressed sparse-row matrix so that we can easily
-    #     # convert the output matrix to a numpy array using the '.A' attribute.
-    #     num_rows = test_index.shape[0]
-    #     test_output = diags(np.ones(num_rows),
-    #                         0, format='csr')
-
-    #     # Bundle the arguments needed for _scobit_transform_deriv_v()
-    #     args = [test_index,
-    #             self.fake_df[self.alt_id_col].values,
-    #             self.fake_rows_to_alts,
-    #             self.fake_shapes]
-
-    #     # Get the derivative using the function defined in clog_log.py.
-    #     derivative = uneven._scobit_transform_deriv_v(*args,
-    #                                                   output_array=test_output)
-
-    #     # Initialize an array of correct results
-    #     # Note the second element is by design where each of the terms in the
-    #     # derivative should evaluate to 1 and we get 1 / 1 = 1.
-    #     correct_derivatives = np.array([np.nan,
-    #                                     1.0,
-    #                                     np.nan,
-    #                                     np.exp(self.fake_shapes[0]),
-    #                                     1.0])
-
-    #     # Calculate 'by hand' what the correct results should be
-    #     for i in [0, 2]:
-    #         shape = np.exp(self.fake_shapes[i])
-    #         numerator = (shape * 
-    #                      np.exp(-test_index[i]) * 
-    #                      np.power(1 + np.exp(-test_index[i]), shape - 1))
-    #         denominator = np.power(1 + np.exp(-test_index[i]), shape) - 1
-    #         correct_derivatives[i] = numerator / denominator
-
-    #     self.assertIsInstance(derivative, type(test_output))
-    #     self.assertEqual(len(derivative.shape), 2)
-    #     self.assertEqual(derivative.shape, (num_rows, num_rows))
-    #     npt.assert_allclose(correct_derivatives,
-    #                         np.diag(derivative.A))
+    def test_uneven_transform_deriv_v(self):
+        """
+        Tests basic behavior of the scobit_transform_deriv_v.
+        """
+        # Note the index has a value that is small and a value that is large to
+        # test whether or not the function correctly deals with underflow and
+        # overflow when calculating the derivative.
+        test_index = np.array([-2, 0, 2, -3000, 800])
+        # Note we use a compressed sparse-row matrix so that we can easily
+        # convert the output matrix to a numpy array using the '.A' attribute.
+        num_rows = test_index.shape[0]
+        test_output = diags(np.ones(num_rows),
+                            0, format='csr')
+
+        # Bundle the arguments needed for _scobit_transform_deriv_v()
+        args = [test_index,
+                self.fake_df[self.alt_id_col].values,
+                self.fake_rows_to_alts,
+                self.fake_shapes]
+
+        # Get the derivative using the function defined in clog_log.py.
+        derivative = uneven._uneven_transform_deriv_v(*args,
+                                                      output_array=test_output)
+
+        # Initialize an array of correct results
+        # Note the second element is by design where each of the terms in the
+        # derivative should evaluate to 1 and we get 1 / 1 = 1.
+        correct_derivatives = np.array([np.nan,
+                                        (1 + np.exp(self.fake_shapes[1])) / 2,
+                                        np.nan,
+                                        np.exp(self.fake_shapes[0]),
+                                        1.0])
+
+        # Calculate 'by hand' what the correct results should be
+        for i in [0, 2]:
+            shape = np.exp(self.fake_shapes[i])
+            index_val = test_index[i]
+            correct_derivatives[i] = ((1 + np.exp(-index_val))**-1 +
+                                       shape / (1 + np.exp(shape * index_val)))
+
+        self.assertIsInstance(derivative, type(test_output))
+        self.assertEqual(len(derivative.shape), 2)
+        self.assertEqual(derivative.shape, (num_rows, num_rows))
+        npt.assert_allclose(correct_derivatives,
+                            np.diag(derivative.A))
 
-    #     return None
+        return None
 
     def test_uneven_transform_deriv_alpha(self):
         """

More uneven logit tests.