project: Moodle
summary: Epic: Collect together deprecated and planned code changes for Moodle 3.8
description: In 3.8 we can remove functionality that was deprecated in 3.4 or earlier (see ) There are a number of parts of the Moodle codebase that have been marked as deprecated as a warning to developers not to use these functions as they will be removed in future. Each of these deprecated functions, especially those in Moodle core code, should have an MDL issue associated with it. In order to time the removal of these deprecated functions issues and not lose sight of them, this issue will be used to collect them together.

1.summary: Final deprecation for core/modal_confirm
description: Phase 2 deprecation for the core/modal_confirm AMD module.
2.summary: Final deprecation of and verify_ remove login and if possible
description: Remove functions and verify_required from lib/pagelib.php Probably cant remove as it has no way to be deprecated before removal Remove login from all places in core (e.g. lib/setup.php)
3.summary: Final deprecation of xxx_print_overview() and related functions
description: These were deprecated in -- (please check the commit as a WS was also deprecated). Also, please remove the strings from the activity modules that are only used by these deprecated functions.
4.summary: Phase 2 of deprecation of functions in lib/deprecatedlib.php initially deprecated in 3.3
description: As per all functions in lib/deprecatedlib.php that were deprecated in 3.3 should be replaced with exceptions in 3.7 This includes all functions in lib/deprecatedlib.php that say since 3.3 _If any functions from this file do not have this comment but also need to be finally deprecated in 3.7- please list them in this issue description_
5.summary: Remove strings deprecated in 3.3
description: Remove strings from language files under the heading "Deprecated in Moodle 3.3" and the respective lines in deprecated.txt files See also
6.summary: Remove behat steps deprecated in 3.3
description: go through lib/tests/behat/behat_deprecated.php and remove steps that were deprecated in Moodle 3.3 please add to the description if you know of any other deprecated behat functionality outside of this file that needs to be removed
7.summary: Final deprecation of media_manager::setup()
description: Final deprecation of media_manager::setup(). It was deprecated in
8.summary: enrol/ldap/cli/sync.php final deprecation
description: Remove enrol/ldap/cli/sync.php as it has been replaced by a task in .
9.summary: Deprecate search engines add_documents implementations returning 4 arguments
description: In we introduced changes to add_documents, now this method should return an extra $partial boolean. We still support implementations returning 4 elements but not forever, this issue is about removing this 4 returned elements compatibility.
10.summary: Remove strings deprecated in 3.4
description: Remove strings from language files under the heading "Deprecated in Moodle 3.4" and the respective lines in deprecated.txt files See also
11.summary: Phase 2 of deprecation of functions in lib/deprecatedlib.php initially deprecated in 3.4
description: As per all functions in lib/deprecatedlib.php that were deprecated in 3.4 should be replaced with exceptions in 3.8 This includes all functions in lib/deprecatedlib.php that say since 3.4 If any functions from this file do not have this comment but also need to be finally deprecated in 3.8 - please list them in this issue description
12.summary: Remove behat steps deprecated in 3.4
description: go through lib/tests/behat/behat_deprecated.php and remove steps that were deprecated in Moodle 3.4 please add to the description if you know of any other deprecated behat functionality outside of this file that needs to be removed
13.summary: Final deprecation of section_edit_controls() in course/format/renderer.php
description: section_edit_controls() in course/format/renderer.php was deprecated in 3.0 (). It should be removed now.
14.summary: Messaging: remove/deprecate get_individual_conversations_between_users()
description: This method was created without having a need for it. Its only called by get_conversation_between_users() in the singular form, and in some unit tests and is not easy to read / maintain. Considering the above two methods, what we want is as follows: - Remove get_individual_conversations_between_users() deprecate sadly, as its public - Rewrite get_conversation_between_users() to just make a DB call based on the type and conversation hash. - Adjust unit tests to use the rewritten method.

Below is an instruction that describes a task, paired with an input that provides an epic with this format: 
"project": "Name of the project" 
"summary": "Summary of the epic user story" 
"description": "Description of the epic user story". Write a response that appropriately completes the request.### Instruction:
Break this epic user story into smaller tasks to help the developers understand the epic better, you can divide this epic into as much as you want depending on the complexity of the epic.
### Input:
project: Moodle
summary: Epic: Collect together deprecated and planned code changes for Moodle 3.8
description: In 3.8 we can remove functionality that was deprecated in 3.4 or earlier (see ) There are a number of parts of the Moodle codebase that have been marked as deprecated as a warning to developers not to use these functions as they will be removed in future. Each of these deprecated functions, especially those in Moodle core code, should have an MDL issue associated with it. In order to time the removal of these deprecated functions issues and not lose sight of them, this issue will be used to collect them together.

### Response:
1.summary: Final deprecation for core/modal_confirm
description: Phase 2 deprecation for the core/modal_confirm AMD module.
2.summary: Final deprecation of and verify_ remove login and if possible
description: Remove functions and verify_required from lib/pagelib.php Probably cant remove as it has no way to be deprecated before removal Remove login from all places in core (e.g. lib/setup.php)
3.summary: Final deprecation of xxx_print_overview() and related functions
description: These were deprecated in -- (please check the commit as a WS was also deprecated). Also, please remove the strings from the activity modules that are only used by these deprecated functions.
4.summary: Phase 2 of deprecation of functions in lib/deprecatedlib.php initially deprecated in 3.3
description: As per all functions in lib/deprecatedlib.php that were deprecated in 3.3 should be replaced with exceptions in 3.7 This includes all functions in lib/deprecatedlib.php that say since 3.3 _If any functions from this file do not have this comment but also need to be finally deprecated in 3.7- please list them in this issue description_
5.summary: Remove strings deprecated in 3.3
description: Remove strings from language files under the heading "Deprecated in Moodle 3.3" and the respective lines in deprecated.txt files See also
6.summary: Remove behat steps deprecated in 3.3
description: go through lib/tests/behat/behat_deprecated.php and remove steps that were deprecated in Moodle 3.3 please add to the description if you know of any other deprecated behat functionality outside of this file that needs to be removed
7.summary: Final deprecation of media_manager::setup()
description: Final deprecation of media_manager::setup(). It was deprecated in
8.summary: enrol/ldap/cli/sync.php final deprecation
description: Remove enrol/ldap/cli/sync.php as it has been replaced by a task in .
9.summary: Deprecate search engines add_documents implementations returning 4 arguments
description: In we introduced changes to add_documents, now this method should return an extra $partial boolean. We still support implementations returning 4 elements but not forever, this issue is about removing this 4 returned elements compatibility.
10.summary: Remove strings deprecated in 3.4
description: Remove strings from language files under the heading "Deprecated in Moodle 3.4" and the respective lines in deprecated.txt files See also
11.summary: Phase 2 of deprecation of functions in lib/deprecatedlib.php initially deprecated in 3.4
description: As per all functions in lib/deprecatedlib.php that were deprecated in 3.4 should be replaced with exceptions in 3.8 This includes all functions in lib/deprecatedlib.php that say since 3.4 If any functions from this file do not have this comment but also need to be finally deprecated in 3.8 - please list them in this issue description
12.summary: Remove behat steps deprecated in 3.4
description: go through lib/tests/behat/behat_deprecated.php and remove steps that were deprecated in Moodle 3.4 please add to the description if you know of any other deprecated behat functionality outside of this file that needs to be removed
13.summary: Final deprecation of section_edit_controls() in course/format/renderer.php
description: section_edit_controls() in course/format/renderer.php was deprecated in 3.0 (). It should be removed now.
14.summary: Messaging: remove/deprecate get_individual_conversations_between_users()
description: This method was created without having a need for it. Its only called by get_conversation_between_users() in the singular form, and in some unit tests and is not easy to read / maintain. Considering the above two methods, what we want is as follows: - Remove get_individual_conversations_between_users() deprecate sadly, as its public - Rewrite get_conversation_between_users() to just make a DB call based on the type and conversation hash. - Adjust unit tests to use the rewritten method.
