prompt
stringlengths 24
63.1k
| response
stringlengths 296
101k
| metadata
stringlengths 143
152
|
|---|---|---|
[FEATURE] Implement `AddressInterface` for `MockDb`
Spin out from #172. Please refer to that issue for more information.
|
<think>
PR Context:
- Title: feat(db): implement `AddressInterface` for `MockDb`
- Merged: 2023-05-19T09:40:37Z
- Files changed: 4 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding c
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(db): implement `AddressInterface` for `MockDb` (#968)
Co-authored-by: jeeva <jeeva.ramu@coduran
Files to modify:
**crates/router/src/db.rs**
Modify existing code
**crates/router/src/db/address.rs**
Modify existing code
**crates/storage_models/src/address.rs**
Add:
- function: pub::create_address
- impl: impl AddressUpdateInternal
|
{"issue_number": 954, "pr_number": 968, "commits_count": 1, "files_changed": 4, "response_length": 1138, "file_count": 5, "needs_breakdown": false}
|
fix: impl `Drop` for `RedisConnectionPool`
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
This fixes #1035
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
#1035
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Manual
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
|
<think>
PR Context:
- Title: fix(redis): fix recreation on redis connection pool
- Merged: 2023-05-08T09:01:49Z
- Files changed: 7 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR fixes the issue of creating multiple Redis connection pool everywhere. It provides a trait to access the interior redis connection pool.
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(redis): fix recreation on redis connection pool (#1063)
Files to modify:
**crates/redis_interface/src/lib.rs**
Modify existing code
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Modify existing code
**crates/router/src/db.rs**
Add:
- function: private::get_redis_conn
- impl: impl services::RedisConnInterface for MockDb
**crates/router/src/services.rs**
Add:
- function: private::get_redis_conn
- trait: pub::RedisConnInterface
- impl: impl RedisConnInterface for Store
|
{"issue_number": 1051, "pr_number": 1063, "commits_count": 1, "files_changed": 7, "response_length": 1431, "file_count": 8, "needs_breakdown": false}
|
fix(users): Only use lowercase letters in emails
Currently uppercase letters in emails are being using at it is. Ideally we should convert them to lowercase before performing any DB operations with it.
|
<think>
PR Context:
- Title: feat(users): Convert emails to lowercase from requests
- Merged: 2024-11-20T13:41:03Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR changes will convert emails from request to lowercase before performing any DB operations.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies applica
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(users): Convert emails to lowercase from requests (#6601)
Files to modify:
**crates/router/src/types/domain/user.rs**
Modify existing code
|
{"issue_number": 6600, "pr_number": 6601, "commits_count": 1, "files_changed": 1, "response_length": 934, "file_count": 3, "needs_breakdown": false}
|
bug(auth_methods): Create auth methods is allowing auth methods with same type to be inserted multiple times
Currently create will accept and insert auth methods with same type and name, which shouldn't be possible.
Create should have checks for this and block these kind of requests.
|
<think>
PR Context:
- Title: fix(auth_methods): Add checks for duplicate `auth_method` in create API
- Merged: 2024-07-02T08:05:59Z
- Files changed: 3 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently create will accept and insert auth methods with same type and name, which shouldn't be possible. This PR fixes that.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
-
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(auth_methods): Add checks for duplicate `auth_method` in create API (#5161)
Files to modify:
**crates/api_models/src/user.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/utils/user.rs**
Add:
- function: private::construct_public_and_private_db_configs
- function: pub::parse_value
|
{"issue_number": 5160, "pr_number": 5161, "commits_count": 1, "files_changed": 3, "response_length": 1160, "file_count": 5, "needs_breakdown": false}
|
feat(core): Add kill switch for Unified Connector Service (UCS)
# feat(core): Add kill switch for Unified Connector Service (UCS)
## Feature Description
We need to implement a kill switch mechanism for the Unified Connector Service (UCS) integration that allows operators to disable UCS immediately without requiring code changes or deployments.
## Problem Statement
Currently, if UCS experiences issues or needs to be disabled for operational reasons, there's no quick way to fall back to traditional connector flows without modifying code and deploying. This poses operational risks during incidents.
## Proposed Solution
Implement a database-driven kill switch that:
- Can be toggled via a configuration entry in the database
- Takes effect immediately without requiring service restart
- Integrates seamlessly with the existing UCS decision flow
- Provides clear logging when the kill switch is active
## Technical Approach
1. Add a new configuration key `UCS_KILL_SWITCH_ACTIVE` that can be stored in the database
2. Implement a helper function to check the kill switch status
3. Integrate the kill switch check into the UCS decision flow before rollout percentage checks
4. Ensure proper error handling when UCS is disabled via kill switch
## Benefits
- **Operational Control**: Immediate ability to disable UCS during incidents
- **Risk Mitigation**: Quick fallback mechanism without deployment delays
- **Debugging**: Easier troubleshooting by toggling UCS on/off
- **Gradual Rollout**: Additional safety layer on top of percentage-based rollout
## Implementation Details
The kill switch will be checked in the `should_call_unified_connector_service` function before any other conditions, ensuring it has the highest priority in the decision flow.
## Acceptance Criteria
- [ ] Kill switch configuration can be set in the database
- [ ] When kill switch is active, UCS is bypassed completely
- [ ] Changes take effect immediately without service restart
- [ ] Proper logging indicates when kill switch is active
- [ ] Traditional connector flow continues to work when UCS is disabled
|
<think>
PR Context:
- Title: feat(core): Implement UCS kill switch for emergency fallback
- Merged: 2025-07-22T09:00:55Z
- Files changed: 4 files
- Commits: 8 commits
Implementation approach:
# feat(core): Implement UCS enable/disable configuration for operational control
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
### Fixes #8644
## Description
<!-- Describe your changes in detail -->
This PR implements a **database-driven enable/disable configuration** for the Unified Connector Service (UCS) int
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(core): Implement UCS kill switch for emergency fallback (#8651)
Files to modify:
**crates/router/src/consts.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Add:
- function: pub::is_ucs_enabled
**crates/router/src/core/unified_connector_service.rs**
Modify existing code
|
{"issue_number": 8644, "pr_number": 8651, "commits_count": 1, "files_changed": 4, "response_length": 1169, "file_count": 7, "needs_breakdown": false}
|
feat(users): Add entity type filter in list users and list roles API
Currently list users and list roles API is sending all the users and roles respectively for those who are same entity level and less.
We need to add filters in these APIs to send users and roles who are only at particular entity level.
|
<think>
PR Context:
- Title: feat(users): Add entity type filter in list users and list roles API
- Merged: 2024-09-24T14:43:55Z
- Files changed: 7 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Adds entity_type filter in list users and list roles API.
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variable
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(users): Add entity type filter in list users and list roles API (#5997)
Files to modify:
**crates/api_models/src/events/user_role.rs**
Modify existing code
**crates/api_models/src/user_role.rs**
Add:
- struct: pub::ListUsersInEntityRequest
**crates/api_models/src/user_role/role.rs**
Add:
- struct: pub::ListRolesRequest
**crates/router/src/core/user_role.rs**
Modify existing code
**crates/router/src/core/user_role/role.rs**
Modify existing code
**crates/router/src/routes/user_role.rs**
Modify existing code
**crates/router/src/utils/user_role.rs**
Add:
- function: pub::fetch_user_roles_by_payload
- function: pub::get_min_entity
|
{"issue_number": 5996, "pr_number": 5997, "commits_count": 1, "files_changed": 7, "response_length": 1477, "file_count": 9, "needs_breakdown": false}
|
Use `frunk` deriving mechanisms to reduce boilerplate
https://github.com/juspay/orca/blob/dddc9eaf1430adcd1293933e726c2f4f296c805b/crates/router/src/types/transformers.rs#L5-L14
Why not just use [frunk](https://crates.io/crates/frunk)?
Here's an example:
```rust
use frunk::LabelledGeneric;
#[derive(LabelledGeneric)]
enum ApiRoutingAlgorithm {
RoundRobin,
MaxConversion,
MinCost,
Custom,
}
#[derive(LabelledGeneric, PartialEq, Debug)]
enum RoutingAlgorithm {
RoundRobin,
MaxConversion,
MinCost,
Custom,
}
fn main() {
let api_algorithm = ApiRoutingAlgorithm::MinCost;
let algorithm: RoutingAlgorithm = frunk::labelled_convert_from(api_algorithm);
assert_eq!(algorithm, RoutingAlgorithm::MinCost);
}
```
|
<think>
PR Context:
- Title: refactor: use frunk deriving mechanisms to reduce boilerplate
- Merged: 2022-12-14T10:17:06Z
- Files changed: 9 files
- Commits: 3 commits
Implementation approach:
## Type of Change
- [x] Refactoring
## Motivation and Context
Closes #122
## How did you test it?
Manual, compiler-guided.
## Checklist
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor: use frunk deriving mechanisms to reduce boilerplate (#137)
Co-authored-by: Arun Raj M <jar
Files to modify:
**crates/api_models/src/enums.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/storage_models/src/address.rs**
Modify existing code
**crates/storage_models/src/enums.rs**
Modify existing code
|
{"issue_number": 122, "pr_number": 137, "commits_count": 1, "files_changed": 9, "response_length": 1011, "file_count": 7, "needs_breakdown": false}
|
Make KV storage flow more generic
Model the KV storage flow as a series of common operations (For example, `set in redis -> get sql query -> push query to redis stream`) and define generic utilities that perform these operations for all KV-enabled storage interfaces (as opposed to rewriting code).
|
<think>
PR Context:
- Title: refactor: use generic function to push to drainer
- Merged: 2023-02-06T11:48:28Z
- Files changed: 4 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
Use a generic function to push sql queries into drainer stream.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug o
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor: use generic function to push to drainer (#496)
Files to modify:
**crates/router/src/db/payment_attempt.rs**
Modify existing code
**crates/router/src/db/payment_intent.rs**
Modify existing code
**crates/router/src/db/refund.rs**
Modify existing code
**crates/router/src/services.rs**
Add:
- function: pub::push_to_drainer_stream
|
{"issue_number": 97, "pr_number": 496, "commits_count": 1, "files_changed": 4, "response_length": 1136, "file_count": 6, "needs_breakdown": false}
|
[BUG] Certificate decode failed when creating the session token for `applepay`
### Bug Description
It bugs out when creating session token for `applepay` if the certificate provided is in the wrong format.
### Expected Behavior
If the certificate provided is in the wrong format, then it should error out during creation of the `merchant_connector_account` where the certificate is provided.
### Actual Behavior
It fails when creating the session token for applepay.
### Steps To Reproduce
Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.
1. Create a mca with wrong applepay certificate ( delete few characters, or do not base64 encode ).
2. Create a payment with confirm = false
3. Create session token
Result -> Applepay session token will not be generated
The log will be
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes/No No
If yes, please provide the value of the `x-request-id` response header for helping us debug your issue.
### Have you spent some time to check if this bug has been raised before?
- [X] I checked and didn't find similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes I am willing to submit a PR!
|
<think>
PR Context:
- Title: fix: certificate decode failed when creating the session token for applepay
- Merged: 2023-06-09T09:59:31Z
- Files changed: 4 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
We used to have a lot of errors when creating applepay session tokens because of invalid certificates being sent when creating the merchant connector account.
This PR will not allow the merchant connector account to be created if the format of certificates are invalid. To do this, it will decode the certificates and then create the identity ( the same pr
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix: certificate decode failed when creating the session token for applepay (#1385)
Files to modify:
**crates/api_models/src/payments.rs**
Add:
- struct: pub::ConnectorMetadata
**crates/router/src/core/admin.rs**
Add:
- function: private::validate_certificate_in_mca_metadata
**crates/router/src/core/payments/helpers.rs**
Add:
- function: pub::create_identity_from_certificate_and_key
**crates/router/src/services/api/client.rs**
Modify existing code
|
{"issue_number": 1373, "pr_number": 1385, "commits_count": 1, "files_changed": 4, "response_length": 1284, "file_count": 6, "needs_breakdown": false}
|
[REFACTOR]: [Payme] Remove Default Case Handling
### :memo: Feature Description
- We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
- These conditions generally go hand in hand with enum variants.
- Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
- So, if all the explicit cases are handled then default is used to handle the rest.
- Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a `_` is put to handle all the other cases.
- This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.
### :hammer: Possible Implementation
- Instead of relying on a default match case `_`, developers should handle each and every variant explicitly.
- By doing so, if there are any changes in the future, they can readily assess the impact of their modifications simply by compiling the code.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/1955
:bookmark: Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: refactor(connector): [Payme] Remove Default Case Handling
- Merged: 2023-10-31T10:10:48Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
- [x] Refactoring
## Description
This PR removes the default case handling and adds error handling for all the available cases.
Fixes #2282
## How did you test it?
No test cases. As In this PR only error message have been populated for all default cases.
## Checklist
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): [Payme] Remove Default Case Handling (#2719)
Files to modify:
**crates/router/src/connector/payme/transformers.rs**
Modify existing code
**Commit 2:** refactor(connector): [Payme] Remove Default Case Handling (#2719)
Files to modify:
**crates/router/src/connector/payme/transformers.rs**
Modify existing code
|
{"issue_number": 2282, "pr_number": 2719, "commits_count": 2, "files_changed": 1, "response_length": 1081, "file_count": 5, "needs_breakdown": false}
|
[REFACTOR] Worldpay payments integration
### Feature Description
WorldPay payments integration currently makes use of modular APIs which gives more control over the integration. This approach is not best compatible with HyperSwitch due to WP's 3DS flows - which requires sending PAN (card numbers) in multiple places. For `on_session` transactions, this would contribute to the added complexity since data is not stored in such transactions (or stored for ~15mins in redis cache).
Migrating to WP's standard payments API follows payment resource creation in an uniform way.
### Possible Implementation
Migrate from modular APIs [[ref](https://developer.worldpay.com/products/access/card-payments)] to standard payment APIs [[ref](https://developer.worldpay.com/products/access/payments/openapi)].
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(connector): [worldpay] add support for mandates
- Merged: 2024-11-08T13:37:39Z
- Files changed: 9 files
- Commits: 16 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #6316 point `#6`
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
F
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [worldpay] add support for mandates (#6479)
Co-authored-by: hyperswitch-bot[bot] <1
Files to modify:
**crates/hyperswitch_connectors/src/connectors/worldpay.rs**
Add:
- function: private::validate_mandate_payment
- function: private::is_webhook_source_verification_mandatory
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
**crates/hyperswitch_connectors/src/connectors/worldpay/requests.rs**
Add:
- struct: pub::TokenCreation
- struct: pub::CustomerAgreement
- enum: pub::TokenCreationType
- enum: pub::CustomerAgreementType
- enum: pub::StoredCardUsageType
- enum: pub::ThreeDsPreference
**crates/hyperswitch_connectors/src/connectors/worldpay/response.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs**
Add:
- function: private::try_from
- function: private::get_settlement_info
- function: private::get_return_url
- function: private::get_auth_type
- function: private::get_browser_info
- function: private::get_payment_method_data
- function: private::get_setup_future_usage
- function: private::get_off_session
- function: private::get_mandate_id
- function: private::get_currency
- function: private::get_optional_billing_address
- function: private::get_connector_meta_data
- function: private::get_payment_method
- function: private::get_payment_method_type
- function: private::get_connector_request_reference_id
- function: private::get_is_mandate_payment
- function: private::get_return_url
- function: private::get_auth_type
- function: private::get_browser_info
- function: private::get_payment_method_data
- function: private::get_setup_future_usage
- function: private::get_off_session
- function: private::get_mandate_id
- function: private::get_currency
- function: private::get_optional_billing_address
- function: private::get_connector_meta_data
- function: private::get_payment_method
- function: private::get_payment_method_type
- function: private::get_connector_request_reference_id
- function: private::get_is_mandate_payment
- function: private::get_settlement_info
- function: private::create_three_ds_request
- function: private::get_token_and_agreement
- impl: impl TryFrom<Option<&pii::SecretSerdeValue>> for WorldpayConnectorMetadataObject
- impl: impl WorldpayPaymentsRequestData for RouterData<SetupMandate, SetupMandateRequestData, PaymentsResponseData>
- impl: impl WorldpayPaymentsRequestData for RouterData<Authorize, PaymentsAuthorizeData, PaymentsResponseData>
**crates/hyperswitch_connectors/src/utils.rs**
Add:
- function: private::get_router_return_url
**crates/hyperswitch_domain_models/src/errors/api_error_response.rs**
Modify existing code
**crates/router/src/consts.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_response.rs**
Modify existing code
**crates/router/src/lib.rs**
Modify existing code
|
{"issue_number": 6316, "pr_number": 6479, "commits_count": 1, "files_changed": 9, "response_length": 3943, "file_count": 11, "needs_breakdown": false}
|
[REFACTOR] Enable runtime flag for `s3` feature
### Feature Description
Tracking issue for refactoring `s3` to include compile time + runtime time flag
Current implementation - We are building 2 docker images, one image contains all the release features including `kms`, `s3`, etc and other without these features which are getting pushed to the public docker hub. This was to ensure that anyone who wants to try out Hyperswitch locally by pulling the pre-built docker image, it shouldn't be a hassle for he/she to setup `s3`. For this very reason we were pushing 2 docker images which was a temporary solution
### Possible Implementation
Providing support for enabling or disabling s3 feature in runtime so that we no longer have to build 2 images.
### Tasks
- [x] #3340
- [x] #3347
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: refactor: add support for extending file storage to other schemes and provide a runtime flag for the same
- Merged: 2024-01-30T08:03:41Z
- Files changed: 18 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR includes refactoring for:
* Enabling easy extension of other file storage schemes.
* Providing a runtime flag for the file storage feature.
* Restrict the file storage objects(structs, methods) visibility wherever possible.
###
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor: add support for extending file storage to other schemes and provide a runtime flag for the
Files to modify:
**crates/external_services/src/file_storage.rs**
Add:
- function: pub::validate
- function: pub::get_file_storage_client
- function: private::fmt
- struct: pub::InvalidFileStorageConfig
- enum: pub::FileStorageConfig
- enum: pub::FileStorageError
- trait: pub::FileStorageInterface
- impl: impl FileStorageConfig
- impl: impl std::error::Error for InvalidFileStorageConfig
- impl: impl Display for InvalidFileStorageConfig
- mod: private::aws_s3
- mod: private::file_system
**crates/external_services/src/file_storage/aws_s3.rs**
Add:
- function: pub::validate
- function: pub::new
- function: private::upload_file
- function: private::delete_file
- function: private::retrieve_file
- function: private::upload_file
- function: private::delete_file
- function: private::retrieve_file
- struct: pub::AwsFileStorageConfig
- struct: pub::AwsFileStorageClient
- enum: private::AwsS3StorageError
- impl: impl AwsFileStorageConfig
- impl: impl AwsFileStorageClient
- impl: impl FileStorageInterface for AwsFileStorageClient
**crates/external_services/src/file_storage/file_system.rs**
Add:
- function: private::get_file_path
- function: private::upload_file
- function: private::delete_file
- function: private::retrieve_file
- function: private::upload_file
- function: private::delete_file
- function: private::retrieve_file
- struct: pub::FileSystem
- enum: private::FileSystemStorageError
- impl: impl FileSystem
- impl: impl FileStorageInterface for FileSystem
**crates/external_services/src/lib.rs**
Add:
- mod: pub::file_storage
**crates/router/src/configs/settings.rs**
Remove:
- struct: pub::FileUploadConfig
**crates/router/src/configs/validations.rs**
Remove:
- function: pub::validate
- impl: impl super::settings::FileUploadConfig
**crates/router/src/core/files.rs**
Remove:
- mod: pub::s3_utils
- mod: pub::fs_utils
**crates/router/src/core/files/fs_utils.rs**
Remove:
- function: pub::get_file_path
- function: pub::save_file_to_fs
- function: pub::delete_file_from_fs
- function: pub::retrieve_file_from_fs
**crates/router/src/core/files/helpers.rs**
Remove:
- function: pub::upload_file
- function: pub::delete_file
- function: pub::retrieve_file
**crates/router/src/core/files/s3_utils.rs**
Remove:
- function: private::get_aws_client
- function: pub::upload_file_to_s3
- function: pub::delete_file_from_s3
- function: pub::retrieve_file_from_s3
**crates/router/src/routes/app.rs**
Modify existing code
|
{"issue_number": 3338, "pr_number": 3348, "commits_count": 1, "files_changed": 18, "response_length": 3622, "file_count": 13, "needs_breakdown": false}
|
feat(router): refactor PML response
Remove duplicate responses and return bank_names
|
<think>
PR Context:
- Title: feat(router): Deduplicate PML response and populate bank details (V2)
- Merged: 2025-07-14T12:45:04Z
- Files changed: 6 files
- Commits: 9 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Merge `payment_experience` for a pm_type, subtype into an array
- Return `bank_names`
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application con
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(router): Deduplicate PML response and populate bank details (V2) (#8583)
Files to modify:
**crates/api_models/src/payment_methods.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/common_enums/src/enums.rs**
Modify existing code
**crates/router/src/core/payment_methods/vault.rs**
Modify existing code
**crates/router/src/core/payments/payment_methods.rs**
Remove:
- function: private::perform_surcharge_calculation
- function: private::perform_filtering
- trait: private::PerformFilteringOnPaymentMethodsEnabled
- impl: impl RequiredFieldsForEnabledPaymentMethodTypes
- impl: impl PerformFilteringOnPaymentMethodsEnabled for hyperswitch_domain_models::merchant_connector_account::FlattenedPaymentMethodsEnabled
Add:
- function: private::perform_filtering
- function: private::merge_and_transform
- function: private::perform_surcharge_calculation
- function: private::get_pm_subtype_specific_data
- function: private::populate_pm_subtype_specific_data
- struct: private::FlattenedPaymentMethodsEnabled
- struct: private::MergedEnabledPaymentMethod
- struct: private::MergedEnabledPaymentMethodTypes
- struct: private::RequiredFieldsAndSurchargeWithExtraInfoForEnabledPaymentMethodType
- struct: private::RequiredFieldsAndSurchargeWithExtraInfoForEnabledPaymentMethodTypes
- impl: impl FlattenedPaymentMethodsEnabled
- impl: impl MergedEnabledPaymentMethodTypes
- impl: impl RequiredFieldsForEnabledPaymentMethodTypes
|
{"issue_number": 8582, "pr_number": 8583, "commits_count": 1, "files_changed": 6, "response_length": 2358, "file_count": 7, "needs_breakdown": false}
|
[FEATURE] return all the `missing_fields` in a request
### Feature Description
During address validation, It would be a good experience to have all the missing fields returned at once instead of making many requests to know the missing fields.
Referring the discussion here https://github.com/juspay/hyperswitch/pull/441#issuecomment-1399482111
### Possible Implementation
A separate error type could be implemented which will take a vector or missing fields and return it.
### Have you spent some time to check if this feature request has been raised before?
- [X] I checked and didn't find similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes I am willing to submit a PR!
|
<think>
PR Context:
- Title: refactor(stripe): return all the missing fields in a request
- Merged: 2023-05-02T20:46:02Z
- Files changed: 9 files
- Commits: 25 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
On address field validation return all the mandatory fields having a null or empty values.
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(stripe): return all the missing fields in a request (#935)
Co-authored-by: jeeva <jeeva.ram
Files to modify:
**crates/common_utils/src/signals.rs**
Add:
- function: pub::signal_handler
- function: pub::get_allowed_signals
- function: pub::handle
- function: pub::close
- struct: pub::DummySignal
- impl: impl DummySignal
**crates/router/src/connector/stripe/transformers.rs**
Add:
- function: private::should_return_ok
- function: private::should_return_err_for_empty_name
- function: private::should_return_err_for_empty_line1
- function: private::should_return_err_for_empty_country
- function: private::should_return_err_for_empty_zip
- function: private::should_return_error_when_missing_multiple_fields
- function: private::get_missing_fields
- function: private::create_stripe_shipping_address
- mod: private::test_validate_shipping_address_against_payment_method
**crates/router/src/core/errors.rs**
Modify existing code
**crates/router/src/macros.rs**
Modify existing code
**crates/router/src/scheduler/utils.rs**
Add:
- function: pub::signal_handler
- function: pub::signal_handler
|
{"issue_number": 451, "pr_number": 935, "commits_count": 1, "files_changed": 9, "response_length": 1977, "file_count": 7, "needs_breakdown": false}
|
feat(core): implement `NameType` for name validation
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
for card holder name in cards, validation is added before creation of request to flag invalid data in case it is present.
Reference is taken from Visa Documetation
<img width="889" alt="image" src="https://github.com/user-attachments/assets/02859794-8313-46fb-a2b2-33a009a03600">
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Tested through Postman:
- Create a MCA (Cybersource):
Case 1: Create a Payment with valid name:
```
{
"amount": 499,
"currency": "EUR",
"confirm": true,
"capture_method": "automatic",
"customer_id": "test_rec7",
"email": "[email protected]",
"customer_acceptance": {
"acceptance_type": "online"
},
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "Sakil Mostak",
"card_cvc": "737",
"card_network": "Visa"
}
},
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here is some \n there is some \n none is some? \n ",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "Sakil",
"last_name": "Mostak"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "[email protected]"
},
"authentication_type": "no_three_ds"
}
```
- The payment should succeed, below is an example:
```
{
"payment_id": "pay_7YANCrkBMUVJngRBg36l",
"merchant_id": "merchant_1737373987",
"status": "succeeded",
"amount": 499,
"net_amount": 499,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": 499,
"connector": "cybersource",
"client_secret": "pay_7YANCrkBMUVJngRBg36l_secret_jp4t6pcoJTnMFrQsGd1R",
"created": "2025-01-20T17:52:24.651Z",
"currency": "EUR",
"customer_id": "test_rec7",
"customer": {
"id": "test_rec7",
"name": null,
"email": "[email protected]",
"phone": null,
"phone_country_code": null
},
"description": null,
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": null,
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "4242",
"card_type": null,
"card_network": null,
"card_issuer": null,
"card_issuing_country": null,
"card_isin": "424242",
"card_extended_bin": null,
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "Sakil Mostak",
"payment_checks": {
"avs_response": {
"code": "X",
"codeRaw": "I1"
},
"card_verification": null
},
"authentication_data": null
},
"billing": null
},
"payment_token": "token_7usZJrOsD3Qoy6kLGDnQ",
"shipping": null,
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here is some \n there is some \n none is some? \n ",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "Sakil",
"last_name": "Mostak"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "[email protected]"
},
"order_details": null,
"email": "[email protected]",
"name": null,
"phone": null,
"return_url": null,
"authentication_type": "no_three_ds",
"statement_descriptor_name": null,
"statement_descriptor_suffix": null,
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "test_rec7",
"created_at": 1737395544,
"expires": 1737399144,
"secret": "epk_b4c0b9ee60c844dd88e6cbc9daa9e7cb"
},
"manual_retry_allowed": false,
"connector_transaction_id": "7373955459786405604807",
"frm_message": null,
"metadata": null,
"connector_metadata": null,
"feature_metadata": null,
"reference_id": "pay_7YANCrkBMUVJngRBg36l_1",
"payment_link": null,
"profile_id": "pro_VcDn0jWTcCmofCpz2CAH",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_KXO79qkYuOXsSZCYByGz",
"incremental_authorization_allowed": false,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2025-01-20T18:07:24.651Z",
"fingerprint": null,
"browser_info": null,
"payment_method_id": null,
"payment_method_status": null,
"updated": "2025-01-20T17:52:26.511Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null
}
```
Case 2: Create a Payment with invalid name:
```
{
"amount": 499,
"currency": "EUR",
"confirm": true,
"capture_method": "automatic",
"customer_id": "test_rec7",
"email": "[email protected]",
"customer_acceptance": {
"acceptance_type": "online"
},
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "S@k*l M0st@k",
"card_cvc": "737",
"card_network": "Visa"
}
},
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here is some \n there is some \n none is some? \n ",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "Sakil",
"last_name": "Mostak"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "[email protected]"
},
"authentication_type": "no_three_ds"
}
```
Response should contain 400 error with below response:
```
{
"error": {
"error_type": "invalid_request",
"message": "Json deserialize error: invalid character found in card holder name: @ at line 23 column 5",
"code": "IR_06"
}
}
```
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [x] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert: implement `NameType` for name validation (#6734)
- Merged: 2025-04-03T16:24:25Z
- Files changed: 30 files
- Commits: 3 commits
Implementation approach:
This reverts commit 1100dcc6053990cf832c00cf29db700d77f78480.
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR revert #6734 in main
This is hotfix for https://github.com/juspay/hyperswitch/pull/7717
Reason: digit couldn't be added to nickname because nickname have the same valid
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6734, "pr_number": 7718, "commits_count": 0, "files_changed": 30, "response_length": 787, "file_count": 0, "needs_breakdown": false}
|
fix(mandate): add mandate_id column in payment_attempt table
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
This change includes
- Adding a new column `mandate_id` in the table `payment_attempt`
- Similarly, adding `mandate_id` field in `PaymentAttempt` structs (which include `New`, `Update` variants)
- Storing `mandate_id`, if generated during payment creation, to the `PaymentAttempt` table (in `PostUpdateTracker`)
<!-- Describe your changes in detail -->
### Additional Changes
- [x] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!-- Provide links to the files with corresponding changes -->
## Motivation and Context
Originally, we didn't have any way to link a payment that is made to a specific mandate. Which makes it impossible to get the related mandate_id while performing a payment sync operation. This change will allow, the payments core to have access to the mandate that is related to the specific payment attempt while performing payment sync and further mandate related functionalities.
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(payment_link): added display_sdk_only option for displaying only sdk without payment details
- Merged: 2024-04-16T13:45:56Z
- Files changed: 7 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently we show payment link with payment details, where
left side of the payment link contains payment details and the right side contains the sdk.
This is a merchant requirement where they want only the sdk to be displayed in payment
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payment_link): added display_sdk_only option for displaying only sdk without payment details (#
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/common_utils/src/consts.rs**
Modify existing code
**crates/router/src/core/payment_link.rs**
Modify existing code
|
{"issue_number": 3, "pr_number": 4363, "commits_count": 1, "files_changed": 7, "response_length": 1198, "file_count": 6, "needs_breakdown": false}
|
[BUG] Make payment method data accessible for `network_transaction_id`
### Bug Description
In the case of `network_transaction_id` some connectors require payment method data. After the new mandate changes a new payment method `MandatePayment` was introduced, which doesn't consider this use case.
### Expected Behavior
The payment method data should be present when the mandate is of type is `network_transaction_id`
### Actual Behavior
The `payment_method_data` is absent and the type is provided as `MandatePayment`
### Steps To Reproduce
Create a recurring payment for authorizedotnet
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the `x-request-id` response header for helping us debug your issue.
If not (or if building/running locally), please provide the following details:
1. Operating System or Linux distribution:
2. Rust version (output of `rustc --version`): ``
3. App version (output of `cargo r -- --version`): ``
### Have you spent some time to check if this bug has been raised before?
- [X] I checked and didn't find similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes I am willing to submit a PR!
|
<think>
PR Context:
- Title: fix(mandate): allow card details to be provided in case of network transaction id
- Merged: 2023-05-13T10:04:06Z
- Files changed: 3 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This change fixes the case where connectors require payment data, when network transaction id is passed. In case of mandate id, no payment data is provided.
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This P
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(mandate): allow card details to be provided in case of network transaction id (#1138)
Files to modify:
**crates/router/src/connector/authorizedotnet/transformers.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
|
{"issue_number": 1139, "pr_number": 1138, "commits_count": 1, "files_changed": 3, "response_length": 1072, "file_count": 4, "needs_breakdown": false}
|
[FEATURE] integrate 3DS for Worldpay connector
### Feature Description
WorldPay offers 3DS capabilities for a card txn. Same needs to be integrated in HyperSwitch.
Flow - https://developer.worldpay.com/products/access/3ds/web
### Possible Implementation
Implementing 3DS for WorldPay requires one additional step of running DDC flows. Flow can be looked at in WorldPay's dev docs
1. Redirect to Worldpay's DDC
2. Redirect to Wordlpay's 3DS redirection form
3. Capture details in HyperSwitch's `/redirect/complete` flow
4. Perform a PSync (optional)
Reference
https://developer.worldpay.com/products/access/3ds/web
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
None
|
<think>
PR Context:
- Title: feat(connector): add 3DS flow for Worldpay
- Merged: 2024-10-21T14:14:20Z
- Files changed: 8 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #6177
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): add 3DS flow for Worldpay (#6374)
Co-authored-by: hyperswitch-bot[bot] <148525504+h
Files to modify:
**crates/diesel_models/src/query/payment_attempt.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_response_types.rs**
Modify existing code
**crates/router/src/connector/worldpay.rs**
Add:
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_flow_type
- impl: impl api::PaymentsCompleteAuthorize for Worldpay
- impl: impl ConnectorIntegration<
api::CompleteAuthorize,
types::CompleteAuthorizeData,
types::PaymentsResponseData,
> for Worldpay
- impl: impl services::ConnectorRedirectResponse for Worldpay
**crates/router/src/connector/worldpay/requests.rs**
Add:
- struct: pub::ThreeDSRequest
- struct: pub::ThreeDSRequestDeviceData
- struct: pub::ThreeDSRequestChallenge
- struct: pub::WorldpayCompleteAuthorizationRequest
- enum: pub::ThreeDSRequestChannel
**crates/router/src/connector/worldpay/response.rs**
Remove:
- function: pub::new
- impl: impl PaymentsResPaymentInstrument
Add:
- function: private::fmt
- struct: pub::ThreeDsChallengedResponse
- struct: pub::AuthenticationResponse
- struct: pub::ThreeDsChallenge
- struct: pub::CompleteThreeDsActionLink
**crates/router/src/connector/worldpay/transformers.rs**
Modify existing code
**crates/router/src/core/payments/flows.rs**
Modify existing code
**crates/router/src/services/api.rs**
Modify existing code
|
{"issue_number": 6177, "pr_number": 6374, "commits_count": 1, "files_changed": 8, "response_length": 2551, "file_count": 10, "needs_breakdown": false}
|
[bug]: fix timestamp sent to kafka events
rdkafka library expects time in millis but we send seconds.
This can be reflected in the kafka-ui at localhost:8090 as well.
We can fix this by either truncating the unix_timestamp_nanos or padding the seconds.
|
<think>
PR Context:
- Title: fix(kafka): fix kafka timestamps sent from application
- Merged: 2024-05-23T09:28:10Z
- Files changed: 5 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
fixes #4706
Convert secs to millis when sending creation timestamp to kafka
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(kafka): fix kafka timestamps sent from application (#4709)
Co-authored-by: hyperswitch-bot[bot]
Files to modify:
**crates/router/src/services/kafka.rs**
Modify existing code
**crates/router/src/services/kafka/dispute.rs**
Remove:
- function: private::creation_timestamp
**crates/router/src/services/kafka/payment_attempt.rs**
Remove:
- function: private::creation_timestamp
**crates/router/src/services/kafka/payment_intent.rs**
Remove:
- function: private::creation_timestamp
**crates/router/src/services/kafka/payout.rs**
Remove:
- function: private::creation_timestamp
|
{"issue_number": 4706, "pr_number": 4709, "commits_count": 1, "files_changed": 5, "response_length": 1395, "file_count": 7, "needs_breakdown": false}
|
fix(connector) : Added signifyd to routableconnectors for frm
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently, Signifyd is mentioned in connectors enum, but not routable connectors enum...this PR is to add that
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
Currently, Signifyd is mentioned in connectors enum, but not routable connectors enum...this PR is to add that
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: revert: fix(connector): Added signifyd to routableconnectors for frm
- Merged: 2023-05-18T12:59:09Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
This PR reverts #1182.
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert: fix(connector): Added signifyd to routableconnectors for frm (#1203)
Files to modify:
**crates/api_models/src/enums.rs**
Modify existing code
|
{"issue_number": 1182, "pr_number": 1203, "commits_count": 1, "files_changed": 1, "response_length": 476, "file_count": 3, "needs_breakdown": false}
|
feat(authn): Use cookies for authentication
Currently we use auth headers and local storage in FE for transfer JWT from FE to BE.
Cookies is a better way to do this, as it is handled by browser and JavaScript doesn't have access to.
First we will test this in Integ and slowly move it to sandbox and production.
|
<think>
PR Context:
- Title: refactor(authn): Enable cookies in Integ
- Merged: 2024-11-26T12:42:14Z
- Files changed: 11 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR will add logging for cookies and also make signout API accessible by any SPT.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [x] This PR modifies application configur
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(authn): Enable cookies in Integ (#6599)
Files to modify:
**crates/router/src/configs/settings.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/routes/user.rs**
Modify existing code
**crates/router/src/services/authentication.rs**
Add:
- function: private::authenticate_and_fetch
- struct: pub::AnyPurposeOrLoginTokenAuth
- impl: impl AuthenticateAndFetch<UserIdFromAuth, A> for AnyPurposeOrLoginTokenAuth
|
{"issue_number": 6598, "pr_number": 6599, "commits_count": 1, "files_changed": 11, "response_length": 1265, "file_count": 6, "needs_breakdown": false}
|
[REFACTOR]: [Worldpay] Remove Default Case Handling
### :memo: Feature Description
- We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
- These conditions generally go hand in hand with enum variants.
- Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
- So, if all the explicit cases are handled then default is used to handle the rest.
- Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a `_` is put to handle all the other cases.
- This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.
### :hammer: Possible Implementation
- Instead of relying on a default match case `_`, developers should handle each and every variant explicitly.
- By doing so, if there are any changes in the future, they can readily assess the impact of their modifications simply by compiling the code.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/1955
:bookmark: Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: refactor(connector): [Worldpay] Remove Default Case Handling
- Merged: 2023-10-25T18:27:57Z
- Files changed: 1 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Instead of relying on a default match case `_` I have added conditions for each type in match statements.
Changes are made at https://github.com/juspay/hyperswitch/blob/main/crates/router/src/connector/worldpay/transformers.rs
## Motivation and Context
Closes #2290
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): [Worldpay] Remove Default Case Handling (#2488)
Co-authored-by: de-harish <hari
Files to modify:
**crates/router/src/connector/worldpay/transformers.rs**
Modify existing code
|
{"issue_number": 2290, "pr_number": 2488, "commits_count": 1, "files_changed": 1, "response_length": 992, "file_count": 3, "needs_breakdown": false}
|
[REFACTOR] Unify the `sandbox` and `production` cargo features
### Description
After #1349, this is the next step towards using a single Docker image across all our environments (see #1346). The `sandbox` and `production` features would have to be unified into a single `release` feature instead. This change would also need corresponding changes in the `Dockerfile` and CI workflows.
|
<think>
PR Context:
- Title: build: unify `sandbox` and `production` cargo features as `release`
- Merged: 2023-06-07T08:34:58Z
- Files changed: 4 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR unifies the `sandbox` and `production` cargo features into a single feature named `release`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the is
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** build: unify `sandbox` and `production` cargo features as `release` (#1356)
Files to modify:
**crates/router/src/core/payment_methods/transformers.rs**
Modify existing code
|
{"issue_number": 1353, "pr_number": 1356, "commits_count": 1, "files_changed": 4, "response_length": 976, "file_count": 3, "needs_breakdown": false}
|
feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLevel and ProfileLevel authentication
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Cherry picked the commit for #5729
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [ ] I formatted the code `cargo +nightly fmt --all`
- [ ] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert: feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLevel and ProfileLevel authentication
- Merged: 2024-09-05T11:19:25Z
- Files changed: 30 files
- Commits: 1 commits
Implementation approach:
Reverts juspay/hyperswitch#5784
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert: feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLeve
Files to modify:
**crates/analytics/src/api_event/core.rs**
Modify existing code
**crates/analytics/src/api_event/filters.rs**
Modify existing code
**crates/analytics/src/api_event/metrics.rs**
Modify existing code
**crates/analytics/src/api_event/metrics/api_count.rs**
Modify existing code
**crates/analytics/src/api_event/metrics/latency.rs**
Modify existing code
**crates/analytics/src/api_event/metrics/status_code_count.rs**
Modify existing code
**crates/analytics/src/clickhouse.rs**
Modify existing code
**crates/analytics/src/disputes/core.rs**
Modify existing code
**crates/analytics/src/disputes/filters.rs**
Modify existing code
**crates/analytics/src/disputes/metrics.rs**
Modify existing code
**crates/analytics/src/disputes/metrics/dispute_status_metric.rs**
Modify existing code
**crates/analytics/src/disputes/metrics/total_amount_disputed.rs**
Modify existing code
**crates/analytics/src/disputes/metrics/total_dispute_lost_amount.rs**
Modify existing code
**crates/analytics/src/enums.rs**
Modify existing code
**crates/analytics/src/errors.rs**
Modify existing code
**crates/analytics/src/lib.rs**
Remove:
- mod: pub::active_payments
- mod: pub::api_event
- mod: pub::auth_events
- mod: pub::connector_events
- mod: pub::enums
- mod: pub::health_check
- mod: pub::opensearch
- mod: pub::outgoing_webhook_event
Add:
- mod: pub::active_payments
- mod: pub::api_event
- mod: pub::auth_events
- mod: pub::connector_events
- mod: pub::health_check
- mod: pub::opensearch
- mod: pub::outgoing_webhook_event
**crates/analytics/src/outgoing_webhook_event/events.rs**
Modify existing code
**crates/analytics/src/payment_intents/core.rs**
Modify existing code
**crates/analytics/src/payment_intents/filters.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics/payment_intent_count.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics/smart_retried_amount.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics/successful_smart_retries.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics/total_smart_retries.rs**
Modify existing code
**crates/analytics/src/payment_intents/types.rs**
Modify existing code
**crates/analytics/src/payments/core.rs**
Modify existing code
**crates/analytics/src/payments/distribution.rs**
Modify existing code
**crates/analytics/src/payments/distribution/payment_error_message.rs**
Modify existing code
**crates/analytics/src/payments/filters.rs**
Remove:
- struct: private::PaymentFilterRow
- trait: pub::PaymentFilterAnalytics
Add:
- struct: private::FilterRow
- trait: pub::PaymentFilterAnalytics
**crates/analytics/src/payments/metrics.rs**
Modify existing code
**crates/analytics/src/payments/metrics/avg_ticket_size.rs**
Modify existing code
**crates/analytics/src/payments/metrics/connector_success_rate.rs**
Modify existing code
**crates/analytics/src/payments/metrics/payment_count.rs**
Modify existing code
**crates/analytics/src/payments/metrics/payment_processed_amount.rs**
Modify existing code
**crates/analytics/src/payments/metrics/payment_success_count.rs**
Modify existing code
**crates/analytics/src/payments/metrics/retries_count.rs**
Modify existing code
**crates/analytics/src/payments/metrics/success_rate.rs**
Modify existing code
**crates/analytics/src/payments/types.rs**
Modify existing code
**crates/analytics/src/query.rs**
Remove:
- function: private::to_sql
- function: private::to_sql
- function: private::to_sql
- function: private::set_filter_clause
- impl: impl ToSql<T> for &MerchantId
- impl: impl ToSql<T> for MerchantId
- impl: impl ToSql<T> for &OrganizationId
- impl: impl ToSql<T> for ProfileId
- impl: impl QueryFilter<T> for AuthInfo
Add:
- impl: impl ToSql<T> for &common_utils::id_type::MerchantId
**crates/analytics/src/refunds/core.rs**
Modify existing code
**crates/analytics/src/refunds/filters.rs**
Modify existing code
**crates/analytics/src/refunds/metrics.rs**
Modify existing code
**crates/analytics/src/refunds/metrics/refund_count.rs**
Modify existing code
**crates/analytics/src/refunds/metrics/refund_processed_amount.rs**
Modify existing code
**crates/analytics/src/refunds/metrics/refund_success_count.rs**
Modify existing code
**crates/analytics/src/refunds/metrics/refund_success_rate.rs**
Modify existing code
**crates/analytics/src/refunds/types.rs**
Modify existing code
**crates/analytics/src/sqlx.rs**
Remove:
- impl: impl FromRow<'a, PgRow> for super::payments::filters::PaymentFilterRow
**crates/api_models/src/analytics.rs**
Modify existing code
**crates/api_models/src/analytics/payment_intents.rs**
Modify existing code
**crates/api_models/src/analytics/payments.rs**
Modify existing code
**crates/api_models/src/analytics/refunds.rs**
Modify existing code
**crates/common_utils/src/types.rs**
Remove:
- mod: pub::authentication
**crates/common_utils/src/types/authentication.rs**
Remove:
- enum: pub::AuthInfo
**crates/hyperswitch_domain_models/src/merchant_account.rs**
Remove:
- function: pub::get_org_id
**crates/router/src/analytics.rs**
Remove:
- function: pub::get_org_payment_metrics
- function: pub::get_merchant_payment_intent_metrics
- function: pub::get_org_payment_intent_metrics
- function: pub::get_merchant_refund_metrics
- function: pub::get_org_refund_metrics
- function: pub::get_profile_refund_filters
- function: pub::get_profile_outgoing_webhook_events
- function: pub::generate_org_dispute_report
- function: pub::generate_profile_dispute_report
- function: pub::get_merchant_api_event_filters
**crates/router/src/core/verification/utils.rs**
Remove:
- function: pub::check_if_profile_id_is_present_in_payment_intent
**crates/router/src/types/domain/user.rs**
Modify existing code
|
{"issue_number": 5784, "pr_number": 5811, "commits_count": 1, "files_changed": 30, "response_length": 6622, "file_count": 60, "needs_breakdown": true}
|
feat(connector): [paypal, trustpay] add in feature matrix
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added paypal, trustpay, nomupay connectors in feature matrix
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
```
curl --location 'http://localhost:8080/feature_matrix' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_jQNBYCfN5R0473yldj23Yl7HsGbCctexthWkELSAMAGpjCxKAspb2fcQDP1KmMJz'
```
Response:
```
{
"connector_count": 2,
"connectors": [
{
"name": "PAYPAL",
"display_name": "Paypal",
"description": "PayPal is a Slovakia-based company specializing in secure e-commerce payments, particularly within the EEA area.",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"Mastercard",
"AmericanExpress",
"DinersClub",
"Discover",
"Interac",
"JCB",
"CartesBancaires"
],
"supported_countries": [
"TTO",
"HND",
"TWN",
"DEU",
"MCO",
"BDI",
"SLV",
"LCA",
"ESP",
"GUF",
"MUS",
"FRO",
"FIN",
"MKD",
"SPM",
"ETH",
"DNK",
"NGA",
"GMB",
"VCT",
"ROU",
"QAT",
"PER",
"MYT",
"TGO",
"NOR",
"TCD",
"KNA",
"DMA",
"FJI",
"POL",
"KOR",
"SLE",
"KIR",
"LAO",
"BFA",
"KWT",
"CRI",
"WSM",
"ABW",
"GBR",
"MWI",
"BHR",
"ZWE",
"BRB",
"MSR",
"BIH",
"SYC",
"TZA",
"NIU",
"COD",
"SMR",
"KAZ",
"NAM",
"BMU",
"CHL",
"ISL",
"LKA",
"NRU",
"BLZ",
"GTM",
"ZMB",
"SGP",
"ARE",
"GIB",
"LSO",
"SUR",
"GAB",
"JPN",
"PAN",
"CHE",
"NCL",
"USA",
"SVK",
"GRD",
"DOM",
"SAU",
"TKM",
"UGA",
"BLR",
"VNM",
"MDV",
"CYP",
"LTU",
"LIE",
"MAR",
"SWZ",
"MHL",
"ERI",
"NER",
"MLT",
"PNG",
"UKR",
"SVN",
"REU",
"NPL",
"PYF",
"FRA",
"NFK",
"SHN",
"CIV",
"ISR",
"COG",
"SJM",
"HKG",
"BWA",
"URY",
"SLB",
"BRA",
"CPV",
"SOM",
"GEO",
"AGO",
"KEN",
"MNE",
"MOZ",
"NIC",
"IND",
"AUS",
"IRL",
"CMR",
"GRL",
"GLP",
"LUX",
"MEX",
"NLD",
"THA",
"CAN",
"HUN",
"PCN",
"PHL",
"TUV",
"AIA",
"VGB",
"PRY",
"KHM",
"DZA",
"GUY",
"MNG",
"BEL",
"TON",
"JAM",
"TCA",
"GNB",
"OMN",
"ZAF",
"COM",
"NZL",
"MDG",
"BRN",
"SRB",
"IDN",
"MLI",
"KGZ",
"AZE",
"VEN",
"RWA",
"ECU",
"GRC",
"COK",
"DJI",
"PRT",
"BHS",
"EGY",
"BTN",
"AUT",
"RUS",
"TUN",
"BOL",
"MYS",
"COL",
"SEN",
"JOR",
"STP",
"HRV",
"ARG",
"FSM",
"GIN",
"ATG",
"MDA",
"SWE",
"ITA",
"LVA",
"EST",
"BEN",
"BGR",
"MRT",
"CZE",
"CYM",
"TJK"
],
"supported_currencies": [
"PLN",
"SEK",
"SGD",
"BRL",
"NZD",
"ILS",
"CHF",
"THB",
"PHP",
"USD",
"CZK",
"JPY",
"CAD",
"CNY",
"MXN",
"GBP",
"HUF",
"HKD",
"EUR",
"MYR",
"NOK",
"AUD",
"DKK",
"TWD"
]
},
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"Mastercard",
"AmericanExpress",
"DinersClub",
"Discover",
"Interac",
"JCB",
"CartesBancaires"
],
"supported_countries": [
"NFK",
"URY",
"FIN",
"NER",
"CAN",
"GMB",
"COM",
"SMR",
"MCO",
"GUF",
"DOM",
"ECU",
"DNK",
"CMR",
"CRI",
"GEO",
"BGR",
"FRA",
"TUN",
"GTM",
"NLD",
"NAM",
"PAN",
"TCA",
"GNB",
"SEN",
"SVK",
"BLZ",
"NZL",
"AGO",
"ATG",
"ISR",
"MRT",
"TON",
"OMN",
"RUS",
"LIE",
"BEN",
"FJI",
"GAB",
"SHN",
"MLT",
"UKR",
"TUV",
"LTU",
"GIN",
"RWA",
"KHM",
"MYS",
"VNM",
"NGA",
"USA",
"TWN",
"DZA",
"MEX",
"AUS",
"MDV",
"SLB",
"CHL",
"MWI",
"ZMB",
"BRA",
"ZWE",
"PCN",
"NIU",
"GRD",
"NOR",
"GUY",
"BTN",
"NRU",
"SAU",
"SJM",
"AZE",
"LAO",
"GBR",
"BHR",
"MDG",
"IND",
"ARG",
"EGY",
"SGP",
"WSM",
"HRV",
"KAZ",
"GIB",
"SPM",
"GLP",
"MDA",
"TKM",
"STP",
"BFA",
"BWA",
"BEL",
"MNE",
"ITA",
"DJI",
"CYP",
"KOR",
"GRC",
"NCL",
"KEN",
"PER",
"VCT",
"CHE",
"FRO",
"KGZ",
"AIA",
"MYT",
"PYF",
"CYM",
"BRB",
"AUT",
"ISL",
"HKG",
"BOL",
"PRY",
"REU",
"IRL",
"JPN",
"COD",
"VGB",
"PHL",
"SWZ",
"EST",
"MAR",
"JOR",
"NIC",
"TZA",
"ETH",
"IDN",
"BMU",
"SUR",
"FSM",
"SLE",
"ROU",
"MNG",
"BHS",
"PNG",
"SOM",
"BRN",
"NPL",
"BDI",
"HND",
"ARE",
"LKA",
"MUS",
"SLV",
"BLR",
"POL",
"CPV",
"JAM",
"SYC",
"TTO",
"MLI",
"ZAF",
"BIH",
"QAT",
"LVA",
"CZE",
"SVN",
"KNA",
"DEU",
"MKD",
"DMA",
"LUX",
"HUN",
"ERI",
"COG",
"COK",
"PRT",
"THA",
"SRB",
"GRL",
"ABW",
"MHL",
"SWE",
"MOZ",
"COL",
"TGO",
"VEN",
"LSO",
"TCD",
"MSR",
"KWT",
"KIR",
"LCA",
"CIV",
"UGA",
"ESP",
"TJK"
],
"supported_currencies": [
"CNY",
"PHP",
"TWD",
"HKD",
"JPY",
"SEK",
"MXN",
"ILS",
"BRL",
"PLN",
"EUR",
"USD",
"DKK",
"HUF",
"AUD",
"CAD",
"CZK",
"NZD",
"MYR",
"NOK",
"GBP",
"SGD",
"CHF",
"THB"
]
},
{
"payment_method": "wallet",
"payment_method_type": "paypal",
"payment_method_type_display_name": "PayPal",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"NCL",
"MRT",
"DMA",
"MYS",
"GIN",
"STP",
"MKD",
"CAN",
"SLV",
"ISR",
"TTO",
"KOR",
"KIR",
"SMR",
"COG",
"MLT",
"MSR",
"KWT",
"ITA",
"COK",
"SLE",
"MNG",
"MOZ",
"FRO",
"GRL",
"TCD",
"DNK",
"MWI",
"URY",
"CPV",
"CMR",
"MDA",
"ESP",
"HND",
"UKR",
"MLI",
"AUT",
"SGP",
"TJK",
"DEU",
"POL",
"SWE",
"GUY",
"SRB",
"KNA",
"ETH",
"THA",
"NPL",
"MUS",
"PAN",
"NIU",
"LKA",
"VEN",
"GLP",
"BRB",
"OMN",
"SWZ",
"MDV",
"PRT",
"LIE",
"SUR",
"ISL",
"LTU",
"AZE",
"TGO",
"FIN",
"LSO",
"HRV",
"PYF",
"CHL",
"NGA",
"BRN",
"NZL",
"FSM",
"LAO",
"MYT",
"LCA",
"BFA",
"BTN",
"ATG",
"CYM",
"HKG",
"ZMB",
"CYP",
"SYC",
"COL",
"AGO",
"HUN",
"MAR",
"CIV",
"DOM",
"BHR",
"SJM",
"KGZ",
"SOM",
"DZA",
"EST",
"MHL",
"PNG",
"MCO",
"TZA",
"GNB",
"WSM",
"KAZ",
"MNE",
"QAT",
"NAM",
"KEN",
"COD",
"TON",
"AIA",
"PHL",
"TCA",
"SEN",
"ERI",
"JAM",
"SHN",
"BEN",
"GIB",
"RUS",
"EGY",
"BOL",
"REU",
"ABW",
"GMB",
"ARG",
"VNM",
"IND",
"LVA",
"NOR",
"MDG",
"GUF",
"TUV",
"GEO",
"TKM",
"ARE",
"JPN",
"VCT",
"SAU",
"FRA",
"GTM",
"SVN",
"TWN",
"LUX",
"NRU",
"KHM",
"BGR",
"BMU",
"BHS",
"ZAF",
"NER",
"TUN",
"PER",
"NIC",
"UGA",
"AUS",
"SPM",
"BIH",
"SLB",
"IRL",
"COM",
"NFK",
"BDI",
"GRD",
"VGB",
"GBR",
"BLR",
"BRA",
"PCN",
"MEX",
"FJI",
"GRC",
"CHE",
"BLZ",
"BEL",
"IDN",
"GAB",
"PRY",
"ROU",
"JOR",
"SVK",
"NLD",
"USA",
"DJI",
"CRI",
"CZE",
"BWA",
"RWA",
"ZWE",
"ECU"
],
"supported_currencies": [
"GBP",
"USD",
"ILS",
"MYR",
"DKK",
"CZK",
"MXN",
"HUF",
"SEK",
"JPY",
"EUR",
"HKD",
"TWD",
"PLN",
"SGD",
"AUD",
"BRL",
"PHP",
"NOK",
"NZD",
"CAD",
"CHF",
"THB",
"CNY"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "eps",
"payment_method_type_display_name": "EPS",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"MDV",
"VGB",
"COG",
"SUR",
"LTU",
"KGZ",
"USA",
"BOL",
"SRB",
"MLI",
"GMB",
"CAN",
"PAN",
"GRD",
"CYP",
"PNG",
"RUS",
"KWT",
"PHL",
"CYM",
"BTN",
"GAB",
"TKM",
"SVN",
"GIN",
"AGO",
"GUF",
"NGA",
"COK",
"LAO",
"BHR",
"SJM",
"TJK",
"BRB",
"BEL",
"FRO",
"SHN",
"TCA",
"TON",
"BLR",
"NIU",
"MNG",
"AIA",
"NAM",
"KNA",
"DOM",
"HND",
"KOR",
"KIR",
"MYT",
"JAM",
"TZA",
"ABW",
"CRI",
"DMA",
"PCN",
"CZE",
"DJI",
"IDN",
"HRV",
"DNK",
"IRL",
"AUS",
"GTM",
"ISL",
"NPL",
"GRC",
"THA",
"GIB",
"LCA",
"CHL",
"SLV",
"AUT",
"VEN",
"NOR",
"MKD",
"ZWE",
"ECU",
"MDA",
"GNB",
"SWE",
"KAZ",
"CIV",
"FSM",
"FRA",
"NER",
"GLP",
"TTO",
"ETH",
"VCT",
"EGY",
"NRU",
"SWZ",
"HUN",
"GUY",
"NLD",
"GRL",
"MWI",
"JPN",
"BGR",
"OMN",
"BRN",
"HKG",
"JOR",
"NCL",
"PER",
"DZA",
"CMR",
"PRY",
"MRT",
"SYC",
"BIH",
"BWA",
"ITA",
"ISR",
"SGP",
"TWN",
"COM",
"LIE",
"MLT",
"MAR",
"MEX",
"SLB",
"MOZ",
"NFK",
"NZL",
"MDG",
"FJI",
"DEU",
"ESP",
"KHM",
"MSR",
"CHE",
"GEO",
"ARG",
"SLE",
"ATG",
"EST",
"PYF",
"BRA",
"ERI",
"SOM",
"UGA",
"LSO",
"SMR",
"LKA",
"TUN",
"GBR",
"BHS",
"STP",
"BEN",
"PRT",
"IND",
"FIN",
"MCO",
"TGO",
"BDI",
"MNE",
"VNM",
"TUV",
"TCD",
"NIC",
"UKR",
"URY",
"LVA",
"QAT",
"POL",
"SEN",
"BMU",
"SVK",
"MYS",
"COD",
"RWA",
"MHL",
"MUS",
"ARE",
"ZAF",
"WSM",
"ZMB",
"AZE",
"BLZ",
"KEN",
"BFA",
"ROU",
"SPM",
"SAU",
"REU",
"CPV",
"COL",
"LUX"
],
"supported_currencies": [
"PHP",
"SEK",
"CAD",
"EUR",
"BRL",
"SGD",
"CNY",
"NOK",
"NZD",
"THB",
"TWD",
"CZK",
"GBP",
"CHF",
"MYR",
"JPY",
"ILS",
"AUD",
"MXN",
"HUF",
"PLN",
"USD",
"DKK",
"HKD"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "giropay",
"payment_method_type_display_name": "Giropay",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"STP",
"GRC",
"ZMB",
"MUS",
"CHE",
"BRB",
"KGZ",
"BFA",
"TCA",
"GMB",
"SUR",
"MSR",
"COL",
"DJI",
"JOR",
"NFK",
"WSM",
"GAB",
"PRY",
"GNB",
"IND",
"MAR",
"KEN",
"TON",
"MLI",
"GBR",
"LCA",
"SGP",
"MHL",
"MKD",
"COG",
"BTN",
"MDG",
"SMR",
"AUT",
"LIE",
"LAO",
"FRA",
"OMN",
"THA",
"BGR",
"KOR",
"REU",
"GLP",
"CMR",
"ABW",
"BOL",
"MOZ",
"HUN",
"SPM",
"CHL",
"TJK",
"BRA",
"NPL",
"COD",
"ETH",
"TCD",
"SVK",
"PHL",
"AUS",
"MDV",
"VGB",
"CRI",
"MDA",
"PER",
"COK",
"CYP",
"MEX",
"KAZ",
"MNG",
"RWA",
"SWE",
"GUF",
"BRN",
"ISL",
"SLE",
"TZA",
"NIC",
"SRB",
"RUS",
"BLR",
"MNE",
"MCO",
"GUY",
"TGO",
"NZL",
"TKM",
"QAT",
"SLV",
"FJI",
"NER",
"BIH",
"SAU",
"TTO",
"NOR",
"VEN",
"TUN",
"BEN",
"LVA",
"EGY",
"MRT",
"USA",
"NCL",
"FRO",
"IDN",
"TWN",
"GEO",
"SYC",
"SVN",
"ESP",
"VCT",
"CAN",
"BMU",
"ZWE",
"EST",
"SEN",
"ZAF",
"MYT",
"PAN",
"BHR",
"PRT",
"SJM",
"SHN",
"CIV",
"CYM",
"GIN",
"KNA",
"UGA",
"VNM",
"BEL",
"AGO",
"AZE",
"LKA",
"UKR",
"PYF",
"GTM",
"COM",
"JAM",
"DEU",
"ITA",
"MYS",
"DOM",
"HKG",
"ARG",
"ECU",
"CZE",
"DNK",
"KHM",
"ARE",
"GRD",
"IRL",
"SOM",
"CPV",
"MLT",
"TUV",
"MWI",
"ROU",
"BDI",
"ISR",
"NIU",
"ATG",
"FSM",
"NAM",
"BLZ",
"LSO",
"NLD",
"URY",
"BWA",
"PNG",
"NRU",
"KIR",
"SLB",
"ERI",
"FIN",
"KWT",
"POL",
"NGA",
"BHS",
"AIA",
"HRV",
"DZA",
"DMA",
"GIB",
"GRL",
"HND",
"SWZ",
"JPN",
"LTU",
"LUX",
"PCN"
],
"supported_currencies": [
"PHP",
"NZD",
"CNY",
"GBP",
"CHF",
"SGD",
"USD",
"ILS",
"BRL",
"AUD",
"TWD",
"PLN",
"CZK",
"DKK",
"EUR",
"MYR",
"MXN",
"CAD",
"THB",
"NOK",
"HKD",
"HUF",
"JPY",
"SEK"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "ideal",
"payment_method_type_display_name": "iDEAL",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"HRV",
"BTN",
"MDA",
"ESP",
"SWE",
"NAM",
"FRA",
"ARG",
"PCN",
"MNE",
"PHL",
"LCA",
"CMR",
"MNG",
"ISL",
"SAU",
"CHE",
"FIN",
"KIR",
"BMU",
"GUF",
"EGY",
"UGA",
"SLV",
"DJI",
"HUN",
"GNB",
"AZE",
"JOR",
"BRB",
"LKA",
"SGP",
"THA",
"CIV",
"TUV",
"COK",
"SWZ",
"SPM",
"VNM",
"NPL",
"CRI",
"LVA",
"ECU",
"GTM",
"CPV",
"BIH",
"COL",
"ITA",
"HND",
"ATG",
"RUS",
"ZWE",
"IRL",
"BLR",
"NIU",
"IND",
"MRT",
"SEN",
"BHS",
"TZA",
"MSR",
"DZA",
"PNG",
"BWA",
"GLP",
"ISR",
"DNK",
"SVK",
"TON",
"MUS",
"CYP",
"MEX",
"KHM",
"KOR",
"ERI",
"ZAF",
"QAT",
"BRA",
"LUX",
"COG",
"GBR",
"NCL",
"TKM",
"JPN",
"KWT",
"FSM",
"KEN",
"MCO",
"PRT",
"GRL",
"TJK",
"BRN",
"NOR",
"DEU",
"LSO",
"STP",
"GEO",
"GIN",
"SVN",
"VCT",
"VGB",
"NER",
"GRC",
"OMN",
"KGZ",
"COD",
"FRO",
"KAZ",
"FJI",
"KNA",
"BHR",
"EST",
"NLD",
"TGO",
"LAO",
"NFK",
"REU",
"NIC",
"UKR",
"SJM",
"JAM",
"GIB",
"TTO",
"PYF",
"BEL",
"IDN",
"CYM",
"BFA",
"PRY",
"ARE",
"BLZ",
"COM",
"ZMB",
"MOZ",
"RWA",
"SMR",
"BDI",
"TWN",
"CZE",
"SYC",
"TUN",
"MLI",
"MYS",
"TCA",
"MAR",
"CAN",
"AGO",
"SOM",
"URY",
"ETH",
"SHN",
"MHL",
"GMB",
"AUS",
"MDG",
"GRD",
"LTU",
"AUT",
"NRU",
"SLE",
"GUY",
"NGA",
"ROU",
"SRB",
"MYT",
"WSM",
"PAN",
"NZL",
"BOL",
"GAB",
"DMA",
"ABW",
"LIE",
"TCD",
"AIA",
"CHL",
"SUR",
"PER",
"BEN",
"SLB",
"MWI",
"MDV",
"MKD",
"BGR",
"VEN",
"USA",
"MLT",
"DOM",
"HKG",
"POL"
],
"supported_currencies": [
"TWD",
"USD",
"DKK",
"MYR",
"NOK",
"CNY",
"MXN",
"CZK",
"ILS",
"CAD",
"NZD",
"SEK",
"CHF",
"SGD",
"PLN",
"PHP",
"GBP",
"HUF",
"EUR",
"HKD",
"THB",
"AUD",
"JPY",
"BRL"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "sofort",
"payment_method_type_display_name": "Sofort",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"IRL",
"NGA",
"MDA",
"BRN",
"GUY",
"RUS",
"IND",
"BLR",
"BMU",
"NCL",
"MUS",
"NOR",
"MYT",
"KOR",
"GNB",
"GLP",
"GIB",
"NIC",
"PCN",
"SLE",
"GBR",
"SMR",
"COK",
"GIN",
"THA",
"LTU",
"TCA",
"ESP",
"VNM",
"TZA",
"AIA",
"BGR",
"COD",
"TUN",
"TJK",
"PYF",
"PAN",
"NFK",
"CHE",
"TWN",
"BRA",
"ISL",
"AUS",
"PRY",
"MWI",
"ARE",
"KWT",
"TUV",
"ATG",
"SLB",
"SLV",
"MNE",
"FRA",
"COM",
"CYP",
"LVA",
"KNA",
"HKG",
"HUN",
"EST",
"KGZ",
"NPL",
"PER",
"CYM",
"JOR",
"URY",
"MEX",
"SWZ",
"TCD",
"WSM",
"BFA",
"MKD",
"SOM",
"MAR",
"SWE",
"CZE",
"BDI",
"GAB",
"BIH",
"SJM",
"DJI",
"LUX",
"CAN",
"GTM",
"UKR",
"FJI",
"KEN",
"SUR",
"MRT",
"REU",
"PNG",
"ZAF",
"NAM",
"GUF",
"BWA",
"GMB",
"SVK",
"BHR",
"GRC",
"MNG",
"BOL",
"JPN",
"ECU",
"POL",
"IDN",
"CHL",
"SPM",
"USA",
"TTO",
"MHL",
"NER",
"QAT",
"TKM",
"VGB",
"BEL",
"CRI",
"KAZ",
"MYS",
"ABW",
"MSR",
"LCA",
"OMN",
"ERI",
"SGP",
"KIR",
"MDG",
"VCT",
"AGO",
"MCO",
"NIU",
"AUT",
"UGA",
"MLI",
"SYC",
"NZL",
"DOM",
"TON",
"DEU",
"COG",
"ISR",
"ZMB",
"FSM",
"DNK",
"STP",
"RWA",
"LIE",
"SAU",
"SVN",
"ROU",
"LSO",
"BHS",
"VEN",
"COL",
"TGO",
"KHM",
"BEN",
"NLD",
"LAO",
"GEO",
"AZE",
"NRU",
"SRB",
"CPV",
"GRL",
"FRO",
"SHN",
"HND",
"EGY",
"ZWE",
"PRT",
"BLZ",
"BTN",
"HRV",
"MLT",
"JAM",
"ITA",
"DZA",
"MOZ",
"FIN",
"CMR",
"DMA",
"PHL",
"MDV",
"LKA",
"SEN",
"ETH",
"BRB",
"GRD",
"CIV",
"ARG"
],
"supported_currencies": [
"BRL",
"ILS",
"PHP",
"THB",
"SGD",
"TWD",
"CZK",
"MXN",
"NZD",
"NOK",
"MYR",
"AUD",
"GBP",
"SEK",
"CHF",
"HUF",
"USD",
"DKK",
"CNY",
"PLN",
"HKD",
"CAD",
"EUR",
"JPY"
]
}
],
"supported_webhook_flows": [
"payments",
"refunds",
"disputes"
]
},
{
"name": "TRUSTPAY",
"display_name": "Trustpay",
"description": "TrustPay is a Slovakia-based company specializing in secure e-commerce payments, particularly within the EEA area.",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"Mastercard",
"AmericanExpress",
"DinersClub",
"Discover",
"Interac",
"JCB",
"CartesBancaires",
"UnionPay"
],
"supported_countries": null,
"supported_currencies": [
"DKK",
"GBP",
"NOK",
"HUF",
"CHF",
"USD",
"CZK",
"AUD",
"SEK",
"EUR",
"CAD",
"PLN",
"NZD",
"RON"
]
},
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"Mastercard",
"AmericanExpress",
"DinersClub",
"Discover",
"Interac",
"JCB",
"CartesBancaires",
"UnionPay"
],
"supported_countries": null,
"supported_currencies": [
"NOK",
"HUF",
"NZD",
"CHF",
"GBP",
"RON",
"AUD",
"USD",
"SEK",
"PLN",
"EUR",
"CAD",
"DKK",
"CZK"
]
},
{
"payment_method": "bank_transfer",
"payment_method_type": "instant_bank_transfer",
"payment_method_type_display_name": "Instant Bank Transfer",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"SVK",
"AUT",
"DEU",
"GBR",
"ITA",
"CZE"
],
"supported_currencies": [
"GBP",
"EUR",
"CZK"
]
},
{
"payment_method": "bank_transfer",
"payment_method_type": "sepa_bank_transfer",
"payment_method_type_display_name": "SEPA Bank Transfer",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": null,
"supported_currencies": null
},
{
"payment_method": "bank_redirect",
"payment_method_type": "giropay",
"payment_method_type_display_name": "Giropay",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": null,
"supported_currencies": null
},
{
"payment_method": "bank_redirect",
"payment_method_type": "sofort",
"payment_method_type_display_name": "Sofort",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"NLD"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "eps",
"payment_method_type_display_name": "EPS",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"AUT"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "ideal",
"payment_method_type_display_name": "iDEAL",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"AUT"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "blik",
"payment_method_type_display_name": "BLIK",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"POL"
],
"supported_currencies": [
"PLN"
]
}
],
"supported_webhook_flows": [
"payments",
"refunds",
"disputes"
]
},
]
}
```
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: feat(connector): revert [paypal, trustpay] add in feature matrix
- Merged: 2025-05-15T14:22:25Z
- Files changed: 9 files
- Commits: 1 commits
Implementation approach:
ORIGINAL PR: https://github.com/juspay/hyperswitch/pull/8042
Reverts juspay/hyperswitch#7911
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): revert [paypal, trustpay] add in feature matrix (#8046)
Files to modify:
**crates/hyperswitch_connectors/src/connectors/paypal.rs**
Remove:
- function: private::get_connector_about
- function: private::get_supported_payment_methods
- function: private::get_supported_webhook_flows
- impl: impl ConnectorSpecifications for Paypal
Add:
- function: private::validate_connector_against_payment_request
- impl: impl ConnectorSpecifications for Paypal
**crates/hyperswitch_connectors/src/connectors/trustpay.rs**
Remove:
- function: private::get_connector_about
- function: private::get_supported_payment_methods
- function: private::get_supported_webhook_flows
- impl: impl ConnectorSpecifications for Trustpay
Add:
- impl: impl ConnectorSpecifications for Trustpay
|
{"issue_number": 7911, "pr_number": 8046, "commits_count": 1, "files_changed": 9, "response_length": 1222, "file_count": 4, "needs_breakdown": false}
|
[FEATURE] scheme error code and messages in /payments API response
### Feature Description
If the payment is declined for a card transaction, the card scheme or issuer can send a raw response explaining why. These are the raw acquirer responses which helps in understanding why a card transaction was declined.
Some connectors like Adyen supports this - [reference](https://docs.adyen.com/development-resources/raw-acquirer-responses/#search-modal).
HyperSwitch today sends back `error_code` and `error_message` in the payments API response which are connector's error code and messages. Payments API response has to be extended to send back issuer specific error codes and messages.
### Possible Implementation
Issuer's error code and messages are received in payments API response or through webhooks. Considering this, below steps are to be followed
1. Ensure issuer's error code and messages are sent back from connector integration to core layer in `ErrorResponse`
2. Ensure this is handled in `IncomingWebhook` flows
3. Ensure this is stored in `payment_attempt` table
4. Ensure this is sent back in payments response
##### Changes required
1. Add below fields in `payment_attempt` table
- `issuer_error_code`
- `issuer_error_message`
2. Add below fields to payments API response
- `issuer_error_code`
- `issuer_error_message`
This maintains the existing naming convention. Today, HyperSwitch has -
- `error_code` and `unified_code`
- `error_message` and `unified_message`
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat: scheme error code and messages in payments api response
- Merged: 2025-03-17T15:03:23Z
- Files changed: 30 files
- Commits: 13 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR introduces -
- Core functionality to read and store raw acquirer responses for `payment` and `refund` operations.
- Read raw acquirer response from connector integration
- Store in `PaymentAttempt` and `Refund` tables
- Updates Adyen connector integration to read r
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat: scheme error code and messages in payments api response (#7528)
Co-authored-by: hyperswitch-bo
Files to modify:
**crates/api_models/src/payments.rs**
Modify existing code
**crates/api_models/src/refunds.rs**
Modify existing code
**crates/diesel_models/src/payment_attempt.rs**
Modify existing code
**crates/diesel_models/src/refund.rs**
Modify existing code
**crates/diesel_models/src/schema.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/aci.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/adyen.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/adyen/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/airwallex.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/amazonpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/authorizedotnet.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/authorizedotnet/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bambora.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bamboraapac.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bamboraapac/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bankofamerica.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bankofamerica/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/billwerk.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/billwerk/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bitpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bluesnap.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/boku.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/braintree.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/braintree/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cashtocode.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cashtocode/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/chargebee.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/checkout.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/checkout/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/coinbase.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/coingate.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cryptopay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cryptopay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cybersource.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/datatrans.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/datatrans/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/deutschebank.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/digitalvirgo.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/dlocal.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/elavon/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/fiserv.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/fiservemea.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/fiuu.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/fiuu/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/forte.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/getnet.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/globalpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/globalpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/globepay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/globepay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/gocardless.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/helcim.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/hipay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/hipay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/iatapay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/iatapay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/inespay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/inespay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/itaubank.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/jpmorgan.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/juspaythreedsserver.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/klarna.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/mifinity.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/mollie.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/moneris.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/multisafepay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nexinets.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nexixpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nomupay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/noon.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/noon/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/novalnet.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nuvei/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/opayo.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/opennode.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paybox.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paybox/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payeezy.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payme.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payme/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paypal.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paystack.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paystack/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payu.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/placetopay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/powertranz.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/powertranz/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/prophetpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/prophetpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/rapyd.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/rapyd/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/razorpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/razorpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/recurly.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/redsys.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/shift4.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/square.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/stax.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/stripebilling.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/taxjar.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/thunes.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/trustpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/trustpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/tsys/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/unified_authentication_service.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/volt.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/volt/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/wellsfargo.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/wellsfargo/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/xendit.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/xendit/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/zen.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/zen/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/zsl.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/zsl/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/utils.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/errors/api_error_response.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_attempt.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_data.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/api.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/connector_integration_v2.rs**
Modify existing code
**crates/router/src/connector/adyenplatform.rs**
Modify existing code
**crates/router/src/connector/dummyconnector.rs**
Modify existing code
**crates/router/src/connector/ebanx.rs**
Modify existing code
**crates/router/src/connector/gpayments.rs**
Modify existing code
**crates/router/src/connector/netcetera.rs**
Modify existing code
**crates/router/src/connector/netcetera/transformers.rs**
Modify existing code
**crates/router/src/connector/nmi.rs**
Modify existing code
**crates/router/src/connector/nmi/transformers.rs**
Modify existing code
**crates/router/src/connector/payone.rs**
Modify existing code
**crates/router/src/connector/plaid.rs**
Modify existing code
**crates/router/src/connector/plaid/transformers.rs**
Modify existing code
**crates/router/src/connector/riskified.rs**
Modify existing code
**crates/router/src/connector/signifyd.rs**
Modify existing code
**crates/router/src/connector/stripe.rs**
Modify existing code
**crates/router/src/connector/stripe/transformers.rs**
Modify existing code
**crates/router/src/connector/threedsecureio.rs**
Modify existing code
**crates/router/src/connector/threedsecureio/transformers.rs**
Modify existing code
**crates/router/src/connector/utils.rs**
Modify existing code
**crates/router/src/connector/wellsfargopayout.rs**
Modify existing code
**crates/router/src/connector/wise.rs**
Modify existing code
**crates/router/src/core/payments/access_token.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_response.rs**
Modify existing code
**crates/router/src/core/payments/retry.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/core/payouts/access_token.rs**
Modify existing code
**crates/router/src/core/refunds.rs**
Modify existing code
**crates/router/src/db/refund.rs**
Modify existing code
**crates/router/src/services/api.rs**
Modify existing code
**crates/router/src/utils.rs**
Modify existing code
**crates/router/src/workflows/payment_sync.rs**
Modify existing code
**crates/router/tests/payments.rs**
Modify existing code
**crates/router/tests/payments2.rs**
Modify existing code
**crates/storage_impl/src/mock_db/payment_attempt.rs**
Modify existing code
**crates/storage_impl/src/payments/payment_attempt.rs**
Modify existing code
|
{"issue_number": 7467, "pr_number": 7528, "commits_count": 1, "files_changed": 30, "response_length": 14386, "file_count": 162, "needs_breakdown": true}
|
[BUG] Add metrics in router scheduler flow as it is being ignored now
### Bug Description
Router is not maintaining any metrics about the task added in scheduler. this has to be fixed
File: crates/router/src/core/payments/helpers.rs
Method: add_domain_task_to_pt
### Expected Behavior
Metrics has to be added to know the TASKS_ADDED_COUNT and TASKS_RESET_COUNT
### Actual Behavior
Currently those are not available
### Steps To Reproduce
NA
### Context For The Bug
_No response_
### Environment
NA
### Have you spent some time checking if this bug has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
None
|
<think>
PR Context:
- Title: fix(metrics): Add TASKS_ADDED_COUNT and TASKS_RESET_COUNT metrics in router scheduler flow
- Merged: 2024-01-18T10:29:35Z
- Files changed: 8 files
- Commits: 9 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
Currently `TASKS_ADDED_COUNT` and `TASKS_RESET_COUNT` metrics does not exist in router to track the tasks added in scheduler. This PR aims at adding that.
Closes #2090
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd r
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(metrics): Add TASKS_ADDED_COUNT and TASKS_RESET_COUNT metrics in router scheduler flow (#3189)
Files to modify:
**crates/router/src/core/api_keys.rs**
Modify existing code
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
**crates/router/src/core/payment_methods/vault.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Modify existing code
**crates/router/src/core/refunds.rs**
Modify existing code
**crates/router/src/routes/metrics.rs**
Modify existing code
**crates/router/src/workflows/api_key_expiry.rs**
Modify existing code
**crates/scheduler/src/metrics.rs**
Modify existing code
|
{"issue_number": 2090, "pr_number": 3189, "commits_count": 1, "files_changed": 8, "response_length": 1485, "file_count": 10, "needs_breakdown": false}
|
Migrate from cargo2nix to rust-flake
Migrate the Nix build/shell system from cargo2nix to rust-flake.
**Parent Issue:** #57
**Related PR:** #8503
## Acceptance Criteria
- [x] Migrate from cargo2nix to rust-flake
- [x] Verify nix CI/CD compatibility
|
<think>
PR Context:
- Title: refactor(nix): Migrate from cargo2nix to rust-flake
- Merged: 2025-07-15T08:20:23Z
- Files changed: 7 files
- Commits: 6 commits
Implementation approach:
# Migrate Nix Configuration to rust-flake
This PR refactors the existing Nix setup by migrating from `cargo2nix` to `rust-flake`.
Resolves: #8538
## TODO:
- [x] **Initial port** - Port current `flake.nix` functionality using rust-flake
- [x] @kashif-m The current [`flake.nix`](https://github.com/juspay/hyperswitch/blob/d305fad2e6c403fde11b9eea785fddefbf3477df/flake.nix#L63-L78) has `default`, `dev`, and `qa` shells. Are all three required? Typically we use `default` for development
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8538, "pr_number": 8503, "commits_count": 0, "files_changed": 7, "response_length": 781, "file_count": 1, "needs_breakdown": false}
|
fix(connector): [Worldpay] add root CA certificate
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds below changes for the Worldpay connector
1. Add a root CA certificate for Worldpay's request client
2. Add a new AuthType for Worldpay - MultiAuthType
3. Use `MultiAuthType` in wasm crate for Worldpay
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
4. `crates/router/src/configs`
5. `loadtest/config`
-->
## Motivation and Context
This fixes the self signed certificate not trusted errors for Worldpay in production.
## How did you test it?
Cannot be tested in non prod env.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert(connector): [Worldpay] add root CA certificate
- Merged: 2025-06-10T08:33:22Z
- Files changed: 5 files
- Commits: 1 commits
Implementation approach:
Reverts juspay/hyperswitch#8205
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert(connector): [Worldpay] add root CA certificate (#8224)
Files to modify:
**crates/hyperswitch_connectors/src/connectors/worldpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs**
Modify existing code
|
{"issue_number": 8205, "pr_number": 8224, "commits_count": 1, "files_changed": 5, "response_length": 579, "file_count": 4, "needs_breakdown": false}
|
fix(cards): Return a 200 response indicating that a customer is none
## Type of Change
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Bug Description
CustomerPaymentMethodsListResponse returns 404 when there is no customer tied to a payment
Proposed Behavior
Return a 200 response somehow indicating that a customer is not associated with the payment
Current Behavior
A 404 response with "Customer does not exist in our records" is being returned, although the customer_id is null
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
Fixes https://github.com/juspay/hyperswitch/issues/3767
|
<think>
PR Context:
- Title: fix(cards): Return a 200 response indicating that a customer is none
- Merged: 2024-02-23T10:31:26Z
- Files changed: 3 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Bug Description
CustomerPaymentMethodsListResponse returns 404 when there is no customer tied to a payment
Proposed Behavior
Return a 200 response indicating that a customer is not associated with the payment
Current Behavior
A 404 response with "Customer does not exist in ou
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(cards): Return a 200 response indicating that a customer is none (#3796)
Files to modify:
**crates/api_models/src/payment_methods.rs**
Modify existing code
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
|
{"issue_number": 3773, "pr_number": 3796, "commits_count": 1, "files_changed": 3, "response_length": 1040, "file_count": 4, "needs_breakdown": false}
|
[CHORE] Update GlobalPay production endpoint
at present, production endpoint points to sandbox and we need to point to production url
|
<think>
PR Context:
- Title: chore: update production endpoint url for globalPay
- Merged: 2025-03-24T08:11:04Z
- Files changed: 4 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR updates the production endpoint url environment value for GlobalPay while fixing minor inconsistencies
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR mo
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** chore: update production endpoint url for globalPay (#7588)
Co-authored-by: hyperswitch-bot[bot] <14
Files to modify:
**crates/hyperswitch_connectors/src/connectors/globalpay.rs**
Modify existing code
|
{"issue_number": 7587, "pr_number": 7588, "commits_count": 1, "files_changed": 4, "response_length": 988, "file_count": 3, "needs_breakdown": false}
|
[REFACTOR] The `Drop` implementation on `RedisConnectionPool` seems unnecessary
### Description
I'll keep this issue as a source of documentation and decisions taken regarding the graceful shutdown of Redis connections.
When I was working on #1743, I noticed that the `Drop` implementation on `RedisConnectionPool` caused panics when tests were being run.
https://github.com/juspay/hyperswitch/blob/1ab4226c780e9205785f012fd1c48c7a4bafb48f/crates/redis_interface/src/lib.rs#L197-L203
When I went down the rabbit hole of identifying possible solutions to it, I found that none of the log messages within [`close_connections()`](https://github.com/juspay/hyperswitch/blob/1ab4226c780e9205785f012fd1c48c7a4bafb48f/crates/redis_interface/src/lib.rs#L157-L179) were ever printed. To address this, I temporarily added a `std::mem::forget(_guard)` line in `router/src/bin/router.rs` so that the logs would be available.
This brought out the fact that all attempts by us to close Redis connections (the connection pool, publisher client and subscriber client) were failing with the following warning:
```text
Fatal error sending QUIT command to router. Client may be stopped or not yet initialized.
```
When I attached the debugger, set a debugger breakpoint at the first line of the `Drop` implementation and listed Redis clients using the `redis-cli` tool, there were no Redis clients arising from the application in the list, and the warning was indeed correct.
It seems that Redis connections are being closed before even the `Drop` implementation has been entered, and I'm unable to explain why. I couldn't find anything relevant in the `fred` codebase either. I was able to reproduce this with a Redis cluster set up using Docker Compose.
|
<think>
PR Context:
- Title: refactor(redis_interface): remove the `Drop` implementation on `RedisConnectionPool`
- Merged: 2023-07-25T10:11:56Z
- Files changed: 2 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR drops the `Drop` implementation (pun intended) on `RedisConnectionPool`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(redis_interface): remove the `Drop` implementation on `RedisConnectionPool` (#1786)
Files to modify:
**crates/redis_interface/src/lib.rs**
Remove:
- function: pub::close_connections
- function: private::drop
- impl: impl Drop for RedisConnectionPool
**crates/router/src/connection.rs**
Modify existing code
|
{"issue_number": 1782, "pr_number": 1786, "commits_count": 1, "files_changed": 2, "response_length": 1151, "file_count": 4, "needs_breakdown": false}
|
fix(router): handle JSON connector response parse error
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Certain connectors (Braintree, Rapyd, Trustpay, Boku) send error response in HTML or string format. This lead to a ``HE_00`` in our system as we try to accept it in a JSON format. Now we have introduced a ``get_json_deserialized`` function in router/utils.rs that can be used to handle Json error. Json Error handling is implemented for Trustpay, Rapyd and Braintree. Boku already handles it.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
<img width="1074" alt="Screen Shot 2023-08-08 at 8 16 57 PM" src="https://github.com/juspay/hyperswitch/assets/131388445/0ca8396b-9379-4372-9750-b77d3afd362f">
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: fix(connector): [Braintree] add merchant_account_id field in authorize request
- Merged: 2023-08-10T18:11:39Z
- Files changed: 5 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
1) added `Merchant Account id` field in authorize request for braintree.
2) handle error response in case of wrong merchant account id
3) cherry pick #1892
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [Braintree] add merchant_account_id field in authorize request (#1913)
Co-authored-b
Files to modify:
**crates/router/src/connector/braintree.rs**
Add:
- function: private::build_error_response
**crates/router/src/connector/braintree/transformers.rs**
Add:
- struct: pub::BraintreeMeta
- struct: pub::BraintreeApiErrorResponse
- struct: pub::TransactionError
- struct: pub::CreditCardError
- struct: pub::ErrorObject
- struct: pub::BraintreeErrorResponse
- enum: pub::ErrorResponse
**crates/router/src/connector/rapyd.rs**
Modify existing code
**crates/router/src/connector/trustpay.rs**
Modify existing code
**crates/router/src/utils.rs**
Add:
- function: pub::handle_json_response_deserialization_failure
|
{"issue_number": 1892, "pr_number": 1913, "commits_count": 1, "files_changed": 5, "response_length": 1585, "file_count": 7, "needs_breakdown": false}
|
[CI] cypress checks for wise failing
wise is returning status as `forbidden`. it is better to replace that with adyen payouts
|
<think>
PR Context:
- Title: ci(cypress-ci): remove wise payout from running in github ci
- Merged: 2025-04-08T08:31:18Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
this pr updates the `adyen` payouts credentials and it also replaces wise from running in github ci
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies appl
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7755, "pr_number": 7756, "commits_count": 0, "files_changed": 1, "response_length": 790, "file_count": 0, "needs_breakdown": false}
|
Nix Support
Nix support for orca:
- Dev shell to include all the required tools, setup
- Build with nix flakes
- CI/CD with nix flakes
|
<think>
PR Context:
- Title: feat: add basic nix support
- Merged: 2022-12-07T11:58:55Z
- Files changed: 2 files
- Commits: 4 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
Adding basic support for nix. This PR gives nix shell with cargo, rustc - 1.63.0. Plan is to make use of nix to do full dev setup.
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 57, "pr_number": 63, "commits_count": 0, "files_changed": 2, "response_length": 757, "file_count": 0, "needs_breakdown": false}
|
fix: print x request id for user postman tests
Console log x request id for users postman tests,
- it will help to debug failed tests for user collection
|
<think>
PR Context:
- Title: ci(postman): log request id for user tests
- Merged: 2024-06-28T14:07:35Z
- Files changed: 6 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
For user postman tests log x request id for every request.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 5158, "pr_number": 5159, "commits_count": 0, "files_changed": 6, "response_length": 772, "file_count": 0, "needs_breakdown": false}
|
feat: add env variable for enable key manager service
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application starts using encryption service for encryption and decryption. Once the config is enabled it shouldn't be disabled.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [x] This PR modifies application configuration/environment variables
## Motivation and Context
This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application starts using encryption service for encryption and decryption.
## How did you test it?
**This can't be tested in Test environment, since it is already enabled in both**
1. key_manager.enabled: false and feature "encryption_service" disabled. Encryption and decryption happens within the application
2. key_manager.enabled: true and feature "encryption_service" disabled. Encryption and decryption happens within the application
3. key_manager.enabled: false and feature "encryption_service" enabled. Encryption and decryption happens within the application
4. key_manager.enabled: true and feature "encryption_service" enabled. Encryption and decryption happens with encryption service. Once this is enabled can't be disabled.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
|
<think>
PR Context:
- Title: feat: add env variable for enable key manager service
- Merged: 2024-07-29T11:23:54Z
- Files changed: 7 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application st
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat: add env variable for enable key manager service (#5465)
Co-authored-by: dracarys18 <karthikey.
Files to modify:
**crates/common_utils/src/types/keymanager.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/type_encryption.rs**
Add:
- function: private::is_encryption_service_enabled
**crates/router/src/configs/defaults.rs**
Modify existing code
**crates/router/src/configs/settings.rs**
Modify existing code
**crates/router/src/routes/admin.rs**
Modify existing code
**crates/router/src/types/domain/types.rs**
Modify existing code
|
{"issue_number": 5442, "pr_number": 5465, "commits_count": 1, "files_changed": 7, "response_length": 1361, "file_count": 8, "needs_breakdown": false}
|
feat(events): allow listing webhook events and webhook delivery attempts by business profile
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR extends the events list APIs added in #4131 to allow specifying either merchant ID or the business profile ID in the URLs. This PR also includes the corresponding OpenAPI specification changes.
The URLs remain the same as described in #4131, with the only difference being that `{merchant_id}` can now be substituted with `{merchant_or_profile_id}`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
This would allow users to list and work with events associated with a specific business profile, which could be useful when users would want to exclude events from other business profiles associated with the same merchant account.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
1. The three functionalities provided by the endpoints must be unaffected when querying by merchant ID:
- List events related to a specific object:
```shell
curl -H 'api-key: test_admin' 'http://localhost:8080/events/merchant_1710609960?object_id=pay_9uclJXQboJ0FZPm9Nq2K' 2>/dev/null | jq '.'
```
- Filter events:
```shell
curl -H 'api-key: test_admin' 'http://localhost:8080/events/merchant_1710609960?created_after=2024-03-18T09:00Z&created_before=2024-03-18T11:00Z&limit=2&offset=2' 2>/dev/null | jq '.'
```
- List delivery attempts:
```shell
$ curl -H 'api-key: test_admin' 'http://localhost:8080/events/merchant_1710609960/evt_018e562fcd4571b0b831098bb9ebe230/attempts' 2>/dev/null | jq '.'
```
2. The above three functionalities must be unaffected if the merchant ID in the URLs is replaced by the profile ID:
- List events related to a specific object:
```shell
$ curl -H 'api-key: test_admin' 'http://localhost:8080/events/pro_H7FbvX2pBuJLjlPhkpRa?object_id=pay_9uclJXQboJ0FZPm9Nq2K' 2>/dev/null | jq '.'
[
{
"event_id": "evt_018e484cb6207265a1c715568f889590",
"merchant_id": "merchant_1710609960",
"profile_id": "pro_H7FbvX2pBuJLjlPhkpRa",
"object_id": "pay_9uclJXQboJ0FZPm9Nq2K",
"event_type": "payment_succeeded",
"event_class": "payments",
"is_delivery_successful": true,
"initial_attempt_id": "evt_018e484cb6207265a1c715568f889590",
"created": "2024-03-16T17:26:10.720Z"
}
]
```
- Filter events:
```shell
$ curl -H 'api-key: test_admin' 'http://localhost:8080/events/pro_H7FbvX2pBuJLjlPhkpRa?created_after=2024-03-18T09:00Z&created_before=2024-03-18T11:00Z&limit=2&offset=2' 2>/dev/null | jq '.'
[
{
"event_id": "evt_018e50da61a674d6bdbd7150775087f2",
"merchant_id": "merchant_1710609960",
"profile_id": "pro_H7FbvX2pBuJLjlPhkpRa",
"object_id": "pay_WkrmqLjtHqyjWdCYA1Ze",
"event_type": "payment_succeeded",
"event_class": "payments",
"is_delivery_successful": false,
"initial_attempt_id": "evt_018e50da61a674d6bdbd7150775087f2",
"created": "2024-03-18T09:17:52.934Z"
},
{
"event_id": "evt_018e50da59e577c6a5e843fe08537a01",
"merchant_id": "merchant_1710609960",
"profile_id": "pro_H7FbvX2pBuJLjlPhkpRa",
"object_id": "pay_ECPc1GBlY8uC4HushNUU",
"event_type": "payment_succeeded",
"event_class": "payments",
"is_delivery_successful": false,
"initial_attempt_id": "evt_018e50da59e577c6a5e843fe08537a01",
"created": "2024-03-18T09:17:50.950Z"
}
]
```
- List delivery attempts:
```shell
$ curl -H 'api-key: test_admin' 'http://localhost:8080/events/pro_H7FbvX2pBuJLjlPhkpRa/evt_018e562fcd4571b0b831098bb9ebe230/attempts' 2>/dev/null | jq '.[length-2:]'
[
{
"event_id": "evt_018e563030bc75a7a682fc3281f1d13d",
"merchant_id": "merchant_1710609960",
"profile_id": "pro_H7FbvX2pBuJLjlPhkpRa",
"object_id": "pay_w1nwB6UxMcIgEc3UDPvx",
"event_type": "payment_succeeded",
"event_class": "payments",
"is_delivery_successful": false,
"initial_attempt_id": "evt_018e562fcd4571b0b831098bb9ebe230",
"created": "2024-03-19T10:09:42.592Z",
"request": {
"body": "{\"merchant_id\":\"merchant_1710609960\",\"event_id\":\"evt_018e562fcd4571b0b831098bb9ebe230\",\"event_type\":\"payment_succeeded\",\"content\":{\"type\":\"payment_details\",\"object\":{\"payment_id\":\"pay_w1nwB6UxMcIgEc3UDPvx\",\"merchant_id\":\"merchant_1710609960\",\"status\":\"succeeded\",\"amount\":6540,\"net_amount\":6540,\"amount_capturable\":0,\"amount_received\":6540,\"connector\":\"stripe\",\"client_secret\":\"pay_w1nwB6UxMcIgEc3UDPvx_secret_ys9LDfhjJE7wiTQkMQru\",\"created\":\"2024-03-19T10:09:15.060Z\",\"currency\":\"USD\",\"customer_id\":\"StripeCustomer\",\"description\":\"Its my first payment request\",\"refunds\":null,\"disputes\":null,\"mandate_id\":null,\"mandate_data\":null,\"setup_future_usage\":null,\"off_session\":null,\"capture_on\":null,\"capture_method\":\"automatic\",\"payment_method\":\"card\",\"payment_method_data\":{\"card\":{\"last4\":\"4242\",\"card_type\":null,\"card_network\":null,\"card_issuer\":null,\"card_issuing_country\":null,\"card_isin\":\"424242\",\"card_extended_bin\":\"42424242\",\"card_exp_month\":\"10\",\"card_exp_year\":\"25\",\"card_holder_name\":\"joseph Doe\"},\"billing\":null},\"payment_token\":null,\"shipping\":{\"address\":{\"city\":\"San Fransico\",\"country\":\"US\",\"line1\":\"1467\",\"line2\":\"Harrison Street\",\"line3\":\"Harrison Street\",\"zip\":\"94122\",\"state\":\"California\",\"first_name\":\"joseph\",\"last_name\":\"Doe\"},\"phone\":{\"number\":\"8056594427\",\"country_code\":\"+91\"},\"email\":null},\"billing\":{\"address\":{\"city\":\"San Fransico\",\"country\":\"US\",\"line1\":\"1467\",\"line2\":\"Harrison Street\",\"line3\":\"Harrison Street\",\"zip\":\"94122\",\"state\":\"California\",\"first_name\":\"joseph\",\"last_name\":\"Doe\"},\"phone\":{\"number\":\"8056594427\",\"country_code\":\"+91\"},\"email\":null},\"order_details\":null,\"email\":\"[email protected]\",\"name\":\"John Doe\",\"phone\":\"999999999\",\"return_url\":\"https://google.com/\",\"authentication_type\":\"no_three_ds\",\"statement_descriptor_name\":\"joseph\",\"statement_descriptor_suffix\":\"JS\",\"next_action\":null,\"cancellation_reason\":null,\"error_code\":null,\"error_message\":null,\"unified_code\":null,\"unified_message\":null,\"payment_experience\":null,\"payment_method_type\":\"credit\",\"connector_label\":null,\"business_country\":null,\"business_label\":\"default\",\"business_sub_label\":null,\"allowed_payment_method_types\":null,\"ephemeral_key\":{\"customer_id\":\"StripeCustomer\",\"created_at\":1710842955,\"expires\":1710846555,\"secret\":\"epk_ea8a42533ae3472fb32da95c3f616886\"},\"manual_retry_allowed\":false,\"connector_transaction_id\":\"pi_3OvzbcD5R7gDAGff0njPHLCh\",\"frm_message\":null,\"metadata\":{\"udf1\":\"value1\",\"login_date\":\"2019-09-10T10:11:12Z\",\"new_customer\":\"true\"},\"connector_metadata\":null,\"feature_metadata\":null,\"reference_id\":\"pi_3OvzbcD5R7gDAGff0njPHLCh\",\"payment_link\":null,\"profile_id\":\"pro_H7FbvX2pBuJLjlPhkpRa\",\"surcharge_details\":null,\"attempt_count\":1,\"merchant_decision\":null,\"merchant_connector_id\":\"mca_qeS5H2fLkr8GLzN9SNWd\",\"incremental_authorization_allowed\":null,\"authorization_count\":null,\"incremental_authorizations\":null,\"external_authentication_details\":null,\"external_3ds_authentication_attempted\":false,\"expires_on\":\"2024-03-19T10:24:15.060Z\",\"fingerprint\":null,\"payment_method_id\":null,\"payment_method_status\":null}},\"timestamp\":\"2024-03-19T10:09:17.125Z\"}",
"headers": [
[
"content-type",
"application/json"
],
[
"X-Webhook-Signature-512",
"af25f54b7018cc35286451645a3ad0167e28a7fa32417c7411cd655c5db06a4bf1f9f7bd4330f2bed1ef54fedcd5b1fc35b09eb6e50f56b035c90cdf8818df30"
]
]
},
"response": {
"body": "",
"headers": [
[
"server",
"mitmproxy 10.2.4"
],
[
"content-length",
"0"
]
],
"status_code": 404
},
"delivery_attempt": "automatic_retry"
},
{
"event_id": "evt_018e562fcd4571b0b831098bb9ebe230",
"merchant_id": "merchant_1710609960",
"profile_id": "pro_H7FbvX2pBuJLjlPhkpRa",
"object_id": "pay_w1nwB6UxMcIgEc3UDPvx",
"event_type": "payment_succeeded",
"event_class": "payments",
"is_delivery_successful": false,
"initial_attempt_id": "evt_018e562fcd4571b0b831098bb9ebe230",
"created": "2024-03-19T10:09:17.125Z",
"request": {
"body": "{\"merchant_id\":\"merchant_1710609960\",\"event_id\":\"evt_018e562fcd4571b0b831098bb9ebe230\",\"event_type\":\"payment_succeeded\",\"content\":{\"type\":\"payment_details\",\"object\":{\"payment_id\":\"pay_w1nwB6UxMcIgEc3UDPvx\",\"merchant_id\":\"merchant_1710609960\",\"status\":\"succeeded\",\"amount\":6540,\"net_amount\":6540,\"amount_capturable\":0,\"amount_received\":6540,\"connector\":\"stripe\",\"client_secret\":\"pay_w1nwB6UxMcIgEc3UDPvx_secret_ys9LDfhjJE7wiTQkMQru\",\"created\":\"2024-03-19T10:09:15.060Z\",\"currency\":\"USD\",\"customer_id\":\"StripeCustomer\",\"description\":\"Its my first payment request\",\"refunds\":null,\"disputes\":null,\"mandate_id\":null,\"mandate_data\":null,\"setup_future_usage\":null,\"off_session\":null,\"capture_on\":null,\"capture_method\":\"automatic\",\"payment_method\":\"card\",\"payment_method_data\":{\"card\":{\"last4\":\"4242\",\"card_type\":null,\"card_network\":null,\"card_issuer\":null,\"card_issuing_country\":null,\"card_isin\":\"424242\",\"card_extended_bin\":\"42424242\",\"card_exp_month\":\"10\",\"card_exp_year\":\"25\",\"card_holder_name\":\"joseph Doe\"},\"billing\":null},\"payment_token\":null,\"shipping\":{\"address\":{\"city\":\"San Fransico\",\"country\":\"US\",\"line1\":\"1467\",\"line2\":\"Harrison Street\",\"line3\":\"Harrison Street\",\"zip\":\"94122\",\"state\":\"California\",\"first_name\":\"joseph\",\"last_name\":\"Doe\"},\"phone\":{\"number\":\"8056594427\",\"country_code\":\"+91\"},\"email\":null},\"billing\":{\"address\":{\"city\":\"San Fransico\",\"country\":\"US\",\"line1\":\"1467\",\"line2\":\"Harrison Street\",\"line3\":\"Harrison Street\",\"zip\":\"94122\",\"state\":\"California\",\"first_name\":\"joseph\",\"last_name\":\"Doe\"},\"phone\":{\"number\":\"8056594427\",\"country_code\":\"+91\"},\"email\":null},\"order_details\":null,\"email\":\"[email protected]\",\"name\":\"John Doe\",\"phone\":\"999999999\",\"return_url\":\"https://google.com/\",\"authentication_type\":\"no_three_ds\",\"statement_descriptor_name\":\"joseph\",\"statement_descriptor_suffix\":\"JS\",\"next_action\":null,\"cancellation_reason\":null,\"error_code\":null,\"error_message\":null,\"unified_code\":null,\"unified_message\":null,\"payment_experience\":null,\"payment_method_type\":\"credit\",\"connector_label\":null,\"business_country\":null,\"business_label\":\"default\",\"business_sub_label\":null,\"allowed_payment_method_types\":null,\"ephemeral_key\":{\"customer_id\":\"StripeCustomer\",\"created_at\":1710842955,\"expires\":1710846555,\"secret\":\"epk_ea8a42533ae3472fb32da95c3f616886\"},\"manual_retry_allowed\":false,\"connector_transaction_id\":\"pi_3OvzbcD5R7gDAGff0njPHLCh\",\"frm_message\":null,\"metadata\":{\"udf1\":\"value1\",\"login_date\":\"2019-09-10T10:11:12Z\",\"new_customer\":\"true\"},\"connector_metadata\":null,\"feature_metadata\":null,\"reference_id\":\"pi_3OvzbcD5R7gDAGff0njPHLCh\",\"payment_link\":null,\"profile_id\":\"pro_H7FbvX2pBuJLjlPhkpRa\",\"surcharge_details\":null,\"attempt_count\":1,\"merchant_decision\":null,\"merchant_connector_id\":\"mca_qeS5H2fLkr8GLzN9SNWd\",\"incremental_authorization_allowed\":null,\"authorization_count\":null,\"incremental_authorizations\":null,\"external_authentication_details\":null,\"external_3ds_authentication_attempted\":false,\"expires_on\":\"2024-03-19T10:24:15.060Z\",\"fingerprint\":null,\"payment_method_id\":null,\"payment_method_status\":null}},\"timestamp\":\"2024-03-19T10:09:17.125Z\"}",
"headers": [
[
"content-type",
"application/json"
],
[
"X-Webhook-Signature-512",
"af25f54b7018cc35286451645a3ad0167e28a7fa32417c7411cd655c5db06a4bf1f9f7bd4330f2bed1ef54fedcd5b1fc35b09eb6e50f56b035c90cdf8818df30"
]
]
},
"response": {
"body": "",
"headers": [
[
"server",
"mitmproxy 10.2.4"
],
[
"content-length",
"0"
]
],
"status_code": 404
},
"delivery_attempt": "initial_attempt"
}
]
```
3. To simulate access from the control center and verifying correct functioning of these APIs:
1. A user sign in operation can be done, and the JWT token can be temporarily stored.
2. Replace the `api-key: test_admin` header in the above commands with `Authorization: Bearer <JWT_TOKEN>`.
3. Try out the APIs specifying both merchant ID and profile ID in the URL, the behavior should be the same.
I've verified that accessing the APIs using the JWT token, specifying both merchant ID and profile ID works as expected.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: refactor: use business profile domain models instead of diesel models
- Merged: 2024-08-08T10:37:52Z
- Files changed: 30 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR contains the following changes:
- Updates the `BusinessProfileInterface` trait methods to use and return business profile domain models instead of the corresponding diesel models. As a result of this, almost all of the code in the
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor: use business profile domain models instead of diesel models (#5566)
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/common_utils/src/types/keymanager.rs**
Modify existing code
**crates/diesel_models/src/business_profile.rs**
Remove:
- function: private::from
- function: private::from
- function: private::from
- struct: pub::BusinessProfileGeneralUpdate
- struct: pub::BusinessProfileGeneralUpdate
- enum: pub::BusinessProfileUpdate
- enum: pub::BusinessProfileUpdate
- impl: impl From<BusinessProfileUpdate> for BusinessProfileUpdateInternal
- impl: impl From<BusinessProfileNew> for BusinessProfile
- impl: impl From<BusinessProfileUpdate> for BusinessProfileUpdateInternal
**crates/diesel_models/src/query/business_profile.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/customer.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/merchant_account.rs**
Modify existing code
**crates/router/src/connector/braintree/transformers.rs**
Remove:
- struct: pub::PsyncInputData
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/authentication.rs**
Modify existing code
**crates/router/src/core/authentication/transformers.rs**
Modify existing code
**crates/router/src/core/authentication/utils.rs**
Modify existing code
**crates/router/src/core/payment_link.rs**
Modify existing code
**crates/router/src/core/payment_methods.rs**
Modify existing code
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/flows.rs**
Modify existing code
**crates/router/src/core/payments/flows/approve_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/authorize_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/cancel_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/capture_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/complete_authorize_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/incremental_authorization_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/psync_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/reject_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/session_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/setup_mandate_flow.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Modify existing code
**crates/router/src/core/payments/operations.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_approve.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_cancel.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_capture.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_complete_authorize.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_confirm.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_create.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_reject.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_response.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_session.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_start.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_status.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_update.rs**
Modify existing code
**crates/router/src/core/payments/operations/payments_incremental_authorization.rs**
Modify existing code
**crates/router/src/core/payments/retry.rs**
Modify existing code
**crates/router/src/core/payments/routing.rs**
Modify existing code
**crates/router/src/core/payments/tokenization.rs**
Modify existing code
**crates/router/src/core/payments/types.rs**
Modify existing code
**crates/router/src/core/payouts.rs**
Modify existing code
**crates/router/src/core/payouts/helpers.rs**
Modify existing code
**crates/router/src/core/payouts/validator.rs**
Modify existing code
**crates/router/src/core/routing.rs**
Modify existing code
**crates/router/src/core/routing/helpers.rs**
Modify existing code
**crates/router/src/core/utils.rs**
Modify existing code
**crates/router/src/core/webhooks/incoming.rs**
Modify existing code
**crates/router/src/core/webhooks/outgoing.rs**
Modify existing code
**crates/router/src/core/webhooks/webhook_events.rs**
Modify existing code
**crates/router/src/db/business_profile.rs**
Modify existing code
**crates/router/src/db/kafka_store.rs**
Modify existing code
**crates/router/src/routes/admin.rs**
Modify existing code
**crates/router/src/routes/routing.rs**
Modify existing code
**crates/router/src/routes/webhook_events.rs**
Modify existing code
**crates/router/src/services/authentication.rs**
Modify existing code
**crates/router/src/types.rs**
Modify existing code
**crates/router/src/types/api/admin.rs**
Add:
- function: private::foreign_try_from
**crates/router/src/types/domain.rs**
Remove:
- mod: private::address
- mod: pub::merchant_account
Add:
- mod: private::merchant_account
- mod: private::business_profile
- mod: private::address
**crates/router/src/types/storage/business_profile.rs**
Modify existing code
**crates/router/src/utils.rs**
Modify existing code
**crates/router/src/utils/user/sample_data.rs**
Modify existing code
**crates/router/src/workflows/outgoing_webhook_retry.rs**
Modify existing code
**crates/router/src/workflows/payment_sync.rs**
Modify existing code
|
{"issue_number": 4159, "pr_number": 5566, "commits_count": 1, "files_changed": 30, "response_length": 6772, "file_count": 70, "needs_breakdown": true}
|
Adding contributors guide
Adding contributors guide
|
<think>
PR Context:
- Title: docs(README): Adding Contributors guide
- Merged: 2024-08-22T12:46:04Z
- Files changed: 2 files
- Commits: 17 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [X] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding ch
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 5344, "pr_number": 5184, "commits_count": 0, "files_changed": 2, "response_length": 770, "file_count": 0, "needs_breakdown": false}
|
[FEATURE]: [Rapyd] Use `connector_response_reference_id` as reference to merchant
### :memo: Feature Description
- Reference id are used to map transactions in the connector’s dashboard.
- Hyperswitch manages several reference ids, such as `payment_id`, `attempt_id`, and `connector_transaction_id` for a single transaction.
- However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.
### :hammer: Possible Implementation
- When we receive a response from the connector for the payment, we deserialize it and populate the `response` field in RouterData.
- For the `TransactionResponse` type, we must fill the `connector_response_reference_id` with a corresponding reference id for the merchant to identify the transaction.
- Please refer to the Rapyd API documentation [here](https://docs.rapyd.net/en/create-payment.html). In the payment response, there is a field called `merchant_reference_id` (an optional field). This `merchant_reference_id` needs to be mapped to the `connector_response_reference_id`.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/1735
🔖 Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: feat(connector): [Rapyd] Use connector_response_reference_id
- Merged: 2024-10-25T08:40:20Z
- Files changed: 1 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Add connector_response_reference_id support for Rapyd
- Used `merchant_reference_id` as the reference id, while implementing this!
Resolves #2346
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modi
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [Rapyd] Use connector_response_reference_id (#6302)
Co-authored-by: DEEPANSHU BANSA
Files to modify:
**crates/router/src/connector/rapyd/transformers.rs**
Modify existing code
|
{"issue_number": 2346, "pr_number": 6302, "commits_count": 1, "files_changed": 1, "response_length": 989, "file_count": 3, "needs_breakdown": false}
|
fix: trustpay eps redirection in cypress
fix: trustpay eps redirection in cypress
they changed it again
|
<think>
PR Context:
- Title: fix: trustpay `eps` redirection in cypress
- Merged: 2024-11-12T07:17:51Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
Fix EPS Bank Redirect redirection in Cypress.
Closes #6528
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment vari
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6528, "pr_number": 6529, "commits_count": 0, "files_changed": 1, "response_length": 772, "file_count": 0, "needs_breakdown": false}
|
[FEATURE]: [Iatapay] Use `connector_request_reference_id` as reference to the connector
### :memo: Feature Description
- We transmit our reference id from Hyperswitch to the connector, enabling merchants to subsequently locate the payment within the connector dashboard.
- Presently, there is a lack of uniformity in this process, as some implementations employ `payment_id` while others utilize `attempt_id`.
- This inconsistency arises from the fact that `payment_id` and `attempt_id` correspond to two distinct entities within our system.
### :hammer: Possible Implementation
- To mitigate this confusion, we've introduced a new field called `connector_request_reference_id` in our RouterData.
- This id should replace them as a reference id to the connector for payment request.
- One might need to have exposure to api docs of the connector for which it is being implemented.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2052
:bookmark: Note : All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: refactor(connector): Use connector_request_reference_id for Iatapay
- Merged: 2023-10-28T18:06:17Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
fixes #2302
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
## How did you test it?
<!--
Did you wri
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): Use connector_request_reference_id for Iatapay (#2692)
Files to modify:
**crates/router/src/connector/iatapay/transformers.rs**
Modify existing code
**Commit 2:** refactor(connector): Use connector_request_reference_id for Iatapay (#2692)
Files to modify:
**crates/router/src/connector/iatapay/transformers.rs**
Modify existing code
|
{"issue_number": 2302, "pr_number": 2692, "commits_count": 2, "files_changed": 1, "response_length": 1162, "file_count": 5, "needs_breakdown": false}
|
refactor(router): add revenue_recovery_metadata to payment intent in diesel and api model for v2 flow
Add the following fields to the api and diesel models Feature meta data
retry_count: Total number of billing connector + recovery retries for a payment intent.
payment_connector_transmission: It's supposed to tell if the payment_connector has been called or not.
billing_connector_id: To update the invoice at billing connector.
active_attempt_payment_connector_id : Process tracker needs payment merchant connector account id to schedule the retry attempt.
billing_connector_mit_token_details : MIT related information given by billing connector contains two fields.
1. customer_id : Customer Id of the customer in billing connector
2. payment_processor_token : The token used by the payment processor to retry the payment.
payment_method_type: This represents payment Method type like Card,Crypto,Mandate etc..
payment_method_subtype : This represents the subtype of the payment method like Credit, CryptoCurrency etc..
|
<think>
PR Context:
- Title: refactor(router): add revenue_recovery_metadata to payment intent in diesel and api model for v2 flow
- Merged: 2025-02-14T11:41:35Z
- Files changed: 6 files
- Commits: 23 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Adds the following fields to the api and diesel models Feature meta data
retry_count: Total number of billing connector + recovery retries for a payment intent.
payment_connector_transmission: It's supposed to tell if the payment_connector has been called or not.
billing_con
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(router): add revenue_recovery_metadata to payment intent in diesel and api model for v2 fl
Files to modify:
**crates/api_models/src/payments.rs**
Add:
- struct: pub::FeatureMetadata
- struct: pub::PaymentRevenueRecoveryMetadata
- struct: pub::BillingConnectorPaymentDetails
**crates/common_enums/src/enums.rs**
Add:
- enum: pub::PaymentConnectorTransmission
**crates/diesel_models/src/types.rs**
Add:
- struct: pub::FeatureMetadata
- struct: pub::PaymentRevenueRecoveryMetadata
- struct: pub::BillingConnectorPaymentDetails
**crates/hyperswitch_domain_models/src/lib.rs**
Add:
- function: private::convert_from
- function: private::convert_back
- function: private::convert_from
- function: private::convert_back
- function: private::convert_from
- function: private::convert_back
- impl: impl ApiModelToDieselModelConvertor<ApiFeatureMetadata> for FeatureMetadata
- impl: impl ApiModelToDieselModelConvertor<ApiRevenueRecoveryMetadata> for PaymentRevenueRecoveryMetadata
- impl: impl ApiModelToDieselModelConvertor<ApiBillingConnectorPaymentDetails> for BillingConnectorPaymentDetails
**crates/openapi/src/openapi_v2.rs**
Modify existing code
|
{"issue_number": 7177, "pr_number": 7176, "commits_count": 1, "files_changed": 6, "response_length": 2069, "file_count": 7, "needs_breakdown": false}
|
[FEATURE]: Add support for merchant order reference id
### Feature Description
Add support for merchant order reference id
### Possible Implementation
Add support for merchant order reference id
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(core): add merchant order reference id
- Merged: 2024-07-04T13:05:00Z
- Files changed: 22 files
- Commits: 9 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Add support for accepting `merchant_order_reference_id` and subsequently pass it to the connector if connector supports accepting multiple reference.
This is being added for merchant to locate the payment using their id in the connector dashb
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(core): add merchant order reference id (#5197)
Co-authored-by: hyperswitch-bot[bot] <148525504+
Files to modify:
**crates/api_models/src/payments.rs**
Modify existing code
**crates/diesel_models/src/payment_intent.rs**
Modify existing code
**crates/diesel_models/src/schema.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_attempt.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_intent.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_request_types.rs**
Modify existing code
**crates/router/src/connector/adyen/transformers.rs**
Modify existing code
**crates/router/src/connector/klarna/transformers.rs**
Modify existing code
**crates/router/src/connector/paypal/transformers.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_confirm.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_create.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_update.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/types.rs**
Modify existing code
**crates/router/src/types/api/verify_connector.rs**
Modify existing code
**crates/router/src/utils/user/sample_data.rs**
Modify existing code
**crates/router/tests/connectors/utils.rs**
Modify existing code
|
{"issue_number": 5198, "pr_number": 5197, "commits_count": 1, "files_changed": 22, "response_length": 2364, "file_count": 21, "needs_breakdown": true}
|
DB changes for split payments (v2)
The following DB changes need to be made to support split payments:
In PaymentIntent:
- Add `active_attempts_group_id` column
- Add `active_attempt_id_type` column
In PaymentAttempt:
- Add `attempts_group_id` column
While currently a `payment_intent` can have only a single `active_attempt`, For split payments case, a `payment_intent` will have a group of active attempts. These attempts will be linked together by the `attempts_group_id`.
This `attempts_group_id` will be stored in the payment intent as the `active_attempts_group_id`. The `active_attempt_id` will be ignored in split payments case.
|
<think>
PR Context:
- Title: feat(router): Add attempts_group DB changes for split payments (v2)
- Merged: 2025-09-24T08:41:25Z
- Files changed: 13 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added DB changes for split payments
In PaymentIntent:
- Add `active_attempts_group_id` column
- Add `active_attempt_id_type` column
In PaymentAttempt:
- Add `attempts_group_id` column
While currently a payment_intent can have only
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(router): Add attempts_group DB changes for split payments (v2) (#9466)
Files to modify:
**crates/common_enums/src/enums.rs**
Add:
- enum: pub::ActiveAttemptIDType
**crates/diesel_models/src/payment_attempt.rs**
Modify existing code
**crates/diesel_models/src/payment_intent.rs**
Modify existing code
**crates/diesel_models/src/schema_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_attempt.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_intent.rs**
Modify existing code
**crates/router/src/services/kafka/payment_attempt.rs**
Modify existing code
**crates/router/src/services/kafka/payment_attempt_event.rs**
Modify existing code
**crates/router/src/services/kafka/payment_intent.rs**
Modify existing code
**crates/router/src/services/kafka/payment_intent_event.rs**
Modify existing code
|
{"issue_number": 9465, "pr_number": 9466, "commits_count": 1, "files_changed": 13, "response_length": 1777, "file_count": 13, "needs_breakdown": false}
|
Support to inject TLS certificate inside Hyperswith App Server
|
<think>
PR Context:
- Title: feat(tls): add support for https in actix web
- Merged: 2024-07-01T10:50:57Z
- Files changed: 7 files
- Commits: 13 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added support for TLS server within `actix-web` using `rustls`
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment var
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(tls): add support for https in actix web (#5089)
Co-authored-by: noagbmn <>
Files to modify:
**crates/router/src/configs/defaults.rs**
Modify existing code
**crates/router/src/configs/settings.rs**
Add:
- struct: pub::ServerTls
**crates/router/src/lib.rs**
Modify existing code
|
{"issue_number": 3475, "pr_number": 5089, "commits_count": 1, "files_changed": 7, "response_length": 1075, "file_count": 5, "needs_breakdown": false}
|
[FEATURE] Add Facilitapay connector
Facilitapay connector is yet another payment processor.
Docs: https://sandbox-portal.facilitapay.com/#/docs
|
<think>
PR Context:
- Title: feat(connector): Introduce connector template code for Facilitapay
- Merged: 2025-03-27T13:33:42Z
- Files changed: 24 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR introduces template code for new connector named `Facilitapay`.
Docs: https://sandbox-portal.facilitapay.com/#/docs
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): Introduce connector template code for Facilitapay (#7631)
Files to modify:
**crates/common_enums/src/connector_enums.rs**
Modify existing code
**crates/connector_configs/src/connector.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors.rs**
Add:
- mod: pub::facilitapay
**crates/hyperswitch_connectors/src/connectors/facilitapay.rs**
Add:
- function: pub::new
- function: private::build_headers
- function: private::id
- function: private::get_currency_unit
- function: private::common_get_content_type
- function: private::base_url
- function: private::get_auth_header
- function: private::build_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_webhook_object_reference_id
- function: private::get_webhook_event_type
- function: private::get_webhook_resource_object
- struct: pub::Facilitapay
- impl: impl Facilitapay
- impl: impl api::Payment for Facilitapay
- impl: impl api::PaymentSession for Facilitapay
- impl: impl api::ConnectorAccessToken for Facilitapay
- impl: impl api::MandateSetup for Facilitapay
- impl: impl api::PaymentAuthorize for Facilitapay
- impl: impl api::PaymentSync for Facilitapay
- impl: impl api::PaymentCapture for Facilitapay
- impl: impl api::PaymentVoid for Facilitapay
- impl: impl api::Refund for Facilitapay
- impl: impl api::RefundExecute for Facilitapay
- impl: impl api::RefundSync for Facilitapay
- impl: impl api::PaymentToken for Facilitapay
- impl: impl ConnectorIntegration<PaymentMethodToken, PaymentMethodTokenizationData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorCommonExt<Flow, Request, Response> for Facilitapay
- impl: impl ConnectorCommon for Facilitapay
- impl: impl ConnectorValidation for Facilitapay
- impl: impl ConnectorIntegration<Session, PaymentsSessionData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<AccessTokenAuth, AccessTokenRequestData, AccessToken> for Facilitapay
- impl: impl ConnectorIntegration<SetupMandate, SetupMandateRequestData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<Capture, PaymentsCaptureData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<Execute, RefundsData, RefundsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for Facilitapay
- impl: impl webhooks::IncomingWebhook for Facilitapay
- impl: impl ConnectorSpecifications for Facilitapay
- mod: pub::transformers
**crates/hyperswitch_connectors/src/connectors/facilitapay/transformers.rs**
Add:
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- struct: pub::FacilitapayRouterData
- struct: pub::FacilitapayPaymentsRequest
- struct: pub::FacilitapayCard
- struct: pub::FacilitapayAuthType
- struct: pub::FacilitapayPaymentsResponse
- struct: pub::FacilitapayRefundRequest
- struct: pub::RefundResponse
- struct: pub::FacilitapayErrorResponse
- enum: pub::FacilitapayPaymentStatus
- enum: pub::RefundStatus
- impl: impl From<(StringMinorUnit, T)> for FacilitapayRouterData<T>
- impl: impl TryFrom<&FacilitapayRouterData<&PaymentsAuthorizeRouterData>> for FacilitapayPaymentsRequest
- impl: impl TryFrom<&ConnectorAuthType> for FacilitapayAuthType
- impl: impl From<FacilitapayPaymentStatus> for common_enums::AttemptStatus
- impl: impl TryFrom<ResponseRouterData<F, FacilitapayPaymentsResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
- impl: impl TryFrom<&FacilitapayRouterData<&RefundsRouterData<F>>> for FacilitapayRefundRequest
- impl: impl From<RefundStatus> for enums::RefundStatus
- impl: impl TryFrom<RefundsResponseRouterData<Execute, RefundResponse>> for RefundsRouterData<Execute>
- impl: impl TryFrom<RefundsResponseRouterData<RSync, RefundResponse>> for RefundsRouterData<RSync>
**crates/hyperswitch_connectors/src/default_implementations.rs**
Modify existing code
**crates/hyperswitch_connectors/src/default_implementations_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/configs.rs**
Modify existing code
**crates/router/src/connector.rs**
Modify existing code
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/payments/flows.rs**
Modify existing code
**crates/router/src/types/api.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/router/tests/connectors/facilitapay.rs**
Add:
- function: private::get_data
- function: private::get_auth_token
- function: private::get_name
- function: private::get_default_payment_info
- function: private::payment_method_details
- function: private::should_only_authorize_payment
- function: private::should_capture_authorized_payment
- function: private::should_partially_capture_authorized_payment
- function: private::should_sync_authorized_payment
- function: private::should_void_authorized_payment
- function: private::should_refund_manually_captured_payment
- function: private::should_partially_refund_manually_captured_payment
- function: private::should_sync_manually_captured_refund
- function: private::should_make_payment
- function: private::should_sync_auto_captured_payment
- function: private::should_refund_auto_captured_payment
- function: private::should_partially_refund_succeeded_payment
- function: private::should_refund_succeeded_payment_multiple_times
- function: private::should_sync_refund
- function: private::should_fail_payment_for_incorrect_cvc
- function: private::should_fail_payment_for_invalid_exp_month
- function: private::should_fail_payment_for_incorrect_expiry_year
- function: private::should_fail_void_payment_for_auto_capture
- function: private::should_fail_capture_for_invalid_payment
- function: private::should_fail_for_refund_amount_higher_than_payment_amount
- struct: private::FacilitapayTest
- impl: impl ConnectorActions for FacilitapayTest
- impl: impl utils::Connector for FacilitapayTest
**crates/router/tests/connectors/main.rs**
Add:
- mod: private::facilitapay
**crates/test_utils/src/connector_auth.rs**
Modify existing code
|
{"issue_number": 7630, "pr_number": 7631, "commits_count": 1, "files_changed": 24, "response_length": 9052, "file_count": 18, "needs_breakdown": true}
|
[BUG] 5xx in PayPal when cancelling the Payment
we're getting 5xx when you try to cancel the payment express checkout page. and this is not intended.
|
<think>
PR Context:
- Title: fix(connector): [GlobalPay] Address `5xx` when cancelling a paypal transaction
- Merged: 2025-03-26T10:26:02Z
- Files changed: 4 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR addresses 5xx that currently is being thrown when a user tries to cancel the PayPal transactions from the redirected page:
<img width="372" alt="image" src="https://github.com/user-attachments/assets/4f920b8b-6ab4-4bcb-9705-dc4d15
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [GlobalPay] Address `5xx` when cancelling a paypal transaction (#7605)
Files to modify:
**crates/hyperswitch_connectors/src/connectors/globalpay/requests.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/globalpay/response.rs**
Remove:
- struct: pub::GlobalpayPaymentsWebhookResponse
- struct: pub::GlobalpayRedirectResponse
- enum: pub::FingerprintPresenceIndicator
Add:
- enum: pub::ActionType
**crates/hyperswitch_connectors/src/connectors/globalpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/recurly/transformers.rs**
Modify existing code
|
{"issue_number": 7607, "pr_number": 7605, "commits_count": 1, "files_changed": 4, "response_length": 1466, "file_count": 6, "needs_breakdown": false}
|
fix cybersource cypress redirection
address ci inconsistency.
cybersource cypress test in github has been failing randomly left right and center for no good reason.
|
<think>
PR Context:
- Title: fix(cypress): address cybersource redirection inconsistency
- Merged: 2025-01-21T07:06:52Z
- Files changed: 6 files
- Commits: 24 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
- enabled video recording for tests that fail
- cybersource connector in github ci, randomly goes through `frictionless` flow without challenge which results in certain expected elements to go missing resulting in respective tests to fail
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7058, "pr_number": 7057, "commits_count": 0, "files_changed": 6, "response_length": 790, "file_count": 0, "needs_breakdown": false}
|
[FEATURE] separate payments_session from payments core
### Feature Description
In the current implementation, the [payments_session](https://github.com/juspay/hyperswitch/blob/main/crates/router/src/core/payments/operations/payment_session.rs) is a part of [payments core](https://github.com/juspay/hyperswitch/blob/main/crates/router/src/core/payments.rs) logic. This was done to reuse certain parts of code which would avoid redundancy, this would also be maintained along with the payments core. The major anamoly from the core logic would be that multiple connectors would be called in parallel.
### Possible Implementation
As we have come a long way in our journey of integrating the connectors / gateways, we have not come across any connector / gateway, where the session token generation ( required to initiate the sdk ) logic, is tied to a payment flow. It would be better to have this logic separated from the core logic. This would help us in
- Deploying it separately since this will have many reads
- Flexibility to add changes without any breaking changes to the payments logic.
- No routing support is required.
This can be implemented as a separate function as which would perform the required functionalities. This can be build in a similar way to [payment_method_list](https://github.com/juspay/hyperswitch/blob/main/crates/router/src/core/payment_methods/cards.rs#L784) api. Additional step would be to call the connector whenever necessary.
### Have you spent some time to check if this feature request has been raised before?
- [X] I checked and didn't find similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
No, but I'm happy to collaborate on a PR with someone else
|
<think>
PR Context:
- Title: refactor(core): move update trackers after build request
- Merged: 2023-06-19T07:59:57Z
- Files changed: 30 files
- Commits: 8 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
Update trackers has been moved before callling the connector. This is to make sure that if there is any validation error, then the payment status will not be updated.
For other flows where connector does not need to be called ( except `session_token` flow, there is an issue to move it outside payment core #888), it will be called as normal.
## Mo
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(core): move update trackers after build request (#1472)
Files to modify:
**crates/router/src/connector/airwallex.rs**
Modify existing code
**crates/router/src/connector/nuvei.rs**
Modify existing code
**crates/router/src/connector/shift4.rs**
Modify existing code
**crates/router/src/core/disputes.rs**
Modify existing code
**crates/router/src/core/files/helpers.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/access_token.rs**
Modify existing code
**crates/router/src/core/payments/customers.rs**
Modify existing code
**crates/router/src/core/payments/flows.rs**
Modify existing code
**crates/router/src/core/payments/flows/authorize_flow.rs**
Remove:
- enum: pub::Action
**crates/router/src/core/payments/flows/cancel_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/capture_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/complete_authorize_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/psync_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/session_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/verify_flow.rs**
Add:
- function: private::build_flow_specific_connector_request
**crates/router/src/core/payments/operations.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_cancel.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_capture.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_complete_authorize.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_confirm.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_create.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_method_validate.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_session.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_start.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_status.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_update.rs**
Modify existing code
**crates/router/src/core/payments/tokenization.rs**
Modify existing code
**crates/router/src/core/refunds.rs**
Modify existing code
**crates/router/src/services/api.rs**
Modify existing code
**crates/router/tests/connectors/aci.rs**
Modify existing code
**crates/router/tests/connectors/utils.rs**
Modify existing code
|
{"issue_number": 888, "pr_number": 1472, "commits_count": 1, "files_changed": 30, "response_length": 3446, "file_count": 34, "needs_breakdown": true}
|
fix(connector): [Peach Payments] fix connector metadata deserialization
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
fix connector metadata deserialization
Currently we deserialize to camelCase.
but dashboard always sends in snake_case.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
<img width="836" height="924" alt="Screenshot 2025-10-14 at 2 13 20 PM" src="https://github.com/user-attachments/assets/15635e0c-128d-4bb6-80bb-6bfa38bcc424" />
<img width="938" height="935" alt="Screenshot 2025-10-14 at 2 13 38 PM" src="https://github.com/user-attachments/assets/20d7197f-f5e6-4adf-911b-67e80663ca7f" />
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [ ] I formatted the code `cargo +nightly fmt --all`
- [ ] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): [Peach Payments] fix connector metadata deserialization
- Merged: 2025-10-14T11:48:24Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
fix connector metadata deserialization
Currently we deserialize to camelCase.
but dashboard always sends in snake_case.
main pr - #9826
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the dat
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [Peach Payments] fix connector metadata deserialization (#9827)
Co-authored-by: Gna
Files to modify:
**crates/hyperswitch_connectors/src/connectors/peachpayments/transformers.rs**
Modify existing code
|
{"issue_number": 9826, "pr_number": 9827, "commits_count": 1, "files_changed": 1, "response_length": 1026, "file_count": 3, "needs_breakdown": false}
|
refactor: fix auth select flow for default users
When no `id` is passed to auth_select request is should consider default case for user authentication method and give `totp` as the next SPT.
|
<think>
PR Context:
- Title: refactor(user_auth_method): populate default user auth method
- Merged: 2024-07-10T19:23:56Z
- Files changed: 3 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
- Populated the User Authentication Method data statically for default users
- Auth select should give next flow as `totp` when no `id` is passed
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies a
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(user_auth_method): populate default user auth method (#5257)
Files to modify:
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/types/domain/user.rs**
Add:
- mod: pub::user_authentication_method
**crates/router/src/types/domain/user/user_authentication_method.rs**
Modify existing code
|
{"issue_number": 5256, "pr_number": 5257, "commits_count": 1, "files_changed": 3, "response_length": 1128, "file_count": 5, "needs_breakdown": false}
|
[FEATURE]: [Worldpay] Use `connector_request_reference_id` as reference to the connector
### :memo: Feature Description
- We transmit our reference id from Hyperswitch to the connector, enabling merchants to subsequently locate the payment within the connector dashboard.
- Presently, there is a lack of uniformity in this process, as some implementations employ `payment_id` while others utilize `attempt_id`.
- This inconsistency arises from the fact that `payment_id` and `attempt_id` correspond to two distinct entities within our system.
### :hammer: Possible Implementation
- To mitigate this confusion, we've introduced a new field called `connector_request_reference_id` in our RouterData.
- This id should replace them as a reference id to the connector for payment request.
- One might need to have exposure to api docs of the connector for which it is being implemented.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2052
:bookmark: Note : All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: feat(connector): [Worldpay] Use connector_request_reference_id as reference to the connector
- Merged: 2023-10-19T07:16:08Z
- Files changed: 1 files
- Commits: 12 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
As mentioned in the issue #2321 , I had to work on the attempt_id and payment_id in the Router data , it should have been replaced with the new introduced connector_request_reference_id.
I think I have did it.
please have a look and merg
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [Worldpay] Use connector_request_reference_id as reference to the connector (#2553)
Files to modify:
**crates/router/src/connector/worldpay/transformers.rs**
Modify existing code
|
{"issue_number": 2321, "pr_number": 2553, "commits_count": 1, "files_changed": 1, "response_length": 1025, "file_count": 3, "needs_breakdown": false}
|
refactor(router): api-key routes refactoring
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [X] Refactoring
- [ ] Dependency updates
## Description
- Refactored API keys routes to use `/api_keys/{merchant_id}`.
- Refactored authentication errors.
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
These changes enable extending projects to have merchant based authentication for api routes.
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [X] I formatted the code `cargo +nightly fmt --all`
- [X] I addressed lints thrown by `cargo clippy`
- [X] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: docs(openapi): document path parameters for API keys endpoints
- Merged: 2023-03-05T15:52:43Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
This PR documents the path parameters added to the API keys endpoints in #600.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** docs(openapi): document path parameters for API keys endpoints (#702)
Files to modify:
**crates/router/src/routes/api_keys.rs**
Modify existing code
|
{"issue_number": 600, "pr_number": 702, "commits_count": 1, "files_changed": 1, "response_length": 947, "file_count": 3, "needs_breakdown": false}
|
[FEATURE] Kv Redis feature for V2 models
### Feature Description
Extend kv support for v2 models
### Possible Implementation
Use existing construct to extend to v2 models
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat: Kv changes for V2 feature
- Merged: 2025-06-26T14:22:59Z
- Files changed: 15 files
- Commits: 26 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
#8389
- Added Kv Redis support to - payment_intent V2, payment_attempt V2 models
- Added enable Kv route for v2 merchant-account
added enable kv api for v2 merchant account
`
curl --location 'https://<host>/v2/merchant-accounts/:mid/kv' \
--header 'Authorization: admin-api
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat: Kv changes for V2 feature (#8198)
Co-authored-by: Akshay S <[email protected]>
Co-authored-by
Files to modify:
**crates/diesel_models/src/kv.rs**
Add:
- struct: pub::PaymentAttemptUpdateMems
**crates/diesel_models/src/payment_attempt.rs**
Add:
- function: pub::apply_changeset
- impl: impl PaymentAttemptUpdateInternal
**crates/diesel_models/src/payment_intent.rs**
Add:
- function: pub::apply_changeset
- impl: impl PaymentIntentUpdateInternal
**crates/router/src/lib.rs**
Modify existing code
**crates/router/src/routes/admin.rs**
Add:
- function: pub::merchant_account_toggle_kv
- function: pub::merchant_account_kv_status
**crates/router/src/routes/app.rs**
Add:
- function: pub::server
- impl: impl DummyConnector
**crates/router/src/routes/dummy_connector.rs**
Modify existing code
**crates/router/src/routes/dummy_connector/core.rs**
Modify existing code
**crates/storage_impl/src/customers.rs**
Add:
- function: pub::get_global_id_label
- function: pub::get_merchant_scoped_id_label
- mod: private::label
**crates/storage_impl/src/lib.rs**
Add:
- function: private::unique_constraints
- function: private::table_name
- impl: impl UniqueConstraints for diesel_models::PaymentAttempt
**crates/storage_impl/src/payments/payment_attempt.rs**
Add:
- function: pub::get_profile_id_connector_transaction_label
- function: pub::get_global_id_label
- mod: private::label
**crates/storage_impl/src/payments/payment_intent.rs**
Modify existing code
**crates/storage_impl/src/redis/kv_store.rs**
Modify existing code
|
{"issue_number": 8389, "pr_number": 8198, "commits_count": 1, "files_changed": 15, "response_length": 2397, "file_count": 15, "needs_breakdown": false}
|
[BUG] : [Bambora] bad request error for non-three-ds card payment
### Bug Description
Bambora expects browser information regardless of type of card payment (3ds or not). But we are not passing this browser details in non 3ds card. This results in a bad request response from bambora.
### Expected Behavior
Pass browser information in non 3ds card payments
### Actual Behavior
Connector returns a bad request response
### Steps To Reproduce
Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the `x-request-id` response header to help us debug your issue.
If not (or if building/running locally), please provide the following details:
1. Operating System or Linux distribution:
2. Rust version (output of `rustc --version`): ``
3. App version (output of `cargo r --features vergen -- --version`): ``
### Have you spent some time checking if this bug has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
None
|
<think>
PR Context:
- Title: refactor(connectors): [Bambora] data masking
- Merged: 2024-02-20T14:27:53Z
- Files changed: 2 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for Bambora
## Test Case
Check if sensitive fields within connector request and response is masked in the click house for bambora
Sanity test
1. Payment c
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connectors): [Bambora] data masking (#3695)
Co-authored-by: Arjun Karthik <m.arjunkarthik@g
Files to modify:
**crates/router/src/connector/bambora.rs**
Modify existing code
**crates/router/src/connector/bambora/transformers.rs**
Modify existing code
|
{"issue_number": 3701, "pr_number": 3695, "commits_count": 1, "files_changed": 2, "response_length": 1042, "file_count": 4, "needs_breakdown": false}
|
feat(redis_interface): implement functions for `HGET`, `HSET`, `HSETNX` commands
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
This PR adds wrapper functions for `HGET`, `HSET` and `HSETNX` commands under the `redis_interface` crate and updates the `router` crate to use those functions.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
This change removes the `fred` crate as a direct dependency of the `router` crate.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Ran the application and created/retrieved payments via Postman.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: fix(redis_interface): fix derps in `HSET` and `HSETNX` command wrappers
- Merged: 2022-12-13T12:44:19Z
- Files changed: 7 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
This PR fixes some bugs introduced in #114.
The changes include:
- Rename `SetNXReply` to `SetnxReply`.
- Add `HsetnxReply` which is returned by the `HSETNX` command wrapper.
- Remove the `serialize_and_set_hash_fields()` function since it wasn't a perfect implementati
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(redis_interface): fix derps in `HSET` and `HSETNX` command wrappers (#129)
Files to modify:
**crates/redis_interface/src/commands.rs**
Remove:
- function: pub::serialize_and_set_hash_fields
**crates/redis_interface/src/types.rs**
Remove:
- enum: pub::SetNXReply
Add:
- enum: pub::SetnxReply
**crates/router/src/db/payment_attempt.rs**
Modify existing code
**crates/router/src/db/payment_intent.rs**
Modify existing code
**crates/router/src/db/queue.rs**
Modify existing code
|
{"issue_number": 114, "pr_number": 129, "commits_count": 1, "files_changed": 7, "response_length": 1312, "file_count": 7, "needs_breakdown": false}
|
feat: change list roles, get role, info api to respond with groups
|
<think>
PR Context:
- Title: feat(roles): Change list roles, get role and authorization info api to respond with groups
- Merged: 2024-02-27T13:11:55Z
- Files changed: 13 files
- Commits: 9 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Change `list_roles`, `get_role` and `get_authorization_info` api to respond with groups if asked.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies applicat
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(roles): Change list roles, get role and authorization info api to respond with groups (#3837)
C
Files to modify:
**crates/api_models/src/events/user_role.rs**
Modify existing code
**crates/api_models/src/user_role.rs**
Remove:
- struct: pub::AuthorizationInfoResponse
Add:
- struct: pub::AuthorizationInfoResponse
- struct: pub::GroupInfo
- enum: pub::AuthorizationInfo
**crates/api_models/src/user_role/role.rs**
Remove:
- struct: pub::RoleInfoResponse
Add:
- struct: pub::GetGroupsQueryParam
- struct: pub::RoleInfoWithPermissionsResponse
- struct: pub::RoleInfoWithGroupsResponse
- enum: pub::RoleInfoResponse
**crates/common_enums/src/enums.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/core/user_role.rs**
Modify existing code
**crates/router/src/core/user_role/role.rs**
Modify existing code
**crates/router/src/routes/user_role.rs**
Modify existing code
**crates/router/src/services/authorization.rs**
Modify existing code
**crates/router/src/services/authorization/info.rs**
Remove:
- struct: pub::PermissionInfo
**crates/router/src/services/authorization/roles.rs**
Modify existing code
**crates/router/src/types/domain/user.rs**
Remove:
- function: private::from
- impl: impl From<info::PermissionInfo> for user_role_api::PermissionInfo
**crates/router/src/utils/user.rs**
Modify existing code
|
{"issue_number": 3836, "pr_number": 3837, "commits_count": 1, "files_changed": 13, "response_length": 2280, "file_count": 15, "needs_breakdown": false}
|
feat(user_roles): Update both V1 and V2 user roles
Since we are introducing V2 user_roles. Before we start inserting V2 data, we should complete the other operations (update, delete and read).
This issue tracks the progress of changes for update.
|
<think>
PR Context:
- Title: feat(user_role): Add update by lineage DB function
- Merged: 2024-08-22T05:24:51Z
- Files changed: 9 files
- Commits: 8 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- This PR adds a new db function which can update a user_role by it's lineage.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/e
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(user_role): Add update by lineage DB function (#5651)
Files to modify:
**crates/diesel_models/src/query/user_role.rs**
Remove:
- function: pub::update_by_user_id_merchant_id
- function: pub::update_by_user_id_org_id
Add:
- function: pub::update_by_user_id_org_id_merchant_id_profile_id
**crates/diesel_models/src/user_role.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/core/user_role.rs**
Modify existing code
**crates/router/src/db/kafka_store.rs**
Remove:
- function: private::update_user_role_by_user_id_merchant_id
- function: private::update_user_roles_by_user_id_org_id
**crates/router/src/db/user_role.rs**
Remove:
- function: private::update_user_role_by_user_id_merchant_id
- function: private::update_user_roles_by_user_id_org_id
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/user_role.rs**
Remove:
- function: pub::transfer_org_ownership
**crates/router/src/utils/user_role.rs**
Add:
- function: pub::update_v1_and_v2_user_roles_in_db
|
{"issue_number": 5650, "pr_number": 5651, "commits_count": 1, "files_changed": 9, "response_length": 1893, "file_count": 11, "needs_breakdown": false}
|
refactor: raise appropriate errors instead of `ValidateError`
## Type of Change
Refactoring
## Description
<!-- Describe your changes in detail -->
To describe briefly, this PR raises appropriate errors instead of `ValidateError` and removes `ValidateError` in favor of `ValidationError`. A better understanding of the changes involved in this PR can be obtained from the commit log.
<details>
<summary>Commit Log (click to expand):</summary>
<ul>
<li>fix(connectors): raise <code>ParsingError</code> or <code>ConnectorError</code> during transformations</li>
<li>feat(errors): introduce <code>PreconditionFailed</code> variant for <code>ApiErrorResponse</code></li>
<li>refactor(stripe errors): minor fixes</li>
<li>docs(ApiErrorResponse): document <code>InvalidDataValue</code> and <code>PreconditionFailed</code> variants</li>
<li>refactor(payments): raise <code>PreconditionFailed</code> error variant instead of <code>ValidateError</code></li>
<li>refactor(ext_traits): raise <code>ValidationError</code> instead of <code>ValidateError</code></li>
</ul>
</details>
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
Building on top of #40, this PR incrementally unblocks splitting the `router` crate's API models into a separate crate.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
N/A
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
<!--
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
-->
|
<think>
PR Context:
- Title: fix(connector-template): raise `ConnectorError` instead of `ValidateError`
- Merged: 2022-12-08T14:37:40Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
This is an extension to #71, fixes two instances in the connector template which included the deprecated `ValidateError` type.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue he
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector-template): raise `ConnectorError` instead of `ValidateError` (#94)
Files to modify:
**connector-template/transformers.rs**
Modify existing code
|
{"issue_number": 71, "pr_number": 94, "commits_count": 1, "files_changed": 1, "response_length": 968, "file_count": 3, "needs_breakdown": false}
|
Adding Deep health check for Hyperswitch
Goal is to create a deep health check endpoint which will verify that the Hyperswitch application is up and running and the connections to all the necessary services are healthy
- [x] Failure of health check should emit logs providing evidential data regarding the failure
The deep health will verify the following services
- [x] #3267
- [x] #3268
- [x] #3269
- [x] #3270
- [x] [Deep health check for Hyperswitch Control Center](https://github.com/juspay/hyperswitch-control-center/issues/374)
|
<think>
PR Context:
- Title: feat(payment-link): add config for enabling form button only when form is complete
- Merged: 2025-03-17T15:05:30Z
- Files changed: 16 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds a payment link config for controlling the behavior or Submit button on payment links (`enable_button_only_on_form_ready`)
- If `enable_button_only_on_form_ready` is true - disallow incomplete form submission
- [DEFAULT and CURRENT] If false - allow incomplete form sub
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payment-link): add config for enabling form button only when form is complete (#7517)
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/diesel_models/src/business_profile.rs**
Modify existing code
**crates/diesel_models/src/payment_intent.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/lib.rs**
Modify existing code
**crates/router/src/consts.rs**
Modify existing code
**crates/router/src/core/payment_link.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
|
{"issue_number": 3264, "pr_number": 7517, "commits_count": 1, "files_changed": 16, "response_length": 1528, "file_count": 11, "needs_breakdown": false}
|
[REFACTOR]: [Noon] Remove Default Case Handling
### :memo: Feature Description
- We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
- These conditions generally go hand in hand with enum variants.
- Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
- So, if all the explicit cases are handled then default is used to handle the rest.
- Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a `_` is put to handle all the other cases.
- This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.
### :hammer: Possible Implementation
- Instead of relying on a default match case `_`, developers should handle each and every variant explicitly.
- By doing so, if there are any changes in the future, they can readily assess the impact of their modifications simply by compiling the code.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/1955
:bookmark: Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: refactor(connector): [Noon] Remove Default Case Handling
- Merged: 2023-10-30T14:10:51Z
- Files changed: 1 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
- Addresses Issue #2277
- Modified `crates/router/src/connector/noon/transformers.rs`
- Convert `NotImplemented` to `NotSupported` in default case
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR mod
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): [Noon] Remove Default Case Handling (#2677)
Files to modify:
**crates/router/src/connector/noon/transformers.rs**
Modify existing code
**Commit 2:** refactor(connector): [Noon] Remove Default Case Handling (#2677)
Files to modify:
**crates/router/src/connector/noon/transformers.rs**
Modify existing code
|
{"issue_number": 2277, "pr_number": 2677, "commits_count": 2, "files_changed": 1, "response_length": 1123, "file_count": 5, "needs_breakdown": false}
|
Properly Handle encoded_data in PSync flow [v2]
PSync is failing for adyen with error: `validate_psync_reference_id failed`. We need to pass the `encoded_data` in payment_attempt
|
<think>
PR Context:
- Title: fix(router): Handle encoded_data in PSync [V2]
- Merged: 2025-06-02T10:26:16Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Add `encoded_data` from `PaymentsRetrieveRequest` in `payment_attempt` inside `get_trackers` for PSync
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies app
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(router): Handle encoded_data in PSync [V2] (#8177)
Files to modify:
**crates/router/src/core/payments/operations/payment_get.rs**
Modify existing code
|
{"issue_number": 8176, "pr_number": 8177, "commits_count": 1, "files_changed": 1, "response_length": 937, "file_count": 3, "needs_breakdown": false}
|
fix(connector): [NMI] Handle empty response in psync and error response in complete authorize
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Handle empty response in psync and error response in complete authorize
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
test cases - Make payment, when status is in authentication_pending, make a psync, status should remain same
make a payment, after redirection , status should be succeeded.
successful payment -
<img width="976" alt="Screenshot 2024-02-05 at 4 38 21 PM" src="https://github.com/juspay/hyperswitch/assets/70575890/91da1fb8-4d1d-46eb-9db7-8d5ad50d5fb7">
<img width="630" alt="Screenshot 2024-02-05 at 4 38 36 PM" src="https://github.com/juspay/hyperswitch/assets/70575890/e205fa9d-fab8-4cb9-9a03-02805dc0701d">
<img width="1016" alt="Screenshot 2024-02-05 at 4 39 01 PM" src="https://github.com/juspay/hyperswitch/assets/70575890/d3e162d9-8f53-4ee2-b645-b23de27f59ad">
payment having error code and message when the fields such as cavv, eci, xid
<img width="631" alt="Screenshot 2024-02-05 at 3 35 43 PM" src="https://github.com/juspay/hyperswitch/assets/70575890/a69510c1-a1ea-4827-8885-c4897a62f072">
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: fix(connector): [NMI] Handle empty response in psync and error response in complete authorize
- Merged: 2024-02-05T12:55:57Z
- Files changed: 2 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Handle empty response in psync and error response in complete authorize
main pr - #3548
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application conf
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [NMI] Handle empty response in psync and error response in complete authorize (#3550
Files to modify:
**crates/router/src/connector/nmi/transformers.rs**
Remove:
- enum: pub::CardHolderAuthType
**crates/router/src/services/api.rs**
Modify existing code
|
{"issue_number": 3548, "pr_number": 3550, "commits_count": 1, "files_changed": 2, "response_length": 1105, "file_count": 4, "needs_breakdown": false}
|
refactor: deprecate V1 signin, verify email and invite APIs
Currently the following endpoints are not being used by the dashboard
`/user/signin`
`/user/verify_email`
`/user/invite`
New APIs are created for the above APIs which are
`/user/v2/signin`
`/user/v2/verify_email`
`/user/invite_multiple`
The old APIs are kept for backwards compatibility, as the movement is completed entirely from the FE side as well, old APIs can be removed.
|
<think>
PR Context:
- Title: refactor(user): Deprecate Signin, Verify email and Invite v1 APIs
- Merged: 2024-04-30T10:12:31Z
- Files changed: 7 files
- Commits: 4 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR will remove the following endpoints and corresponding APIs
`/user/signin`
`/user/verify_email`
`/user/invite`
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] Th
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(user): Deprecate Signin, Verify email and Invite v1 APIs (#4465)
Files to modify:
**crates/api_models/src/events/user.rs**
Modify existing code
**crates/api_models/src/user.rs**
Remove:
- struct: pub::InviteUserResponse
**crates/router/src/core/user.rs**
Remove:
- function: pub::signin_without_invite_checks
- function: pub::invite_user
- function: pub::verify_email_without_invite_checks
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/lock_utils.rs**
Modify existing code
**crates/router/src/routes/user.rs**
Remove:
- function: pub::user_signin_without_invite_checks
- function: pub::invite_user
- function: pub::verify_email_without_invite_checks
**crates/router_env/src/logger/types.rs**
Modify existing code
|
{"issue_number": 4464, "pr_number": 4465, "commits_count": 1, "files_changed": 7, "response_length": 1607, "file_count": 9, "needs_breakdown": false}
|
Add onboarding flow for VSAAS
- Support for endpoint to create a platform
- Create platform org and platform merchant account
- Support to create connected merchant account inside platform org
- Modify existing list responses for org and merchant, to distinguish platform from standard.
|
<think>
PR Context:
- Title: feat(vsaas): integrate onboarding flow for vertical saas
- Merged: 2025-05-12T15:02:09Z
- Files changed: 22 files
- Commits: 11 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
The PR supports onboarding for new VSAAS merchants.
- Creating Platform Org
- Creation of Platform, and connected merchant accounts
- Change List response of merchant and organization list.
### Additional Changes
- [ ] This PR modifies the API contract
- [x] This PR modifie
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(vsaas): integrate onboarding flow for vertical saas (#7884)
Files to modify:
**crates/api_models/src/events/user.rs**
Modify existing code
**crates/api_models/src/organization.rs**
Modify existing code
**crates/api_models/src/user.rs**
Add:
- struct: pub::PlatformAccountCreateRequest
- struct: pub::PlatformAccountCreateResponse
**crates/common_enums/src/enums.rs**
Modify existing code
**crates/common_enums/src/enums/accounts.rs**
Add:
- enum: pub::MerchantAccountType
- enum: pub::OrganizationType
**crates/diesel_models/src/merchant_account.rs**
Modify existing code
**crates/diesel_models/src/organization.rs**
Add:
- function: pub::get_organization_type
- function: pub::get_organization_type
**crates/diesel_models/src/schema.rs**
Modify existing code
**crates/diesel_models/src/schema_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/merchant_account.rs**
Modify existing code
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/user.rs**
Add:
- function: pub::create_platform_account
**crates/router/src/db/organization.rs**
Modify existing code
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/lock_utils.rs**
Modify existing code
**crates/router/src/routes/user.rs**
Add:
- function: pub::create_platform
**crates/router/src/types/domain/user.rs**
Add:
- function: private::from
- function: private::try_from
- impl: impl From<user_api::PlatformAccountCreateRequest> for NewUserOrganization
- impl: impl TryFrom<user_api::PlatformAccountCreateRequest> for NewUserMerchant
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/router/src/utils/user.rs**
Add:
- function: pub::generate_env_specific_merchant_id
**crates/router_env/src/logger/types.rs**
Modify existing code
|
{"issue_number": 7889, "pr_number": 7884, "commits_count": 1, "files_changed": 22, "response_length": 2696, "file_count": 22, "needs_breakdown": true}
|
[FEATURE]: [Tsys] Use `connector_request_reference_id` as reference to the connector
### :memo: Feature Description
- We transmit our reference id from Hyperswitch to the connector, enabling merchants to subsequently locate the payment within the connector dashboard.
- Presently, there is a lack of uniformity in this process, as some implementations employ `payment_id` while others utilize `attempt_id`.
- This inconsistency arises from the fact that `payment_id` and `attempt_id` correspond to two distinct entities within our system.
### :hammer: Possible Implementation
- To mitigate this confusion, we've introduced a new field called `connector_request_reference_id` in our RouterData.
- This id should replace them as a reference id to the connector for payment request.
- One might need to have exposure to api docs of the connector for which it is being implemented.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2052
:bookmark: Note : All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: feat(connector): [Tsys] Use connector_request_reference_id as reference to the connector
- Merged: 2023-10-18T14:25:59Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
- [x] New feature
## Description
The `connector_request_reference_id` parameter has been set for the Tsys Payment Solutions for uniform reference and transaction tracking.
### File Changes
- [x] This PR modifies the Tsys Transformers file.
**Location- router/src/connector/tsys/transformers.rs**
## Motivation and Context
This PR was raised so that it Fixes #2319 !
## How did you test it?
- **I ran the following command, and all the errors wer
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [Tsys] Use connector_request_reference_id as reference to the connector (#2631)
Files to modify:
**crates/router/src/connector/tsys/transformers.rs**
Modify existing code
|
{"issue_number": 2319, "pr_number": 2631, "commits_count": 1, "files_changed": 1, "response_length": 1012, "file_count": 4, "needs_breakdown": false}
|
refactor(routing): update configs on updation of mca
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
https://github.com/juspay/hyperswitch/pull/9659
This pull request introduces a new helper function to update the default fallback connector configuration whenever a merchant connector account (MCA) is updated. This ensures that changes to connector status (such as disabling or enabling) are accurately reflected in both merchant and profile configurations. The changes also include necessary imports and function calls to integrate this logic into the connector update flow.
**Connector fallback configuration updates:**
* Added the `update_default_fallback_on_mca_update` function in `routing/helpers.rs` to update merchant and profile default connector configurations based on the status of the updated MCA. The function ensures that disabled or inactive connectors are removed from the defaults, and enabled connectors are added if not already present.
* Integrated the new helper into the `update_connector` flow in `admin.rs`, so it is triggered automatically after connector updates.
**Imports and code organization:**
* Added necessary imports for `update_default_fallback_on_mca_update` and related types in `admin.rs` and `helpers.rs` to support the new logic. [[1]](diffhunk://#diff-7e1b4a44fadc4de1af2a6abeb318b3ddf044177c44ba00731c33dbf4cdce92b7R25-R28) [[2]](diffhunk://#diff-ea48d33e52b2cb7edbbba1d236b55f946fdb2c178f8c76f4226818b3630c4658R6)
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
1. Create two connectors namely adyen and wise
2. check configs table
```
SELECT key, config
FROM configs
WHERE key = 'routing_default_po_pro_RTMoW14AvhG5cjmcpcNb';
```
```
SELECT key, config
FROM configs
WHERE key = 'routing_default_po_merchant_id';
```
3. disable one of them
4. check configs table again for above query, this time the disabled shouldn't be present.
5. Re-enable the disabled connector, then query the table for the connector to be added back.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [ ] I formatted the code `cargo +nightly fmt --all`
- [ ] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert(routing): update configs on updation of mca
- Merged: 2025-10-08T08:46:29Z
- Files changed: 3 files
- Commits: 1 commits
Implementation approach:
Reverts juspay/hyperswitch#9689
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert(routing): update configs on updation of mca (#9740)
Files to modify:
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/routing.rs**
Modify existing code
**crates/router/src/core/routing/helpers.rs**
Remove:
- function: pub::redact_cgraph_cache
- function: pub::redact_routing_cache
- function: pub::update_default_fallback_on_mca_update
|
{"issue_number": 9689, "pr_number": 9740, "commits_count": 1, "files_changed": 3, "response_length": 711, "file_count": 5, "needs_breakdown": false}
|
[FEATURE]: [Mollie] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the amount value is expected to be always provided in minor units.
- For example: In USD, If the amount is 1 in base unit (Dollar), then it will be equivalent to 100 in minor units (Cent)
- Some of the connectors integrated require the amount to be converted to a desirable unit before being passed to them.
- We have functions `to_currency_base_unit` and `to_currency_lower_unit` in place to convert the minor unit amount to its decimal equivalent and vice versa. These conversions are handled explicitly based on the connector.
### :hammer: Possible Implementation
- ConnectorCommon trait have been implemented for the connector.
- This trait contains `get_currency_unit` method. This method needs to be implemented.
- It will define what type of conversion needs to be done during `connector_router_data` creation. Concurrently handle the creation of `connector_router_data` to be passed for the connector request body creation.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2196
:bookmark: Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: feat(connector): [Mollie] Currency Unit Conversion
- Merged: 2023-10-27T12:03:58Z
- Files changed: 2 files
- Commits: 10 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
- Addressing Issue: #2231
- Modified two files in `hyperswitch/crates/router/src/connector/`
- `mollie.rs`
- Implement `get_currency_unit` function
- Modify `ConnectorIntegration` implementations for `Mollie`
- `mollie/transformers.rs`
- Implement `MollieRouterD
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [Mollie] Currency Unit Conversion (#2671)
Co-authored-by: SamraatBansal <55536657+S
Files to modify:
**crates/router/src/connector/mollie.rs**
Add:
- function: private::get_currency_unit
**crates/router/src/connector/mollie/transformers.rs**
Add:
- function: private::try_from
- struct: pub::MollieRouterData
- impl: impl TryFrom<(
&types::api::CurrencyUnit,
types::storage::enums::Currency,
i64,
T,
)> for MollieRouterData<T>
**Commit 2:** feat(connector): [Mollie] Currency Unit Conversion (#2671)
Co-authored-by: SamraatBansal <55536657+S
Files to modify:
**crates/router/src/connector/mollie.rs**
Add:
- function: private::get_currency_unit
**crates/router/src/connector/mollie/transformers.rs**
Add:
- function: private::try_from
- struct: pub::MollieRouterData
- impl: impl TryFrom<(
&types::api::CurrencyUnit,
types::storage::enums::Currency,
i64,
T,
)> for MollieRouterData<T>
|
{"issue_number": 2231, "pr_number": 2671, "commits_count": 2, "files_changed": 2, "response_length": 1804, "file_count": 7, "needs_breakdown": false}
|
[FEATURE]: [Worldline] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the amount value is expected to be always provided in minor units.
- For example: In USD, If the amount is 1 in base unit (Dollar), then it will be equivalent to 100 in minor units (Cent)
- Some of the connectors integrated require the amount to be converted to a desirable unit before being passed to them.
- We have functions `to_currency_base_unit` and `to_currency_lower_unit` in place to convert the minor unit amount to its decimal equivalent and vice versa. These conversions are handled explicitly based on the connector.
### :hammer: Possible Implementation
- ConnectorCommon trait have been implemented for the connector.
- This trait contains `get_currency_unit` method. This method needs to be implemented.
- It will define what type of conversion needs to be done during `connector_router_data` creation. Concurrently handle the creation of `connector_router_data` to be passed for the connector request body creation.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2196
:bookmark: Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: refactor(connector): [Worldline] Currency Unit Conversion
- Merged: 2023-10-13T10:22:23Z
- Files changed: 2 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This pull request implements the get_currency_unit from the ConnectorCommon trait for the Worldline connector. This function allows connectors to declare their accepted currency unit as either Base or Minor. For Worldline it accepts currency as Minor units.
### Additional Changes
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): [Worldline] Currency Unit Conversion (#2569)
Files to modify:
**crates/router/src/connector/worldline.rs**
Add:
- function: private::get_currency_unit
**crates/router/src/connector/worldline/transformers.rs**
Add:
- function: private::try_from
- struct: pub::WorldlineRouterData
- impl: impl TryFrom<(
&types::api::CurrencyUnit,
types::storage::enums::Currency,
i64,
T,
)> for WorldlineRouterData<T>
|
{"issue_number": 2249, "pr_number": 2569, "commits_count": 1, "files_changed": 2, "response_length": 1269, "file_count": 4, "needs_breakdown": false}
|
Update broken readme icon
Updating broken readme icon along with reposition of the hero image
|
<think>
PR Context:
- Title: docs(README): Updated the icon and repositioned the hero image
- Merged: 2024-11-03T14:12:33Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
TOC icon and reposition of the hero image in readme
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [x] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Updated the icon of CI Push and repositioned the hero image
closes #6449
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6449, "pr_number": 6445, "commits_count": 0, "files_changed": 1, "response_length": 792, "file_count": 0, "needs_breakdown": false}
|
refactor: [Noon] adding new field max_amount to mandate request
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Resolves [#3844](https://github.com/juspay/hyperswitch-cloud/issues/3844)
_Note
1.While connector create ensure `test_mode` is set to true
2.Ensure the currency passed is `AED` and country is `AE`_
## How did you test it?
1.Create a CIT with noon
with
```
"connector_metadata": {
"noon": {
"order_category": "pay"
}
}
```
<img width="898" alt="Screenshot 2024-01-12 at 2 16 26 PM" src="https://github.com/juspay/hyperswitch/assets/131388445/4b99d41c-7d91-4e5c-b60c-b1d45b5f2e19">
</n>
without order_category it should throw an error
<img width="637" alt="Screenshot 2024-01-12 at 2 16 44 PM" src="https://github.com/juspay/hyperswitch/assets/131388445/24bffbaf-3699-4173-af78-ef432d82d1fe">
2. Make a MIT
<img width="675" alt="Screenshot 2024-01-12 at 2 02 35 PM" src="https://github.com/juspay/hyperswitch/assets/131388445/8d913c5f-cab0-436b-ad1d-8a0b3625f620">
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: Refactor(Router): [Noon] revert adding new field max_amount to mandate request
- Merged: 2024-01-24T10:55:57Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
Reverts juspay/hyperswitch#3209
Resolves [#3445](https://github.com/juspay/hyperswitch/issues/3445)
Dependency change not made
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** Refactor(Router): [Noon] revert adding new field max_amount to mandate request (#3435)
Files to modify:
**crates/router/src/connector/noon/transformers.rs**
Modify existing code
|
{"issue_number": 3209, "pr_number": 3435, "commits_count": 1, "files_changed": 1, "response_length": 624, "file_count": 3, "needs_breakdown": false}
|
feat(connector): [ZSL] add connector template code
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Zsl only supports automatic payment create and payment status gets updated through webhooks
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: refactor(core): add cache redaction for cgraph
- Merged: 2025-10-01T08:33:13Z
- Files changed: 3 files
- Commits: 9 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This pull request enhances cache management for connector creation by introducing a new mechanism to invalidate related cache entries whenever a new connector is added. The main change is the addition of the `redact_cgraph_cache` function, whi
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(core): add cache redaction for cgraph (#9629)
Files to modify:
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/routing/helpers.rs**
Add:
- function: pub::redact_cgraph_cache
**crates/router/src/core/subscription.rs**
Remove:
- impl: impl SubscriptionWithHandler<'a>
Add:
- impl: impl SubscriptionWithHandler<'_>
|
{"issue_number": 4285, "pr_number": 9629, "commits_count": 1, "files_changed": 3, "response_length": 1157, "file_count": 5, "needs_breakdown": false}
|
enhance(storage_models): delete client secret when status is succeeded, failed, cancelled
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
Previously client secret was only deleted when payment was succeeded.
Now the client secret gets deleted when status is succeeded/failed/cancelled
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Manual
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(pm_list): handle client secret check
- Merged: 2023-03-21T12:10:59Z
- Files changed: 3 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] New feature
## Description
<!-- Describe your changes in detail -->
If there is no client secret in payment_intent then it has expired, so if we receive a client secret in request and there is no client secret in payment intent then the client secret provided has expired.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue he
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(pm_list): handle client secret check (#759)
Files to modify:
**crates/router/src/compatibility/stripe/errors.rs**
Modify existing code
**crates/router/src/core/errors/api_error_response.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Modify existing code
|
{"issue_number": 724, "pr_number": 759, "commits_count": 1, "files_changed": 3, "response_length": 1068, "file_count": 5, "needs_breakdown": false}
|
fix(connector): [Cybersource] change commerce indicator for applepay
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Change the commerce indicator for cybersource applepay payment which was failing payment in production
Note: This pr is crucial for flowbird
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Tested through postman:
- Create an MCA for Cybersource:
- Create a Payment with Applepay:
```
{
"amount": 650,
"currency": "USD",
"confirm": true,
"amount_to_capture": 650,
"customer_id": "test_fb",
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"authentication_type": "three_ds",
"return_url": "https://google.com",
"email": "[email protected]",
"name": "Joseph Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment request",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"payment_method": "wallet",
"payment_method_type": "apple_pay",
"payment_method_data": {
"wallet": {
"apple_pay": {
"payment_data": "{{payment_data}}",
"payment_method": {
"display_name": "MasterCard 7599",
"network": "MasterCard",
"type": "credit"
},
"transaction_identifier": "{{transaction_identifier}}"
}
},
"billing": {
"address": {
"line1": "jhkdsa",
"zip": "10000",
"last_name": "chikke",
"city": "adf",
"country": "US",
"first_name": "srujan",
"state": "Alabama"
},
"email": "[email protected]"
}
}
}
```
- The payment should `succeed`
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): [Cybersource] change commerce indicator for applepay
- Merged: 2024-11-22T12:26:57Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Change the commerce indicator for cybersource applepay payment which was failing payment in production
Hotfix correspond to PR - [#6634](https://github.com/juspay/hyperswitch/pull/6634)
Note: This pr is crucial for flowbird
### Additi
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [Cybersource] change commerce indicator for applepay (#6641)
Files to modify:
**crates/router/src/connector/cybersource/transformers.rs**
Modify existing code
|
{"issue_number": 6634, "pr_number": 6641, "commits_count": 1, "files_changed": 1, "response_length": 979, "file_count": 3, "needs_breakdown": false}
|
feat(connector): [Authorizedotnet] implement payment and refund webhook flow for Authorizedotnet
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Payments and refund Webhook Flow for Authorizedotnet
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
Payments and refund webhook flow Authorizedotnet
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Outgoing payment webhook
<img width="1169" alt="Screenshot 2023-05-16 at 7 55 40 PM" src="https://github.com/juspay/hyperswitch/assets/121822803/0a35ba1a-9c4a-4cd3-9863-4ec22fd5029f">
Payment retrieve for same payment
<img width="1280" alt="Screenshot 2023-05-16 at 7 56 17 PM" src="https://github.com/juspay/hyperswitch/assets/121822803/697ad716-1224-4f63-a46a-ce4f6117331f">
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(connector): [Authorizedotnet] implement Capture flow and webhooks for Authorizedotnet
- Merged: 2023-05-18T15:05:33Z
- Files changed: 3 files
- Commits: 13 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR modifies following changes
1)add capture flow to authorizedotnet
2)add unit tests for authorizedotnet
3)refactor exisiting code for authorizedotnet
4)Payments and refund Webhooks #1176
**Note** :To update the status after autho
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [Authorizedotnet] implement Capture flow and webhooks for Authorizedotnet (#1171)
S
Files to modify:
**crates/router/src/connector/authorizedotnet.rs**
Add:
- function: private::build_headers
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- impl: impl ConnectorCommonExt<Flow, Request, Response> for Authorizedotnet
- impl: impl ConnectorIntegration<api::Verify, types::VerifyRequestData, types::PaymentsResponseData> for Authorizedotnet
- impl: impl ConnectorIntegration<api::Capture, types::PaymentsCaptureData, types::PaymentsResponseData> for Authorizedotnet
- impl: impl impl ConnectorIntegration<api::Authorize, types::PaymentsAuthorizeData, types::PaymentsResponseData>
**crates/router/src/connector/authorizedotnet/transformers.rs**
Remove:
- struct: private::TransactionVoidRequest
- struct: private::ResponseMessage
Add:
- struct: private::TransactionVoidOrCaptureRequest
**crates/router/tests/connectors/authorizedotnet.rs**
Add:
- function: private::get_data
- function: private::get_auth_token
- function: private::should_capture_authorized_payment
- function: private::should_sync_authorized_payment
- function: private::should_void_authorized_payment
- function: private::should_make_payment
- function: private::should_sync_auto_captured_payment
- function: private::should_fail_payment_for_empty_card_number
- function: private::should_fail_payment_for_incorrect_cvc
- function: private::should_fail_payment_for_invalid_exp_month
- function: private::should_fail_payment_for_incorrect_expiry_year
- function: private::should_fail_void_payment_for_auto_capture
- impl: impl ConnectorActions for AuthorizedotnetTest
|
{"issue_number": 1176, "pr_number": 1171, "commits_count": 1, "files_changed": 3, "response_length": 2798, "file_count": 6, "needs_breakdown": false}
|
[FEATURE]: [Nuvei] Use `connector_response_reference_id` as reference to merchant
### :memo: Feature Description
- Reference id are used to map transactions in the connector’s dashboard.
- Hyperswitch manages several reference ids, such as `payment_id`, `attempt_id`, and `connector_transaction_id` for a single transaction.
- However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.
### :hammer: Possible Implementation
- When we receive a response from the connector for the payment, we deserialize it and populate the `response` field in RouterData.
- For the `TransactionResponse` type, we must fill the `connector_response_reference_id` with a corresponding reference id for the merchant to identify the transaction.
- One might need to have exposure to api docs of the connector for which it is being implemented to decide what to fill in connector_response_reference_id.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/1735
🔖 Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: feat(connector): [Nuvei] Add order id as the reference id
- Merged: 2023-10-02T13:11:50Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Nuvei is using just the [order id](https://developer.nuvei.com/chapter-4-payment-page) to track the transaction.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR m
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [Nuvei] Add order id as the reference id (#2408)
Files to modify:
**crates/router/src/connector/nuvei/transformers.rs**
Modify existing code
|
{"issue_number": 2340, "pr_number": 2408, "commits_count": 1, "files_changed": 1, "response_length": 951, "file_count": 3, "needs_breakdown": false}
|
feat(core): add backwards compatibility for multiple mca
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] New feature
## Description
<!-- Describe your changes in detail -->
This will use default values if not passed in the request if feature `backwards_compatibality` is enabled. If not then the additional fields will be mandatory.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
To support backwards compatibality
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
- Run the application with `backwards_compatible` feature
- Create a merchant account without business details -> autopopulated
- Create a merchant connector account without business details -> autopopulated
- Create a payment without business details -> taken from merchant account.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
|
<think>
PR Context:
- Title: Changelog for release v0.5.6
- Merged: 2023-04-17T06:54:49Z
- Files changed: 1 files
- Commits: 10 commits
Implementation approach:
# 0.5.6 2023-04-14
## Build System / Dependencies
* **deps:** bump `fred` from `5.2.0` to `6.0.0` (#869) (01bc162d)
## Continuous Integration
* **manual_release:** add `multiple_mca` feature in ci (#872) (aebb4dca)
## New Features
* **core:** add backwards compatibility for multiple mca (#866) (cf902f19)
* **router:**
* added dispute retrieve and dispute list apis (#842) (acab7671)
* separate straight through algorithm in separate column in payment attempt (#863) (0
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 866, "pr_number": 859, "commits_count": 0, "files_changed": 1, "response_length": 759, "file_count": 4, "needs_breakdown": false}
|
feat(connector): [ACI, AUTHORIZEDOTNET, BRAINTREE, FIUU, FORTE, PLACETOPAY] Supported features for feature matrix
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added Feature Matrix supported payment methods, countries and currencies for ACI, Authorizedotnet, Braintree, Fiuu, Forte and Placetopay.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
- Request
```
curl --location --request GET 'http://localhost:8080/feature_matrix' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_kl7vP0fysoyX8f1O7wZiJae7n1XS5zhEJbe2zK4rtuDNCg4JMSsWhSc0GNkNKWwC' \
--header 'X-Merchant-Id: merchant_1738299466' \
--data '{
}'
```
- Response
```
{
"connector_count": 48,
"connectors": [
{
"name": "ACI",
"display_name": "ACI",
"description": "ACI Payments delivers secure, real-time electronic payment solutions for businesses, banks, and governments, enabling seamless transactions across channels.",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "wallet",
"payment_method_type": "mb_way",
"payment_method_type_display_name": "MB WAY",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"ESP",
"EST",
"PRT"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "wallet",
"payment_method_type": "ali_pay",
"payment_method_type_display_name": "Alipay",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"CHN"
],
"supported_currencies": [
"CNY"
]
},
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic"
],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"DinersClub",
"Discover",
"JCB",
"Maestro",
"Mastercard",
"UnionPay",
"Visa"
],
"supported_countries": [
"EST",
"PRT",
"GRC",
"ZMB",
"POL",
"KHM",
"LUX",
"SVK",
"HKG",
"VNM",
"HND",
"SWE",
"LTU",
"IRL",
"NZL",
"SVN",
"ARE",
"OMN",
"BGR",
"CHN",
"LIE",
"EGY",
"AND",
"CHE",
"UKR",
"FRA",
"QAT",
"MEX",
"NGA",
"ETH",
"SLV",
"GBR",
"GIB",
"THA",
"DOM",
"SAU",
"IDN",
"MKD",
"JPN",
"CRI",
"USA",
"ISL",
"COL",
"DNK",
"MMR",
"SEN",
"ROU",
"LAO",
"URY",
"FIN",
"CYP",
"ITA",
"PAN",
"HUN",
"CZE",
"PER",
"BEL",
"GHA",
"AUT",
"HRV",
"DEU",
"GTM",
"ESP",
"LBY",
"MOZ",
"PAK",
"MYS"
],
"supported_currencies": [
"ALL",
"KPW",
"ISK",
"PLN",
"BGN",
"EGP",
"CHF",
"LKR",
"PKR",
"ILS",
"USD",
"CZK",
"DOP",
"NZD",
"SGD",
"NOK",
"VND",
"KHR",
"SEK",
"CNY",
"THB",
"COP",
"DKK",
"TRY",
"UYU",
"CRC",
"CLP",
"GBP",
"NGN",
"PEN",
"ZAR",
"HRK",
"IDR",
"MXN",
"HNL",
"UAH",
"RSD",
"PAB",
"HUF",
"SAR",
"TWD",
"JPY",
"MAD",
"MKD",
"PHP",
"MMK",
"EUR",
"QAR",
"LAK",
"RON",
"MYR",
"HKD",
"MZN",
"OMR",
"ZMW",
"ARS",
"AED",
"GHS"
]
},
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic"
],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"DinersClub",
"Discover",
"JCB",
"Maestro",
"Mastercard",
"UnionPay",
"Visa"
],
"supported_countries": [
"SVK",
"SAU",
"NGA",
"ESP",
"QAT",
"HKG",
"SWE",
"ZMB",
"URY",
"CRI",
"GHA",
"OMN",
"VNM",
"PER",
"CHE",
"PAK",
"DNK",
"PAN",
"CHN",
"ETH",
"MYS",
"NZL",
"ITA",
"LBY",
"KHM",
"MEX",
"ROU",
"IDN",
"JPN",
"GBR",
"MKD",
"MMR",
"HND",
"USA",
"DEU",
"MOZ",
"POL",
"BEL",
"AUT",
"PRT",
"THA",
"GIB",
"GRC",
"CZE",
"SLV",
"HUN",
"SEN",
"GTM",
"CYP",
"FRA",
"LUX",
"LAO",
"FIN",
"EGY",
"LTU",
"SVN",
"HRV",
"ARE",
"COL",
"ISL",
"EST",
"BGR",
"LIE",
"UKR",
"IRL",
"DOM",
"AND"
],
"supported_currencies": [
"ALL",
"CRC",
"COP",
"RSD",
"AED",
"MMK",
"MXN",
"ARS",
"PLN",
"NZD",
"HRK",
"SAR",
"SGD",
"GHS",
"TWD",
"BGN",
"THB",
"PHP",
"CZK",
"OMR",
"HKD",
"VND",
"GBP",
"LKR",
"ISK",
"ILS",
"NGN",
"PEN",
"TRY",
"ZMW",
"CNY",
"KPW",
"LAK",
"PKR",
"IDR",
"NOK",
"CHF",
"KHR",
"SEK",
"JPY",
"UAH",
"DKK",
"MYR",
"EGP",
"ZAR",
"CLP",
"MKD",
"QAR",
"MAD",
"RON",
"UYU",
"HNL",
"EUR",
"MZN",
"PAB",
"HUF",
"DOP",
"USD"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "interac",
"payment_method_type_display_name": "Interac",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"CAN"
],
"supported_currencies": [
"CAD",
"USD"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "sofort",
"payment_method_type_display_name": "Sofort",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"ESP",
"GBR",
"POL",
"DEU",
"ITA",
"CHE",
"NLD",
"AUT",
"BEL"
],
"supported_currencies": [
"GBP",
"CHF",
"HUF",
"EUR",
"PLN"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "giropay",
"payment_method_type_display_name": "Giropay",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"DEU"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "przelewy24",
"payment_method_type_display_name": "Przelewy24",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"POL"
],
"supported_currencies": [
"EUR",
"GBP",
"CZK",
"PLN"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "ideal",
"payment_method_type_display_name": "iDEAL",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"NLD"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "eft",
"payment_method_type_display_name": "EFT",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": null,
"supported_currencies": null
},
{
"payment_method": "bank_redirect",
"payment_method_type": "eps",
"payment_method_type_display_name": "EPS",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"AUT"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "trustly",
"payment_method_type_display_name": "Trustly",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"SWE",
"LVA",
"NOR",
"EST",
"ESP",
"DNK",
"DEU",
"NLD",
"GBR",
"AUT",
"LTU",
"FIN"
],
"supported_currencies": [
"DKK",
"SEK",
"NOK",
"EUR",
"CZK",
"GBP"
]
},
{
"payment_method": "pay_later",
"payment_method_type": "klarna",
"payment_method_type_display_name": "Klarna",
"mandates": "not_supported",
"refunds": "not_supported",
"supported_capture_methods": [
"automatic"
],
"supported_countries": [
"NLD",
"NOR",
"POL",
"BEL",
"FIN",
"GRC",
"CZE",
"IRL",
"SWE",
"GBR",
"DNK",
"DEU",
"CAN",
"CHE",
"NZL",
"AUS",
"AUT",
"ITA",
"ESP",
"PRT",
"USA",
"FRA"
],
"supported_currencies": [
"CAD",
"CHF",
"DKK",
"NZD",
"NOK",
"USD",
"SEK",
"AUD",
"GBP",
"PLN",
"EUR"
]
}
],
"supported_webhook_flows": []
},
{
"name": "AUTHORIZEDOTNET",
"display_name": "Authorize.net",
"description": " Authorize.net supports payment processing by helping small businesses accept credit card and eCheck payments online, in person on the go.",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"Discover",
"JCB",
"Mastercard",
"Visa"
],
"supported_countries": [
"USA",
"CAN"
],
"supported_currencies": [
"CAD",
"USD"
]
},
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"Discover",
"JCB",
"Mastercard",
"Visa"
],
"supported_countries": [
"USA",
"CAN"
],
"supported_currencies": [
"CAD",
"USD"
]
},
{
"payment_method": "wallet",
"payment_method_type": "google_pay",
"payment_method_type_display_name": "Google Pay",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"DEU",
"TWN",
"OMN",
"TUR",
"ZAF",
"KAZ",
"BHR",
"PRT",
"CZE",
"NZL",
"URY",
"EST",
"JOR",
"SAU",
"SWE",
"FIN",
"HUN",
"IDN",
"THA",
"PAN",
"BEL",
"DZA",
"ISR",
"ESP",
"VNM",
"ARG",
"POL",
"BRA",
"IND",
"ITA",
"SGP",
"MYS",
"ASM",
"HRV",
"BLR",
"MEX",
"UKR",
"QAT",
"GBR",
"ROU",
"PAK",
"KEN",
"PHL",
"USA",
"ATG",
"LBN",
"BGR",
"EGY",
"LVA",
"AGO",
"AUS",
"RUS",
"COL",
"CHE",
"AUT",
"ARE",
"LKA",
"LTU",
"DNK",
"SVK",
"LUX",
"JPN",
"NLD",
"NOR",
"DOM",
"ALB",
"AZE",
"FRA",
"PER",
"IRL",
"CHL",
"CAN",
"GRC",
"KWT",
"HKG"
],
"supported_currencies": [
"NZD",
"NOK",
"DKK",
"SEK",
"CHF",
"GBP",
"EUR",
"USD",
"AUD",
"PLN",
"CAD"
]
},
{
"payment_method": "wallet",
"payment_method_type": "apple_pay",
"payment_method_type_display_name": "Apple Pay",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"ITA",
"CHE",
"ARG",
"LTU",
"ISR",
"VNM",
"EST",
"IRL",
"JPN",
"MLT",
"MNE",
"ECU",
"MAR",
"GBR",
"NZL",
"IMN",
"CHL",
"DNK",
"GTM",
"MAC",
"FRA",
"AUT",
"FRO",
"SRB",
"BGR",
"AZE",
"ARE",
"NOR",
"HND",
"SVK",
"ALB",
"COL",
"FIN",
"PRT",
"POL",
"UKR",
"URY",
"KWT",
"SGP",
"ARM",
"ROU",
"CYP",
"HRV",
"DOM",
"MEX",
"GGY",
"CZE",
"TWN",
"ISL",
"HUN",
"BRA",
"AUS",
"MCO",
"SLV",
"DEU",
"LVA",
"BHR",
"CRI",
"GEO",
"PER",
"QAT",
"ZAF",
"USA",
"GRC",
"NLD",
"PAN",
"SVN",
"CAN",
"SWE",
"MDA",
"LIE",
"MYS",
"LUX",
"BEL",
"PRY",
"KAZ",
"SAU",
"HKG",
"GRL",
"ESP"
],
"supported_currencies": [
"EGP",
"PYG",
"QAR",
"INR",
"AED",
"CLP",
"GTQ",
"UAH",
"COP",
"HNL",
"BRL",
"HKD",
"KWD",
"MAD",
"NOK",
"PEN",
"RON",
"VND",
"PLN",
"JPY",
"GHS",
"KZT",
"ZAR",
"ISK",
"CZK",
"KRW",
"EUR",
"CAD",
"AUD",
"HUF",
"SAR",
"SGD",
"CRC",
"DKK",
"USD",
"MYR",
"SEK",
"THB",
"TWD",
"GEL",
"ILS",
"NZD",
"GBP",
"MXN"
]
}
],
"supported_webhook_flows": [
"payments",
"refunds"
]
},
{
"name": "BRAINTREE",
"display_name": "Braintree",
"description": "Braintree, a PayPal service, offers a full-stack payment platform that simplifies accepting payments in your app or website, supporting various payment methods including credit cards and PayPal.",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"Discover",
"JCB",
"UnionPay",
"Mastercard",
"Visa"
],
"supported_countries": [
"SVK",
"PRT",
"MYS",
"FIN",
"SGP",
"JEY",
"CAN",
"ESP",
"HKG",
"LUX",
"SMR",
"FRA",
"CZE",
"AUS",
"POL",
"CHE",
"LIE",
"MCO",
"AUT",
"DEU",
"IMN",
"HRV",
"GGY",
"NZL",
"IRL",
"ITA",
"GBR",
"LVA",
"GRC",
"BGR",
"NOR",
"BEL",
"LTU",
"HUN",
"MLT",
"DNK",
"USA",
"EST",
"NLD",
"CYP",
"ROU",
"SVN",
"AND",
"GIB",
"SWE"
],
"supported_currencies": [
"SRD",
"FJD",
"BMD",
"GTQ",
"TTD",
"DZD",
"MDL",
"ISK",
"ZWL",
"NGN",
"CRC",
"JPY",
"KZT",
"UAH",
"CAD",
"AED",
"QAR",
"PAB",
"GIP",
"SLL",
"BWP",
"NOK",
"ZAR",
"SZL",
"MWK",
"HUF",
"UZS",
"FKP",
"PHP",
"MUR",
"BRL",
"RWF",
"MYR",
"MVR",
"CNY",
"MNT",
"TRY",
"MKD",
"STD",
"SBD",
"CLP",
"SOS",
"TJS",
"AUD",
"BBD",
"BDT",
"BIF",
"CVE",
"AZN",
"AOA",
"IDR",
"KES",
"GEL",
"SYP",
"MOP",
"ETB",
"SEK",
"DOP",
"XOF",
"BZD",
"BSD",
"EGP",
"HKD",
"CHF",
"KYD",
"UGX",
"HNL",
"USD",
"BAM",
"THB",
"GHS",
"AWG",
"CZK",
"NAD",
"NIO",
"PYG",
"SVC",
"LKR",
"YER",
"RUB",
"KHR",
"BYN",
"VES",
"XCD",
"XAF",
"HTG",
"SAR",
"BOB",
"SHP",
"PKR",
"TZS",
"TOP",
"BND",
"GMD",
"EUR",
"UYU",
"KRW",
"DKK",
"GYD",
"COP",
"MAD",
"SCR",
"ILS",
"MXN",
"VND",
"LAK",
"WST",
"INR",
"LBP",
"BGN",
"VUV",
"PEN",
"DJF",
"JMD",
"ARS",
"GBP",
"NPR",
"KMF",
"KGS",
"PLN",
"MZN",
"LRD",
"ZMW",
"XPF",
"GNF",
"LSL",
"SGD",
"TWD",
"RSD",
"RON",
"NZD",
"PGK",
"AMD",
"HRK"
]
},
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"Discover",
"JCB",
"UnionPay",
"Mastercard",
"Visa"
],
"supported_countries": [
"DEU",
"CHE",
"DNK",
"CZE",
"GBR",
"BEL",
"USA",
"GGY",
"POL",
"CAN",
"AUS",
"ROU",
"NOR",
"FIN",
"IRL",
"MCO",
"FRA",
"LIE",
"LTU",
"PRT",
"SGP",
"HKG",
"IMN",
"SWE",
"EST",
"ITA",
"MLT",
"SVK",
"NLD",
"NZL",
"AND",
"HRV",
"GRC",
"SVN",
"JEY",
"MYS",
"LVA",
"CYP",
"AUT",
"HUN",
"ESP",
"SMR",
"LUX",
"BGR",
"GIB"
],
"supported_currencies": [
"GIP",
"TTD",
"GYD",
"BND",
"GTQ",
"LAK",
"UYU",
"ISK",
"GMD",
"KHR",
"BYN",
"QAR",
"AWG",
"MXN",
"NPR",
"KGS",
"SRD",
"SCR",
"CVE",
"FKP",
"PHP",
"AZN",
"SGD",
"BWP",
"RSD",
"NGN",
"BBD",
"NAD",
"BOB",
"CRC",
"BSD",
"MUR",
"RWF",
"XCD",
"HRK",
"XPF",
"SEK",
"MDL",
"INR",
"SYP",
"XAF",
"ARS",
"KYD",
"MZN",
"AED",
"KRW",
"GEL",
"NOK",
"BMD",
"MWK",
"TJS",
"SOS",
"JMD",
"DJF",
"CLP",
"PEN",
"WST",
"BIF",
"MKD",
"GHS",
"MAD",
"VES",
"DKK",
"HUF",
"LKR",
"TRY",
"GBP",
"TOP",
"CZK",
"SAR",
"XOF",
"KMF",
"LRD",
"HTG",
"PYG",
"RON",
"BGN",
"FJD",
"VUV",
"MNT",
"PLN",
"SHP",
"UAH",
"BZD",
"CHF",
"SBD",
"BRL",
"TWD",
"RUB",
"CNY",
"GNF",
"JPY",
"ZAR",
"AMD",
"EGP",
"IDR",
"BDT",
"LBP",
"AOA",
"HKD",
"THB",
"MYR",
"ZMW",
"SLL",
"HNL",
"KES",
"UZS",
"MVR",
"PAB",
"DZD",
"CAD",
"NZD",
"NIO",
"LSL",
"STD",
"TZS",
"COP",
"YER",
"EUR",
"ZWL",
"ETB",
"PKR",
"KZT",
"PGK",
"BAM",
"UGX",
"SVC",
"MOP",
"SZL",
"VND",
"USD",
"DOP",
"ILS",
"AUD"
]
}
],
"supported_webhook_flows": [
"payments",
"refunds"
]
},
{
"name": "FIUU",
"display_name": "Fiuu",
"description": "Fiuu, formerly known as Razer Merchant Services, is a leading online payment gateway in Southeast Asia, offering secure and seamless payment solutions for businesses of all sizes, including credit and debit cards, e-wallets, and bank transfers.",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "bank_redirect",
"payment_method_type": "online_banking_fpx",
"payment_method_type_display_name": "Online Banking FPX",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"MYS"
],
"supported_currencies": [
"MYR"
]
},
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"JCB",
"DinersClub",
"UnionPay",
"Mastercard",
"Discover"
],
"supported_countries": [
"IDN",
"VNM",
"CHN",
"SGP",
"TWN",
"HKG",
"THA",
"MYS",
"PHL"
],
"supported_currencies": [
"IDR",
"PHP",
"MYR",
"CNY",
"SGD",
"VND",
"THB",
"TWD",
"HKD"
]
},
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"JCB",
"DinersClub",
"UnionPay",
"Mastercard",
"Discover"
],
"supported_countries": [
"PHL",
"MYS",
"SGP",
"IDN",
"TWN",
"HKG",
"THA",
"VNM",
"CHN"
],
"supported_currencies": [
"HKD",
"IDR",
"MYR",
"CNY",
"SGD",
"THB",
"VND",
"TWD",
"PHP"
]
},
{
"payment_method": "real_time_payment",
"payment_method_type": "duit_now",
"payment_method_type_display_name": "DuitNow",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"MYS"
],
"supported_currencies": [
"MYR"
]
},
{
"payment_method": "wallet",
"payment_method_type": "apple_pay",
"payment_method_type_display_name": "Apple Pay",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"MYS"
],
"supported_currencies": [
"MYR"
]
},
{
"payment_method": "wallet",
"payment_method_type": "google_pay",
"payment_method_type_display_name": "Google Pay",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"MYS"
],
"supported_currencies": [
"MYR"
]
}
],
"supported_webhook_flows": [
"payments",
"refunds"
]
},
{
"name": "FORTE",
"display_name": "Forte",
"description": "CSG Forte offers a unified payments platform, enabling businesses to securely process credit cards, debit cards, ACH/eCheck transactions, and more, with advanced fraud prevention and seamless integration.",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"Discover",
"DinersClub",
"JCB",
"Mastercard",
"Visa"
],
"supported_countries": [
"USA",
"CAN"
],
"supported_currencies": [
"USD",
"CAD"
]
},
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"Discover",
"DinersClub",
"JCB",
"Mastercard",
"Visa"
],
"supported_countries": [
"CAN",
"USA"
],
"supported_currencies": [
"USD",
"CAD"
]
}
],
"supported_webhook_flows": []
},
{
"name": "PLACETOPAY",
"display_name": "PlacetoPay",
"description": "PlacetoPay is a Latin American financial technology company's online payment platform, offering various payment methods and integrations for businesses",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"sequential_automatic"
],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"DinersClub",
"Mastercard",
"Visa"
],
"supported_countries": [
"PRI",
"URY",
"CRI",
"CHE",
"ECU",
"BEL",
"COL",
"HND",
"MEX",
"PAN"
],
"supported_currencies": [
"USD",
"CLP",
"COP"
]
},
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"sequential_automatic"
],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"AmericanExpress",
"DinersClub",
"Mastercard",
"Visa"
],
"supported_countries": [
"PAN",
"ECU",
"CHE",
"MEX",
"HND",
"CRI",
"COL",
"URY",
"BEL",
"PRI"
],
"supported_currencies": [
"CLP",
"USD",
"COP"
]
}
],
"supported_webhook_flows": []
}
]
}
```
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): Added Paypal in feature matrix for authorizedotnet
- Merged: 2025-05-21T10:23:21Z
- Files changed: 1 files
- Commits: 7 commits
Implementation approach:
## Type of Change
Added paypal in feature matrix for authorizedotnet
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Added the missed feature matrix supported PM , paypal for authorizedotnet.
Changes we added to authorizedotnet.rs file only, .toml files already have the desired changes in original PR.
Original PR : #7854
### Additional Changes
- [ ] This PR modifies the API contra
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): Added Paypal in feature matrix for authorizedotnet (#8072)
Co-authored-by: Chaitak G
Files to modify:
**crates/hyperswitch_connectors/src/connectors/authorizedotnet.rs**
Modify existing code
|
{"issue_number": 7854, "pr_number": 8072, "commits_count": 1, "files_changed": 1, "response_length": 1009, "file_count": 3, "needs_breakdown": false}
|
feat(router): Add `psp_tokenization_enabled` field in Customer Saved Payment Methods List
Required to show whether `psp_tokenization` is enabled for a saved payment method
|
<think>
PR Context:
- Title: feat(router): Return psp_tokenization_enabled in Customer PML
- Merged: 2025-03-20T10:04:56Z
- Files changed: 8 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added `psp_tokenization_enabled` field to `CustomerPaymentMethod` that denotes whether `psp_tokenization` is enabled for a saved payment method
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the da
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(router): Return psp_tokenization_enabled in Customer PML (#7519)
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/api_models/src/payment_methods.rs**
Modify existing code
**crates/openapi/src/openapi.rs**
Modify existing code
**crates/openapi/src/openapi_v2.rs**
Modify existing code
**crates/openapi/src/routes/payment_method.rs**
Modify existing code
**crates/router/src/core/payment_methods/transformers.rs**
Modify existing code
|
{"issue_number": 7518, "pr_number": 7519, "commits_count": 1, "files_changed": 8, "response_length": 1283, "file_count": 8, "needs_breakdown": false}
|
docs(openapi): document path parameters for API keys endpoints
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
This PR documents the path parameters added to the API keys endpoints in #600.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
Documenting the path parameters correctly makes it easier for users to try out our APIs via the SwaggerUI preview.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Generated the OpenAPI specification locally, tested the rendered Swagger UI preview.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: release: Update CHANGELOG for release v0.5.0
- Merged: 2023-03-21T09:28:58Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
# 0.5.0 (2023-03-21)
## Build System / Dependencies
* **deps:** update deps (#734) (16bc886c)
## Chores
* **merchant_account:** remove `api_key` field (#713) (230fcdd4)
* **config:** move connector base URLs under the `[connectors]` table (#723) (df8c8b5a)
* address Rust 1.68 clippy lints (#728) (1ffabb40)
## Continuous Integration
* **release:** specify `fetch-depth` for code checkout and use official Docker GitHub actions (#722) (c451368f)
## Documentation Changes
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 702, "pr_number": 788, "commits_count": 0, "files_changed": 1, "response_length": 774, "file_count": 4, "needs_breakdown": false}
|
fix(connector): [noon] address `next_action_url` being `null` for cards in 3ds payment
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
previously, when making a 3ds card transaction via noon connector, we would get `next_action` as `null` which is not intended. and that is because, paypal response would override the transaction data. this pr fixes this by unifying both of them.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
3ds transactions are expected to have an object in next action while at present, we are getting it as null for card payments and this is not intended.
closes #7831
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
3ds card payment:
```curl
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_dSMvDZeLPCEUIv7ZV4JQxAQIoTuE0kdlKZEhxK7gn15IY7WkcKKAgbvSEG8FEuOY' \
--data-raw '{
"amount": 390,
"currency": "AED",
"confirm": true,
"capture_method": "automatic",
"customer_id": "sammantest2722",
"capture_on": "2022-09-10T10:11:12Z",
"authentication_type": "three_ds",
"return_url": "https://google.com",
"email": "[email protected]",
"name": "Joseph Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4000000000002701",
"card_exp_month": "01",
"card_exp_year": "2035",
"card_holder_name": "joseph Doe",
"card_cvc": "100"
}
},
"billing": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "AE",
"first_name": "joseph",
"last_name": "Doe"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
}
},
"browser_info": {
"user_agent": "Mozilla\/5.0 (iPhone NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
"accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
"language": "nl-NL",
"color_depth": 24,
"screen_height": 723,
"screen_width": 1536,
"time_zone": 0,
"java_enabled": true,
"java_script_enabled": true,
"ip_address": "128.0.0.1"
},
"connector_metadata": {
"noon": {
"order_category": "pay"
}
},
"order_details": [
{
"product_name": "Apple iphone 15",
"quantity": 1,
"amount": 390,
"account_name": "transaction_processing"
}
]
}'
```
```json
{
"payment_id": "pay_kgxQFsLwpvRE5DN7pOjF",
"merchant_id": "postman_merchant_GHAction_7ec10174-0196-450e-a39a-4f9b61a32def",
"status": "requires_customer_action",
"amount": 390,
"net_amount": 390,
"shipping_cost": null,
"amount_capturable": 390,
"amount_received": null,
"connector": "noon",
"client_secret": "pay_kgxQFsLwpvRE5DN7pOjF_secret_JwwEA4oIyoD2w8lyNkuw",
"created": "2025-04-16T12:07:18.695Z",
"currency": "AED",
"customer_id": "sammantest2722",
"customer": {
"id": "sammantest2722",
"name": "Joseph Doe",
"email": "[email protected]",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": "Its my first payment",
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": null,
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "2701",
"card_type": "CREDIT",
"card_network": "Visa",
"card_issuer": "INTL HDQTRS-CENTER OWNED",
"card_issuing_country": "UNITEDSTATES",
"card_isin": "400000",
"card_extended_bin": null,
"card_exp_month": "01",
"card_exp_year": "2035",
"card_holder_name": "joseph Doe",
"payment_checks": null,
"authentication_data": null
},
"billing": null
},
"payment_token": null,
"shipping": null,
"billing": {
"address": {
"city": "San Fransico",
"country": "AE",
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"zip": "94122",
"state": "California",
"first_name": "joseph",
"last_name": "Doe"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
},
"email": null
},
"order_details": [
{
"brand": null,
"amount": 390,
"category": null,
"quantity": 1,
"tax_rate": null,
"product_id": null,
"product_name": "Apple iphone 15",
"product_type": null,
"sub_category": null,
"product_img_link": null,
"product_tax_code": null,
"total_tax_amount": null,
"requires_shipping": null
}
],
"email": "[email protected]",
"name": "Joseph Doe",
"phone": "999999999",
"return_url": "https://google.com/",
"authentication_type": "three_ds",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"next_action": {
"type": "redirect_to_url",
"redirect_to_url": "http://localhost:8080/payments/redirect/pay_kgxQFsLwpvRE5DN7pOjF/postman_merchant_GHAction_7ec10174-0196-450e-a39a-4f9b61a32def/pay_kgxQFsLwpvRE5DN7pOjF_1"
},
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "sammantest2722",
"created_at": 1744805238,
"expires": 1744808838,
"secret": "epk_77e21be22ea44e7cbc97ea1893092c71"
},
"manual_retry_allowed": null,
"connector_transaction_id": "783189382167",
"frm_message": null,
"metadata": null,
"connector_metadata": {
"apple_pay": null,
"airwallex": null,
"noon": {
"order_category": "pay"
},
"braintree": null
},
"feature_metadata": null,
"reference_id": "pay_kgxQFsLwpvRE5DN7pOjF_1",
"payment_link": null,
"profile_id": "pro_x1xo34goINdpBDkYDEhK",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_bPPkbMzjo94rCiHfRJyu",
"incremental_authorization_allowed": null,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2025-04-16T12:22:18.695Z",
"fingerprint": null,
"browser_info": {
"language": "nl-NL",
"time_zone": 0,
"ip_address": "128.0.0.1",
"user_agent": "Mozilla/5.0 (iPhone NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
"color_depth": 24,
"java_enabled": true,
"screen_width": 1536,
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"screen_height": 723,
"java_script_enabled": true
},
"payment_method_id": null,
"payment_method_status": null,
"updated": "2025-04-16T12:07:21.111Z",
"split_payments": null,
"frm_metadata": null,
"extended_authorization_applied": null,
"capture_before": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null,
"card_discovery": "manual",
"force_3ds_challenge": false,
"force_3ds_challenge_trigger": false,
"issuer_error_code": null,
"issuer_error_message": null
}
```
paypal payment:
```curl
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_dSMvDZeLPCEUIv7ZV4JQxAQIoTuE0kdlKZEhxK7gn15IY7WkcKKAgbvSEG8FEuOY' \
--data-raw '{
"amount": 1000,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"customer_id": "sammantest2722",
"capture_on": "2022-09-10T10:11:12Z",
"authentication_type": "three_ds",
"return_url": "https://google.com",
"email": "[email protected]",
"name": "Joseph Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"payment_method": "wallet",
"payment_method_type": "paypal",
"payment_method_data": {
"wallet": {
"paypal_redirect": {}
}
},
"browser_info": {
"user_agent": "Mozilla\/5.0 (iPhone NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
"accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
"language": "nl-NL",
"color_depth": 24,
"screen_height": 723,
"screen_width": 1536,
"time_zone": 0,
"java_enabled": true,
"java_script_enabled": true,
"ip_address": "128.0.0.1"
},
"connector_metadata": {
"noon": {
"order_category": "pay"
}
},
"order_details": [
{
"product_name": "Apple iphone 15",
"quantity": 1,
"amount": 390,
"account_name": "transaction_processing"
}
]
}'
```
```json
{
"payment_id": "pay_ZMSscM4kmOOYEGrwuRoC",
"merchant_id": "postman_merchant_GHAction_7ec10174-0196-450e-a39a-4f9b61a32def",
"status": "requires_customer_action",
"amount": 1000,
"net_amount": 1000,
"shipping_cost": null,
"amount_capturable": 1000,
"amount_received": null,
"connector": "noon",
"client_secret": "pay_ZMSscM4kmOOYEGrwuRoC_secret_I9V3GqB1X1emQncgY8Bt",
"created": "2025-04-16T12:02:55.230Z",
"currency": "USD",
"customer_id": "sammantest2722",
"customer": {
"id": "sammantest2722",
"name": "Joseph Doe",
"email": "[email protected]",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": "Its my first payment",
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": null,
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "wallet",
"payment_method_data": {
"wallet": {},
"billing": null
},
"payment_token": null,
"shipping": null,
"billing": null,
"order_details": [
{
"brand": null,
"amount": 390,
"category": null,
"quantity": 1,
"tax_rate": null,
"product_id": null,
"product_name": "Apple iphone 15",
"product_type": null,
"sub_category": null,
"product_img_link": null,
"product_tax_code": null,
"total_tax_amount": null,
"requires_shipping": null
}
],
"email": "[email protected]",
"name": "Joseph Doe",
"phone": "999999999",
"return_url": "https://google.com/",
"authentication_type": "three_ds",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"next_action": {
"type": "redirect_to_url",
"redirect_to_url": "http://localhost:8080/payments/redirect/pay_ZMSscM4kmOOYEGrwuRoC/postman_merchant_GHAction_7ec10174-0196-450e-a39a-4f9b61a32def/pay_ZMSscM4kmOOYEGrwuRoC_1"
},
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "paypal",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "sammantest2722",
"created_at": 1744804975,
"expires": 1744808575,
"secret": "epk_2483fa5baf0a4b91b294a5a8df1da3d6"
},
"manual_retry_allowed": null,
"connector_transaction_id": "493715212829",
"frm_message": null,
"metadata": null,
"connector_metadata": {
"apple_pay": null,
"airwallex": null,
"noon": {
"order_category": "pay"
},
"braintree": null
},
"feature_metadata": null,
"reference_id": "pay_ZMSscM4kmOOYEGrwuRoC_1",
"payment_link": null,
"profile_id": "pro_x1xo34goINdpBDkYDEhK",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_bPPkbMzjo94rCiHfRJyu",
"incremental_authorization_allowed": null,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2025-04-16T12:17:55.230Z",
"fingerprint": null,
"browser_info": {
"language": "nl-NL",
"time_zone": 0,
"ip_address": "128.0.0.1",
"user_agent": "Mozilla/5.0 (iPhone NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
"color_depth": 24,
"java_enabled": true,
"screen_width": 1536,
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"screen_height": 723,
"java_script_enabled": true
},
"payment_method_id": null,
"payment_method_status": null,
"updated": "2025-04-16T12:02:57.669Z",
"split_payments": null,
"frm_metadata": null,
"extended_authorization_applied": null,
"capture_before": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null,
"card_discovery": null,
"force_3ds_challenge": false,
"force_3ds_challenge_trigger": false,
"issuer_error_code": null,
"issuer_error_message": null
}
```
in 3ds card payment, we now get the next action url and it works as intended.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `just clippy && just clippy_v2`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert: fix(connector): [noon] address `next_action_url` being `null` for cards in 3ds payment
- Merged: 2025-04-21T17:24:14Z
- Files changed: 2 files
- Commits: 1 commits
Implementation approach:
Reverts juspay/hyperswitch#7832
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert: fix(connector): [noon] address `next_action_url` being `null` for cards in 3ds payment (#785
Files to modify:
**crates/hyperswitch_connectors/src/connectors/noon.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/noon/transformers.rs**
Add:
- function: private::try_from
- struct: pub::NoonPaypalResponse
- struct: pub::NoonPaypalResponseResult
- enum: pub::NoonAuthPaymentResponse
- impl: impl TryFrom<ResponseRouterData<F, NoonPaypalResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
|
{"issue_number": 7832, "pr_number": 7859, "commits_count": 1, "files_changed": 2, "response_length": 928, "file_count": 4, "needs_breakdown": false}
|
feat(connector): Add recovery support for stripebilling
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Context: In case of some billing connectors we dont get the enough data in the webhook itself to support creation of payment intent and payment attempt in our system. So previously we derived a flow named "AdditionalRevenuerecoveryDetails" in this PR:#7402 which name is now changed to "BillingConnectorPaymentSync". This flow is used to fetch payment details of the invoices from the billing connectors using an API call to that billing connector. In this pr we are calling the flow and getting the details which are needed to create payment intent and attempt in our system.
1. Creates a connector integration in stripe billing that supports the API call.
2. Call the flow in recovery_incoming.rs file and using that details further we are creating the payment intent and attempt and verifying them.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
3. `crates/router/src/configs`
4. `loadtest/config`
-->
## Motivation and Context
## Testing
1. Go to stripe create a new webhook endpoint with a dummy url to get webhook secret key.
2. create a payment processor stripe
```
curl --location 'http://localhost:8080/v2/connector-accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-merchant-id: cloth_seller_mQRYaJduFokPeZ54W6bN' \
--header 'x-profile-id: pro_me6dnNKlhwuq32xhfjCA' \
--header 'Authorization: admin-api-key=test_admin' \
--header 'api-key: test_admin' \
--data '{
"connector_type": "payment_processor",
"connector_name": "stripe",
"connector_account_details": {
"auth_type": "HeaderKey",
"api_key": "api-key
},
"payment_methods_enabled": [
{
"payment_method_type": "card_redirect",
"payment_method_subtypes": [
{
"payment_method_subtype": "card_redirect",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": 1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "card",
"payment_method_subtypes": [
{
"payment_method_subtype": "credit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "debit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "wallet",
"payment_method_subtypes": [
{
"payment_method_subtype": "google_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "apple_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "we_chat_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "ali_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "paypal",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "mb_way",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "pay_later",
"payment_method_subtypes": [
{
"payment_method_subtype": "klarna",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "affirm",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "afterpay_clearpay",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "walley",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "bank_redirect",
"payment_method_subtypes": [
{
"payment_method_subtype": "giropay",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "ideal",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "eps",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "bancontact_card",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "przelewy24",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "sofort",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "blik",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "trustly",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "online_banking_finland",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "online_banking_poland",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "bank_transfer",
"payment_method_subtypes": [
{
"payment_method_subtype": "ach",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "sepa",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "bacs",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "bank_debit",
"payment_method_subtypes": [
{
"payment_method_subtype": "ach",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "sepa",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "bacs",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "becs",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
}
],
"metadata": {
"status_url": "https://2753-2401-4900-1cb8-2ff9-24dd-1ccf-ed12-b464.in.ngrok.io/webhooks/merchant_1678699058/globalpay",
"account_name": "transaction_processing",
"pricing_type": "fixed_price",
"acquirer_bin": "438309",
"acquirer_merchant_id": "00002000000"
},
"frm_configs": null,
"connector_webhook_details": {
"merchant_secret": ""
},
"profile_id": "pro_me6dnNKlhwuq32xhfjCA"
}'
```
change the profile id and other feilds while creating you own one
3. copy the mca id of stripe and paste it in the billing mca curl in feature metadata
```
curl --location 'http://localhost:8080/v2/connector-accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-merchant-id: cloth_seller_mQRYaJduFokPeZ54W6bN' \
--header 'x-profile-id: pro_me6dnNKlhwuq32xhfjCA' \
--header 'Authorization: admin-api-key=test_admin' \
--header 'api-key: test_admin' \
--data '{
"connector_type": "billing_processor",
"connector_name": "stripebilling",
"connector_account_details": {
"auth_type": "HeaderKey",
"api_key": "{your api key}"
},
"payment_methods_enabled": [
{
"payment_method_type": "card",
"payment_method_subtypes": [
{
"payment_method_subtype": "credit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "debit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
}
],
"metadata": {
"status_url": "https://2753-2401-4900-1cb8-2ff9-24dd-1ccf-ed12-b464.in.ngrok.io/webhooks/merchant_1678699058/globalpay",
"account_name": "transaction_processing",
"pricing_type": "fixed_price",
"acquirer_bin": "438309",
"acquirer_merchant_id": "00002000000"
},
"frm_configs": null,
"feature_metadata" : {
"revenue_recovery":{
"max_retry_count" : 16,
"billing_connector_retry_threshold": 2,
"billing_account_reference": {
"{your stripe mca id here}": "stripebilling"
}
}
},
"connector_webhook_details": {
"merchant_secret": "{webhook secret you have copied here}"
},
"profile_id": "pro_me6dnNKlhwuq32xhfjCA"
}'
```
4. copy the mca id, profile id and merchant id to construct the endpoint of the webhook.
5. install ngrok and run the service it will give you a https url for your local host port.
6. copy the https url of ngrok
7. construct the webhook endpoint : url/v2/webhooks/merchant_id/profile_id/billing_mca_id
8. paste this endpoint in the place of dummy url you have used to create endpoint in stripe dashboard
9. now create a test subscription use this card "4000 0000 0000 0341" while creating a test subscription and the billing day should start from the next day. If you are creating a test subscription today billing date should start from tommorow.
10. now move the clock past one month.
11. no observe the payment intent table and payment attempt table in db and verify those details with ones we are getting.
Images of the logs:
<img width="1728" alt="Screenshot 2025-03-11 at 5 52 53 PM" src="https://github.com/user-attachments/assets/0a97b656-2417-4812-b9cd-a808183411ea" />
<img width="1728" alt="Screenshot 2025-03-11 at 5 53 10 PM" src="https://github.com/user-attachments/assets/5a9872f1-45a3-4bf5-978c-6e477df36c9f" />
<img width="1728" alt="Screenshot 2025-03-11 at 5 53 21 PM" src="https://github.com/user-attachments/assets/5cbac559-09d8-4939-b2a6-04bc8f50a1bc" />
<img width="1728" alt="Screenshot 2025-03-11 at 5 54 32 PM" src="https://github.com/user-attachments/assets/3eb3fb41-afd4-4a05-8c8b-715310a79d7d" />
<img width="1710" alt="Screenshot 2025-03-10 at 4 52 08 PM" src="https://github.com/user-attachments/assets/05477fdc-656b-42cd-ba27-880d5748cc19" />
<img width="1190" alt="Screenshot 2025-03-10 at 4 52 20 PM" src="https://github.com/user-attachments/assets/d9900f24-2b8f-45c5-b6c5-bd5dcd62357d" />
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: refactor(connector): [Stripebilling] change Billing Connector Payment Sync url from charges to payment intents api
- Merged: 2025-05-02T12:12:23Z
- Files changed: 2 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR changes the url of billing connector payment sync flow from using stripe charge api to stripe payment intents api. Because in Recovery Flow there is a chance to call stripe's psync flow to update the error codes and other details for an attempt. And psync flow accepts paymen
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): [Stripebilling] change Billing Connector Payment Sync url from charges to payme
Files to modify:
**crates/hyperswitch_connectors/src/connectors/stripebilling.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/stripebilling/transformers.rs**
Add:
- struct: pub::StripebillingBillingConnectorPaymentSyncResponseData
|
{"issue_number": 7461, "pr_number": 7893, "commits_count": 1, "files_changed": 2, "response_length": 1214, "file_count": 4, "needs_breakdown": false}
|
Fix UCS address precedence order for payment method billing addresses
## Problem
The current implementation in the UCS (Unified Connector Service) transformers has incorrect precedence order when handling addresses. The unified payment method billing address should take priority over the shipping/billing addresses from the payment request.
## Current Behavior
- Shipping address: `shipping.or(unified_payment_method_billing.clone())`
- Billing address: `billing.or(unified_payment_method_billing)`
This means the payment request addresses take precedence over the unified payment method billing address.
## Expected Behavior
The unified payment method billing address should take precedence:
- Shipping address: `unified_payment_method_billing.clone().or(shipping)`
- Billing address: `unified_payment_method_billing.or(billing)`
## Impact
This affects address data consistency in UCS transformations and could lead to incorrect address information being sent to connectors.
## Files Affected
- `crates/router/src/core/unified_connector_service/transformers.rs`
|
<think>
PR Context:
- Title: fix: change precedence order in address that we send to ucs
- Merged: 2025-09-03T17:28:26Z
- Files changed: 1 files
- Commits: 3 commits
Implementation approach:
## Summary
This PR fixes the billing address precedence order in the UCS (Unified Connector Service) transformers to ensure that unified payment method billing addresses take priority over billing addresses from payment requests.
## Changes
- Changed billing address precedence: `unified_payment_method_billing.or(billing)` instead of `billing.or(unified_payment_method_billing)`
- Shipping address logic remains unchanged: `shipping`
## Related Issues
- Closes #9268: Fix UCS address
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix: change precedence order in address that we send to ucs (#9269)
Files to modify:
**crates/router/src/core/unified_connector_service/transformers.rs**
Modify existing code
|
{"issue_number": 9268, "pr_number": 9269, "commits_count": 1, "files_changed": 1, "response_length": 970, "file_count": 3, "needs_breakdown": false}
|
feat(authz): Make permissions entity and scope aware
Currently the permissions we use doesn't have any entity level context. But some of our APIs need that context.
For example,
1. `payment/list` - This can only be accessible by merchant level users or higher. Profile level users should not be able to access it.
2. `payment/profile/list` - This can be accessible by all level of users.
With current setup, this is not directly possible by the permissions. We had to introduce `min_entity_level` to solve this, but this is very separated from the permissions.
To solve this, we need to have entity level context at permissions level itself.
### Scope for permissions
The write permissions currently doesn't have access to read APIs, but since write is a superset of read, they should be able to access read APIs as well.
So, this PR also introduces scope context in permissions.
|
<think>
PR Context:
- Title: feat(authz): Create a permission generator
- Merged: 2024-10-24T14:36:07Z
- Files changed: 30 files
- Commits: 11 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Entity level context in Permissions
Currently the permissions we use doesn't have any entity level context. But some of our APIs need that context.
For example,
1. `payment/list` - This can only be accessible by merchant level users o
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(authz): Create a permission generator (#6394)
Co-authored-by: hyperswitch-bot[bot] <148525504+h
Files to modify:
**crates/api_models/src/user_role.rs**
Remove:
- enum: pub::ParentGroup
**crates/common_enums/src/enums.rs**
Add:
- enum: pub::ParentGroup
- enum: pub::Resource
- enum: pub::PermissionScope
**crates/router/src/analytics.rs**
Modify existing code
**crates/router/src/core/user_role.rs**
Modify existing code
**crates/router/src/routes/admin.rs**
Modify existing code
**crates/router/src/routes/api_keys.rs**
Modify existing code
**crates/router/src/routes/blocklist.rs**
Modify existing code
**crates/router/src/routes/connector_onboarding.rs**
Modify existing code
**crates/router/src/routes/customers.rs**
Modify existing code
**crates/router/src/routes/disputes.rs**
Modify existing code
**crates/router/src/routes/mandates.rs**
Modify existing code
**crates/router/src/routes/payment_methods.rs**
Modify existing code
**crates/router/src/routes/payments.rs**
Modify existing code
**crates/router/src/routes/payouts.rs**
Modify existing code
**crates/router/src/routes/profiles.rs**
Modify existing code
**crates/router/src/routes/recon.rs**
Modify existing code
**crates/router/src/routes/refunds.rs**
Modify existing code
**crates/router/src/routes/routing.rs**
Modify existing code
**crates/router/src/routes/user.rs**
Modify existing code
**crates/router/src/routes/user_role.rs**
Modify existing code
**crates/router/src/routes/verification.rs**
Modify existing code
**crates/router/src/routes/verify_connector.rs**
Modify existing code
**crates/router/src/routes/webhook_events.rs**
Modify existing code
**crates/router/src/services/authentication.rs**
Modify existing code
**crates/router/src/services/authorization.rs**
Remove:
- function: pub::check_entity
**crates/router/src/services/authorization/info.rs**
Modify existing code
**crates/router/src/services/authorization/permission_groups.rs**
Add:
- function: private::scope
- function: private::parent
- function: private::resources
- function: private::accessible_groups
- function: private::resources
- trait: pub::PermissionGroupExt
- trait: pub::ParentGroupExt
- impl: impl PermissionGroupExt for PermissionGroup
- impl: impl ParentGroupExt for ParentGroup
**crates/router/src/services/authorization/permissions.rs**
Remove:
- enum: pub::Permission
**crates/router/src/services/authorization/roles.rs**
Modify existing code
**crates/router_derive/src/lib.rs**
Add:
- function: pub::generate_permissions
**crates/router_derive/src/macros.rs**
Add:
- mod: pub::generate_permissions
**crates/router_derive/src/macros/generate_permissions.rs**
Add:
- function: private::parse
- function: private::parse
- function: private::parse_label_with_punctuated_data
- function: pub::generate_permissions_inner
- struct: private::ResourceInput
- struct: private::Input
- impl: impl Parse for Input
- impl: impl Parse for ResourceInput
|
{"issue_number": 6391, "pr_number": 6394, "commits_count": 1, "files_changed": 30, "response_length": 3882, "file_count": 34, "needs_breakdown": true}
|
[BUGFIX] Replacing the occurrences of `gen_range` with a safe alternative
## Description
Following up with the issue https://github.com/rust-random/rand/issues/1326 created by @lsampras. The function `gen_range` in itself can cause panics and error handling isn't done for some cases. This is a unpredictable behaviour and needs to be replaced with a safe alternative which allows for error handling and recoverability.
## Objective
- Deciding open a safe alternative for `gen_range` while keeping the behaviour relatively same
- Replacing the occurrences of `gen_range` with the decided safe alternative
## Guidelines
- Please mention the approach for solving the above mentioned issue and reasoning of it being recoverable.
|
<think>
PR Context:
- Title: fix(router/scheduler): replace the occurrences of gen_range with a safer alternative
- Merged: 2023-09-12T09:11:47Z
- Files changed: 4 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This is a bugfix for issue [1754](https://github.com/juspay/hyperswitch/issues/1754).
I have replaced the instances of `gen_range()` with `Uniform.sample`.
This should reduce the risk of `gen_range()` throwing a `panic!`.
### Additional Changes
- [ ] This PR modifies the API
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(router/scheduler): replace the occurrences of gen_range with a safer alternative (#2126)
Files to modify:
**crates/router/src/routes/dummy_connector/utils.rs**
Modify existing code
**crates/scheduler/src/consumer.rs**
Modify existing code
**crates/scheduler/src/producer.rs**
Modify existing code
|
{"issue_number": 1754, "pr_number": 2126, "commits_count": 1, "files_changed": 4, "response_length": 1127, "file_count": 5, "needs_breakdown": false}
|
[FEATURE] add cypress tests for void payment in v2
### Feature Description
This implementation adds comprehensive V2 API testing for payment void/cancel operations across different payment states. The feature introduces a new Cypress test suite that validates three critical scenarios: successfully voiding a payment in the requires_capture state `after manual capture confirmation`, attempting to void a payment in the `requires_payment_method` state, and attempting to void a completed payment in the `succeeded` state.
### Possible Implementation
A new test file `VoidPayments.cy.js` contains three separate test contexts that verify void behavior across payment states using both manual and automatic capture flows.
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: test(cypress): add cypress tests for void payment in v2
- Merged: 2025-10-07T17:28:46Z
- Files changed: 9 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This implementation adds comprehensive V2 API testing for payment void/cancel operations across different payment states. The feature introduces a new Cypress test suite that validates three critical scenarios: successfully voiding a payment i
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 9638, "pr_number": 9646, "commits_count": 0, "files_changed": 9, "response_length": 785, "file_count": 0, "needs_breakdown": false}
|
[FEATURE]: [Rapyd] Use `connector_request_reference_id` as reference to the connector
### :memo: Feature Description
- We transmit our reference id from Hyperswitch to the connector, enabling merchants to subsequently locate the payment within the connector dashboard.
- Presently, there is a lack of uniformity in this process, as some implementations employ `payment_id` while others utilize `attempt_id`.
- This inconsistency arises from the fact that `payment_id` and `attempt_id` correspond to two distinct entities within our system.
### :hammer: Possible Implementation
- To mitigate this confusion, we've introduced a new field called `connector_request_reference_id` in our RouterData.
- This id should replace them as a reference id to the connector for payment request.
- One might need to have exposure to api docs of the connector for which it is being implemented.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2052
:bookmark: Note : All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: feat(connector): [Rapyd] Use connector_request_reference_id
- Merged: 2024-10-25T08:41:35Z
- Files changed: 1 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Add connector_request_reference_id support for Rapyd
- Used `merchant_reference_id` as the reference id, while implementing this!
Resolves #2315
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modif
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [Rapyd] Use connector_request_reference_id (#6296)
Co-authored-by: DEEPANSHU BANSAL
Files to modify:
**crates/router/src/connector/rapyd/transformers.rs**
Modify existing code
|
{"issue_number": 2315, "pr_number": 6296, "commits_count": 1, "files_changed": 1, "response_length": 988, "file_count": 3, "needs_breakdown": false}
|
fix(connector): [CYBERSOURCE] fix CartesBancaires card_type for Cybersource
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [X] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Payment via CartesBancaires were failing via Cybersource, since the card_type passed was wrong. It was previously "006" ,but should be "036" - this PR introduces this fix.
source
https://developer.cybersource.com/library/documentation/dev_guides/Retail_SO_API/html/Topics/app_card_types.htm
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
### Enable CartesBancaires card_network for credit, debit pmt for Cybersource
### Request
**/payments curl via Cybersource**
`curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_5xoZZGCiGtFDREHNPd9l2i9CRJowAtZlrDRmuy0LTNBLBjtQlH661r0VTMNBXPgm' \
--data-raw '{
"amount": 700,
"currency": "EUR",
"confirm": true,
"payment_link": false,
"capture_on": "2029-09-10T10:11:12Z",
"amount_to_capture": 700,
"name": "John Doe",
"email": "[email protected]",
"phone": "999999999",
"phone_country_code": "+1",
"description": "Its my first payment request",
"authentication_type": "no_three_ds",
"return_url": "https://google.com",
"payment_method_data": {
"card": {
"card_number": "4035 5014 2814 6300",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "joseph Doe",
"card_cvc": "737",
"card_network": "CartesBancaires"
},
"billing": {
"address": {
"line1": "1467",
"line2": "CA",
"city": "Thise",
"state": "Alsace",
"zip": "94122",
"country": "FR",
"first_name": "Henry",
"last_name": "Henry"
}
}
},
"payment_method": "card",
"payment_method_type": "credit",
"browser_info": {
"color_depth": 24,
"java_enabled": true,
"java_script_enabled": true,
"language": "en-GB",
"screen_height": 720,
"screen_width": 1280,
"time_zone": -330,
"ip_address": "208.127.127.193",
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0"
},
"metadata": {
"disable_avs": true,
"udf1": "value1",
"new_customer": "true",
"login_date": "2019-09-10T10:11:12Z"
},
"order_details": [
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
}
]
}'`
**After PR changes**
<img width="1066" alt="Screenshot 2025-05-20 at 2 26 17 PM" src="https://github.com/user-attachments/assets/c0d7fbb6-cca7-479c-b0aa-3c1bccb55df8" />
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [X] I formatted the code `cargo +nightly fmt --all`
- [X] I addressed lints thrown by `cargo clippy`
- [X] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): [CYBERSOURCE] fix CartesBancaires card_type for Cybersource
- Merged: 2025-05-22T09:47:47Z
- Files changed: 6 files
- Commits: 1 commits
Implementation approach:
…source (#8031)
## Type of Change
<!-- Put an `x` in the boxes that apply -->
Hotfix for [8031](https://github.com/juspay/hyperswitch/pull/8031)
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Clippy screenshot
### Addi
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [CYBERSOURCE] fix CartesBancaires card_type for Cybersource (#8108)
Co-authored-by:
Files to modify:
**crates/hyperswitch_connectors/src/connectors/adyen/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/multisafepay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payeezy/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payone/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/utils.rs**
Modify existing code
|
{"issue_number": 8031, "pr_number": 8108, "commits_count": 1, "files_changed": 6, "response_length": 1488, "file_count": 8, "needs_breakdown": false}
|
Add audit events for PaymentUpdate update
Created from #4525
This covers adding events for PaymentUpdate operation
This event should include the payment data similar to [PaymentCancel](https://github.com/juspay/hyperswitch/pull/4166)
It should also include any metadata for the event
e.g reason for payment rejection, error codes, rejection source etc
### Submission Process:
- Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
- Once assigned, submit a pull request (PR).
- Maintainers will review and provide feedback, if any.
- Maintainers can unassign issues due to inactivity, [read more here](https://github.com/juspay/hyperswitch/wiki/Hacktoberfest-Contribution-Rules).
Refer [here](https://github.com/juspay/hyperswitch/blob/main/docs/TERMS_OF_CONTEST.md) for Terms and conditions for the contest.
|
<think>
PR Context:
- Title: feat(payments): Add audit events for PaymentUpdate update
- Merged: 2024-11-08T13:37:22Z
- Files changed: 2 files
- Commits: 6 commits
Implementation approach:
## Type of Change
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds an Audit event for the PaymentUpdate operation.
### Additional Changes
- [x] This PR modifies the files below
- `crates/router/src/core/payments/operations/payment_update.rs`
- `crates/router/src/events/audit_events.rs`
## Motivation and Context
This PR fixes #4682
## How did you test it
- H
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payments): Add audit events for PaymentUpdate update (#6426)
Files to modify:
**crates/router/src/core/payments/operations/payment_update.rs**
Modify existing code
**crates/router/src/events/audit_events.rs**
Modify existing code
|
{"issue_number": 4682, "pr_number": 6426, "commits_count": 1, "files_changed": 2, "response_length": 1031, "file_count": 4, "needs_breakdown": false}
|
refactor(authentication): authenticate merchant by API keys from API keys table
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
This PR updates the API key authentication code to use the API keys from the API keys table instead of the merchant account table. I'll be taking up the deprecation of the `api_key` field from the merchant account table in a separate PR.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
This is an extension of PRs #511, #639 and #705, thus completely addressing #501.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Manually. After I made the change, I created a new merchant account and API key, and tested out creating customers and payments. Things worked as expected.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
---
~Marking as this as draft as this is blocked by #639 and #705 being merged to `main` branch.~
|
<think>
PR Context:
- Title: chore(merchant_account): remove `api_key` field
- Merged: 2023-03-13T09:20:25Z
- Files changed: 14 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
This PR removes the unused `api_key` field from the merchant account table and request/response schemas.
### Additional Changes
- [x] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to t
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** chore(merchant_account): remove `api_key` field (#713)
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/db/merchant_account.rs**
Remove:
- function: private::find_merchant_account_by_api_key
- function: private::find_merchant_account_by_api_key
**crates/router/src/services/api.rs**
Remove:
- function: pub::authenticate_by_api_key
**crates/router/src/types/api/admin.rs**
Modify existing code
**crates/router/tests/connectors/globalpay.rs**
Modify existing code
**crates/router/tests/payments.rs**
Modify existing code
**crates/router/tests/payments2.rs**
Modify existing code
**crates/storage_models/src/merchant_account.rs**
Modify existing code
**crates/storage_models/src/query/merchant_account.rs**
Remove:
- function: pub::find_by_api_key
**crates/storage_models/src/schema.rs**
Modify existing code
|
{"issue_number": 712, "pr_number": 713, "commits_count": 1, "files_changed": 14, "response_length": 1738, "file_count": 13, "needs_breakdown": false}
|
[BUG] : [Bambora] bad request error for non-three-ds card payment
### Bug Description
Bambora expects browser information regardless of type of card payment (3ds or not). But we are not passing this browser details in non 3ds card. This results in a bad request response from bambora.
### Expected Behavior
Pass browser information in non 3ds card payments
### Actual Behavior
Connector returns a bad request response
### Steps To Reproduce
Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the `x-request-id` response header to help us debug your issue.
If not (or if building/running locally), please provide the following details:
1. Operating System or Linux distribution:
2. Rust version (output of `rustc --version`): ``
3. App version (output of `cargo r --features vergen -- --version`): ``
### Have you spent some time checking if this bug has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
None
|
<think>
PR Context:
- Title: feat(pm_list): add required fields for Ideal
- Merged: 2024-01-09T15:28:40Z
- Files changed: 0 files
- Commits: 0 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Resolves [#3701](https://github.com/juspay/hyperswitch-cloud/issues/3701)
### Test Cases
1. Create an eps payment with mollie with empty payment method object. The payment should succeed.
```
{
"amount": 1000,
"currency": "EUR",
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(pm_list): add required fields for Ideal (#3183)
Co-authored-by: hyperswitch-bot[bot] <14852550
Files to modify:
**crates/api_models/src/payments.rs**
Modify existing code
**crates/router/src/configs/defaults.rs**
Modify existing code
**crates/router/src/connector/aci/transformers.rs**
Modify existing code
**crates/router/src/connector/adyen/transformers.rs**
Modify existing code
**crates/router/src/connector/paypal/transformers.rs**
Modify existing code
**crates/router/src/connector/stripe/transformers.rs**
Remove:
- function: private::try_from
- impl: impl TryFrom<&payments::BankRedirectData> for StripeBillingAddress
Add:
- function: private::try_from
**crates/router/src/connector/utils.rs**
Add:
- function: private::is_customer_initiated_mandate_payment
|
{"issue_number": 3701, "pr_number": 3183, "commits_count": 1, "files_changed": 0, "response_length": 1590, "file_count": 9, "needs_breakdown": false}
|
[FIX] batch encrypt decrypt for mca fetch/insert/update
This adds batch encryption/decryption support for fetch/insert/update of the Merchant Connector Account.
|
<think>
PR Context:
- Title: fix: batch encrypt/decrypt on merchant connector account
- Merged: 2024-10-04T13:50:35Z
- Files changed: 3 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Enhancement
## Description
<!-- Describe your changes in detail -->
This adds batch encrypt/decrypt support for Merchant Connector account create/fetch/update
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix: batch encrypt/decrypt on merchant connector account (#6206)
Files to modify:
**crates/hyperswitch_domain_models/src/merchant_connector_account.rs**
Add:
- function: private::from_encryptable
- function: private::to_encryptable
- function: private::from_encryptable
- function: private::to_encryptable
- function: private::from_encryptable
- function: private::to_encryptable
- struct: pub::McaFromRequestfromUpdate
- struct: pub::McaFromRequest
- struct: pub::DecryptedMca
- struct: pub::EncryptedMca
- struct: pub::DecryptedUpdateMca
- impl: impl ToEncryptable<DecryptedMca, Secret<serde_json::Value>, Encryption> for EncryptedMca
- impl: impl ToEncryptable<DecryptedUpdateMca, Secret<serde_json::Value>, Secret<serde_json::Value>> for McaFromRequestfromUpdate
- impl: impl ToEncryptable<DecryptedMca, Secret<serde_json::Value>, Secret<serde_json::Value>> for McaFromRequest
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Modify existing code
|
{"issue_number": 6205, "pr_number": 6206, "commits_count": 1, "files_changed": 3, "response_length": 1860, "file_count": 5, "needs_breakdown": false}
|
[REFACTOR]: [TSYS] Add amount conversion framework to Tsys
### :memo: Feature Description
Currently, amounts are represented as `i64` values throughout the application. We want to introduce a `Unit` struct that explicitly states the denomination. A new type, `MinorUnit`, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.
Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.
### :hammer: Possible Implementation
- For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
- Connectors should invoke the `convert` function to receive the amount in their required format.
- Refer to the [connector documentation](https://developers.tsys.com/api/product?key=Authentication+Platform) to determine the required amount format for each connector.
- You can refer [this PR](https://github.com/juspay/hyperswitch/pull/4825) for more context.
🔖 Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/` , `crates/router/src/types/api.rs` , `crates/router/tests/connectors/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [ ] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [ ] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :package: Submission Process:
- Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
- Once assigned, submit a pull request (PR).
- Maintainers will review and provide feedback, if any.
- Maintainers can unassign issues due to inactivity, [read more here](https://github.com/juspay/hyperswitch/wiki/Hacktoberfest-Contribution-Rules).
Refer [here](https://github.com/juspay/hyperswitch/blob/main/docs/TERMS_OF_CONTEST.md) for Terms and conditions for the contest.
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: refactor(connector): add amount conversion framework to tsys
- Merged: 2024-10-25T11:31:47Z
- Files changed: 4 files
- Commits: 8 commits
Implementation approach:
## Type of Change
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
added `StringMajorUnit` for amount conversion
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): add amount conversion framework to tsys (#6282)
Co-authored-by: DEEPANSHU BANSA
Files to modify:
**crates/hyperswitch_connectors/src/connectors/tsys.rs**
Remove:
- struct: pub::Tsys
Add:
- function: pub::new
- struct: pub::Tsys
- impl: impl Tsys
**crates/hyperswitch_connectors/src/connectors/tsys/transformers.rs**
Add:
- function: private::from
- struct: pub::TsysRouterData
- impl: impl From<(StringMinorUnit, T)> for TsysRouterData<T>
**crates/router/src/types/api.rs**
Modify existing code
**crates/router/tests/connectors/tsys.rs**
Modify existing code
|
{"issue_number": 6097, "pr_number": 6282, "commits_count": 1, "files_changed": 4, "response_length": 1415, "file_count": 6, "needs_breakdown": false}
|
[BUG] using FRM with Signifyd throws 5xx
### Bug Description
Enabling Signifyd FRM connector for payments, and using this for a payment throws 5xx. This is due to Signifyd sending 303 which is not handled in HyperSwitch. Signifyd throws 303 as the URL is malformed.
https://api.signifyd.com//v3/orders/events/sales as opposed to https://api.signifyd.com/v3/orders/events/sales
### Expected Behavior
Calling any Signifyd API should return an expected status code.
### Actual Behavior
Calling any Signifyd API returns 303 - which is not handled in the response handler of `execute_connector_processing_step` leading to 500 - Something went wrong.
### Steps To Reproduce
1. Enable FRM via Signifyd for a payment connector
2. Create a payment
3. 5xx is thrown in API response
### Have you spent some time checking if this bug has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: fix(connector): update API endpoints for signifyd
- Merged: 2024-09-30T10:41:48Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #5956
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): update API endpoints for signifyd (#5957)
Files to modify:
**crates/router/src/connector/signifyd.rs**
Modify existing code
|
{"issue_number": 5956, "pr_number": 5957, "commits_count": 1, "files_changed": 1, "response_length": 925, "file_count": 3, "needs_breakdown": false}
|
[FEATURE] [DEUTSCHEBANK] Integrate SEPA Payments
### Feature Description
Integrate SEPA Payments for connector Deutsche Bank
### Possible Implementation
https://testmerch.directpos.de/rest-api/apidoc/v2.1/index.html#chap_sdd
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(payments): propagate additional payment method data for google pay during MIT
- Merged: 2024-11-26T14:14:16Z
- Files changed: 5 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #5858 # 2 point
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Fo
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payments): propagate additional payment method data for google pay during MIT (#6644)
Co-author
Files to modify:
**crates/api_models/src/payment_methods.rs**
Add:
- function: private::from
- function: private::from
- struct: pub::PaymentMethodDataWalletInfo
- impl: impl From<payments::additional_info::WalletAdditionalDataForCard> for PaymentMethodDataWalletInfo
- impl: impl From<PaymentMethodDataWalletInfo> for payments::additional_info::WalletAdditionalDataForCard
**crates/hyperswitch_domain_models/src/payment_method_data.rs**
Add:
- function: private::from
- impl: impl From<GooglePayWalletData> for payment_methods::PaymentMethodDataWalletInfo
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_create.rs**
Modify existing code
**crates/router/src/core/payments/tokenization.rs**
Modify existing code
|
{"issue_number": 5858, "pr_number": 6644, "commits_count": 1, "files_changed": 5, "response_length": 1748, "file_count": 7, "needs_breakdown": false}
|
refactor(users): Remove v1 insertions for user_roles
Currently, we are inserting user_roles in v1 version and v2 version.
Since we moved all the APIs to work with v2 data, we can stop inserting v1 data.
This will also help in migrating v1 data to v2.
|
<think>
PR Context:
- Title: refactor(user_role): Remove V1 insertion for `user_roles` and allow Invites for `org_admins`
- Merged: 2024-10-04T11:58:49Z
- Files changed: 6 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently we are inserting user_roles in v1 version and v2 version. Since we have completely moved the APIs to support v2, we don't have to insert v1 anymore.
Allow inviting, updating and deleting org_admins.
### Additional Changes
-
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(user_role): Remove V1 insertion for `user_roles` and allow Invites for `org_admins` (#6185)
Files to modify:
**crates/diesel_models/src/query/user_role.rs**
Remove:
- function: pub::insert_multiple_user_roles
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/db/kafka_store.rs**
Modify existing code
**crates/router/src/db/user_role.rs**
Remove:
- function: private::convert_to_vec
- enum: pub::InsertUserRolePayload
- impl: impl InsertUserRolePayload
**crates/router/src/services/authorization/roles/predefined_roles.rs**
Modify existing code
**crates/router/src/types/domain/user.rs**
Remove:
- function: private::convert_to_new_v1_role
- function: pub::insert_in_v1
- function: pub::insert_in_v1_and_v2
- function: pub::insert_in_v1_and_v2
- impl: impl NewUserRole<E>
- impl: impl NewUserRole<OrganizationLevel>
- impl: impl NewUserRole<MerchantLevel>
Add:
- function: private::from
- function: private::from
- impl: impl From<OrganizationLevel> for EntityInfo
- impl: impl From<MerchantLevel> for EntityInfo
|
{"issue_number": 6184, "pr_number": 6185, "commits_count": 1, "files_changed": 6, "response_length": 1952, "file_count": 8, "needs_breakdown": false}
|
refactor(core): restrict requires_customer_action in confirm
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
This PR will restrict a payment to be confirmed again if the status is `requires_customer_action`.
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
A payment which is in `requires_customer_action` cannot be confirmed again. Only failed payments can be retried by passing `retry_action` as `retry`.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
- Confirm a payment which is in `requires_customer_action` state.
<img width="982" alt="Screenshot 2024-01-03 at 7 09 41 PM" src="https://github.com/juspay/hyperswitch/assets/48803246/c74c6f0d-0cc6-465d-8ea2-66c9b682127b">
- Create sepa bank transfer payment via stripe ( payments_confirm happens via webhooks )
<img width="619" alt="Screenshot 2024-01-03 at 8 46 11 PM" src="https://github.com/juspay/hyperswitch/assets/48803246/e4263ddc-3f24-436a-bc95-ba1c6e7fa16c">
- Payment updated by charged webhook
<img width="1404" alt="Screenshot 2024-01-03 at 8 47 38 PM" src="https://github.com/juspay/hyperswitch/assets/48803246/a322c0de-f9db-4358-bff9-b416ebb343d7">
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
|
<think>
PR Context:
- Title: ci: add test cases for restricting customer action in confirm flow
- Merged: 2024-01-31T06:45:44Z
- Files changed: 9 files
- Commits: 4 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR adds test cases for #3235
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that wil
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 3235, "pr_number": 3499, "commits_count": 0, "files_changed": 9, "response_length": 796, "file_count": 0, "needs_breakdown": false}
|
Adding Deep health check for Hyperswitch
Goal is to create a deep health check endpoint which will verify that the Hyperswitch application is up and running and the connections to all the necessary services are healthy
- [x] Failure of health check should emit logs providing evidential data regarding the failure
The deep health will verify the following services
- [x] #3267
- [x] #3268
- [x] #3269
- [x] #3270
- [x] [Deep health check for Hyperswitch Control Center](https://github.com/juspay/hyperswitch-control-center/issues/374)
|
<think>
PR Context:
- Title: feat(payment_link): expose payment link configs for SDK UI rules and payment button
- Merged: 2025-03-05T17:28:25Z
- Files changed: 16 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR exposes customizations for payment links. Below configs are added -
- SDK UI rules - https://docs.hyperswitch.io/explore-hyperswitch/merchant-controls/integration-guide/web/customization#id-4.-rules
- Payment Link UI rules - similar to SDK UI rules, but for payment link temp
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payment_link): expose payment link configs for SDK UI rules and payment button (#7427)
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/diesel_models/src/business_profile.rs**
Modify existing code
**crates/diesel_models/src/payment_intent.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/lib.rs**
Modify existing code
**crates/router/src/core/payment_link.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/routes/admin.rs**
Modify existing code
**crates/router/src/routes/ephemeral_key.rs**
Modify existing code
**crates/router/src/routes/verification.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
|
{"issue_number": 3264, "pr_number": 7427, "commits_count": 1, "files_changed": 16, "response_length": 1675, "file_count": 13, "needs_breakdown": false}
|
ci: add tests that make use of locker
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR introduces necessary refactoring to add support for locker specific tests. This includes `addition of delete payment method` (which is restricted to work only on hosted environments and not local given `tartarus` is unavailable and is complicated to setup things) but not limited to:
- fixes:
- fix reports not being generated
- fix multiple credential not picking proper api keys
- refactoring:
- move configs that makes use of response custom under `getCustomExchange`
- misc:
- clarify ntid files to make them meaningful
- update dependencies
- update cypress credential to support stripe multiple api keys
- feat:
- add multiple credential support for stripe
- add ntid support for stripe with another api key
- add recurring mit payment endpoint to ntid connector agnostic flows
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
delete payment method:
|local|hosted|
|-|-|
|<img width="457" alt="image" src="https://github.com/user-attachments/assets/8b65aa07-3ee6-46f7-83ac-8850e3530aa2">|<img width="462" alt="image" src="https://github.com/user-attachments/assets/2712463c-a458-483c-9daf-d17b3f9b573b">|
|`5xx` is expected since this requires locker to be set up locally which is not optimal|`2xx` is expected since locker is already setup|
ntid with mit based on payment token:
|cybersource|stripe|
|-|-|
|<img width="463" alt="image" src="https://github.com/user-attachments/assets/64686ac4-4b0f-4bbc-94c7-f60d0c5c4a7f" />|<img width="467" alt="image" src="https://github.com/user-attachments/assets/4059ac5c-2ad1-4bc0-b149-a2c867b465ed" />|
|adyen|bluesnap|cybersource|stripe|
|-|-|-|-|
|<img width="467" alt="image" src="https://github.com/user-attachments/assets/0716b0bb-f34b-47bf-a27f-32bfe322935f" />|<img width="462" alt="image" src="https://github.com/user-attachments/assets/ca98cc84-cb72-4dc8-91c3-7654c628f347" />|<img width="554" alt="image" src="https://github.com/user-attachments/assets/4e01f0fe-acb0-4ecf-8873-be35a16c052c" />|<img width="555" alt="image" src="https://github.com/user-attachments/assets/86a052c2-3a51-4952-abf8-8f93826959e9" />|
|adyen ntid failure has been addressed in #6851. #6735 has been soft cherry-picked and the tests have been run against local|||stripe with multiple credential support (ntid)|
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `prettier . --write`
- [ ] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): add expiry year conversion for adyen mit transactions
- Merged: 2024-12-17T11:32:24Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR fixes MIT payments failing especially during NTID flow.
We previously used to get below error message during MIT Confirm call:
```log
"The provided Expiry Date is not valid.: Expiry year should be a 4 digit number greater than 2
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): add expiry year conversion for adyen mit transactions (#6851)
Files to modify:
**crates/router/src/connector/adyen/transformers.rs**
Modify existing code
|
{"issue_number": 6735, "pr_number": 6851, "commits_count": 1, "files_changed": 1, "response_length": 975, "file_count": 3, "needs_breakdown": false}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.