You have a pending review.
Publish Review
Improve output when scanning for a usable client.
Review Request #12512 — Created Aug. 8, 2022 and submitted Aug. 15, 2022, 7:15 p.m.
chipx86
RBTools
release-4.x
This rewords some of the output when trying to scan for a usable client
but failing to find anything. It aims to add context to the messages,
helping to see the input (repository type or URL) that led to the error,
and to add instructions to help resolve the issue (saying to check for a
.reviewboardrc, what it should contain, and pointing users to
rbt setup-repo).
The work here is just a base for upcoming work on this logic to clean
things up and to provide error reporting that works with the upcoming
formal SCMClient dependency support.
Testing Done
Tested all the error/warning conditions, verifying the output.
All Issues: All: 3
Can we say "could not" instead of "couldn't"? I feel like it reads better.
david Aug. 15, 2022, 2:11 p.m.
This can use single quotes.
Checks run (2 succeeded)
Aug. 8, 2022, 1:56 p.m.
flake8 passed.
JSHint passed.
Aug. 11, 2022, 12:43 p.m.
rbtools/clients/__init__.py (Diff revision 1)
Show all issues
chipx86 Aug. 15, 2022, 2:11 p.m.
Updating these to use "was not" to be in line with other logs here.
Review request changed
Aug. 15, 2022, 2:12 p.m.
Change Summary:
Changed some text to say "a repository was not found ..." instead of "a repository couldn't be found ..."
Updated strings to use single line quotes.
Diff:
Revision 2 (+62 -14)
rbtools/clients/__init__.py
Status: Closed (submitted)
Pushed to release-4.x (9b34e23)