Submitted by Aman Gupta on Oct. 20, 2016, 12:45 a.m.
Aman Gupta Oct. 20, 2016, 12:45 a.m.
forgiving, atleast on my specific combination of OS version and hardware.
their AVERROR counterparts (especially in this case, with AVERROR_UNKNOWN).
Richard Kern Oct. 24, 2016, 1:09 a.m.
Could this be a bug in another part of the code? It seems like extradata should be set.
> forgiving, atleast on my specific combination of OS version and hardware.
Which container has this issue?
> their AVERROR counterparts (especially in this case, with AVERROR_UNKNOWN).
This is somewhat confusing. The extradata_size check is only needed for videotoolbox_esds_extradata_create(). It should check the sps and pps sizes are valid before creating the avcc atom.
Aman Gupta Oct. 24, 2016, 6:20 a.m.
where the same sample and ffmpeg version worked.
> > forgiving, atleast on my specific combination of OS version and hardware.
> Which container has this issue?
I saw it with an mpegts file, but only on iOS.
> sizes are valid before creating the avcc atom.
around or inside the esds_create if that makes more sense.
Aman Gupta Oct. 24, 2016, 7:18 p.m.
> where the same sample and ffmpeg version worked.
rather only happens when you skip calling avformat_find_stream_info().
enough to discover available streams on mpegts containers.
still think it's an optimization worth making.
>> Which container has this issue?
> I saw it with an mpegts file, but only on iOS.
>> sizes are valid before creating the avcc atom.
> around or inside the esds_create if that makes more sense.
wm4 Oct. 24, 2016, 7:25 p.m.
> >> > the avctx->extradata.
> >> should be set.
> > where the same sample and ffmpeg version worked.
> rather only happens when you skip calling avformat_find_stream_info().
> enough to discover available streams on mpegts containers.
> still think it's an optimization worth making.
pseudo extradata that libavformat constructs.
least in the h264 code and was an oversight.