by default dont simplify 3D mesh

app.py

@@ -72,7 +72,7 @@ def resize_image(image_path, max_size=1024):
             return temp_file.name
 
 @spaces.GPU(duration=30)  # Increased duration to 30 seconds
-def generate_3d_model(depth, image_path, focallength_px, simplification_factor=0.8, smoothing_iterations=1, thin_threshold=0.01):
+def generate_3d_model(depth, image_path, focallength_px, simplification_factor=1.0, smoothing_iterations=0, thin_threshold=0):
     """
     Generate a textured 3D mesh from the depth map and the original image.
     """
@@ -131,33 +131,26 @@ def generate_3d_model(depth, image_path, focallength_px, simplification_factor=0
         # Create the mesh using Trimesh with vertex colors
         mesh = trimesh.Trimesh(vertices=vertices, faces=faces, vertex_colors=colors, process=False)
 
-        # Mesh cleaning and improvement steps
-        print("Original mesh - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
-
-        print("Simplifying mesh")
-        # 1. Mesh simplification
-        target_faces = int(len(mesh.faces) * simplification_factor)
-        mesh = mesh.simplify_quadric_decimation(face_count=target_faces)
-        print("After simplification - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
-
-        print("Removing small components")
-        # 2. Remove small disconnected components
-        components = mesh.split(only_watertight=False)
-        if len(components) > 1:
-            areas = np.array([c.area for c in components])
-            mesh = components[np.argmax(areas)]
-            print("After removing small components - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
-
-        print("Smoothing mesh")
-        # 3. Smooth the mesh
-        for _ in range(smoothing_iterations):
-            mesh = mesh.smoothed()
-        print("After smoothing - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
-
-        print("Removing thin features")
-        # 4. Remove thin features
-        mesh = remove_thin_features(mesh, thickness_threshold=thin_threshold)
-        print("After removing thin features - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
+        # Mesh cleaning and improvement steps (only if not using default values)
+        if simplification_factor < 1.0 or smoothing_iterations > 0 or thin_threshold > 0:
+            print("Original mesh - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
+
+            if simplification_factor < 1.0:
+                print("Simplifying mesh")
+                target_faces = int(len(mesh.faces) * simplification_factor)
+                mesh = mesh.simplify_quadric_decimation(face_count=target_faces)
+                print("After simplification - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
+
+            if smoothing_iterations > 0:
+                print("Smoothing mesh")
+                for _ in range(smoothing_iterations):
+                    mesh = mesh.smoothed()
+                print("After smoothing - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
+
+            if thin_threshold > 0:
+                print("Removing thin features")
+                mesh = remove_thin_features(mesh, thickness_threshold=thin_threshold)
+                print("After removing thin features - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
 
         # Export the mesh to OBJ files with unique filenames
         timestamp = int(time.time())
@@ -334,9 +327,9 @@ with gr.Blocks() as iface:
         download_texture = gr.File(label="Download Texture (PNG)")
     
     with gr.Row():
-        simplification_factor = gr.Slider(minimum=0.1, maximum=1.0, value=0.8, step=0.1, label="Simplification Factor")
-        smoothing_iterations = gr.Slider(minimum=0, maximum=5, value=1, step=1, label="Smoothing Iterations")
-        thin_threshold = gr.Slider(minimum=0.01, maximum=1, value=0.05, step=0.01, label="Thin Feature Threshold (meters)")
+        simplification_factor = gr.Slider(minimum=0.1, maximum=1.0, value=1.0, step=0.1, label="Simplification Factor (1.0 = No simplification)")
+        smoothing_iterations = gr.Slider(minimum=0, maximum=5, value=0, step=1, label="Smoothing Iterations (0 = No smoothing)")
+        thin_threshold = gr.Slider(minimum=0, maximum=0.1, value=0, step=0.001, label="Thin Feature Threshold (0 = No thin feature removal)")
     
     regenerate_button = gr.Button("Regenerate 3D Model")
     model_status = gr.Textbox(label="3D Model Status")

history.md

@@ -38,3 +38,12 @@
   1. Investigate and fix the texture mapping in the 3D model generation process.
   2. Clarify the units for the thin threshold and consider adjusting its range.
 
+## 2024-10-06 00:30 PST
+### Reverting 3D Model Simplification and Smoothing
+- Problem: The 3D model still lacks proper colorization from the original image.
+- Action: Reverting simplification and smoothing operations to their default state (no processing) to isolate the colorization issue.
+- Changes:
+  1. Set default values for simplification_factor, smoothing_iterations, and thin_threshold to 1.0, 0, and 0 respectively.
+  2. Adjust the generate_3d_model function to skip simplification and smoothing steps when default values are used.
+- Next steps: Re-test the 3D model generation to verify if colorization is restored without these processing steps.
+