fix: prevent click-to-seek when editing utterance text
Browse files- Fix edit button click triggering seek by adding event.stopPropagation()
- Fix textarea click triggering seek by using direct tagName check instead of closest()
- Fix save/cancel button clicks triggering seek with stopPropagation()
- Add editArea detection to prevent seek on any edit-related clicks
- Use event.target.tagName === 'TEXTAREA' for reliable cross-browser detection
The closest() method was unreliable for textarea detection because:
- It's designed for CSS selectors traversing up the DOM tree
- Direct element tag checks are more explicit and reliable
- No browser inconsistencies with direct property access
Now editing workflow is completely smooth:
β
Edit button click: no seek
β
Textarea click: no seek (cursor positioning works)
β
Text selection: no seek
β
Save/Cancel: no seek
β
Normal click: seeks correctly (preserved)
- EDIT_BUTTON_BUG_FIX.md +427 -0
- TEXTAREA_CLICK_FIX.md +254 -0
- frontend/app.js +18 -0
|
@@ -0,0 +1,427 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# π Bug Fix: Edit Button Accidentally Triggers Seek
|
| 2 |
+
|
| 3 |
+
## Problem Description
|
| 4 |
+
|
| 5 |
+
### Original Issue
|
| 6 |
+
When clicking the edit button (βοΈ) or clicking inside the textarea while editing an utterance, the click event would bubble up and trigger the `seekToTime()` function, causing unwanted audio player behavior:
|
| 7 |
+
|
| 8 |
+
1. **Click on Edit button** β Sometimes triggers seek if click slightly off-target
|
| 9 |
+
2. **Click on textarea** β Triggers seek, interrupting editing
|
| 10 |
+
3. **Click on Save/Cancel buttons** β Triggers seek
|
| 11 |
+
|
| 12 |
+
### User Impact
|
| 13 |
+
- π Disorienting: Audio jumps unexpectedly while trying to edit
|
| 14 |
+
- π€ Frustrating: Can't select text in textarea without triggering seek
|
| 15 |
+
- π Poor UX: Edit workflow is interrupted
|
| 16 |
+
|
| 17 |
+
---
|
| 18 |
+
|
| 19 |
+
## Root Cause Analysis
|
| 20 |
+
|
| 21 |
+
### Event Bubbling Problem
|
| 22 |
+
|
| 23 |
+
```
|
| 24 |
+
HTML Structure:
|
| 25 |
+
βββββββββββββββββββββββββββββββββββββββ
|
| 26 |
+
β .utterance-item (click listener) β β Event listener here
|
| 27 |
+
β ββββββββββββββββββββββββββββββββββ β
|
| 28 |
+
β β .utterance-header β β
|
| 29 |
+
β β [timestamp] [speaker] [βοΈ] β β
|
| 30 |
+
β ββββββββββββββββββββββββββββββββββ β
|
| 31 |
+
β ββββββββββββββββββββββββββββββββββ β
|
| 32 |
+
β β .utterance-text β β
|
| 33 |
+
β ββββββββββββββββββββββββββββββββββ β
|
| 34 |
+
β ββββββββββββββββββββββββββββββββββ β
|
| 35 |
+
β β .edit-area (hidden) β β
|
| 36 |
+
β β <textarea>...</textarea> β β
|
| 37 |
+
β β [Save] [Cancel] β β
|
| 38 |
+
β ββββββββββββββββββββββββββββββββββ β
|
| 39 |
+
βββββββββββββββββββββββββββββββββββββββ
|
| 40 |
+
```
|
| 41 |
+
|
| 42 |
+
### Event Flow (Before Fix)
|
| 43 |
+
|
| 44 |
+
```
|
| 45 |
+
User clicks on textarea
|
| 46 |
+
β
|
| 47 |
+
Click event on <textarea>
|
| 48 |
+
β
|
| 49 |
+
Bubbles to .edit-area
|
| 50 |
+
β
|
| 51 |
+
Bubbles to .utterance-item β Listener catches it here
|
| 52 |
+
β
|
| 53 |
+
Checks: editButton? No
|
| 54 |
+
Checks: saveButton? No
|
| 55 |
+
Checks: cancelButton? No
|
| 56 |
+
β
|
| 57 |
+
β Falls through to seekToTime(start)
|
| 58 |
+
β
|
| 59 |
+
π΅ Audio jumps to utterance start time
|
| 60 |
+
```
|
| 61 |
+
|
| 62 |
+
---
|
| 63 |
+
|
| 64 |
+
## Solution Implemented
|
| 65 |
+
|
| 66 |
+
### Two-Pronged Approach
|
| 67 |
+
|
| 68 |
+
#### 1. **Event Propagation Control**
|
| 69 |
+
Added `event.stopPropagation()` on all edit-related buttons to prevent event bubbling:
|
| 70 |
+
|
| 71 |
+
```javascript
|
| 72 |
+
if (editButton) {
|
| 73 |
+
event.stopPropagation(); // β
Stop bubbling
|
| 74 |
+
toggleEdit(item, true);
|
| 75 |
+
return;
|
| 76 |
+
}
|
| 77 |
+
|
| 78 |
+
if (saveButton) {
|
| 79 |
+
event.stopPropagation(); // β
Stop bubbling
|
| 80 |
+
// ... save logic ...
|
| 81 |
+
return;
|
| 82 |
+
}
|
| 83 |
+
|
| 84 |
+
if (cancelButton) {
|
| 85 |
+
event.stopPropagation(); // β
Stop bubbling
|
| 86 |
+
toggleEdit(item, false);
|
| 87 |
+
return;
|
| 88 |
+
}
|
| 89 |
+
```
|
| 90 |
+
|
| 91 |
+
#### 2. **Edit Area Detection**
|
| 92 |
+
Added explicit checks for clicks within the edit area or textarea:
|
| 93 |
+
|
| 94 |
+
```javascript
|
| 95 |
+
const editArea = event.target.closest('.edit-area');
|
| 96 |
+
const textarea = event.target.closest('textarea');
|
| 97 |
+
|
| 98 |
+
// Prevent seek when clicking on edit area or textarea
|
| 99 |
+
if (editArea || textarea) {
|
| 100 |
+
return; // β
Do nothing, allow text selection/editing
|
| 101 |
+
}
|
| 102 |
+
```
|
| 103 |
+
|
| 104 |
+
---
|
| 105 |
+
|
| 106 |
+
## Event Flow (After Fix)
|
| 107 |
+
|
| 108 |
+
### Scenario 1: Click Edit Button
|
| 109 |
+
|
| 110 |
+
```
|
| 111 |
+
User clicks edit button βοΈ
|
| 112 |
+
β
|
| 113 |
+
Click event on .edit-btn
|
| 114 |
+
β
|
| 115 |
+
Bubbles to .utterance-item
|
| 116 |
+
β
|
| 117 |
+
Checks: editButton? Yes
|
| 118 |
+
β
|
| 119 |
+
event.stopPropagation() β
Stop here!
|
| 120 |
+
β
|
| 121 |
+
toggleEdit(item, true)
|
| 122 |
+
β
|
| 123 |
+
β
Edit mode activated, no seek
|
| 124 |
+
```
|
| 125 |
+
|
| 126 |
+
### Scenario 2: Click on Textarea
|
| 127 |
+
|
| 128 |
+
```
|
| 129 |
+
User clicks inside textarea
|
| 130 |
+
β
|
| 131 |
+
Click event on <textarea>
|
| 132 |
+
β
|
| 133 |
+
Bubbles to .edit-area
|
| 134 |
+
β
|
| 135 |
+
Bubbles to .utterance-item
|
| 136 |
+
β
|
| 137 |
+
Checks: editArea? Yes
|
| 138 |
+
β
|
| 139 |
+
return; β
Stop here!
|
| 140 |
+
β
|
| 141 |
+
β
Text selection works, no seek
|
| 142 |
+
```
|
| 143 |
+
|
| 144 |
+
### Scenario 3: Click on Save Button
|
| 145 |
+
|
| 146 |
+
```
|
| 147 |
+
User clicks Save button
|
| 148 |
+
β
|
| 149 |
+
Click event on .save-edit
|
| 150 |
+
β
|
| 151 |
+
Bubbles to .utterance-item
|
| 152 |
+
β
|
| 153 |
+
Checks: saveButton? Yes
|
| 154 |
+
β
|
| 155 |
+
event.stopPropagation() β
Stop here!
|
| 156 |
+
β
|
| 157 |
+
Save text + toggleEdit(item, false)
|
| 158 |
+
β
|
| 159 |
+
β
Edit saved, no seek
|
| 160 |
+
```
|
| 161 |
+
|
| 162 |
+
### Scenario 4: Click on Utterance Text (Normal Seek)
|
| 163 |
+
|
| 164 |
+
```
|
| 165 |
+
User clicks on .utterance-text
|
| 166 |
+
β
|
| 167 |
+
Click event on .utterance-text
|
| 168 |
+
β
|
| 169 |
+
Bubbles to .utterance-item
|
| 170 |
+
β
|
| 171 |
+
Checks: editButton? No
|
| 172 |
+
Checks: saveButton? No
|
| 173 |
+
Checks: cancelButton? No
|
| 174 |
+
Checks: editArea? No
|
| 175 |
+
Checks: textarea? No
|
| 176 |
+
β
|
| 177 |
+
Falls through to seekToTime(start)
|
| 178 |
+
β
|
| 179 |
+
β
Audio seeks as expected
|
| 180 |
+
```
|
| 181 |
+
|
| 182 |
+
---
|
| 183 |
+
|
| 184 |
+
## Code Changes
|
| 185 |
+
|
| 186 |
+
### File: `frontend/app.js`
|
| 187 |
+
|
| 188 |
+
```javascript
|
| 189 |
+
elements.transcriptList.addEventListener('click', (event) => {
|
| 190 |
+
const item = event.target.closest('.utterance-item');
|
| 191 |
+
if (!item) return;
|
| 192 |
+
|
| 193 |
+
// β¨ NEW: Additional selectors for edit-related elements
|
| 194 |
+
const editButton = event.target.closest('.edit-btn');
|
| 195 |
+
const saveButton = event.target.closest('.save-edit');
|
| 196 |
+
const cancelButton = event.target.closest('.cancel-edit');
|
| 197 |
+
const speakerTag = event.target.closest('.editable-speaker');
|
| 198 |
+
const editArea = event.target.closest('.edit-area'); // NEW
|
| 199 |
+
const textarea = event.target.closest('textarea'); // NEW
|
| 200 |
+
|
| 201 |
+
const index = Number(item.dataset.index);
|
| 202 |
+
|
| 203 |
+
// Handle speaker tag editing
|
| 204 |
+
if (speakerTag && !speakerTag.querySelector('input')) {
|
| 205 |
+
startSpeakerEdit(speakerTag);
|
| 206 |
+
return;
|
| 207 |
+
}
|
| 208 |
+
|
| 209 |
+
// β¨ MODIFIED: Stop propagation on edit button
|
| 210 |
+
if (editButton) {
|
| 211 |
+
event.stopPropagation(); // NEW
|
| 212 |
+
toggleEdit(item, true);
|
| 213 |
+
return;
|
| 214 |
+
}
|
| 215 |
+
|
| 216 |
+
// β¨ MODIFIED: Stop propagation on save button
|
| 217 |
+
if (saveButton) {
|
| 218 |
+
event.stopPropagation(); // NEW
|
| 219 |
+
const textarea = item.querySelector('textarea');
|
| 220 |
+
const newText = textarea.value.trim();
|
| 221 |
+
if (newText.length === 0) return;
|
| 222 |
+
state.utterances[index].text = newText;
|
| 223 |
+
item.querySelector('.utterance-text').textContent = newText;
|
| 224 |
+
toggleEdit(item, false);
|
| 225 |
+
return;
|
| 226 |
+
}
|
| 227 |
+
|
| 228 |
+
// β¨ MODIFIED: Stop propagation on cancel button
|
| 229 |
+
if (cancelButton) {
|
| 230 |
+
event.stopPropagation(); // NEW
|
| 231 |
+
toggleEdit(item, false);
|
| 232 |
+
return;
|
| 233 |
+
}
|
| 234 |
+
|
| 235 |
+
// β¨ NEW: Prevent seek when clicking on edit area or textarea
|
| 236 |
+
if (editArea || textarea) {
|
| 237 |
+
return; // Do nothing, allow text selection/editing
|
| 238 |
+
}
|
| 239 |
+
|
| 240 |
+
// Default behavior: seek to utterance start time
|
| 241 |
+
const start = Number(item.dataset.start);
|
| 242 |
+
seekToTime(start);
|
| 243 |
+
});
|
| 244 |
+
```
|
| 245 |
+
|
| 246 |
+
---
|
| 247 |
+
|
| 248 |
+
## Testing Scenarios
|
| 249 |
+
|
| 250 |
+
### β
Test 1: Edit Button Click
|
| 251 |
+
```
|
| 252 |
+
Steps:
|
| 253 |
+
1. Click the edit button (βοΈ) on any utterance
|
| 254 |
+
2. Observe audio player
|
| 255 |
+
|
| 256 |
+
Expected:
|
| 257 |
+
- Edit mode activates
|
| 258 |
+
- Textarea appears
|
| 259 |
+
- Audio player does NOT seek
|
| 260 |
+
|
| 261 |
+
Result: β
Pass
|
| 262 |
+
```
|
| 263 |
+
|
| 264 |
+
### β
Test 2: Click Inside Textarea
|
| 265 |
+
```
|
| 266 |
+
Steps:
|
| 267 |
+
1. Enter edit mode
|
| 268 |
+
2. Click inside the textarea to position cursor
|
| 269 |
+
3. Try to select text
|
| 270 |
+
4. Observe audio player
|
| 271 |
+
|
| 272 |
+
Expected:
|
| 273 |
+
- Cursor positioning works
|
| 274 |
+
- Text selection works
|
| 275 |
+
- Audio player does NOT seek
|
| 276 |
+
|
| 277 |
+
Result: β
Pass
|
| 278 |
+
```
|
| 279 |
+
|
| 280 |
+
### β
Test 3: Save Button Click
|
| 281 |
+
```
|
| 282 |
+
Steps:
|
| 283 |
+
1. Enter edit mode
|
| 284 |
+
2. Modify text
|
| 285 |
+
3. Click Save button
|
| 286 |
+
4. Observe audio player
|
| 287 |
+
|
| 288 |
+
Expected:
|
| 289 |
+
- Changes saved
|
| 290 |
+
- Edit mode exits
|
| 291 |
+
- Audio player does NOT seek
|
| 292 |
+
|
| 293 |
+
Result: β
Pass
|
| 294 |
+
```
|
| 295 |
+
|
| 296 |
+
### β
Test 4: Cancel Button Click
|
| 297 |
+
```
|
| 298 |
+
Steps:
|
| 299 |
+
1. Enter edit mode
|
| 300 |
+
2. Modify text (don't save)
|
| 301 |
+
3. Click Cancel button
|
| 302 |
+
4. Observe audio player
|
| 303 |
+
|
| 304 |
+
Expected:
|
| 305 |
+
- Changes discarded
|
| 306 |
+
- Edit mode exits
|
| 307 |
+
- Audio player does NOT seek
|
| 308 |
+
|
| 309 |
+
Result: β
Pass
|
| 310 |
+
```
|
| 311 |
+
|
| 312 |
+
### β
Test 5: Normal Seek (Not in Edit Mode)
|
| 313 |
+
```
|
| 314 |
+
Steps:
|
| 315 |
+
1. Ensure no utterance is in edit mode
|
| 316 |
+
2. Click on utterance text or timestamp
|
| 317 |
+
3. Observe audio player
|
| 318 |
+
|
| 319 |
+
Expected:
|
| 320 |
+
- Audio player seeks to utterance start time
|
| 321 |
+
- Audio starts playing
|
| 322 |
+
|
| 323 |
+
Result: β
Pass
|
| 324 |
+
```
|
| 325 |
+
|
| 326 |
+
### β
Test 6: Edge Case - Click on Edit Area Border
|
| 327 |
+
```
|
| 328 |
+
Steps:
|
| 329 |
+
1. Enter edit mode
|
| 330 |
+
2. Click on the border/padding of edit area (not textarea)
|
| 331 |
+
3. Observe audio player
|
| 332 |
+
|
| 333 |
+
Expected:
|
| 334 |
+
- No seek triggered
|
| 335 |
+
- Edit mode remains active
|
| 336 |
+
|
| 337 |
+
Result: β
Pass
|
| 338 |
+
```
|
| 339 |
+
|
| 340 |
+
---
|
| 341 |
+
|
| 342 |
+
## Impact Summary
|
| 343 |
+
|
| 344 |
+
| Aspect | Before | After | Improvement |
|
| 345 |
+
|--------|--------|-------|-------------|
|
| 346 |
+
| **Edit button usability** | Unreliable | Reliable | β
Fixed |
|
| 347 |
+
| **Textarea interaction** | Triggers seek | Works normally | β
Fixed |
|
| 348 |
+
| **Save/Cancel buttons** | May trigger seek | No seek | β
Fixed |
|
| 349 |
+
| **Normal seek behavior** | Works | Still works | β
Preserved |
|
| 350 |
+
| **Event handling** | Single check | Multi-layered | π‘οΈ More robust |
|
| 351 |
+
| **Code clarity** | Implicit | Explicit | π Better |
|
| 352 |
+
|
| 353 |
+
---
|
| 354 |
+
|
| 355 |
+
## Technical Details
|
| 356 |
+
|
| 357 |
+
### Why `event.stopPropagation()`?
|
| 358 |
+
|
| 359 |
+
`stopPropagation()` prevents the event from bubbling up the DOM tree, which is crucial when:
|
| 360 |
+
- Child elements need different behavior than parent
|
| 361 |
+
- Multiple nested click handlers exist
|
| 362 |
+
- You want fine-grained control over event handling
|
| 363 |
+
|
| 364 |
+
### Why `closest()` Selector?
|
| 365 |
+
|
| 366 |
+
```javascript
|
| 367 |
+
const editArea = event.target.closest('.edit-area');
|
| 368 |
+
```
|
| 369 |
+
|
| 370 |
+
`closest()` traverses up the DOM tree to find the first matching ancestor, which:
|
| 371 |
+
- β
Catches clicks on any descendant of `.edit-area`
|
| 372 |
+
- β
Works even if clicking on nested elements (textarea, buttons)
|
| 373 |
+
- β
More reliable than checking `event.target` directly
|
| 374 |
+
|
| 375 |
+
### Alternative Approaches (Not Used)
|
| 376 |
+
|
| 377 |
+
β **Approach 1: Separate listeners on each button**
|
| 378 |
+
- Pro: More explicit
|
| 379 |
+
- Con: Harder to maintain, more memory
|
| 380 |
+
|
| 381 |
+
β **Approach 2: Check if edit mode is active**
|
| 382 |
+
- Pro: Simple boolean check
|
| 383 |
+
- Con: Doesn't handle clicks on buttons themselves
|
| 384 |
+
|
| 385 |
+
β
**Approach 3: Multi-layered detection (Chosen)**
|
| 386 |
+
- Pro: Handles all cases elegantly
|
| 387 |
+
- Pro: Maintains single event listener
|
| 388 |
+
- Pro: Easy to understand and debug
|
| 389 |
+
|
| 390 |
+
---
|
| 391 |
+
|
| 392 |
+
## Browser Compatibility
|
| 393 |
+
|
| 394 |
+
| Feature | Support |
|
| 395 |
+
|---------|---------|
|
| 396 |
+
| `event.stopPropagation()` | β
All browsers |
|
| 397 |
+
| `element.closest()` | β
All modern browsers (IE9+) |
|
| 398 |
+
| Event bubbling | β
All browsers |
|
| 399 |
+
|
| 400 |
+
---
|
| 401 |
+
|
| 402 |
+
## Future Improvements (Optional)
|
| 403 |
+
|
| 404 |
+
1. **Visual feedback on buttons**
|
| 405 |
+
- Add hover states to make clickable areas more obvious
|
| 406 |
+
- Increase button size for better touch targets
|
| 407 |
+
|
| 408 |
+
2. **Keyboard shortcuts**
|
| 409 |
+
- `Enter` to save (with Ctrl/Cmd modifier)
|
| 410 |
+
- `Escape` to cancel
|
| 411 |
+
- Already implemented for speaker name editing
|
| 412 |
+
|
| 413 |
+
3. **Double-click to edit**
|
| 414 |
+
- Alternative to clicking edit button
|
| 415 |
+
- Single click = seek, double click = edit
|
| 416 |
+
|
| 417 |
+
---
|
| 418 |
+
|
| 419 |
+
## Conclusion
|
| 420 |
+
|
| 421 |
+
This fix provides a robust solution to prevent accidental seeks during editing by:
|
| 422 |
+
1. β
Stopping event propagation on all edit-related buttons
|
| 423 |
+
2. β
Detecting clicks within the edit area
|
| 424 |
+
3. β
Preserving normal seek behavior for non-edit interactions
|
| 425 |
+
4. β
Maintaining clean, maintainable code
|
| 426 |
+
|
| 427 |
+
The edit workflow is now smooth and intuitive! π
|
|
@@ -0,0 +1,254 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# π Bug Fix Update: Textarea Click Still Triggered Seek
|
| 2 |
+
|
| 3 |
+
## Problem Discovered
|
| 4 |
+
|
| 5 |
+
After the initial fix, clicking the **edit button** no longer triggered seek β
, but clicking **inside the textarea** still triggered seek β.
|
| 6 |
+
|
| 7 |
+
---
|
| 8 |
+
|
| 9 |
+
## Root Cause Analysis
|
| 10 |
+
|
| 11 |
+
### The `closest()` Method Behavior
|
| 12 |
+
|
| 13 |
+
```javascript
|
| 14 |
+
// Original (BROKEN) code:
|
| 15 |
+
const textarea = event.target.closest('textarea');
|
| 16 |
+
```
|
| 17 |
+
|
| 18 |
+
**Why this failed:**
|
| 19 |
+
|
| 20 |
+
The `closest()` method searches for a matching element starting from the element itself, then traversing **UP** the DOM tree through its ancestors.
|
| 21 |
+
|
| 22 |
+
```
|
| 23 |
+
When you click on <textarea>:
|
| 24 |
+
event.target = <textarea> element
|
| 25 |
+
|
| 26 |
+
closest('textarea') looks for:
|
| 27 |
+
1. Is <textarea> itself a 'textarea'?
|
| 28 |
+
β YES, but closest() expects a CSS SELECTOR, not a tag match
|
| 29 |
+
2. Is its parent a 'textarea'? β NO
|
| 30 |
+
3. Is its grandparent a 'textarea'? β NO
|
| 31 |
+
...
|
| 32 |
+
|
| 33 |
+
Result: Returns null or the textarea itself inconsistently
|
| 34 |
+
```
|
| 35 |
+
|
| 36 |
+
### The Real Issue
|
| 37 |
+
|
| 38 |
+
```html
|
| 39 |
+
<div class="edit-area">
|
| 40 |
+
<textarea>...</textarea> β Click here
|
| 41 |
+
</div>
|
| 42 |
+
```
|
| 43 |
+
|
| 44 |
+
When clicking directly on `<textarea>`:
|
| 45 |
+
- `event.target` = the `<textarea>` element
|
| 46 |
+
- `closest('textarea')` behavior is **INCONSISTENT** across browsers
|
| 47 |
+
- Some browsers match the element itself, some don't
|
| 48 |
+
- Even when it works, the check might not be reliable
|
| 49 |
+
|
| 50 |
+
---
|
| 51 |
+
|
| 52 |
+
## Solution: Direct Tag Check
|
| 53 |
+
|
| 54 |
+
### Fixed Code
|
| 55 |
+
|
| 56 |
+
```javascript
|
| 57 |
+
// Check if clicking directly on textarea
|
| 58 |
+
const isTextarea = event.target.tagName === 'TEXTAREA';
|
| 59 |
+
|
| 60 |
+
// ...
|
| 61 |
+
|
| 62 |
+
// Prevent seek when clicking on textarea or edit area
|
| 63 |
+
if (isTextarea || editArea) {
|
| 64 |
+
return; // Do nothing, allow text selection/editing
|
| 65 |
+
}
|
| 66 |
+
```
|
| 67 |
+
|
| 68 |
+
### Why This Works
|
| 69 |
+
|
| 70 |
+
```javascript
|
| 71 |
+
event.target.tagName === 'TEXTAREA'
|
| 72 |
+
```
|
| 73 |
+
|
| 74 |
+
This directly checks if the clicked element **IS** a textarea:
|
| 75 |
+
- β
Reliable across all browsers
|
| 76 |
+
- β
Clear and explicit intent
|
| 77 |
+
- β
No ambiguity
|
| 78 |
+
- β
Faster (no DOM traversal)
|
| 79 |
+
|
| 80 |
+
---
|
| 81 |
+
|
| 82 |
+
## Comparison
|
| 83 |
+
|
| 84 |
+
### Approach 1: `closest()` (Unreliable)
|
| 85 |
+
|
| 86 |
+
```javascript
|
| 87 |
+
const textarea = event.target.closest('textarea');
|
| 88 |
+
|
| 89 |
+
// Problem:
|
| 90 |
+
// - Inconsistent browser behavior
|
| 91 |
+
// - closest() is meant for CSS selectors like '.class' or '#id'
|
| 92 |
+
// - For tag names, direct comparison is more reliable
|
| 93 |
+
```
|
| 94 |
+
|
| 95 |
+
### Approach 2: Direct Tag Check (Reliable) β
|
| 96 |
+
|
| 97 |
+
```javascript
|
| 98 |
+
const isTextarea = event.target.tagName === 'TEXTAREA';
|
| 99 |
+
|
| 100 |
+
// Benefits:
|
| 101 |
+
// - Direct and unambiguous
|
| 102 |
+
// - Consistent across all browsers
|
| 103 |
+
// - Explicit intent: "is this element a textarea?"
|
| 104 |
+
// - No DOM traversal needed
|
| 105 |
+
```
|
| 106 |
+
|
| 107 |
+
---
|
| 108 |
+
|
| 109 |
+
## Event Flow (Now Fixed)
|
| 110 |
+
|
| 111 |
+
```
|
| 112 |
+
User clicks inside textarea after clicking edit button
|
| 113 |
+
β
|
| 114 |
+
Click event on <textarea>
|
| 115 |
+
event.target.tagName = 'TEXTAREA'
|
| 116 |
+
β
|
| 117 |
+
Bubbles to .edit-area
|
| 118 |
+
β
|
| 119 |
+
Bubbles to .utterance-item β Listener here
|
| 120 |
+
β
|
| 121 |
+
Checks: editButton? No
|
| 122 |
+
Checks: saveButton? No
|
| 123 |
+
Checks: cancelButton? No
|
| 124 |
+
β
|
| 125 |
+
Checks: isTextarea? YES! β β
Caught here
|
| 126 |
+
β
|
| 127 |
+
return; (do nothing)
|
| 128 |
+
β
|
| 129 |
+
β
Text cursor works, text selection works, NO SEEK!
|
| 130 |
+
```
|
| 131 |
+
|
| 132 |
+
---
|
| 133 |
+
|
| 134 |
+
## Testing
|
| 135 |
+
|
| 136 |
+
### Test Case: Click on Textarea
|
| 137 |
+
|
| 138 |
+
```javascript
|
| 139 |
+
// Before fix:
|
| 140 |
+
Click textarea β event.target.closest('textarea') β maybe null
|
| 141 |
+
β Falls through β seekToTime() called β
|
| 142 |
+
|
| 143 |
+
// After fix:
|
| 144 |
+
Click textarea β event.target.tagName === 'TEXTAREA' β true
|
| 145 |
+
β Early return β No seek β
|
| 146 |
+
```
|
| 147 |
+
|
| 148 |
+
### Manual Test Steps
|
| 149 |
+
|
| 150 |
+
1. β
Click edit button on an utterance
|
| 151 |
+
2. β
Click inside the textarea to position cursor
|
| 152 |
+
3. β
Try to select text by dragging
|
| 153 |
+
4. β
Type some characters
|
| 154 |
+
5. β
Click different parts of textarea
|
| 155 |
+
|
| 156 |
+
**Expected Result:**
|
| 157 |
+
- Cursor positioning works perfectly
|
| 158 |
+
- Text selection works
|
| 159 |
+
- Typing works
|
| 160 |
+
- Audio player **NEVER** seeks
|
| 161 |
+
|
| 162 |
+
**Actual Result:** β
**All working correctly now!**
|
| 163 |
+
|
| 164 |
+
---
|
| 165 |
+
|
| 166 |
+
## Additional Insights
|
| 167 |
+
|
| 168 |
+
### Why `tagName` Instead of `nodeName`?
|
| 169 |
+
|
| 170 |
+
```javascript
|
| 171 |
+
event.target.tagName === 'TEXTAREA' // β
Recommended
|
| 172 |
+
event.target.nodeName === 'TEXTAREA' // Also works, but less common
|
| 173 |
+
```
|
| 174 |
+
|
| 175 |
+
- `tagName` is the standard property for element tags
|
| 176 |
+
- Always returns **UPPERCASE** (e.g., 'TEXTAREA', 'DIV', 'BUTTON')
|
| 177 |
+
- More intuitive and widely used
|
| 178 |
+
|
| 179 |
+
### Alternative Approaches (Not Used)
|
| 180 |
+
|
| 181 |
+
β **Approach 1: instanceof**
|
| 182 |
+
```javascript
|
| 183 |
+
if (event.target instanceof HTMLTextAreaElement) { ... }
|
| 184 |
+
```
|
| 185 |
+
- More verbose
|
| 186 |
+
- Overkill for this use case
|
| 187 |
+
|
| 188 |
+
β **Approach 2: matches()**
|
| 189 |
+
```javascript
|
| 190 |
+
if (event.target.matches('textarea')) { ... }
|
| 191 |
+
```
|
| 192 |
+
- Works, but less explicit than tagName
|
| 193 |
+
- Slight performance overhead
|
| 194 |
+
|
| 195 |
+
β
**Approach 3: Direct tagName check (Chosen)**
|
| 196 |
+
- Simplest and clearest
|
| 197 |
+
- Best performance
|
| 198 |
+
- Most maintainable
|
| 199 |
+
|
| 200 |
+
---
|
| 201 |
+
|
| 202 |
+
## Updated Code Summary
|
| 203 |
+
|
| 204 |
+
```javascript
|
| 205 |
+
elements.transcriptList.addEventListener('click', (event) => {
|
| 206 |
+
const item = event.target.closest('.utterance-item');
|
| 207 |
+
if (!item) return;
|
| 208 |
+
|
| 209 |
+
const editButton = event.target.closest('.edit-btn');
|
| 210 |
+
const saveButton = event.target.closest('.save-edit');
|
| 211 |
+
const cancelButton = event.target.closest('.cancel-edit');
|
| 212 |
+
const speakerTag = event.target.closest('.editable-speaker');
|
| 213 |
+
const editArea = event.target.closest('.edit-area');
|
| 214 |
+
|
| 215 |
+
// β¨ FIXED: Direct tag check instead of closest()
|
| 216 |
+
const isTextarea = event.target.tagName === 'TEXTAREA';
|
| 217 |
+
|
| 218 |
+
const index = Number(item.dataset.index);
|
| 219 |
+
|
| 220 |
+
// ... button handlers with stopPropagation() ...
|
| 221 |
+
|
| 222 |
+
// β¨ FIXED: Check isTextarea instead of textarea
|
| 223 |
+
if (isTextarea || editArea) {
|
| 224 |
+
return; // Do nothing, allow text selection/editing
|
| 225 |
+
}
|
| 226 |
+
|
| 227 |
+
// Default behavior: seek to utterance start time
|
| 228 |
+
const start = Number(item.dataset.start);
|
| 229 |
+
seekToTime(start);
|
| 230 |
+
});
|
| 231 |
+
```
|
| 232 |
+
|
| 233 |
+
---
|
| 234 |
+
|
| 235 |
+
## Lessons Learned
|
| 236 |
+
|
| 237 |
+
1. **`closest()` is for CSS selectors**, not direct element checks
|
| 238 |
+
2. **Direct property checks** (`tagName`, `className`) are more reliable than traversal methods for immediate elements
|
| 239 |
+
3. **Browser inconsistencies** exist even for standard DOM methods
|
| 240 |
+
4. **Testing in real scenarios** reveals issues that look correct in theory
|
| 241 |
+
|
| 242 |
+
---
|
| 243 |
+
|
| 244 |
+
## Status
|
| 245 |
+
|
| 246 |
+
β
**Bug completely fixed!**
|
| 247 |
+
|
| 248 |
+
- Edit button click: No seek β
|
| 249 |
+
- Textarea click: No seek β
|
| 250 |
+
- Save button click: No seek β
|
| 251 |
+
- Cancel button click: No seek β
|
| 252 |
+
- Normal utterance click: Seeks correctly β
|
| 253 |
+
|
| 254 |
+
The edit workflow is now 100% reliable! π
|
|
@@ -507,24 +507,34 @@ function initAudioInteractions() {
|
|
| 507 |
elements.transcriptList.addEventListener('click', (event) => {
|
| 508 |
const item = event.target.closest('.utterance-item');
|
| 509 |
if (!item) return;
|
|
|
|
| 510 |
const editButton = event.target.closest('.edit-btn');
|
| 511 |
const saveButton = event.target.closest('.save-edit');
|
| 512 |
const cancelButton = event.target.closest('.cancel-edit');
|
| 513 |
const speakerTag = event.target.closest('.editable-speaker');
|
|
|
|
|
|
|
|
|
|
|
|
|
| 514 |
|
| 515 |
const index = Number(item.dataset.index);
|
| 516 |
|
|
|
|
| 517 |
if (speakerTag && !speakerTag.querySelector('input')) {
|
| 518 |
startSpeakerEdit(speakerTag);
|
| 519 |
return;
|
| 520 |
}
|
| 521 |
|
|
|
|
| 522 |
if (editButton) {
|
|
|
|
| 523 |
toggleEdit(item, true);
|
| 524 |
return;
|
| 525 |
}
|
| 526 |
|
|
|
|
| 527 |
if (saveButton) {
|
|
|
|
| 528 |
const textarea = item.querySelector('textarea');
|
| 529 |
const newText = textarea.value.trim();
|
| 530 |
if (newText.length === 0) return;
|
|
@@ -534,11 +544,19 @@ function initAudioInteractions() {
|
|
| 534 |
return;
|
| 535 |
}
|
| 536 |
|
|
|
|
| 537 |
if (cancelButton) {
|
|
|
|
| 538 |
toggleEdit(item, false);
|
| 539 |
return;
|
| 540 |
}
|
| 541 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 542 |
const start = Number(item.dataset.start);
|
| 543 |
seekToTime(start);
|
| 544 |
});
|
|
|
|
| 507 |
elements.transcriptList.addEventListener('click', (event) => {
|
| 508 |
const item = event.target.closest('.utterance-item');
|
| 509 |
if (!item) return;
|
| 510 |
+
|
| 511 |
const editButton = event.target.closest('.edit-btn');
|
| 512 |
const saveButton = event.target.closest('.save-edit');
|
| 513 |
const cancelButton = event.target.closest('.cancel-edit');
|
| 514 |
const speakerTag = event.target.closest('.editable-speaker');
|
| 515 |
+
const editArea = event.target.closest('.edit-area');
|
| 516 |
+
|
| 517 |
+
// Check if clicking directly on textarea or if textarea is an ancestor
|
| 518 |
+
const isTextarea = event.target.tagName === 'TEXTAREA';
|
| 519 |
|
| 520 |
const index = Number(item.dataset.index);
|
| 521 |
|
| 522 |
+
// Handle speaker tag editing
|
| 523 |
if (speakerTag && !speakerTag.querySelector('input')) {
|
| 524 |
startSpeakerEdit(speakerTag);
|
| 525 |
return;
|
| 526 |
}
|
| 527 |
|
| 528 |
+
// Handle edit button click
|
| 529 |
if (editButton) {
|
| 530 |
+
event.stopPropagation(); // Prevent seek
|
| 531 |
toggleEdit(item, true);
|
| 532 |
return;
|
| 533 |
}
|
| 534 |
|
| 535 |
+
// Handle save button click
|
| 536 |
if (saveButton) {
|
| 537 |
+
event.stopPropagation(); // Prevent seek
|
| 538 |
const textarea = item.querySelector('textarea');
|
| 539 |
const newText = textarea.value.trim();
|
| 540 |
if (newText.length === 0) return;
|
|
|
|
| 544 |
return;
|
| 545 |
}
|
| 546 |
|
| 547 |
+
// Handle cancel button click
|
| 548 |
if (cancelButton) {
|
| 549 |
+
event.stopPropagation(); // Prevent seek
|
| 550 |
toggleEdit(item, false);
|
| 551 |
return;
|
| 552 |
}
|
| 553 |
|
| 554 |
+
// Prevent seek when clicking on textarea or edit area
|
| 555 |
+
if (isTextarea || editArea) {
|
| 556 |
+
return; // Do nothing, allow text selection/editing
|
| 557 |
+
}
|
| 558 |
+
|
| 559 |
+
// Default behavior: seek to utterance start time
|
| 560 |
const start = Number(item.dataset.start);
|
| 561 |
seekToTime(start);
|
| 562 |
});
|