please I would like to ask you for review of a new openvas package - openvas-gsd.
Please note that package name (openvas-gsd) is different from the original name of the distribution tarball (gsd). I decided this to be like that to keep the naming convention used for the resto of the openvas modules (openvas-libraries, openvas-scanner, openvas-cli, openvas-manager, openvas-administrator).
Even EPEL 5 ships Cmake 2.6. I think, you don't need the version constraint.
Please inform upstream about the incorrect FSF postal address.
You try to own the directory /etc/openvas, which is already owned by another package.
> Even EPEL 5 ships Cmake 2.6. I think, you don't need the version constraint.
> Please inform upstream about the incorrect FSF postal address.
I have seen it when packaging the gsd - that guideline is for gettext localisations. Translations in GSD are not done using gettext, but it uses the QT functionalities for that. As there are no special guideline for that I have checked how it is in other projects using the QT (scribus, smplayer, scidavis) and left it as it is in the translations directory.
Historical reasons for that - openvas-libraries originally didn't own the directory so it is owned by each of the openvas packages storing there the configuration. I will remove it.
OK I will remove it.
Quite about every possible build target (besides EPEL4 maybe) ships CMake 2.6 or newer. You don't have an older version anywhere around, so the version restriction is pointless. It is fulfilled whatever may be.
The configuration file points to a log directory, that doesn't exist. Create it or require a package that provides it.
Ad translations: Forget the gettext part, but the rest applies.
Please use -p when you install the icon to keep the timestamp. Why do you set 755 for an icon?
While it is not necessary from a technical point of view, it avoids to install things inadvertently.
Concerning the CMake flags: It is probably easier to set CMAKE_INSTALL_PREFIX empty, but I haven't tried.
I'm pretty certain, "Requires: htmldoc" is not needed to run the program. It also pulls in other packages. I beg your pardon, if I'm wrong.
If you BR Doxygen, you should also use it: See INSTALL -- there is a build target for the documentation. I don't know though, whether the output is valuable.
once again thanks for comments.
Sorry for delay - I am fighting the deprecated gnutls code in openvas-libraries to be able to update whole suite to recent versions.
>You can drop the defattr line, if you don't plan to package to EPEL4.
I do plan for EPEL as the other packages of openvas do.
>Why do you set 755 for an icon?
This is just wrong should be 644.
Unfortunately the core packages (libraries, server, manager) are still not working properly to me.
There is still issue with gnutls x openvas.
According to upstream - gnutls in fedora is old and not compiled with the recommended ASN1 library.
Truth is probably somewhere in between.
According the network dumps the difference is that on working systems connection is established in one TCP packet and data is read on other. With gnutls the TLS connection and data is in 1 TCP packet and openvas-library keeps waiting forever.
I will describe more on openvas-cli.
Once openvas-library is fixed this will start working as well so please do the review.
For working please test against the LiveCD from Openvas Project.
OpenVas5 seems to work with current version of gnutls in Fedora 17.
Please make the build verbose! Also, read through the locale guidelines once more, as they apply.
>Please make the build verbose!
Build is made verbose by makro %cmake by default.
I have added explicit -DCMAKE_VERBOSE_MAKEFILE:BOOL=TRUE, but I believe it is redundant.
Please can you confirm this is what you have meant?
>Also, read through the locale guidelines once more, as they apply.
Can we close this request?
Yes we can close this one ... not supported in the 7.x branch anyway.