mtrent added a comment to D60285: Make calls into the pthread library use weak symbols..
Nick any thoughts? I'd like to move forward, for whatever definition of "forward" we may settle on.
mtrent committed rG02a2ce9a4b55: Fix Mach-O bind and rebase validation errors in libObject (authored by mtrent).
mtrent committed rL356629: Fix Mach-O bind and rebase validation errors in libObject.
mtrent closed D59574: Fix Mach-O bind and rebase validation errors in libObject.
mtrent added inline comments to D59574: Fix Mach-O bind and rebase validation errors in libObject.
mtrent created D59574: Fix Mach-O bind and rebase validation errors in libObject.
mtrent committed rG76d66123b27d: Detect malformed LC_LINKER_COMMANDs in Mach-O binaries (authored by mtrent).
mtrent committed rL355851: Detect malformed LC_LINKER_COMMANDs in Mach-O binaries.
mtrent closed D59179: Detect malformed LC_LINKER_COMMANDs in Mach-O binaries.
mtrent created D59179: Detect malformed LC_LINKER_COMMANDs in Mach-O binaries.
mtrent added a comment to D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.
mtrent requested changes to D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.
I agree, simply updating the enum by itself doesn't accomplish much. Is there something specific driving this change?
mtrent accepted D58263: Compute and Print Type and Section columns in "llvm-nm -f sysv" output..
Built it locally, stepped through the nm code for Mach-O files, didn't see any unintended problems. Elf changes reviewed visually only, they look mechanical. The name for "getNMSectionTagAndName" seems imperfect to me, as the Mach-O symbol type code isn't strictly about the section (A, I, -); that said, sysv is not a common format for viewing Mach-O, so I just offer it as a minor point to consider.
mtrent committed rG7dcfac617122: objdump fails to parse Mach-O binaries with n_desc bearing stabs (authored by mtrent).
mtrent committed rL354722: objdump fails to parse Mach-O binaries with n_desc bearing stabs.
mtrent closed D58568: objdump fails to parse Mach-O binaries with n_desc bearing stabs.
mtrent created D58568: objdump fails to parse Mach-O binaries with n_desc bearing stabs.
mtrent abandoned D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist.
Crud! The wrong code got into this arc request. I'm going to abandon the revision and try again.
mtrent added a comment to D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist.
Looks like we can have print_protocol_list64_t also call the new print_protocol_64_t, but that can be done in a later NFC commit.
mtrent updated the diff for D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist.
... and fix the lit test when always printing the imp pointer.
Always print the imp pointer.
mtrent created D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist.
mtrent reopened D57190: [MC] Teach the MachO object writer about N_FUNC_COLD.
mtrent accepted D57190: [MC] Teach the MachO object writer about N_FUNC_COLD.
mtrent added a comment to D57190: [MC] Teach the MachO object writer about N_FUNC_COLD.
mtrent committed rL352104: Limit dyld image suffixes guessed by guessLibraryShortName().
mtrent closed D56978: Limit dyld image suffixes guessed by guessLibraryShortName().
mtrent created D56978: Limit dyld image suffixes guessed by guessLibraryShortName().
mtrent committed rL351238: llvm-objdump -m -D should disassemble all text segments.
mtrent closed D56649: llvm-objdump -m -D should disassemble all text segments.
mtrent updated the diff for D56649: llvm-objdump -m -D should disassemble all text segments.
mtrent updated the summary of D56649: llvm-objdump -m -D should disassemble all text segments.
mtrent created D56649: llvm-objdump -m -D should disassemble all text segments.
mtrent accepted D54674: [llvm-objcopy] First bits for MachO .
The approach here seems reasonable. I have not tested these changes.
mtrent committed rL349779: Add PLATFORM constants for iOS, tvOS, and watchOS simulators.
mtrent closed D55905: Add PLATFORM constants for iOS, tvOS, and watchOS simulators.
mtrent created D55905: Add PLATFORM constants for iOS, tvOS, and watchOS simulators.
mtrent committed rL348632: Update the Swift version numbers reported by objdump.
mtrent closed D55442: Update the Swift version numbers reported by objdump.
mtrent created D55442: Update the Swift version numbers reported by objdump.
mtrent committed rL339250: Add a CommandGuide for llvm-objdump.
mtrent closed D50034: Add a CommandGuide for llvm-objdump.
mtrent added a comment to D50034: Add a CommandGuide for llvm-objdump.
mtrent updated the diff for D50034: Add a CommandGuide for llvm-objdump.
Remove the obsolete "-cfg" option, as called out during review feedback.
The short summary is "-macho" doesn't mean the target file is Mach-O. "-macho" means use the Mach-O specific file parser for walking the file contents, instead of using llvm-Object. When run in this way llvm-objdump will display information in a different way. Like it or hate it, it's what llvm-objdump does currently.
mtrent added inline comments to D50034: Add a CommandGuide for llvm-objdump.
mtrent edited reviewers for D50034: Add a CommandGuide for llvm-objdump, added: beanz; removed: enderby.
mtrent created D50034: Add a CommandGuide for llvm-objdump.
mtrent committed rL321773: Do not look up symbol names when n_strx == 0.
mtrent closed D41657: Do not look up symbol names when n_strx == 0.
mtrent updated the diff for D41657: Do not look up symbol names when n_strx == 0.
Updating comment based upon review feedback.
Updating change request with review feedback.
mtrent added a comment to D41657: Do not look up symbol names when n_strx == 0.
I wonder whether you can use something like yaml2obj to craft the object? (or, assuming it's valid, llvm-mc)?
That would improve the readability a lot IMHO.
If not, can you at least add comments to the test (e.g. source file + compiler/linker version etc..) in case we need to regenerate this in the future?
mtrent created D41657: Do not look up symbol names when n_strx == 0.
mtrent committed rL320832: Updated llvm-objdump to display local relocations in Mach-O binaries.
mtrent closed D41199: Updated llvm-objdump to display local relocations in Mach-O binaries.
mtrent created D41199: Updated llvm-objdump to display local relocations in Mach-O binaries.
mtrent committed rL320534: reverting out -r320532 because a warning is breaking the lld build.
mtrent committed rL320532: Updated llvm-objdump to display local relocations in Mach-O binaries.
mtrent closed D41061: Updated llvm-objdump to display local relocations in Mach-O binaries.
mtrent updated the diff for D41061: Updated llvm-objdump to display local relocations in Mach-O binaries.
mtrent created D41061: Updated llvm-objdump to display local relocations in Mach-O binaries.
mtrent committed rL320174: Reverting r320166 to fix test failures..
Reverting r320166 to fix test failures.
mtrent committed rL320166: Updated llvm-objdump to display local relocations in Mach-O binaries.
mtrent closed D40867: Updated llvm-objdump to display local relocations in Mach-O binaries.
mtrent created D40867: Updated llvm-objdump to display local relocations in Mach-O binaries.