Dataset Viewer
prompt
stringlengths 24
63.1k
| response
stringlengths 296
101k
| metadata
stringlengths 143
152
|
|---|---|---|
[FEATURE] Implement `AddressInterface` for `MockDb`
Spin out from #172. Please refer to that issue for more information.
|
<think>
PR Context:
- Title: feat(db): implement `AddressInterface` for `MockDb`
- Merged: 2023-05-19T09:40:37Z
- Files changed: 4 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding c
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(db): implement `AddressInterface` for `MockDb` (#968)
Co-authored-by: jeeva <jeeva.ramu@coduran
Files to modify:
**crates/router/src/db.rs**
Modify existing code
**crates/router/src/db/address.rs**
Modify existing code
**crates/storage_models/src/address.rs**
Add:
- function: pub::create_address
- impl: impl AddressUpdateInternal
|
{"issue_number": 954, "pr_number": 968, "commits_count": 1, "files_changed": 4, "response_length": 1138, "file_count": 5, "needs_breakdown": false}
|
fix: impl `Drop` for `RedisConnectionPool`
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
This fixes #1035
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
#1035
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Manual
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
|
<think>
PR Context:
- Title: fix(redis): fix recreation on redis connection pool
- Merged: 2023-05-08T09:01:49Z
- Files changed: 7 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR fixes the issue of creating multiple Redis connection pool everywhere. It provides a trait to access the interior redis connection pool.
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(redis): fix recreation on redis connection pool (#1063)
Files to modify:
**crates/redis_interface/src/lib.rs**
Modify existing code
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Modify existing code
**crates/router/src/db.rs**
Add:
- function: private::get_redis_conn
- impl: impl services::RedisConnInterface for MockDb
**crates/router/src/services.rs**
Add:
- function: private::get_redis_conn
- trait: pub::RedisConnInterface
- impl: impl RedisConnInterface for Store
|
{"issue_number": 1051, "pr_number": 1063, "commits_count": 1, "files_changed": 7, "response_length": 1431, "file_count": 8, "needs_breakdown": false}
|
fix(users): Only use lowercase letters in emails
Currently uppercase letters in emails are being using at it is. Ideally we should convert them to lowercase before performing any DB operations with it.
|
<think>
PR Context:
- Title: feat(users): Convert emails to lowercase from requests
- Merged: 2024-11-20T13:41:03Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR changes will convert emails from request to lowercase before performing any DB operations.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies applica
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(users): Convert emails to lowercase from requests (#6601)
Files to modify:
**crates/router/src/types/domain/user.rs**
Modify existing code
|
{"issue_number": 6600, "pr_number": 6601, "commits_count": 1, "files_changed": 1, "response_length": 934, "file_count": 3, "needs_breakdown": false}
|
bug(auth_methods): Create auth methods is allowing auth methods with same type to be inserted multiple times
Currently create will accept and insert auth methods with same type and name, which shouldn't be possible.
Create should have checks for this and block these kind of requests.
|
<think>
PR Context:
- Title: fix(auth_methods): Add checks for duplicate `auth_method` in create API
- Merged: 2024-07-02T08:05:59Z
- Files changed: 3 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently create will accept and insert auth methods with same type and name, which shouldn't be possible. This PR fixes that.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
-
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(auth_methods): Add checks for duplicate `auth_method` in create API (#5161)
Files to modify:
**crates/api_models/src/user.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/utils/user.rs**
Add:
- function: private::construct_public_and_private_db_configs
- function: pub::parse_value
|
{"issue_number": 5160, "pr_number": 5161, "commits_count": 1, "files_changed": 3, "response_length": 1160, "file_count": 5, "needs_breakdown": false}
|
feat(core): Add kill switch for Unified Connector Service (UCS)
# feat(core): Add kill switch for Unified Connector Service (UCS)
## Feature Description
We need to implement a kill switch mechanism for the Unified Connector Service (UCS) integration that allows operators to disable UCS immediately without requiring code changes or deployments.
## Problem Statement
Currently, if UCS experiences issues or needs to be disabled for operational reasons, there's no quick way to fall back to traditional connector flows without modifying code and deploying. This poses operational risks during incidents.
## Proposed Solution
Implement a database-driven kill switch that:
- Can be toggled via a configuration entry in the database
- Takes effect immediately without requiring service restart
- Integrates seamlessly with the existing UCS decision flow
- Provides clear logging when the kill switch is active
## Technical Approach
1. Add a new configuration key `UCS_KILL_SWITCH_ACTIVE` that can be stored in the database
2. Implement a helper function to check the kill switch status
3. Integrate the kill switch check into the UCS decision flow before rollout percentage checks
4. Ensure proper error handling when UCS is disabled via kill switch
## Benefits
- **Operational Control**: Immediate ability to disable UCS during incidents
- **Risk Mitigation**: Quick fallback mechanism without deployment delays
- **Debugging**: Easier troubleshooting by toggling UCS on/off
- **Gradual Rollout**: Additional safety layer on top of percentage-based rollout
## Implementation Details
The kill switch will be checked in the `should_call_unified_connector_service` function before any other conditions, ensuring it has the highest priority in the decision flow.
## Acceptance Criteria
- [ ] Kill switch configuration can be set in the database
- [ ] When kill switch is active, UCS is bypassed completely
- [ ] Changes take effect immediately without service restart
- [ ] Proper logging indicates when kill switch is active
- [ ] Traditional connector flow continues to work when UCS is disabled
|
<think>
PR Context:
- Title: feat(core): Implement UCS kill switch for emergency fallback
- Merged: 2025-07-22T09:00:55Z
- Files changed: 4 files
- Commits: 8 commits
Implementation approach:
# feat(core): Implement UCS enable/disable configuration for operational control
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
### Fixes #8644
## Description
<!-- Describe your changes in detail -->
This PR implements a **database-driven enable/disable configuration** for the Unified Connector Service (UCS) int
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(core): Implement UCS kill switch for emergency fallback (#8651)
Files to modify:
**crates/router/src/consts.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Add:
- function: pub::is_ucs_enabled
**crates/router/src/core/unified_connector_service.rs**
Modify existing code
|
{"issue_number": 8644, "pr_number": 8651, "commits_count": 1, "files_changed": 4, "response_length": 1169, "file_count": 7, "needs_breakdown": false}
|
feat(users): Add entity type filter in list users and list roles API
Currently list users and list roles API is sending all the users and roles respectively for those who are same entity level and less.
We need to add filters in these APIs to send users and roles who are only at particular entity level.
|
<think>
PR Context:
- Title: feat(users): Add entity type filter in list users and list roles API
- Merged: 2024-09-24T14:43:55Z
- Files changed: 7 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Adds entity_type filter in list users and list roles API.
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variable
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(users): Add entity type filter in list users and list roles API (#5997)
Files to modify:
**crates/api_models/src/events/user_role.rs**
Modify existing code
**crates/api_models/src/user_role.rs**
Add:
- struct: pub::ListUsersInEntityRequest
**crates/api_models/src/user_role/role.rs**
Add:
- struct: pub::ListRolesRequest
**crates/router/src/core/user_role.rs**
Modify existing code
**crates/router/src/core/user_role/role.rs**
Modify existing code
**crates/router/src/routes/user_role.rs**
Modify existing code
**crates/router/src/utils/user_role.rs**
Add:
- function: pub::fetch_user_roles_by_payload
- function: pub::get_min_entity
|
{"issue_number": 5996, "pr_number": 5997, "commits_count": 1, "files_changed": 7, "response_length": 1477, "file_count": 9, "needs_breakdown": false}
|
Use `frunk` deriving mechanisms to reduce boilerplate
https://github.com/juspay/orca/blob/dddc9eaf1430adcd1293933e726c2f4f296c805b/crates/router/src/types/transformers.rs#L5-L14
Why not just use [frunk](https://crates.io/crates/frunk)?
Here's an example:
```rust
use frunk::LabelledGeneric;
#[derive(LabelledGeneric)]
enum ApiRoutingAlgorithm {
RoundRobin,
MaxConversion,
MinCost,
Custom,
}
#[derive(LabelledGeneric, PartialEq, Debug)]
enum RoutingAlgorithm {
RoundRobin,
MaxConversion,
MinCost,
Custom,
}
fn main() {
let api_algorithm = ApiRoutingAlgorithm::MinCost;
let algorithm: RoutingAlgorithm = frunk::labelled_convert_from(api_algorithm);
assert_eq!(algorithm, RoutingAlgorithm::MinCost);
}
```
|
<think>
PR Context:
- Title: refactor: use frunk deriving mechanisms to reduce boilerplate
- Merged: 2022-12-14T10:17:06Z
- Files changed: 9 files
- Commits: 3 commits
Implementation approach:
## Type of Change
- [x] Refactoring
## Motivation and Context
Closes #122
## How did you test it?
Manual, compiler-guided.
## Checklist
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor: use frunk deriving mechanisms to reduce boilerplate (#137)
Co-authored-by: Arun Raj M <jar
Files to modify:
**crates/api_models/src/enums.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/storage_models/src/address.rs**
Modify existing code
**crates/storage_models/src/enums.rs**
Modify existing code
|
{"issue_number": 122, "pr_number": 137, "commits_count": 1, "files_changed": 9, "response_length": 1011, "file_count": 7, "needs_breakdown": false}
|
Make KV storage flow more generic
Model the KV storage flow as a series of common operations (For example, `set in redis -> get sql query -> push query to redis stream`) and define generic utilities that perform these operations for all KV-enabled storage interfaces (as opposed to rewriting code).
|
<think>
PR Context:
- Title: refactor: use generic function to push to drainer
- Merged: 2023-02-06T11:48:28Z
- Files changed: 4 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
Use a generic function to push sql queries into drainer stream.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug o
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor: use generic function to push to drainer (#496)
Files to modify:
**crates/router/src/db/payment_attempt.rs**
Modify existing code
**crates/router/src/db/payment_intent.rs**
Modify existing code
**crates/router/src/db/refund.rs**
Modify existing code
**crates/router/src/services.rs**
Add:
- function: pub::push_to_drainer_stream
|
{"issue_number": 97, "pr_number": 496, "commits_count": 1, "files_changed": 4, "response_length": 1136, "file_count": 6, "needs_breakdown": false}
|
[BUG] Certificate decode failed when creating the session token for `applepay`
### Bug Description
It bugs out when creating session token for `applepay` if the certificate provided is in the wrong format.
### Expected Behavior
If the certificate provided is in the wrong format, then it should error out during creation of the `merchant_connector_account` where the certificate is provided.
### Actual Behavior
It fails when creating the session token for applepay.
### Steps To Reproduce
Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.
1. Create a mca with wrong applepay certificate ( delete few characters, or do not base64 encode ).
2. Create a payment with confirm = false
3. Create session token
Result -> Applepay session token will not be generated
The log will be
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes/No No
If yes, please provide the value of the `x-request-id` response header for helping us debug your issue.
### Have you spent some time to check if this bug has been raised before?
- [X] I checked and didn't find similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes I am willing to submit a PR!
|
<think>
PR Context:
- Title: fix: certificate decode failed when creating the session token for applepay
- Merged: 2023-06-09T09:59:31Z
- Files changed: 4 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
We used to have a lot of errors when creating applepay session tokens because of invalid certificates being sent when creating the merchant connector account.
This PR will not allow the merchant connector account to be created if the format of certificates are invalid. To do this, it will decode the certificates and then create the identity ( the same pr
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix: certificate decode failed when creating the session token for applepay (#1385)
Files to modify:
**crates/api_models/src/payments.rs**
Add:
- struct: pub::ConnectorMetadata
**crates/router/src/core/admin.rs**
Add:
- function: private::validate_certificate_in_mca_metadata
**crates/router/src/core/payments/helpers.rs**
Add:
- function: pub::create_identity_from_certificate_and_key
**crates/router/src/services/api/client.rs**
Modify existing code
|
{"issue_number": 1373, "pr_number": 1385, "commits_count": 1, "files_changed": 4, "response_length": 1284, "file_count": 6, "needs_breakdown": false}
|
[REFACTOR]: [Payme] Remove Default Case Handling
### :memo: Feature Description
- We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
- These conditions generally go hand in hand with enum variants.
- Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
- So, if all the explicit cases are handled then default is used to handle the rest.
- Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a `_` is put to handle all the other cases.
- This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.
### :hammer: Possible Implementation
- Instead of relying on a default match case `_`, developers should handle each and every variant explicitly.
- By doing so, if there are any changes in the future, they can readily assess the impact of their modifications simply by compiling the code.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/1955
:bookmark: Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: refactor(connector): [Payme] Remove Default Case Handling
- Merged: 2023-10-31T10:10:48Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
- [x] Refactoring
## Description
This PR removes the default case handling and adds error handling for all the available cases.
Fixes #2282
## How did you test it?
No test cases. As In this PR only error message have been populated for all default cases.
## Checklist
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): [Payme] Remove Default Case Handling (#2719)
Files to modify:
**crates/router/src/connector/payme/transformers.rs**
Modify existing code
**Commit 2:** refactor(connector): [Payme] Remove Default Case Handling (#2719)
Files to modify:
**crates/router/src/connector/payme/transformers.rs**
Modify existing code
|
{"issue_number": 2282, "pr_number": 2719, "commits_count": 2, "files_changed": 1, "response_length": 1081, "file_count": 5, "needs_breakdown": false}
|
[REFACTOR] Worldpay payments integration
### Feature Description
WorldPay payments integration currently makes use of modular APIs which gives more control over the integration. This approach is not best compatible with HyperSwitch due to WP's 3DS flows - which requires sending PAN (card numbers) in multiple places. For `on_session` transactions, this would contribute to the added complexity since data is not stored in such transactions (or stored for ~15mins in redis cache).
Migrating to WP's standard payments API follows payment resource creation in an uniform way.
### Possible Implementation
Migrate from modular APIs [[ref](https://developer.worldpay.com/products/access/card-payments)] to standard payment APIs [[ref](https://developer.worldpay.com/products/access/payments/openapi)].
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(connector): [worldpay] add support for mandates
- Merged: 2024-11-08T13:37:39Z
- Files changed: 9 files
- Commits: 16 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #6316 point `#6`
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
F
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [worldpay] add support for mandates (#6479)
Co-authored-by: hyperswitch-bot[bot] <1
Files to modify:
**crates/hyperswitch_connectors/src/connectors/worldpay.rs**
Add:
- function: private::validate_mandate_payment
- function: private::is_webhook_source_verification_mandatory
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
**crates/hyperswitch_connectors/src/connectors/worldpay/requests.rs**
Add:
- struct: pub::TokenCreation
- struct: pub::CustomerAgreement
- enum: pub::TokenCreationType
- enum: pub::CustomerAgreementType
- enum: pub::StoredCardUsageType
- enum: pub::ThreeDsPreference
**crates/hyperswitch_connectors/src/connectors/worldpay/response.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs**
Add:
- function: private::try_from
- function: private::get_settlement_info
- function: private::get_return_url
- function: private::get_auth_type
- function: private::get_browser_info
- function: private::get_payment_method_data
- function: private::get_setup_future_usage
- function: private::get_off_session
- function: private::get_mandate_id
- function: private::get_currency
- function: private::get_optional_billing_address
- function: private::get_connector_meta_data
- function: private::get_payment_method
- function: private::get_payment_method_type
- function: private::get_connector_request_reference_id
- function: private::get_is_mandate_payment
- function: private::get_return_url
- function: private::get_auth_type
- function: private::get_browser_info
- function: private::get_payment_method_data
- function: private::get_setup_future_usage
- function: private::get_off_session
- function: private::get_mandate_id
- function: private::get_currency
- function: private::get_optional_billing_address
- function: private::get_connector_meta_data
- function: private::get_payment_method
- function: private::get_payment_method_type
- function: private::get_connector_request_reference_id
- function: private::get_is_mandate_payment
- function: private::get_settlement_info
- function: private::create_three_ds_request
- function: private::get_token_and_agreement
- impl: impl TryFrom<Option<&pii::SecretSerdeValue>> for WorldpayConnectorMetadataObject
- impl: impl WorldpayPaymentsRequestData for RouterData<SetupMandate, SetupMandateRequestData, PaymentsResponseData>
- impl: impl WorldpayPaymentsRequestData for RouterData<Authorize, PaymentsAuthorizeData, PaymentsResponseData>
**crates/hyperswitch_connectors/src/utils.rs**
Add:
- function: private::get_router_return_url
**crates/hyperswitch_domain_models/src/errors/api_error_response.rs**
Modify existing code
**crates/router/src/consts.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_response.rs**
Modify existing code
**crates/router/src/lib.rs**
Modify existing code
|
{"issue_number": 6316, "pr_number": 6479, "commits_count": 1, "files_changed": 9, "response_length": 3943, "file_count": 11, "needs_breakdown": false}
|
[REFACTOR] Enable runtime flag for `s3` feature
### Feature Description
Tracking issue for refactoring `s3` to include compile time + runtime time flag
Current implementation - We are building 2 docker images, one image contains all the release features including `kms`, `s3`, etc and other without these features which are getting pushed to the public docker hub. This was to ensure that anyone who wants to try out Hyperswitch locally by pulling the pre-built docker image, it shouldn't be a hassle for he/she to setup `s3`. For this very reason we were pushing 2 docker images which was a temporary solution
### Possible Implementation
Providing support for enabling or disabling s3 feature in runtime so that we no longer have to build 2 images.
### Tasks
- [x] #3340
- [x] #3347
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: refactor: add support for extending file storage to other schemes and provide a runtime flag for the same
- Merged: 2024-01-30T08:03:41Z
- Files changed: 18 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR includes refactoring for:
* Enabling easy extension of other file storage schemes.
* Providing a runtime flag for the file storage feature.
* Restrict the file storage objects(structs, methods) visibility wherever possible.
###
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor: add support for extending file storage to other schemes and provide a runtime flag for the
Files to modify:
**crates/external_services/src/file_storage.rs**
Add:
- function: pub::validate
- function: pub::get_file_storage_client
- function: private::fmt
- struct: pub::InvalidFileStorageConfig
- enum: pub::FileStorageConfig
- enum: pub::FileStorageError
- trait: pub::FileStorageInterface
- impl: impl FileStorageConfig
- impl: impl std::error::Error for InvalidFileStorageConfig
- impl: impl Display for InvalidFileStorageConfig
- mod: private::aws_s3
- mod: private::file_system
**crates/external_services/src/file_storage/aws_s3.rs**
Add:
- function: pub::validate
- function: pub::new
- function: private::upload_file
- function: private::delete_file
- function: private::retrieve_file
- function: private::upload_file
- function: private::delete_file
- function: private::retrieve_file
- struct: pub::AwsFileStorageConfig
- struct: pub::AwsFileStorageClient
- enum: private::AwsS3StorageError
- impl: impl AwsFileStorageConfig
- impl: impl AwsFileStorageClient
- impl: impl FileStorageInterface for AwsFileStorageClient
**crates/external_services/src/file_storage/file_system.rs**
Add:
- function: private::get_file_path
- function: private::upload_file
- function: private::delete_file
- function: private::retrieve_file
- function: private::upload_file
- function: private::delete_file
- function: private::retrieve_file
- struct: pub::FileSystem
- enum: private::FileSystemStorageError
- impl: impl FileSystem
- impl: impl FileStorageInterface for FileSystem
**crates/external_services/src/lib.rs**
Add:
- mod: pub::file_storage
**crates/router/src/configs/settings.rs**
Remove:
- struct: pub::FileUploadConfig
**crates/router/src/configs/validations.rs**
Remove:
- function: pub::validate
- impl: impl super::settings::FileUploadConfig
**crates/router/src/core/files.rs**
Remove:
- mod: pub::s3_utils
- mod: pub::fs_utils
**crates/router/src/core/files/fs_utils.rs**
Remove:
- function: pub::get_file_path
- function: pub::save_file_to_fs
- function: pub::delete_file_from_fs
- function: pub::retrieve_file_from_fs
**crates/router/src/core/files/helpers.rs**
Remove:
- function: pub::upload_file
- function: pub::delete_file
- function: pub::retrieve_file
**crates/router/src/core/files/s3_utils.rs**
Remove:
- function: private::get_aws_client
- function: pub::upload_file_to_s3
- function: pub::delete_file_from_s3
- function: pub::retrieve_file_from_s3
**crates/router/src/routes/app.rs**
Modify existing code
|
{"issue_number": 3338, "pr_number": 3348, "commits_count": 1, "files_changed": 18, "response_length": 3622, "file_count": 13, "needs_breakdown": false}
|
feat(router): refactor PML response
Remove duplicate responses and return bank_names
|
<think>
PR Context:
- Title: feat(router): Deduplicate PML response and populate bank details (V2)
- Merged: 2025-07-14T12:45:04Z
- Files changed: 6 files
- Commits: 9 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Merge `payment_experience` for a pm_type, subtype into an array
- Return `bank_names`
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application con
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(router): Deduplicate PML response and populate bank details (V2) (#8583)
Files to modify:
**crates/api_models/src/payment_methods.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/common_enums/src/enums.rs**
Modify existing code
**crates/router/src/core/payment_methods/vault.rs**
Modify existing code
**crates/router/src/core/payments/payment_methods.rs**
Remove:
- function: private::perform_surcharge_calculation
- function: private::perform_filtering
- trait: private::PerformFilteringOnPaymentMethodsEnabled
- impl: impl RequiredFieldsForEnabledPaymentMethodTypes
- impl: impl PerformFilteringOnPaymentMethodsEnabled for hyperswitch_domain_models::merchant_connector_account::FlattenedPaymentMethodsEnabled
Add:
- function: private::perform_filtering
- function: private::merge_and_transform
- function: private::perform_surcharge_calculation
- function: private::get_pm_subtype_specific_data
- function: private::populate_pm_subtype_specific_data
- struct: private::FlattenedPaymentMethodsEnabled
- struct: private::MergedEnabledPaymentMethod
- struct: private::MergedEnabledPaymentMethodTypes
- struct: private::RequiredFieldsAndSurchargeWithExtraInfoForEnabledPaymentMethodType
- struct: private::RequiredFieldsAndSurchargeWithExtraInfoForEnabledPaymentMethodTypes
- impl: impl FlattenedPaymentMethodsEnabled
- impl: impl MergedEnabledPaymentMethodTypes
- impl: impl RequiredFieldsForEnabledPaymentMethodTypes
|
{"issue_number": 8582, "pr_number": 8583, "commits_count": 1, "files_changed": 6, "response_length": 2358, "file_count": 7, "needs_breakdown": false}
|
[FEATURE] return all the `missing_fields` in a request
### Feature Description
During address validation, It would be a good experience to have all the missing fields returned at once instead of making many requests to know the missing fields.
Referring the discussion here https://github.com/juspay/hyperswitch/pull/441#issuecomment-1399482111
### Possible Implementation
A separate error type could be implemented which will take a vector or missing fields and return it.
### Have you spent some time to check if this feature request has been raised before?
- [X] I checked and didn't find similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes I am willing to submit a PR!
|
<think>
PR Context:
- Title: refactor(stripe): return all the missing fields in a request
- Merged: 2023-05-02T20:46:02Z
- Files changed: 9 files
- Commits: 25 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
On address field validation return all the mandatory fields having a null or empty values.
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(stripe): return all the missing fields in a request (#935)
Co-authored-by: jeeva <jeeva.ram
Files to modify:
**crates/common_utils/src/signals.rs**
Add:
- function: pub::signal_handler
- function: pub::get_allowed_signals
- function: pub::handle
- function: pub::close
- struct: pub::DummySignal
- impl: impl DummySignal
**crates/router/src/connector/stripe/transformers.rs**
Add:
- function: private::should_return_ok
- function: private::should_return_err_for_empty_name
- function: private::should_return_err_for_empty_line1
- function: private::should_return_err_for_empty_country
- function: private::should_return_err_for_empty_zip
- function: private::should_return_error_when_missing_multiple_fields
- function: private::get_missing_fields
- function: private::create_stripe_shipping_address
- mod: private::test_validate_shipping_address_against_payment_method
**crates/router/src/core/errors.rs**
Modify existing code
**crates/router/src/macros.rs**
Modify existing code
**crates/router/src/scheduler/utils.rs**
Add:
- function: pub::signal_handler
- function: pub::signal_handler
|
{"issue_number": 451, "pr_number": 935, "commits_count": 1, "files_changed": 9, "response_length": 1977, "file_count": 7, "needs_breakdown": false}
|
feat(core): implement `NameType` for name validation
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
for card holder name in cards, validation is added before creation of request to flag invalid data in case it is present.
Reference is taken from Visa Documetation
<img width="889" alt="image" src="https://github.com/user-attachments/assets/02859794-8313-46fb-a2b2-33a009a03600">
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Tested through Postman:
- Create a MCA (Cybersource):
Case 1: Create a Payment with valid name:
```
{
"amount": 499,
"currency": "EUR",
"confirm": true,
"capture_method": "automatic",
"customer_id": "test_rec7",
"email": "[email protected]",
"customer_acceptance": {
"acceptance_type": "online"
},
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "Sakil Mostak",
"card_cvc": "737",
"card_network": "Visa"
}
},
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here is some \n there is some \n none is some? \n ",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "Sakil",
"last_name": "Mostak"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "[email protected]"
},
"authentication_type": "no_three_ds"
}
```
- The payment should succeed, below is an example:
```
{
"payment_id": "pay_7YANCrkBMUVJngRBg36l",
"merchant_id": "merchant_1737373987",
"status": "succeeded",
"amount": 499,
"net_amount": 499,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": 499,
"connector": "cybersource",
"client_secret": "pay_7YANCrkBMUVJngRBg36l_secret_jp4t6pcoJTnMFrQsGd1R",
"created": "2025-01-20T17:52:24.651Z",
"currency": "EUR",
"customer_id": "test_rec7",
"customer": {
"id": "test_rec7",
"name": null,
"email": "[email protected]",
"phone": null,
"phone_country_code": null
},
"description": null,
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": null,
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "4242",
"card_type": null,
"card_network": null,
"card_issuer": null,
"card_issuing_country": null,
"card_isin": "424242",
"card_extended_bin": null,
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "Sakil Mostak",
"payment_checks": {
"avs_response": {
"code": "X",
"codeRaw": "I1"
},
"card_verification": null
},
"authentication_data": null
},
"billing": null
},
"payment_token": "token_7usZJrOsD3Qoy6kLGDnQ",
"shipping": null,
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here is some \n there is some \n none is some? \n ",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "Sakil",
"last_name": "Mostak"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "[email protected]"
},
"order_details": null,
"email": "[email protected]",
"name": null,
"phone": null,
"return_url": null,
"authentication_type": "no_three_ds",
"statement_descriptor_name": null,
"statement_descriptor_suffix": null,
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "test_rec7",
"created_at": 1737395544,
"expires": 1737399144,
"secret": "epk_b4c0b9ee60c844dd88e6cbc9daa9e7cb"
},
"manual_retry_allowed": false,
"connector_transaction_id": "7373955459786405604807",
"frm_message": null,
"metadata": null,
"connector_metadata": null,
"feature_metadata": null,
"reference_id": "pay_7YANCrkBMUVJngRBg36l_1",
"payment_link": null,
"profile_id": "pro_VcDn0jWTcCmofCpz2CAH",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_KXO79qkYuOXsSZCYByGz",
"incremental_authorization_allowed": false,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2025-01-20T18:07:24.651Z",
"fingerprint": null,
"browser_info": null,
"payment_method_id": null,
"payment_method_status": null,
"updated": "2025-01-20T17:52:26.511Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null
}
```
Case 2: Create a Payment with invalid name:
```
{
"amount": 499,
"currency": "EUR",
"confirm": true,
"capture_method": "automatic",
"customer_id": "test_rec7",
"email": "[email protected]",
"customer_acceptance": {
"acceptance_type": "online"
},
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "S@k*l M0st@k",
"card_cvc": "737",
"card_network": "Visa"
}
},
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here is some \n there is some \n none is some? \n ",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "Sakil",
"last_name": "Mostak"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "[email protected]"
},
"authentication_type": "no_three_ds"
}
```
Response should contain 400 error with below response:
```
{
"error": {
"error_type": "invalid_request",
"message": "Json deserialize error: invalid character found in card holder name: @ at line 23 column 5",
"code": "IR_06"
}
}
```
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [x] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert: implement `NameType` for name validation (#6734)
- Merged: 2025-04-03T16:24:25Z
- Files changed: 30 files
- Commits: 3 commits
Implementation approach:
This reverts commit 1100dcc6053990cf832c00cf29db700d77f78480.
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR revert #6734 in main
This is hotfix for https://github.com/juspay/hyperswitch/pull/7717
Reason: digit couldn't be added to nickname because nickname have the same valid
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6734, "pr_number": 7718, "commits_count": 0, "files_changed": 30, "response_length": 787, "file_count": 0, "needs_breakdown": false}
|
fix(mandate): add mandate_id column in payment_attempt table
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
This change includes
- Adding a new column `mandate_id` in the table `payment_attempt`
- Similarly, adding `mandate_id` field in `PaymentAttempt` structs (which include `New`, `Update` variants)
- Storing `mandate_id`, if generated during payment creation, to the `PaymentAttempt` table (in `PostUpdateTracker`)
<!-- Describe your changes in detail -->
### Additional Changes
- [x] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!-- Provide links to the files with corresponding changes -->
## Motivation and Context
Originally, we didn't have any way to link a payment that is made to a specific mandate. Which makes it impossible to get the related mandate_id while performing a payment sync operation. This change will allow, the payments core to have access to the mandate that is related to the specific payment attempt while performing payment sync and further mandate related functionalities.
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(payment_link): added display_sdk_only option for displaying only sdk without payment details
- Merged: 2024-04-16T13:45:56Z
- Files changed: 7 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently we show payment link with payment details, where
left side of the payment link contains payment details and the right side contains the sdk.
This is a merchant requirement where they want only the sdk to be displayed in payment
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payment_link): added display_sdk_only option for displaying only sdk without payment details (#
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/common_utils/src/consts.rs**
Modify existing code
**crates/router/src/core/payment_link.rs**
Modify existing code
|
{"issue_number": 3, "pr_number": 4363, "commits_count": 1, "files_changed": 7, "response_length": 1198, "file_count": 6, "needs_breakdown": false}
|
[BUG] Make payment method data accessible for `network_transaction_id`
### Bug Description
In the case of `network_transaction_id` some connectors require payment method data. After the new mandate changes a new payment method `MandatePayment` was introduced, which doesn't consider this use case.
### Expected Behavior
The payment method data should be present when the mandate is of type is `network_transaction_id`
### Actual Behavior
The `payment_method_data` is absent and the type is provided as `MandatePayment`
### Steps To Reproduce
Create a recurring payment for authorizedotnet
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the `x-request-id` response header for helping us debug your issue.
If not (or if building/running locally), please provide the following details:
1. Operating System or Linux distribution:
2. Rust version (output of `rustc --version`): ``
3. App version (output of `cargo r -- --version`): ``
### Have you spent some time to check if this bug has been raised before?
- [X] I checked and didn't find similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes I am willing to submit a PR!
|
<think>
PR Context:
- Title: fix(mandate): allow card details to be provided in case of network transaction id
- Merged: 2023-05-13T10:04:06Z
- Files changed: 3 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This change fixes the case where connectors require payment data, when network transaction id is passed. In case of mandate id, no payment data is provided.
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This P
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(mandate): allow card details to be provided in case of network transaction id (#1138)
Files to modify:
**crates/router/src/connector/authorizedotnet/transformers.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
|
{"issue_number": 1139, "pr_number": 1138, "commits_count": 1, "files_changed": 3, "response_length": 1072, "file_count": 4, "needs_breakdown": false}
|
[FEATURE] integrate 3DS for Worldpay connector
### Feature Description
WorldPay offers 3DS capabilities for a card txn. Same needs to be integrated in HyperSwitch.
Flow - https://developer.worldpay.com/products/access/3ds/web
### Possible Implementation
Implementing 3DS for WorldPay requires one additional step of running DDC flows. Flow can be looked at in WorldPay's dev docs
1. Redirect to Worldpay's DDC
2. Redirect to Wordlpay's 3DS redirection form
3. Capture details in HyperSwitch's `/redirect/complete` flow
4. Perform a PSync (optional)
Reference
https://developer.worldpay.com/products/access/3ds/web
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
None
|
<think>
PR Context:
- Title: feat(connector): add 3DS flow for Worldpay
- Merged: 2024-10-21T14:14:20Z
- Files changed: 8 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #6177
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): add 3DS flow for Worldpay (#6374)
Co-authored-by: hyperswitch-bot[bot] <148525504+h
Files to modify:
**crates/diesel_models/src/query/payment_attempt.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_response_types.rs**
Modify existing code
**crates/router/src/connector/worldpay.rs**
Add:
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_flow_type
- impl: impl api::PaymentsCompleteAuthorize for Worldpay
- impl: impl ConnectorIntegration<
api::CompleteAuthorize,
types::CompleteAuthorizeData,
types::PaymentsResponseData,
> for Worldpay
- impl: impl services::ConnectorRedirectResponse for Worldpay
**crates/router/src/connector/worldpay/requests.rs**
Add:
- struct: pub::ThreeDSRequest
- struct: pub::ThreeDSRequestDeviceData
- struct: pub::ThreeDSRequestChallenge
- struct: pub::WorldpayCompleteAuthorizationRequest
- enum: pub::ThreeDSRequestChannel
**crates/router/src/connector/worldpay/response.rs**
Remove:
- function: pub::new
- impl: impl PaymentsResPaymentInstrument
Add:
- function: private::fmt
- struct: pub::ThreeDsChallengedResponse
- struct: pub::AuthenticationResponse
- struct: pub::ThreeDsChallenge
- struct: pub::CompleteThreeDsActionLink
**crates/router/src/connector/worldpay/transformers.rs**
Modify existing code
**crates/router/src/core/payments/flows.rs**
Modify existing code
**crates/router/src/services/api.rs**
Modify existing code
|
{"issue_number": 6177, "pr_number": 6374, "commits_count": 1, "files_changed": 8, "response_length": 2551, "file_count": 10, "needs_breakdown": false}
|
[bug]: fix timestamp sent to kafka events
rdkafka library expects time in millis but we send seconds.
This can be reflected in the kafka-ui at localhost:8090 as well.
We can fix this by either truncating the unix_timestamp_nanos or padding the seconds.
|
<think>
PR Context:
- Title: fix(kafka): fix kafka timestamps sent from application
- Merged: 2024-05-23T09:28:10Z
- Files changed: 5 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
fixes #4706
Convert secs to millis when sending creation timestamp to kafka
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(kafka): fix kafka timestamps sent from application (#4709)
Co-authored-by: hyperswitch-bot[bot]
Files to modify:
**crates/router/src/services/kafka.rs**
Modify existing code
**crates/router/src/services/kafka/dispute.rs**
Remove:
- function: private::creation_timestamp
**crates/router/src/services/kafka/payment_attempt.rs**
Remove:
- function: private::creation_timestamp
**crates/router/src/services/kafka/payment_intent.rs**
Remove:
- function: private::creation_timestamp
**crates/router/src/services/kafka/payout.rs**
Remove:
- function: private::creation_timestamp
|
{"issue_number": 4706, "pr_number": 4709, "commits_count": 1, "files_changed": 5, "response_length": 1395, "file_count": 7, "needs_breakdown": false}
|
fix(connector) : Added signifyd to routableconnectors for frm
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently, Signifyd is mentioned in connectors enum, but not routable connectors enum...this PR is to add that
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
Currently, Signifyd is mentioned in connectors enum, but not routable connectors enum...this PR is to add that
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: revert: fix(connector): Added signifyd to routableconnectors for frm
- Merged: 2023-05-18T12:59:09Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
This PR reverts #1182.
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert: fix(connector): Added signifyd to routableconnectors for frm (#1203)
Files to modify:
**crates/api_models/src/enums.rs**
Modify existing code
|
{"issue_number": 1182, "pr_number": 1203, "commits_count": 1, "files_changed": 1, "response_length": 476, "file_count": 3, "needs_breakdown": false}
|
feat(authn): Use cookies for authentication
Currently we use auth headers and local storage in FE for transfer JWT from FE to BE.
Cookies is a better way to do this, as it is handled by browser and JavaScript doesn't have access to.
First we will test this in Integ and slowly move it to sandbox and production.
|
<think>
PR Context:
- Title: refactor(authn): Enable cookies in Integ
- Merged: 2024-11-26T12:42:14Z
- Files changed: 11 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR will add logging for cookies and also make signout API accessible by any SPT.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [x] This PR modifies application configur
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(authn): Enable cookies in Integ (#6599)
Files to modify:
**crates/router/src/configs/settings.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/routes/user.rs**
Modify existing code
**crates/router/src/services/authentication.rs**
Add:
- function: private::authenticate_and_fetch
- struct: pub::AnyPurposeOrLoginTokenAuth
- impl: impl AuthenticateAndFetch<UserIdFromAuth, A> for AnyPurposeOrLoginTokenAuth
|
{"issue_number": 6598, "pr_number": 6599, "commits_count": 1, "files_changed": 11, "response_length": 1265, "file_count": 6, "needs_breakdown": false}
|
[REFACTOR]: [Worldpay] Remove Default Case Handling
### :memo: Feature Description
- We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
- These conditions generally go hand in hand with enum variants.
- Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
- So, if all the explicit cases are handled then default is used to handle the rest.
- Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a `_` is put to handle all the other cases.
- This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.
### :hammer: Possible Implementation
- Instead of relying on a default match case `_`, developers should handle each and every variant explicitly.
- By doing so, if there are any changes in the future, they can readily assess the impact of their modifications simply by compiling the code.
- You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/1955
:bookmark: Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: refactor(connector): [Worldpay] Remove Default Case Handling
- Merged: 2023-10-25T18:27:57Z
- Files changed: 1 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Instead of relying on a default match case `_` I have added conditions for each type in match statements.
Changes are made at https://github.com/juspay/hyperswitch/blob/main/crates/router/src/connector/worldpay/transformers.rs
## Motivation and Context
Closes #2290
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): [Worldpay] Remove Default Case Handling (#2488)
Co-authored-by: de-harish <hari
Files to modify:
**crates/router/src/connector/worldpay/transformers.rs**
Modify existing code
|
{"issue_number": 2290, "pr_number": 2488, "commits_count": 1, "files_changed": 1, "response_length": 992, "file_count": 3, "needs_breakdown": false}
|
[REFACTOR] Unify the `sandbox` and `production` cargo features
### Description
After #1349, this is the next step towards using a single Docker image across all our environments (see #1346). The `sandbox` and `production` features would have to be unified into a single `release` feature instead. This change would also need corresponding changes in the `Dockerfile` and CI workflows.
|
<think>
PR Context:
- Title: build: unify `sandbox` and `production` cargo features as `release`
- Merged: 2023-06-07T08:34:58Z
- Files changed: 4 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR unifies the `sandbox` and `production` cargo features into a single feature named `release`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the is
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** build: unify `sandbox` and `production` cargo features as `release` (#1356)
Files to modify:
**crates/router/src/core/payment_methods/transformers.rs**
Modify existing code
|
{"issue_number": 1353, "pr_number": 1356, "commits_count": 1, "files_changed": 4, "response_length": 976, "file_count": 3, "needs_breakdown": false}
|
feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLevel and ProfileLevel authentication
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Cherry picked the commit for #5729
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [ ] I formatted the code `cargo +nightly fmt --all`
- [ ] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert: feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLevel and ProfileLevel authentication
- Merged: 2024-09-05T11:19:25Z
- Files changed: 30 files
- Commits: 1 commits
Implementation approach:
Reverts juspay/hyperswitch#5784
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert: feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLeve
Files to modify:
**crates/analytics/src/api_event/core.rs**
Modify existing code
**crates/analytics/src/api_event/filters.rs**
Modify existing code
**crates/analytics/src/api_event/metrics.rs**
Modify existing code
**crates/analytics/src/api_event/metrics/api_count.rs**
Modify existing code
**crates/analytics/src/api_event/metrics/latency.rs**
Modify existing code
**crates/analytics/src/api_event/metrics/status_code_count.rs**
Modify existing code
**crates/analytics/src/clickhouse.rs**
Modify existing code
**crates/analytics/src/disputes/core.rs**
Modify existing code
**crates/analytics/src/disputes/filters.rs**
Modify existing code
**crates/analytics/src/disputes/metrics.rs**
Modify existing code
**crates/analytics/src/disputes/metrics/dispute_status_metric.rs**
Modify existing code
**crates/analytics/src/disputes/metrics/total_amount_disputed.rs**
Modify existing code
**crates/analytics/src/disputes/metrics/total_dispute_lost_amount.rs**
Modify existing code
**crates/analytics/src/enums.rs**
Modify existing code
**crates/analytics/src/errors.rs**
Modify existing code
**crates/analytics/src/lib.rs**
Remove:
- mod: pub::active_payments
- mod: pub::api_event
- mod: pub::auth_events
- mod: pub::connector_events
- mod: pub::enums
- mod: pub::health_check
- mod: pub::opensearch
- mod: pub::outgoing_webhook_event
Add:
- mod: pub::active_payments
- mod: pub::api_event
- mod: pub::auth_events
- mod: pub::connector_events
- mod: pub::health_check
- mod: pub::opensearch
- mod: pub::outgoing_webhook_event
**crates/analytics/src/outgoing_webhook_event/events.rs**
Modify existing code
**crates/analytics/src/payment_intents/core.rs**
Modify existing code
**crates/analytics/src/payment_intents/filters.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics/payment_intent_count.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics/smart_retried_amount.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics/successful_smart_retries.rs**
Modify existing code
**crates/analytics/src/payment_intents/metrics/total_smart_retries.rs**
Modify existing code
**crates/analytics/src/payment_intents/types.rs**
Modify existing code
**crates/analytics/src/payments/core.rs**
Modify existing code
**crates/analytics/src/payments/distribution.rs**
Modify existing code
**crates/analytics/src/payments/distribution/payment_error_message.rs**
Modify existing code
**crates/analytics/src/payments/filters.rs**
Remove:
- struct: private::PaymentFilterRow
- trait: pub::PaymentFilterAnalytics
Add:
- struct: private::FilterRow
- trait: pub::PaymentFilterAnalytics
**crates/analytics/src/payments/metrics.rs**
Modify existing code
**crates/analytics/src/payments/metrics/avg_ticket_size.rs**
Modify existing code
**crates/analytics/src/payments/metrics/connector_success_rate.rs**
Modify existing code
**crates/analytics/src/payments/metrics/payment_count.rs**
Modify existing code
**crates/analytics/src/payments/metrics/payment_processed_amount.rs**
Modify existing code
**crates/analytics/src/payments/metrics/payment_success_count.rs**
Modify existing code
**crates/analytics/src/payments/metrics/retries_count.rs**
Modify existing code
**crates/analytics/src/payments/metrics/success_rate.rs**
Modify existing code
**crates/analytics/src/payments/types.rs**
Modify existing code
**crates/analytics/src/query.rs**
Remove:
- function: private::to_sql
- function: private::to_sql
- function: private::to_sql
- function: private::set_filter_clause
- impl: impl ToSql<T> for &MerchantId
- impl: impl ToSql<T> for MerchantId
- impl: impl ToSql<T> for &OrganizationId
- impl: impl ToSql<T> for ProfileId
- impl: impl QueryFilter<T> for AuthInfo
Add:
- impl: impl ToSql<T> for &common_utils::id_type::MerchantId
**crates/analytics/src/refunds/core.rs**
Modify existing code
**crates/analytics/src/refunds/filters.rs**
Modify existing code
**crates/analytics/src/refunds/metrics.rs**
Modify existing code
**crates/analytics/src/refunds/metrics/refund_count.rs**
Modify existing code
**crates/analytics/src/refunds/metrics/refund_processed_amount.rs**
Modify existing code
**crates/analytics/src/refunds/metrics/refund_success_count.rs**
Modify existing code
**crates/analytics/src/refunds/metrics/refund_success_rate.rs**
Modify existing code
**crates/analytics/src/refunds/types.rs**
Modify existing code
**crates/analytics/src/sqlx.rs**
Remove:
- impl: impl FromRow<'a, PgRow> for super::payments::filters::PaymentFilterRow
**crates/api_models/src/analytics.rs**
Modify existing code
**crates/api_models/src/analytics/payment_intents.rs**
Modify existing code
**crates/api_models/src/analytics/payments.rs**
Modify existing code
**crates/api_models/src/analytics/refunds.rs**
Modify existing code
**crates/common_utils/src/types.rs**
Remove:
- mod: pub::authentication
**crates/common_utils/src/types/authentication.rs**
Remove:
- enum: pub::AuthInfo
**crates/hyperswitch_domain_models/src/merchant_account.rs**
Remove:
- function: pub::get_org_id
**crates/router/src/analytics.rs**
Remove:
- function: pub::get_org_payment_metrics
- function: pub::get_merchant_payment_intent_metrics
- function: pub::get_org_payment_intent_metrics
- function: pub::get_merchant_refund_metrics
- function: pub::get_org_refund_metrics
- function: pub::get_profile_refund_filters
- function: pub::get_profile_outgoing_webhook_events
- function: pub::generate_org_dispute_report
- function: pub::generate_profile_dispute_report
- function: pub::get_merchant_api_event_filters
**crates/router/src/core/verification/utils.rs**
Remove:
- function: pub::check_if_profile_id_is_present_in_payment_intent
**crates/router/src/types/domain/user.rs**
Modify existing code
|
{"issue_number": 5784, "pr_number": 5811, "commits_count": 1, "files_changed": 30, "response_length": 6622, "file_count": 60, "needs_breakdown": true}
|
feat(connector): [paypal, trustpay] add in feature matrix
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added paypal, trustpay, nomupay connectors in feature matrix
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
```
curl --location 'http://localhost:8080/feature_matrix' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_jQNBYCfN5R0473yldj23Yl7HsGbCctexthWkELSAMAGpjCxKAspb2fcQDP1KmMJz'
```
Response:
```
{
"connector_count": 2,
"connectors": [
{
"name": "PAYPAL",
"display_name": "Paypal",
"description": "PayPal is a Slovakia-based company specializing in secure e-commerce payments, particularly within the EEA area.",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"Mastercard",
"AmericanExpress",
"DinersClub",
"Discover",
"Interac",
"JCB",
"CartesBancaires"
],
"supported_countries": [
"TTO",
"HND",
"TWN",
"DEU",
"MCO",
"BDI",
"SLV",
"LCA",
"ESP",
"GUF",
"MUS",
"FRO",
"FIN",
"MKD",
"SPM",
"ETH",
"DNK",
"NGA",
"GMB",
"VCT",
"ROU",
"QAT",
"PER",
"MYT",
"TGO",
"NOR",
"TCD",
"KNA",
"DMA",
"FJI",
"POL",
"KOR",
"SLE",
"KIR",
"LAO",
"BFA",
"KWT",
"CRI",
"WSM",
"ABW",
"GBR",
"MWI",
"BHR",
"ZWE",
"BRB",
"MSR",
"BIH",
"SYC",
"TZA",
"NIU",
"COD",
"SMR",
"KAZ",
"NAM",
"BMU",
"CHL",
"ISL",
"LKA",
"NRU",
"BLZ",
"GTM",
"ZMB",
"SGP",
"ARE",
"GIB",
"LSO",
"SUR",
"GAB",
"JPN",
"PAN",
"CHE",
"NCL",
"USA",
"SVK",
"GRD",
"DOM",
"SAU",
"TKM",
"UGA",
"BLR",
"VNM",
"MDV",
"CYP",
"LTU",
"LIE",
"MAR",
"SWZ",
"MHL",
"ERI",
"NER",
"MLT",
"PNG",
"UKR",
"SVN",
"REU",
"NPL",
"PYF",
"FRA",
"NFK",
"SHN",
"CIV",
"ISR",
"COG",
"SJM",
"HKG",
"BWA",
"URY",
"SLB",
"BRA",
"CPV",
"SOM",
"GEO",
"AGO",
"KEN",
"MNE",
"MOZ",
"NIC",
"IND",
"AUS",
"IRL",
"CMR",
"GRL",
"GLP",
"LUX",
"MEX",
"NLD",
"THA",
"CAN",
"HUN",
"PCN",
"PHL",
"TUV",
"AIA",
"VGB",
"PRY",
"KHM",
"DZA",
"GUY",
"MNG",
"BEL",
"TON",
"JAM",
"TCA",
"GNB",
"OMN",
"ZAF",
"COM",
"NZL",
"MDG",
"BRN",
"SRB",
"IDN",
"MLI",
"KGZ",
"AZE",
"VEN",
"RWA",
"ECU",
"GRC",
"COK",
"DJI",
"PRT",
"BHS",
"EGY",
"BTN",
"AUT",
"RUS",
"TUN",
"BOL",
"MYS",
"COL",
"SEN",
"JOR",
"STP",
"HRV",
"ARG",
"FSM",
"GIN",
"ATG",
"MDA",
"SWE",
"ITA",
"LVA",
"EST",
"BEN",
"BGR",
"MRT",
"CZE",
"CYM",
"TJK"
],
"supported_currencies": [
"PLN",
"SEK",
"SGD",
"BRL",
"NZD",
"ILS",
"CHF",
"THB",
"PHP",
"USD",
"CZK",
"JPY",
"CAD",
"CNY",
"MXN",
"GBP",
"HUF",
"HKD",
"EUR",
"MYR",
"NOK",
"AUD",
"DKK",
"TWD"
]
},
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"three_ds": "supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"Mastercard",
"AmericanExpress",
"DinersClub",
"Discover",
"Interac",
"JCB",
"CartesBancaires"
],
"supported_countries": [
"NFK",
"URY",
"FIN",
"NER",
"CAN",
"GMB",
"COM",
"SMR",
"MCO",
"GUF",
"DOM",
"ECU",
"DNK",
"CMR",
"CRI",
"GEO",
"BGR",
"FRA",
"TUN",
"GTM",
"NLD",
"NAM",
"PAN",
"TCA",
"GNB",
"SEN",
"SVK",
"BLZ",
"NZL",
"AGO",
"ATG",
"ISR",
"MRT",
"TON",
"OMN",
"RUS",
"LIE",
"BEN",
"FJI",
"GAB",
"SHN",
"MLT",
"UKR",
"TUV",
"LTU",
"GIN",
"RWA",
"KHM",
"MYS",
"VNM",
"NGA",
"USA",
"TWN",
"DZA",
"MEX",
"AUS",
"MDV",
"SLB",
"CHL",
"MWI",
"ZMB",
"BRA",
"ZWE",
"PCN",
"NIU",
"GRD",
"NOR",
"GUY",
"BTN",
"NRU",
"SAU",
"SJM",
"AZE",
"LAO",
"GBR",
"BHR",
"MDG",
"IND",
"ARG",
"EGY",
"SGP",
"WSM",
"HRV",
"KAZ",
"GIB",
"SPM",
"GLP",
"MDA",
"TKM",
"STP",
"BFA",
"BWA",
"BEL",
"MNE",
"ITA",
"DJI",
"CYP",
"KOR",
"GRC",
"NCL",
"KEN",
"PER",
"VCT",
"CHE",
"FRO",
"KGZ",
"AIA",
"MYT",
"PYF",
"CYM",
"BRB",
"AUT",
"ISL",
"HKG",
"BOL",
"PRY",
"REU",
"IRL",
"JPN",
"COD",
"VGB",
"PHL",
"SWZ",
"EST",
"MAR",
"JOR",
"NIC",
"TZA",
"ETH",
"IDN",
"BMU",
"SUR",
"FSM",
"SLE",
"ROU",
"MNG",
"BHS",
"PNG",
"SOM",
"BRN",
"NPL",
"BDI",
"HND",
"ARE",
"LKA",
"MUS",
"SLV",
"BLR",
"POL",
"CPV",
"JAM",
"SYC",
"TTO",
"MLI",
"ZAF",
"BIH",
"QAT",
"LVA",
"CZE",
"SVN",
"KNA",
"DEU",
"MKD",
"DMA",
"LUX",
"HUN",
"ERI",
"COG",
"COK",
"PRT",
"THA",
"SRB",
"GRL",
"ABW",
"MHL",
"SWE",
"MOZ",
"COL",
"TGO",
"VEN",
"LSO",
"TCD",
"MSR",
"KWT",
"KIR",
"LCA",
"CIV",
"UGA",
"ESP",
"TJK"
],
"supported_currencies": [
"CNY",
"PHP",
"TWD",
"HKD",
"JPY",
"SEK",
"MXN",
"ILS",
"BRL",
"PLN",
"EUR",
"USD",
"DKK",
"HUF",
"AUD",
"CAD",
"CZK",
"NZD",
"MYR",
"NOK",
"GBP",
"SGD",
"CHF",
"THB"
]
},
{
"payment_method": "wallet",
"payment_method_type": "paypal",
"payment_method_type_display_name": "PayPal",
"mandates": "supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"NCL",
"MRT",
"DMA",
"MYS",
"GIN",
"STP",
"MKD",
"CAN",
"SLV",
"ISR",
"TTO",
"KOR",
"KIR",
"SMR",
"COG",
"MLT",
"MSR",
"KWT",
"ITA",
"COK",
"SLE",
"MNG",
"MOZ",
"FRO",
"GRL",
"TCD",
"DNK",
"MWI",
"URY",
"CPV",
"CMR",
"MDA",
"ESP",
"HND",
"UKR",
"MLI",
"AUT",
"SGP",
"TJK",
"DEU",
"POL",
"SWE",
"GUY",
"SRB",
"KNA",
"ETH",
"THA",
"NPL",
"MUS",
"PAN",
"NIU",
"LKA",
"VEN",
"GLP",
"BRB",
"OMN",
"SWZ",
"MDV",
"PRT",
"LIE",
"SUR",
"ISL",
"LTU",
"AZE",
"TGO",
"FIN",
"LSO",
"HRV",
"PYF",
"CHL",
"NGA",
"BRN",
"NZL",
"FSM",
"LAO",
"MYT",
"LCA",
"BFA",
"BTN",
"ATG",
"CYM",
"HKG",
"ZMB",
"CYP",
"SYC",
"COL",
"AGO",
"HUN",
"MAR",
"CIV",
"DOM",
"BHR",
"SJM",
"KGZ",
"SOM",
"DZA",
"EST",
"MHL",
"PNG",
"MCO",
"TZA",
"GNB",
"WSM",
"KAZ",
"MNE",
"QAT",
"NAM",
"KEN",
"COD",
"TON",
"AIA",
"PHL",
"TCA",
"SEN",
"ERI",
"JAM",
"SHN",
"BEN",
"GIB",
"RUS",
"EGY",
"BOL",
"REU",
"ABW",
"GMB",
"ARG",
"VNM",
"IND",
"LVA",
"NOR",
"MDG",
"GUF",
"TUV",
"GEO",
"TKM",
"ARE",
"JPN",
"VCT",
"SAU",
"FRA",
"GTM",
"SVN",
"TWN",
"LUX",
"NRU",
"KHM",
"BGR",
"BMU",
"BHS",
"ZAF",
"NER",
"TUN",
"PER",
"NIC",
"UGA",
"AUS",
"SPM",
"BIH",
"SLB",
"IRL",
"COM",
"NFK",
"BDI",
"GRD",
"VGB",
"GBR",
"BLR",
"BRA",
"PCN",
"MEX",
"FJI",
"GRC",
"CHE",
"BLZ",
"BEL",
"IDN",
"GAB",
"PRY",
"ROU",
"JOR",
"SVK",
"NLD",
"USA",
"DJI",
"CRI",
"CZE",
"BWA",
"RWA",
"ZWE",
"ECU"
],
"supported_currencies": [
"GBP",
"USD",
"ILS",
"MYR",
"DKK",
"CZK",
"MXN",
"HUF",
"SEK",
"JPY",
"EUR",
"HKD",
"TWD",
"PLN",
"SGD",
"AUD",
"BRL",
"PHP",
"NOK",
"NZD",
"CAD",
"CHF",
"THB",
"CNY"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "eps",
"payment_method_type_display_name": "EPS",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"MDV",
"VGB",
"COG",
"SUR",
"LTU",
"KGZ",
"USA",
"BOL",
"SRB",
"MLI",
"GMB",
"CAN",
"PAN",
"GRD",
"CYP",
"PNG",
"RUS",
"KWT",
"PHL",
"CYM",
"BTN",
"GAB",
"TKM",
"SVN",
"GIN",
"AGO",
"GUF",
"NGA",
"COK",
"LAO",
"BHR",
"SJM",
"TJK",
"BRB",
"BEL",
"FRO",
"SHN",
"TCA",
"TON",
"BLR",
"NIU",
"MNG",
"AIA",
"NAM",
"KNA",
"DOM",
"HND",
"KOR",
"KIR",
"MYT",
"JAM",
"TZA",
"ABW",
"CRI",
"DMA",
"PCN",
"CZE",
"DJI",
"IDN",
"HRV",
"DNK",
"IRL",
"AUS",
"GTM",
"ISL",
"NPL",
"GRC",
"THA",
"GIB",
"LCA",
"CHL",
"SLV",
"AUT",
"VEN",
"NOR",
"MKD",
"ZWE",
"ECU",
"MDA",
"GNB",
"SWE",
"KAZ",
"CIV",
"FSM",
"FRA",
"NER",
"GLP",
"TTO",
"ETH",
"VCT",
"EGY",
"NRU",
"SWZ",
"HUN",
"GUY",
"NLD",
"GRL",
"MWI",
"JPN",
"BGR",
"OMN",
"BRN",
"HKG",
"JOR",
"NCL",
"PER",
"DZA",
"CMR",
"PRY",
"MRT",
"SYC",
"BIH",
"BWA",
"ITA",
"ISR",
"SGP",
"TWN",
"COM",
"LIE",
"MLT",
"MAR",
"MEX",
"SLB",
"MOZ",
"NFK",
"NZL",
"MDG",
"FJI",
"DEU",
"ESP",
"KHM",
"MSR",
"CHE",
"GEO",
"ARG",
"SLE",
"ATG",
"EST",
"PYF",
"BRA",
"ERI",
"SOM",
"UGA",
"LSO",
"SMR",
"LKA",
"TUN",
"GBR",
"BHS",
"STP",
"BEN",
"PRT",
"IND",
"FIN",
"MCO",
"TGO",
"BDI",
"MNE",
"VNM",
"TUV",
"TCD",
"NIC",
"UKR",
"URY",
"LVA",
"QAT",
"POL",
"SEN",
"BMU",
"SVK",
"MYS",
"COD",
"RWA",
"MHL",
"MUS",
"ARE",
"ZAF",
"WSM",
"ZMB",
"AZE",
"BLZ",
"KEN",
"BFA",
"ROU",
"SPM",
"SAU",
"REU",
"CPV",
"COL",
"LUX"
],
"supported_currencies": [
"PHP",
"SEK",
"CAD",
"EUR",
"BRL",
"SGD",
"CNY",
"NOK",
"NZD",
"THB",
"TWD",
"CZK",
"GBP",
"CHF",
"MYR",
"JPY",
"ILS",
"AUD",
"MXN",
"HUF",
"PLN",
"USD",
"DKK",
"HKD"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "giropay",
"payment_method_type_display_name": "Giropay",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"STP",
"GRC",
"ZMB",
"MUS",
"CHE",
"BRB",
"KGZ",
"BFA",
"TCA",
"GMB",
"SUR",
"MSR",
"COL",
"DJI",
"JOR",
"NFK",
"WSM",
"GAB",
"PRY",
"GNB",
"IND",
"MAR",
"KEN",
"TON",
"MLI",
"GBR",
"LCA",
"SGP",
"MHL",
"MKD",
"COG",
"BTN",
"MDG",
"SMR",
"AUT",
"LIE",
"LAO",
"FRA",
"OMN",
"THA",
"BGR",
"KOR",
"REU",
"GLP",
"CMR",
"ABW",
"BOL",
"MOZ",
"HUN",
"SPM",
"CHL",
"TJK",
"BRA",
"NPL",
"COD",
"ETH",
"TCD",
"SVK",
"PHL",
"AUS",
"MDV",
"VGB",
"CRI",
"MDA",
"PER",
"COK",
"CYP",
"MEX",
"KAZ",
"MNG",
"RWA",
"SWE",
"GUF",
"BRN",
"ISL",
"SLE",
"TZA",
"NIC",
"SRB",
"RUS",
"BLR",
"MNE",
"MCO",
"GUY",
"TGO",
"NZL",
"TKM",
"QAT",
"SLV",
"FJI",
"NER",
"BIH",
"SAU",
"TTO",
"NOR",
"VEN",
"TUN",
"BEN",
"LVA",
"EGY",
"MRT",
"USA",
"NCL",
"FRO",
"IDN",
"TWN",
"GEO",
"SYC",
"SVN",
"ESP",
"VCT",
"CAN",
"BMU",
"ZWE",
"EST",
"SEN",
"ZAF",
"MYT",
"PAN",
"BHR",
"PRT",
"SJM",
"SHN",
"CIV",
"CYM",
"GIN",
"KNA",
"UGA",
"VNM",
"BEL",
"AGO",
"AZE",
"LKA",
"UKR",
"PYF",
"GTM",
"COM",
"JAM",
"DEU",
"ITA",
"MYS",
"DOM",
"HKG",
"ARG",
"ECU",
"CZE",
"DNK",
"KHM",
"ARE",
"GRD",
"IRL",
"SOM",
"CPV",
"MLT",
"TUV",
"MWI",
"ROU",
"BDI",
"ISR",
"NIU",
"ATG",
"FSM",
"NAM",
"BLZ",
"LSO",
"NLD",
"URY",
"BWA",
"PNG",
"NRU",
"KIR",
"SLB",
"ERI",
"FIN",
"KWT",
"POL",
"NGA",
"BHS",
"AIA",
"HRV",
"DZA",
"DMA",
"GIB",
"GRL",
"HND",
"SWZ",
"JPN",
"LTU",
"LUX",
"PCN"
],
"supported_currencies": [
"PHP",
"NZD",
"CNY",
"GBP",
"CHF",
"SGD",
"USD",
"ILS",
"BRL",
"AUD",
"TWD",
"PLN",
"CZK",
"DKK",
"EUR",
"MYR",
"MXN",
"CAD",
"THB",
"NOK",
"HKD",
"HUF",
"JPY",
"SEK"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "ideal",
"payment_method_type_display_name": "iDEAL",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"HRV",
"BTN",
"MDA",
"ESP",
"SWE",
"NAM",
"FRA",
"ARG",
"PCN",
"MNE",
"PHL",
"LCA",
"CMR",
"MNG",
"ISL",
"SAU",
"CHE",
"FIN",
"KIR",
"BMU",
"GUF",
"EGY",
"UGA",
"SLV",
"DJI",
"HUN",
"GNB",
"AZE",
"JOR",
"BRB",
"LKA",
"SGP",
"THA",
"CIV",
"TUV",
"COK",
"SWZ",
"SPM",
"VNM",
"NPL",
"CRI",
"LVA",
"ECU",
"GTM",
"CPV",
"BIH",
"COL",
"ITA",
"HND",
"ATG",
"RUS",
"ZWE",
"IRL",
"BLR",
"NIU",
"IND",
"MRT",
"SEN",
"BHS",
"TZA",
"MSR",
"DZA",
"PNG",
"BWA",
"GLP",
"ISR",
"DNK",
"SVK",
"TON",
"MUS",
"CYP",
"MEX",
"KHM",
"KOR",
"ERI",
"ZAF",
"QAT",
"BRA",
"LUX",
"COG",
"GBR",
"NCL",
"TKM",
"JPN",
"KWT",
"FSM",
"KEN",
"MCO",
"PRT",
"GRL",
"TJK",
"BRN",
"NOR",
"DEU",
"LSO",
"STP",
"GEO",
"GIN",
"SVN",
"VCT",
"VGB",
"NER",
"GRC",
"OMN",
"KGZ",
"COD",
"FRO",
"KAZ",
"FJI",
"KNA",
"BHR",
"EST",
"NLD",
"TGO",
"LAO",
"NFK",
"REU",
"NIC",
"UKR",
"SJM",
"JAM",
"GIB",
"TTO",
"PYF",
"BEL",
"IDN",
"CYM",
"BFA",
"PRY",
"ARE",
"BLZ",
"COM",
"ZMB",
"MOZ",
"RWA",
"SMR",
"BDI",
"TWN",
"CZE",
"SYC",
"TUN",
"MLI",
"MYS",
"TCA",
"MAR",
"CAN",
"AGO",
"SOM",
"URY",
"ETH",
"SHN",
"MHL",
"GMB",
"AUS",
"MDG",
"GRD",
"LTU",
"AUT",
"NRU",
"SLE",
"GUY",
"NGA",
"ROU",
"SRB",
"MYT",
"WSM",
"PAN",
"NZL",
"BOL",
"GAB",
"DMA",
"ABW",
"LIE",
"TCD",
"AIA",
"CHL",
"SUR",
"PER",
"BEN",
"SLB",
"MWI",
"MDV",
"MKD",
"BGR",
"VEN",
"USA",
"MLT",
"DOM",
"HKG",
"POL"
],
"supported_currencies": [
"TWD",
"USD",
"DKK",
"MYR",
"NOK",
"CNY",
"MXN",
"CZK",
"ILS",
"CAD",
"NZD",
"SEK",
"CHF",
"SGD",
"PLN",
"PHP",
"GBP",
"HUF",
"EUR",
"HKD",
"THB",
"AUD",
"JPY",
"BRL"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "sofort",
"payment_method_type_display_name": "Sofort",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [
"automatic",
"manual",
"sequential_automatic"
],
"supported_countries": [
"IRL",
"NGA",
"MDA",
"BRN",
"GUY",
"RUS",
"IND",
"BLR",
"BMU",
"NCL",
"MUS",
"NOR",
"MYT",
"KOR",
"GNB",
"GLP",
"GIB",
"NIC",
"PCN",
"SLE",
"GBR",
"SMR",
"COK",
"GIN",
"THA",
"LTU",
"TCA",
"ESP",
"VNM",
"TZA",
"AIA",
"BGR",
"COD",
"TUN",
"TJK",
"PYF",
"PAN",
"NFK",
"CHE",
"TWN",
"BRA",
"ISL",
"AUS",
"PRY",
"MWI",
"ARE",
"KWT",
"TUV",
"ATG",
"SLB",
"SLV",
"MNE",
"FRA",
"COM",
"CYP",
"LVA",
"KNA",
"HKG",
"HUN",
"EST",
"KGZ",
"NPL",
"PER",
"CYM",
"JOR",
"URY",
"MEX",
"SWZ",
"TCD",
"WSM",
"BFA",
"MKD",
"SOM",
"MAR",
"SWE",
"CZE",
"BDI",
"GAB",
"BIH",
"SJM",
"DJI",
"LUX",
"CAN",
"GTM",
"UKR",
"FJI",
"KEN",
"SUR",
"MRT",
"REU",
"PNG",
"ZAF",
"NAM",
"GUF",
"BWA",
"GMB",
"SVK",
"BHR",
"GRC",
"MNG",
"BOL",
"JPN",
"ECU",
"POL",
"IDN",
"CHL",
"SPM",
"USA",
"TTO",
"MHL",
"NER",
"QAT",
"TKM",
"VGB",
"BEL",
"CRI",
"KAZ",
"MYS",
"ABW",
"MSR",
"LCA",
"OMN",
"ERI",
"SGP",
"KIR",
"MDG",
"VCT",
"AGO",
"MCO",
"NIU",
"AUT",
"UGA",
"MLI",
"SYC",
"NZL",
"DOM",
"TON",
"DEU",
"COG",
"ISR",
"ZMB",
"FSM",
"DNK",
"STP",
"RWA",
"LIE",
"SAU",
"SVN",
"ROU",
"LSO",
"BHS",
"VEN",
"COL",
"TGO",
"KHM",
"BEN",
"NLD",
"LAO",
"GEO",
"AZE",
"NRU",
"SRB",
"CPV",
"GRL",
"FRO",
"SHN",
"HND",
"EGY",
"ZWE",
"PRT",
"BLZ",
"BTN",
"HRV",
"MLT",
"JAM",
"ITA",
"DZA",
"MOZ",
"FIN",
"CMR",
"DMA",
"PHL",
"MDV",
"LKA",
"SEN",
"ETH",
"BRB",
"GRD",
"CIV",
"ARG"
],
"supported_currencies": [
"BRL",
"ILS",
"PHP",
"THB",
"SGD",
"TWD",
"CZK",
"MXN",
"NZD",
"NOK",
"MYR",
"AUD",
"GBP",
"SEK",
"CHF",
"HUF",
"USD",
"DKK",
"CNY",
"PLN",
"HKD",
"CAD",
"EUR",
"JPY"
]
}
],
"supported_webhook_flows": [
"payments",
"refunds",
"disputes"
]
},
{
"name": "TRUSTPAY",
"display_name": "Trustpay",
"description": "TrustPay is a Slovakia-based company specializing in secure e-commerce payments, particularly within the EEA area.",
"category": "payment_gateway",
"supported_payment_methods": [
{
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_type_display_name": "Credit Card",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"Mastercard",
"AmericanExpress",
"DinersClub",
"Discover",
"Interac",
"JCB",
"CartesBancaires",
"UnionPay"
],
"supported_countries": null,
"supported_currencies": [
"DKK",
"GBP",
"NOK",
"HUF",
"CHF",
"USD",
"CZK",
"AUD",
"SEK",
"EUR",
"CAD",
"PLN",
"NZD",
"RON"
]
},
{
"payment_method": "card",
"payment_method_type": "debit",
"payment_method_type_display_name": "Debit Card",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"three_ds": "not_supported",
"no_three_ds": "supported",
"supported_card_networks": [
"Visa",
"Mastercard",
"AmericanExpress",
"DinersClub",
"Discover",
"Interac",
"JCB",
"CartesBancaires",
"UnionPay"
],
"supported_countries": null,
"supported_currencies": [
"NOK",
"HUF",
"NZD",
"CHF",
"GBP",
"RON",
"AUD",
"USD",
"SEK",
"PLN",
"EUR",
"CAD",
"DKK",
"CZK"
]
},
{
"payment_method": "bank_transfer",
"payment_method_type": "instant_bank_transfer",
"payment_method_type_display_name": "Instant Bank Transfer",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"SVK",
"AUT",
"DEU",
"GBR",
"ITA",
"CZE"
],
"supported_currencies": [
"GBP",
"EUR",
"CZK"
]
},
{
"payment_method": "bank_transfer",
"payment_method_type": "sepa_bank_transfer",
"payment_method_type_display_name": "SEPA Bank Transfer",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": null,
"supported_currencies": null
},
{
"payment_method": "bank_redirect",
"payment_method_type": "giropay",
"payment_method_type_display_name": "Giropay",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": null,
"supported_currencies": null
},
{
"payment_method": "bank_redirect",
"payment_method_type": "sofort",
"payment_method_type_display_name": "Sofort",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"NLD"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "eps",
"payment_method_type_display_name": "EPS",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"AUT"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "ideal",
"payment_method_type_display_name": "iDEAL",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"AUT"
],
"supported_currencies": [
"EUR"
]
},
{
"payment_method": "bank_redirect",
"payment_method_type": "blik",
"payment_method_type_display_name": "BLIK",
"mandates": "not_supported",
"refunds": "supported",
"supported_capture_methods": [],
"supported_countries": [
"POL"
],
"supported_currencies": [
"PLN"
]
}
],
"supported_webhook_flows": [
"payments",
"refunds",
"disputes"
]
},
]
}
```
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: feat(connector): revert [paypal, trustpay] add in feature matrix
- Merged: 2025-05-15T14:22:25Z
- Files changed: 9 files
- Commits: 1 commits
Implementation approach:
ORIGINAL PR: https://github.com/juspay/hyperswitch/pull/8042
Reverts juspay/hyperswitch#7911
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): revert [paypal, trustpay] add in feature matrix (#8046)
Files to modify:
**crates/hyperswitch_connectors/src/connectors/paypal.rs**
Remove:
- function: private::get_connector_about
- function: private::get_supported_payment_methods
- function: private::get_supported_webhook_flows
- impl: impl ConnectorSpecifications for Paypal
Add:
- function: private::validate_connector_against_payment_request
- impl: impl ConnectorSpecifications for Paypal
**crates/hyperswitch_connectors/src/connectors/trustpay.rs**
Remove:
- function: private::get_connector_about
- function: private::get_supported_payment_methods
- function: private::get_supported_webhook_flows
- impl: impl ConnectorSpecifications for Trustpay
Add:
- impl: impl ConnectorSpecifications for Trustpay
|
{"issue_number": 7911, "pr_number": 8046, "commits_count": 1, "files_changed": 9, "response_length": 1222, "file_count": 4, "needs_breakdown": false}
|
[FEATURE] scheme error code and messages in /payments API response
### Feature Description
If the payment is declined for a card transaction, the card scheme or issuer can send a raw response explaining why. These are the raw acquirer responses which helps in understanding why a card transaction was declined.
Some connectors like Adyen supports this - [reference](https://docs.adyen.com/development-resources/raw-acquirer-responses/#search-modal).
HyperSwitch today sends back `error_code` and `error_message` in the payments API response which are connector's error code and messages. Payments API response has to be extended to send back issuer specific error codes and messages.
### Possible Implementation
Issuer's error code and messages are received in payments API response or through webhooks. Considering this, below steps are to be followed
1. Ensure issuer's error code and messages are sent back from connector integration to core layer in `ErrorResponse`
2. Ensure this is handled in `IncomingWebhook` flows
3. Ensure this is stored in `payment_attempt` table
4. Ensure this is sent back in payments response
##### Changes required
1. Add below fields in `payment_attempt` table
- `issuer_error_code`
- `issuer_error_message`
2. Add below fields to payments API response
- `issuer_error_code`
- `issuer_error_message`
This maintains the existing naming convention. Today, HyperSwitch has -
- `error_code` and `unified_code`
- `error_message` and `unified_message`
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat: scheme error code and messages in payments api response
- Merged: 2025-03-17T15:03:23Z
- Files changed: 30 files
- Commits: 13 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR introduces -
- Core functionality to read and store raw acquirer responses for `payment` and `refund` operations.
- Read raw acquirer response from connector integration
- Store in `PaymentAttempt` and `Refund` tables
- Updates Adyen connector integration to read r
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat: scheme error code and messages in payments api response (#7528)
Co-authored-by: hyperswitch-bo
Files to modify:
**crates/api_models/src/payments.rs**
Modify existing code
**crates/api_models/src/refunds.rs**
Modify existing code
**crates/diesel_models/src/payment_attempt.rs**
Modify existing code
**crates/diesel_models/src/refund.rs**
Modify existing code
**crates/diesel_models/src/schema.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/aci.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/adyen.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/adyen/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/airwallex.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/amazonpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/authorizedotnet.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/authorizedotnet/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bambora.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bamboraapac.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bamboraapac/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bankofamerica.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bankofamerica/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/billwerk.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/billwerk/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bitpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/bluesnap.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/boku.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/braintree.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/braintree/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cashtocode.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cashtocode/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/chargebee.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/checkout.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/checkout/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/coinbase.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/coingate.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cryptopay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cryptopay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cybersource.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/datatrans.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/datatrans/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/deutschebank.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/deutschebank/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/digitalvirgo.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/dlocal.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/elavon/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/fiserv.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/fiservemea.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/fiuu.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/fiuu/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/forte.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/getnet.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/globalpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/globalpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/globepay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/globepay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/gocardless.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/helcim.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/hipay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/hipay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/iatapay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/iatapay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/inespay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/inespay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/itaubank.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/jpmorgan.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/juspaythreedsserver.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/klarna.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/mifinity.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/mollie.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/moneris.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/multisafepay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nexinets.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nexixpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nomupay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/noon.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/noon/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/novalnet.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nuvei/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/opayo.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/opennode.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paybox.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paybox/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payeezy.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payme.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payme/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paypal.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paystack.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paystack/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payu.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/placetopay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/powertranz.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/powertranz/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/prophetpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/prophetpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/rapyd.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/rapyd/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/razorpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/razorpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/recurly.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/redsys.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/shift4.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/square.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/stax.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/stripebilling.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/taxjar.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/thunes.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/trustpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/trustpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/tsys/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/unified_authentication_service.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/volt.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/volt/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/wellsfargo.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/wellsfargo/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/xendit.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/xendit/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/zen.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/zen/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/zsl.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/zsl/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/utils.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/errors/api_error_response.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_attempt.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_data.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/api.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/connector_integration_v2.rs**
Modify existing code
**crates/router/src/connector/adyenplatform.rs**
Modify existing code
**crates/router/src/connector/dummyconnector.rs**
Modify existing code
**crates/router/src/connector/ebanx.rs**
Modify existing code
**crates/router/src/connector/gpayments.rs**
Modify existing code
**crates/router/src/connector/netcetera.rs**
Modify existing code
**crates/router/src/connector/netcetera/transformers.rs**
Modify existing code
**crates/router/src/connector/nmi.rs**
Modify existing code
**crates/router/src/connector/nmi/transformers.rs**
Modify existing code
**crates/router/src/connector/payone.rs**
Modify existing code
**crates/router/src/connector/plaid.rs**
Modify existing code
**crates/router/src/connector/plaid/transformers.rs**
Modify existing code
**crates/router/src/connector/riskified.rs**
Modify existing code
**crates/router/src/connector/signifyd.rs**
Modify existing code
**crates/router/src/connector/stripe.rs**
Modify existing code
**crates/router/src/connector/stripe/transformers.rs**
Modify existing code
**crates/router/src/connector/threedsecureio.rs**
Modify existing code
**crates/router/src/connector/threedsecureio/transformers.rs**
Modify existing code
**crates/router/src/connector/utils.rs**
Modify existing code
**crates/router/src/connector/wellsfargopayout.rs**
Modify existing code
**crates/router/src/connector/wise.rs**
Modify existing code
**crates/router/src/core/payments/access_token.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_response.rs**
Modify existing code
**crates/router/src/core/payments/retry.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/core/payouts/access_token.rs**
Modify existing code
**crates/router/src/core/refunds.rs**
Modify existing code
**crates/router/src/db/refund.rs**
Modify existing code
**crates/router/src/services/api.rs**
Modify existing code
**crates/router/src/utils.rs**
Modify existing code
**crates/router/src/workflows/payment_sync.rs**
Modify existing code
**crates/router/tests/payments.rs**
Modify existing code
**crates/router/tests/payments2.rs**
Modify existing code
**crates/storage_impl/src/mock_db/payment_attempt.rs**
Modify existing code
**crates/storage_impl/src/payments/payment_attempt.rs**
Modify existing code
|
{"issue_number": 7467, "pr_number": 7528, "commits_count": 1, "files_changed": 30, "response_length": 14386, "file_count": 162, "needs_breakdown": true}
|
[BUG] Add metrics in router scheduler flow as it is being ignored now
### Bug Description
Router is not maintaining any metrics about the task added in scheduler. this has to be fixed
File: crates/router/src/core/payments/helpers.rs
Method: add_domain_task_to_pt
### Expected Behavior
Metrics has to be added to know the TASKS_ADDED_COUNT and TASKS_RESET_COUNT
### Actual Behavior
Currently those are not available
### Steps To Reproduce
NA
### Context For The Bug
_No response_
### Environment
NA
### Have you spent some time checking if this bug has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
None
|
<think>
PR Context:
- Title: fix(metrics): Add TASKS_ADDED_COUNT and TASKS_RESET_COUNT metrics in router scheduler flow
- Merged: 2024-01-18T10:29:35Z
- Files changed: 8 files
- Commits: 9 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
Currently `TASKS_ADDED_COUNT` and `TASKS_RESET_COUNT` metrics does not exist in router to track the tasks added in scheduler. This PR aims at adding that.
Closes #2090
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd r
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(metrics): Add TASKS_ADDED_COUNT and TASKS_RESET_COUNT metrics in router scheduler flow (#3189)
Files to modify:
**crates/router/src/core/api_keys.rs**
Modify existing code
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
**crates/router/src/core/payment_methods/vault.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Modify existing code
**crates/router/src/core/refunds.rs**
Modify existing code
**crates/router/src/routes/metrics.rs**
Modify existing code
**crates/router/src/workflows/api_key_expiry.rs**
Modify existing code
**crates/scheduler/src/metrics.rs**
Modify existing code
|
{"issue_number": 2090, "pr_number": 3189, "commits_count": 1, "files_changed": 8, "response_length": 1485, "file_count": 10, "needs_breakdown": false}
|
Migrate from cargo2nix to rust-flake
Migrate the Nix build/shell system from cargo2nix to rust-flake.
**Parent Issue:** #57
**Related PR:** #8503
## Acceptance Criteria
- [x] Migrate from cargo2nix to rust-flake
- [x] Verify nix CI/CD compatibility
|
<think>
PR Context:
- Title: refactor(nix): Migrate from cargo2nix to rust-flake
- Merged: 2025-07-15T08:20:23Z
- Files changed: 7 files
- Commits: 6 commits
Implementation approach:
# Migrate Nix Configuration to rust-flake
This PR refactors the existing Nix setup by migrating from `cargo2nix` to `rust-flake`.
Resolves: #8538
## TODO:
- [x] **Initial port** - Port current `flake.nix` functionality using rust-flake
- [x] @kashif-m The current [`flake.nix`](https://github.com/juspay/hyperswitch/blob/d305fad2e6c403fde11b9eea785fddefbf3477df/flake.nix#L63-L78) has `default`, `dev`, and `qa` shells. Are all three required? Typically we use `default` for development
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8538, "pr_number": 8503, "commits_count": 0, "files_changed": 7, "response_length": 781, "file_count": 1, "needs_breakdown": false}
|
fix(connector): [Worldpay] add root CA certificate
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds below changes for the Worldpay connector
1. Add a root CA certificate for Worldpay's request client
2. Add a new AuthType for Worldpay - MultiAuthType
3. Use `MultiAuthType` in wasm crate for Worldpay
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
4. `crates/router/src/configs`
5. `loadtest/config`
-->
## Motivation and Context
This fixes the self signed certificate not trusted errors for Worldpay in production.
## How did you test it?
Cannot be tested in non prod env.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert(connector): [Worldpay] add root CA certificate
- Merged: 2025-06-10T08:33:22Z
- Files changed: 5 files
- Commits: 1 commits
Implementation approach:
Reverts juspay/hyperswitch#8205
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert(connector): [Worldpay] add root CA certificate (#8224)
Files to modify:
**crates/hyperswitch_connectors/src/connectors/worldpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs**
Modify existing code
|
{"issue_number": 8205, "pr_number": 8224, "commits_count": 1, "files_changed": 5, "response_length": 579, "file_count": 4, "needs_breakdown": false}
|
fix(cards): Return a 200 response indicating that a customer is none
## Type of Change
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Bug Description
CustomerPaymentMethodsListResponse returns 404 when there is no customer tied to a payment
Proposed Behavior
Return a 200 response somehow indicating that a customer is not associated with the payment
Current Behavior
A 404 response with "Customer does not exist in our records" is being returned, although the customer_id is null
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
Fixes https://github.com/juspay/hyperswitch/issues/3767
|
<think>
PR Context:
- Title: fix(cards): Return a 200 response indicating that a customer is none
- Merged: 2024-02-23T10:31:26Z
- Files changed: 3 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Bug Description
CustomerPaymentMethodsListResponse returns 404 when there is no customer tied to a payment
Proposed Behavior
Return a 200 response indicating that a customer is not associated with the payment
Current Behavior
A 404 response with "Customer does not exist in ou
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(cards): Return a 200 response indicating that a customer is none (#3796)
Files to modify:
**crates/api_models/src/payment_methods.rs**
Modify existing code
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
|
{"issue_number": 3773, "pr_number": 3796, "commits_count": 1, "files_changed": 3, "response_length": 1040, "file_count": 4, "needs_breakdown": false}
|
[CHORE] Update GlobalPay production endpoint
at present, production endpoint points to sandbox and we need to point to production url
|
<think>
PR Context:
- Title: chore: update production endpoint url for globalPay
- Merged: 2025-03-24T08:11:04Z
- Files changed: 4 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR updates the production endpoint url environment value for GlobalPay while fixing minor inconsistencies
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR mo
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** chore: update production endpoint url for globalPay (#7588)
Co-authored-by: hyperswitch-bot[bot] <14
Files to modify:
**crates/hyperswitch_connectors/src/connectors/globalpay.rs**
Modify existing code
|
{"issue_number": 7587, "pr_number": 7588, "commits_count": 1, "files_changed": 4, "response_length": 988, "file_count": 3, "needs_breakdown": false}
|
[REFACTOR] The `Drop` implementation on `RedisConnectionPool` seems unnecessary
### Description
I'll keep this issue as a source of documentation and decisions taken regarding the graceful shutdown of Redis connections.
When I was working on #1743, I noticed that the `Drop` implementation on `RedisConnectionPool` caused panics when tests were being run.
https://github.com/juspay/hyperswitch/blob/1ab4226c780e9205785f012fd1c48c7a4bafb48f/crates/redis_interface/src/lib.rs#L197-L203
When I went down the rabbit hole of identifying possible solutions to it, I found that none of the log messages within [`close_connections()`](https://github.com/juspay/hyperswitch/blob/1ab4226c780e9205785f012fd1c48c7a4bafb48f/crates/redis_interface/src/lib.rs#L157-L179) were ever printed. To address this, I temporarily added a `std::mem::forget(_guard)` line in `router/src/bin/router.rs` so that the logs would be available.
This brought out the fact that all attempts by us to close Redis connections (the connection pool, publisher client and subscriber client) were failing with the following warning:
```text
Fatal error sending QUIT command to router. Client may be stopped or not yet initialized.
```
When I attached the debugger, set a debugger breakpoint at the first line of the `Drop` implementation and listed Redis clients using the `redis-cli` tool, there were no Redis clients arising from the application in the list, and the warning was indeed correct.
It seems that Redis connections are being closed before even the `Drop` implementation has been entered, and I'm unable to explain why. I couldn't find anything relevant in the `fred` codebase either. I was able to reproduce this with a Redis cluster set up using Docker Compose.
|
<think>
PR Context:
- Title: refactor(redis_interface): remove the `Drop` implementation on `RedisConnectionPool`
- Merged: 2023-07-25T10:11:56Z
- Files changed: 2 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR drops the `Drop` implementation (pun intended) on `RedisConnectionPool`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(redis_interface): remove the `Drop` implementation on `RedisConnectionPool` (#1786)
Files to modify:
**crates/redis_interface/src/lib.rs**
Remove:
- function: pub::close_connections
- function: private::drop
- impl: impl Drop for RedisConnectionPool
**crates/router/src/connection.rs**
Modify existing code
|
{"issue_number": 1782, "pr_number": 1786, "commits_count": 1, "files_changed": 2, "response_length": 1151, "file_count": 4, "needs_breakdown": false}
|
fix(router): handle JSON connector response parse error
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Certain connectors (Braintree, Rapyd, Trustpay, Boku) send error response in HTML or string format. This lead to a ``HE_00`` in our system as we try to accept it in a JSON format. Now we have introduced a ``get_json_deserialized`` function in router/utils.rs that can be used to handle Json error. Json Error handling is implemented for Trustpay, Rapyd and Braintree. Boku already handles it.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
<img width="1074" alt="Screen Shot 2023-08-08 at 8 16 57 PM" src="https://github.com/juspay/hyperswitch/assets/131388445/0ca8396b-9379-4372-9750-b77d3afd362f">
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: fix(connector): [Braintree] add merchant_account_id field in authorize request
- Merged: 2023-08-10T18:11:39Z
- Files changed: 5 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
1) added `Merchant Account id` field in authorize request for braintree.
2) handle error response in case of wrong merchant account id
3) cherry pick #1892
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [Braintree] add merchant_account_id field in authorize request (#1913)
Co-authored-b
Files to modify:
**crates/router/src/connector/braintree.rs**
Add:
- function: private::build_error_response
**crates/router/src/connector/braintree/transformers.rs**
Add:
- struct: pub::BraintreeMeta
- struct: pub::BraintreeApiErrorResponse
- struct: pub::TransactionError
- struct: pub::CreditCardError
- struct: pub::ErrorObject
- struct: pub::BraintreeErrorResponse
- enum: pub::ErrorResponse
**crates/router/src/connector/rapyd.rs**
Modify existing code
**crates/router/src/connector/trustpay.rs**
Modify existing code
**crates/router/src/utils.rs**
Add:
- function: pub::handle_json_response_deserialization_failure
|
{"issue_number": 1892, "pr_number": 1913, "commits_count": 1, "files_changed": 5, "response_length": 1585, "file_count": 7, "needs_breakdown": false}
|
[CI] cypress checks for wise failing
wise is returning status as `forbidden`. it is better to replace that with adyen payouts
|
<think>
PR Context:
- Title: ci(cypress-ci): remove wise payout from running in github ci
- Merged: 2025-04-08T08:31:18Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
this pr updates the `adyen` payouts credentials and it also replaces wise from running in github ci
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies appl
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7755, "pr_number": 7756, "commits_count": 0, "files_changed": 1, "response_length": 790, "file_count": 0, "needs_breakdown": false}
|
Nix Support
Nix support for orca:
- Dev shell to include all the required tools, setup
- Build with nix flakes
- CI/CD with nix flakes
|
<think>
PR Context:
- Title: feat: add basic nix support
- Merged: 2022-12-07T11:58:55Z
- Files changed: 2 files
- Commits: 4 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
Adding basic support for nix. This PR gives nix shell with cargo, rustc - 1.63.0. Plan is to make use of nix to do full dev setup.
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 57, "pr_number": 63, "commits_count": 0, "files_changed": 2, "response_length": 757, "file_count": 0, "needs_breakdown": false}
|
fix: print x request id for user postman tests
Console log x request id for users postman tests,
- it will help to debug failed tests for user collection
|
<think>
PR Context:
- Title: ci(postman): log request id for user tests
- Merged: 2024-06-28T14:07:35Z
- Files changed: 6 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
For user postman tests log x request id for every request.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 5158, "pr_number": 5159, "commits_count": 0, "files_changed": 6, "response_length": 772, "file_count": 0, "needs_breakdown": false}
|
feat: add env variable for enable key manager service
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application starts using encryption service for encryption and decryption. Once the config is enabled it shouldn't be disabled.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [x] This PR modifies application configuration/environment variables
## Motivation and Context
This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application starts using encryption service for encryption and decryption.
## How did you test it?
**This can't be tested in Test environment, since it is already enabled in both**
1. key_manager.enabled: false and feature "encryption_service" disabled. Encryption and decryption happens within the application
2. key_manager.enabled: true and feature "encryption_service" disabled. Encryption and decryption happens within the application
3. key_manager.enabled: false and feature "encryption_service" enabled. Encryption and decryption happens within the application
4. key_manager.enabled: true and feature "encryption_service" enabled. Encryption and decryption happens with encryption service. Once this is enabled can't be disabled.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
|
<think>
PR Context:
- Title: feat: add env variable for enable key manager service
- Merged: 2024-07-29T11:23:54Z
- Files changed: 7 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds env variable for enabling encryption service. Application changes for encryption service is not backward compatible, so once the build is deployed and certified stable this feature will be enabled by setting up "true" to key_manager.enabled flag. Later only application st
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat: add env variable for enable key manager service (#5465)
Co-authored-by: dracarys18 <karthikey.
Files to modify:
**crates/common_utils/src/types/keymanager.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/type_encryption.rs**
Add:
- function: private::is_encryption_service_enabled
**crates/router/src/configs/defaults.rs**
Modify existing code
**crates/router/src/configs/settings.rs**
Modify existing code
**crates/router/src/routes/admin.rs**
Modify existing code
**crates/router/src/types/domain/types.rs**
Modify existing code
|
{"issue_number": 5442, "pr_number": 5465, "commits_count": 1, "files_changed": 7, "response_length": 1361, "file_count": 8, "needs_breakdown": false}
|
End of preview. Expand
in Data Studio
Rust Commit Dataset - Hyperswitch
Dataset Description
This dataset contains Rust commit messages paired with their corresponding code patches from the Hyperswitch repository.
Dataset Summary
- Total Examples: 900
- Language: Rust
- Source: Hyperswitch GitHub repository
- Format: Prompt-response pairs for supervised fine-tuning (SFT)
Data Fields
prompt: The commit message describing the changeresponse: The git patch/diff showing the actual code changes
Example
{
"prompt": "fix: update payment status handling",
"response": "diff --git a/src/payment.rs b/src/payment.rs\n..."
}
Usage
from datasets import load_dataset
# Load dataset
dataset = load_dataset("archit11/hyperswitch-issue-to-code_v3")
# Access train/test splits
train_data = dataset['train']
test_data = dataset['test']
# Example
print(train_data[0]['prompt'])
print(train_data[0]['response'])
Training
This dataset is designed for fine-tuning code generation models on Rust commit-to-patch generation tasks.
Example training command:
python train_sft.py \
--dataset archit11/hyperswitch-issue-to-code_v3 \
--model Qwen/Qwen3-4B \
--output_dir ./qwen-rust-sft \
--use_4bit \
--use_lora
Data Collection
The data was collected using PyDriller and tree-sitter for parsing Rust identifiers:
- Only commits with 20+ lines changed are included
- Rust-specific identifier tracking (functions, structs, enums, traits, impls, modules)
Citation
If you use this dataset, please cite the Hyperswitch repository:
@misc{hyperswitch2024,
title={Hyperswitch},
author={Juspay},
year={2024},
url={https://github.com/juspay/hyperswitch}
}
License
This dataset follows the same license as the Hyperswitch project.
- Downloads last month
- 84